From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6572343095; Fri, 18 Aug 2023 12:04:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 449EF40ED9; Fri, 18 Aug 2023 12:04:52 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2081.outbound.protection.outlook.com [40.107.243.81]) by mails.dpdk.org (Postfix) with ESMTP id BFA8540395 for ; Fri, 18 Aug 2023 12:04:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVVNwIcwweUvLpNRw7GroOnRcYMOo7FpmIBWvevB1njK9ga42qWapvE3pN5Eb8LQBXlSXG2XCoXJjN5ON8RLNo2Gq8BeN7LwjQT6reKKITa1d/n4wiDX2dQZyWMp/pAF7L9VaXssPuhL+73n0OU1ppRxbjwXPIEJ4bdALkpWjfM/n7cqIkdA8asx+SZl4IPEKX5aQMO/AktY4EhWTvZtTs5KI0liQGh66Kot28SsvucnlqvSZMfn1AhqKkZkXXEr78cUKFiGL/HjFvagVtf3lt2ZtyvY/8mllz5eQnKQuj2FZD221i0cFcfPEeqMbseDdBmR7DHzvFo8M+Cpii/e1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jQ2RYawV84tKitb/fRuNv2rIJoGCmJuK1bxRR0YKBX8=; b=EfvJ4IQz83TIGgUE/jlYVKGb/vFC9fuYeK3tLtoQjslMDYp+3DtZYHEme66oviYAUVGFwr18z9AZAnxA0gDz/9s2crCuhjTuJ/UiFIXadU09e/6+zH9TfzUlMU/WbOc1X4ZqtuCSVJ6hxmL8ft+SOIGlZyxucMG9DCHt/jh7L5IQb6JOTO48mFH98fmGPPEWT2OC8yAz0XSA4Xf+0iF8flFmgD8PyYhRrcmA/5MdWVY93OdbFZdr6OZpVMSqz887vIbZJBGJ1QE3Ikizn1Q6enWVigZvi5pTCigCIcd68kS3GJRhUuLaH8zGv+IEvc9p3AC52A0z5u85gHjcCsMgnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jQ2RYawV84tKitb/fRuNv2rIJoGCmJuK1bxRR0YKBX8=; b=V8WXcPV+UKIZJaXKx+A4OV+Y0c1VaaytVcpq16UFOQnjXP0FtC3DQ1mFBAubGldFdzxUihKEDR7byU1AHt1WR75DwpcasaAK/iSxLILrJ13pnY1HIxJkVX0cTTsHGPI7Btxuh67Q6ObnQku/ZwuvzRUJGnKDie9qOUEjkPaqrIlV78A5vqks3FCUpMmMaHPQhCYfVluohxpOPMrkdfer/UwL2HCKiE8t/59tLhsMMpa8aJwxPXqEW9gg60htZixqs20EhN0j+rLBtGZYDEt/9SIb82qNkJ6oAb1yXE2EKwbvdwDkEsq/V9PWMzQZ5USPrqt4AylKqYylOXrG8i09gw== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by SA3PR12MB7976.namprd12.prod.outlook.com (2603:10b6:806:312::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.31; Fri, 18 Aug 2023 10:04:49 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::a33:526e:2801:acc]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::a33:526e:2801:acc%5]) with mapi id 15.20.6699.020; Fri, 18 Aug 2023 10:04:48 +0000 From: Slava Ovsiienko To: Dariusz Sosnowski , Matan Azrad , Ori Kam , Suanming Mou , "Jiawei(Jonny) Wang" CC: "dev@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix bond resource release Thread-Topic: [PATCH] net/mlx5: fix bond resource release Thread-Index: AQHZxvdkqmOz4n2kvE2S0A5C2H2P/a/v6MAQ Date: Fri, 18 Aug 2023 10:04:48 +0000 Message-ID: References: <20230804171536.1724554-1-dsosnowski@nvidia.com> In-Reply-To: <20230804171536.1724554-1-dsosnowski@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3753:EE_|SA3PR12MB7976:EE_ x-ms-office365-filtering-correlation-id: efc85f1c-357d-4e61-5757-08db9fd28e92 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lmnPQpZPT2ZEu0FPO1/bXEmW5XvfmdSGAZU8l77GwFIGnwG/dI77tzePkaf0401e0UsIyUFFTA5wT/o0UfxKh5ICZGOGDkeCLQZViMLywLbfE8FpbxfckzDH3nHi8/6+pwAj9WO+CNcYY1G+hcNFaBHFiU5PT4Oo0nInFWDS2G1ETpOygNEy9G7507rTYvU8uZE2Jmhxsz4Ha7ENJ37L2h6kpqCt1UyqjnPn9OHscqh2mWJFqfpKQhhwryGzg8PD9j8QbVqRoLgtW7oXZIfTDsj15qLDYYAW35qYMZXDPGN3NLTO/N0YGdezOtXWPkglbp3BwAQ5IClQZXWHrXZmNh/YoxNYS6SmoS2Bc7WK7p27PBfcIi4Y3NHK/muitPbm04J0SND/uI4VQUWeKGhHzPZ0WHSkDVOj7UTEkHi9O1yb8HLp8g0kN0AbtXo3kg3kHcpwuvGXGIiOUBSXwIHAc0Fhla+X/B7+CjZwSsPCO1CiVXF1pVgGpgKRGO97HqfbpFztQXSQH4QJV8j7AOiw0ZXaI+XYcR3kM4i41EYvv7JP1yG1qmviM/awdMWmYtTO+Zn7f8BpIMrdgZVb/A9fz78GYohOMa/BrCBIGJBo6UVpIVlTFVDQ00f7F/FwOK2b x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(136003)(396003)(39860400002)(451199024)(1800799009)(186009)(33656002)(86362001)(38100700002)(122000001)(38070700005)(55016003)(76116006)(52536014)(5660300002)(55236004)(66556008)(66446008)(66476007)(478600001)(64756008)(6506007)(71200400001)(110136005)(7696005)(6636002)(316002)(66946007)(53546011)(41300700001)(9686003)(4326008)(8936002)(26005)(8676002)(2906002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T6XTkJZMdYcsezKWcGtcJTYNFciNLq7SKonal/xpI3uRm9XjuFdEEUCCldDW?= =?us-ascii?Q?7POjjOpslI/9dEAookZnQ3GEyvZ3ozJ7+BNuaAJWGYWtdtBS6jBcGwnUjQJj?= =?us-ascii?Q?n2RxXcY3ArgPnuJlHxhMo7pOggYfvM9M0UGVPrS8y/9qvrtY1X+YtgOIlsPN?= =?us-ascii?Q?T6quW/WR6YvQGenRVfIs2GspDYgXqfUVAS7ucXO5ubPwFo16HrqRKXQB09wQ?= =?us-ascii?Q?rDO241ltRfeVoeLeGeHdJDAN7rronQtFkEtjG7iSwuSU3txT0xID38n73JCY?= =?us-ascii?Q?lqHMzXNvCSCg3rOLTscEq+xxhkCkgebSQCigGcz4z+H9hdvvUQluYes0akGF?= =?us-ascii?Q?Cf4Df7Fo8k/tG6STpBhuqjaUfVEo9L6t7+1k22DmKIYR6aXFWiZ1LD35Vz6t?= =?us-ascii?Q?JQlLkHAvCUcf6hYhEV68jnON0toITuGiGMP1sWgV7Ui/OLOovHGd95LBjbdA?= =?us-ascii?Q?A/plJvueQem2J1sfbV9J/Qr4OERMdQejploULqmXV2WQiKMqZyLFHiM3KGIt?= =?us-ascii?Q?VKYXoH0cGpFghOnoYFOATvz3HamBd3+wc9z5K1rwq69naZpsDIxhsdQoI6q8?= =?us-ascii?Q?YxWVj+Gudg7bnvwqG0rSlPz2h5LW3wi3/pB9MdnRWM0fo1c2Ve4erPYG7WKC?= =?us-ascii?Q?HJNHKOCWtNjxAjvGvGzGAmwXFOWlKu/Se8nQsXcxoJ5qldzmuE9kriWmPWIl?= =?us-ascii?Q?CtoZz+xgzCxUsg1RGRhCJ9+c5Wx0HDj1tQ85IKwDLj1zFpTkndJA7cm2JTgO?= =?us-ascii?Q?R6+xutyp6H+E752L5Q4U2o6fMzr2Nz2jejX0XIAH1qOJJPbQ22WfH/GU9Pt5?= =?us-ascii?Q?bcIQjcJRGPh1fNWe3moTp2CGZIc9SVZKHQNMNTDIIMDpoxvgAiFJ7YBtxqw9?= =?us-ascii?Q?r1AB2EwZAjJY8Grokn+yFohVbr0FRGmt3wDH9tyCKI//KNKq7dKnDe7PW+y8?= =?us-ascii?Q?mPFiTI02OQ4U6TjbcfxHUSsMsACEvS9e/YqKroq2WwVwTtRWfJgH+jbKWCk3?= =?us-ascii?Q?W2YpMkmR2yBikdhRM8mRsH7OwzDW6hLtGE473LsyxXjqqp6ICXSyKqcXA0O5?= =?us-ascii?Q?H/oT+7XpDDgw0HbtHkljNiXCuVclMVqZikY+H3W+OYll1X0HSm9WSXjaPzf+?= =?us-ascii?Q?Gtimb7AuuTHgYqxuPGoHyjhWAwVWJ26qj9hduS6CAd6kSEtrkC/7F/neUiy2?= =?us-ascii?Q?G0dUkGpjnfF+XxSpDACRbl2DtC7rbu46fJHw1A0XTRXSszAXFCtSPHIpvLyz?= =?us-ascii?Q?T2GhtTGMH6ArwqwMfLSEz+2mbL1TqAfyD5yy0LetD5dDsctJnWooxzru5Mey?= =?us-ascii?Q?AiRFIGfVMB8eG1/eYKZocRu5OJCmdPShQG+mSPHuQ/nwdYo51VMvyQ3HIs5c?= =?us-ascii?Q?Gs63B1zTZ0aJPOMdaSGySL6J6ErvS0MxpZHrlEJyVgZTJa7BfFPiVth9aL7n?= =?us-ascii?Q?QMmYNykcYQL2qkIy5g0p8MA8fh/rQr9LRwApLVQku5/j3Ex+2OMHVvStFpEU?= =?us-ascii?Q?KcEz2SoHfqbbA8e/JeOQJUvD2ucunMrpB0CaSKwHnTqRPg7arjWTl1mVi51C?= =?us-ascii?Q?RGGiIdY5FvnAFJX+Q7171q8iH0qIH3iIy7QIa+Ww?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: efc85f1c-357d-4e61-5757-08db9fd28e92 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2023 10:04:48.6713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FfLgp27VRHUa1w43y9fRHY+68noZIyNjuWRLkIsU0CYyLU9hCXNpwaVRloI+VXahfl4FGsqzympN7+y7XOBeWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7976 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dariusz Sosnowski > Sent: Friday, August 4, 2023 8:16 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Jiawei(Jonny) Wang > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix bond resource release >=20 > When a port is spawned on top of mlx5 bonding device, > the following TIS objects are created: >=20 > - TIS with index 0 - for default HW hash bonding mode, > - TIS with index 1 - for sending packets on 1st physical port, > - TIS with index 2 - for sending packets on 2nd physical port, > - and so on. >=20 > These TIS objects are used according to configured Tx queue affinity, > which was set up using rte_eth_dev_map_aggr_tx_affinity() API. >=20 > Before this patch, when DPDK was compiled in debug mode and > RTE_LIBRTE_MLX5_DEBUG macro was declared, applications were asserting > on failed call to destroy the TD object (on which TIS objects > are dependent) during closing of the ports. > Failure was caused by the fact that when TD object was destroyed, not > all TIS objects were destroyed yet. This was caused by "off-by-one" > issue in mlx5_free_shared_dev_ctx(). > This function was releasing n TIS objects, but it should > release n + 1 objects, where n is number of aggregated ports. > (n + 1, because there are n TIS objects for each physical port > and 1 TIS object for default HW hash mode). >=20 > This patch fixes this issue in resource release of TIS objects. >=20 > Fixes: ce306af6341b ("net/mlx5: enhance Tx queue affinity") > Cc: jiaweiw@nvidia.com >=20 > Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko