DPDK patches and discussions
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Raslan Darawsheh <rasland@nvidia.com>,
	Matan Azrad <matan@nvidia.com>,
	Michael Baum <michaelba@nvidia.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/mlx5: support flow count action handle
Date: Fri, 30 Apr 2021 09:01:46 +0000
Message-ID: <DM6PR12MB3753148FCE6A5955087BBCCBDF5E9@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <de558a5a-b903-99d3-1069-d74ceae2ec43@intel.com>

Hi, Ferruh

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, April 30, 2021 11:35
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Michael Baum <michaelba@nvidia.com>; NBU-
> Contact-Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: [PATCH v2 1/5] net/mlx5: support flow count action handle
> 
> On 4/29/2021 10:55 AM, Viacheslav Ovsiienko wrote:
> > From: Michael Baum <michaelba@nvidia.com>
> >
> > Existing API supports counter action to count traffic of a single flow.
> > The user can share the count action among different flows using the
> > shared flag and the same counter ID in the count action configuration.
> >
> > Recent patch [1] introduced the indirect action API.
> > Using this API, an action can be created as indirect, unattached to
> > any flow rule.
> > Multiple flows can then be created using the same indirect action.
> > The new API also supports query operation of an indirect action.
> >
> > The new API is more efficient because the driver gets it's own handler
> > for the count action instead of managing a mapping between the user ID
> > to the driver handle.
> >
> > Support create, query and destroy indirect action operations for flow
> > count action.
> >
> > Application will use the indirect action query operation to query this
> > count action.
> >
> > In the meantime the old sharing mechanism (with the sharing flag)
> > continues to be supported, and the user can choose the way he wants to
> > share the counter.
> > The new indirect action API is only supported in DevX, so sharing
> > counter action in Verbs can only be done through the old mechanism.
> >
> 
> There is already a deprecation note to remove the 'shared' flag from counter
> action [2] in favor of 'shared actions'.
> 
> Shared action become "indirect actions" [3] which this patch implements
> 
> Is it a good time to remove the old sharing mechanism from driver since
> touching on it?

As I can see:
- it is planned to 21.11 as deprecation note says
- now there Is no support for new "indirect actions" with Verbs (not sure
 we will provide), so shared counters API might be still useful
- our CI did not migrate to the new counter approach yet (even DPDK patch is not merged yet 😊)
- hence, l would prefer keep shared counter support (by id and flag) in 21.05 
 (and very likely in 21.08), just to maintain maximal backward compatibility as long
as possible

With best regards,
Slava

> 
> 
> [2]
> https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst?h=v2
> 1.05-rc1#n95
> 
> [3]
> https://git.dpdk.org/dpdk/commit/?h=v21.05-rc1&id=4b61b8774be9
> 
> 
> > [1] https://mails.dpdk.org/archives/dev/2020-July/174110.html
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> 
> <...>

  reply	other threads:[~2021-04-30  9:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 12:42 [dpdk-dev] [PATCH 0/5] net/mlx5: add indirect count action Michael Baum
2021-04-26 12:42 ` [dpdk-dev] [PATCH 1/5] net/mlx5: support flow count action handle Michael Baum
2021-04-26 12:42 ` [dpdk-dev] [PATCH 2/5] app/testpmd: remove indirect RSS action query Michael Baum
2021-04-29 13:46   ` Ori Kam
2021-04-26 12:42 ` [dpdk-dev] [PATCH 3/5] app/testpmd: support indirect counter " Michael Baum
2021-04-29 13:45   ` Ori Kam
2021-04-26 12:42 ` [dpdk-dev] [PATCH 4/5] net/mlx5: fix flow age event triggering Michael Baum
2021-04-26 12:42 ` [dpdk-dev] [PATCH 5/5] net/mlx5: use aging by counter when counter is existed Michael Baum
2021-04-29  9:55 ` [dpdk-dev] [PATCH v2 0/5] Add support of indirect action API for count action Viacheslav Ovsiienko
2021-04-29  9:55   ` [dpdk-dev] [PATCH v2 1/5] net/mlx5: support flow count action handle Viacheslav Ovsiienko
2021-04-30  8:34     ` Ferruh Yigit
2021-04-30  9:01       ` Slava Ovsiienko [this message]
2021-04-30  9:22         ` Ferruh Yigit
2021-04-29  9:55   ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: remove indirect RSS action query Viacheslav Ovsiienko
2021-04-29  9:55   ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: support indirect counter " Viacheslav Ovsiienko
2021-04-29  9:55   ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: fix flow age event triggering Viacheslav Ovsiienko
2021-04-29  9:55   ` [dpdk-dev] [PATCH v2 5/5] net/mlx5: use aging by counter when counter is existed Viacheslav Ovsiienko
2021-04-30 10:43   ` [dpdk-dev] [PATCH v2 0/5] Add support of indirect action API for count action Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB3753148FCE6A5955087BBCCBDF5E9@DM6PR12MB3753.namprd12.prod.outlook.com \
    --to=viacheslavo@nvidia.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@nvidia.com \
    --cc=michaelba@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git