From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B09BEA0A02; Fri, 26 Mar 2021 14:23:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3980040685; Fri, 26 Mar 2021 14:23:36 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2072.outbound.protection.outlook.com [40.107.244.72]) by mails.dpdk.org (Postfix) with ESMTP id DE1764067B for ; Fri, 26 Mar 2021 14:23:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kmQ3notaxxyYJvrc2Bb4P1JzQHpByQe/4Kp0eYqRIixAtd8kbyozt+g9m0w5UhR9FjP0tWynsTW7oPzbZwaOBH/Z0MgbL63c/yJ170vaFcJ2iZyBqTfzTMSRTsNZF32c6OpegFW4L8h73fpnq3ByVPLr1KB5FieTB3Se/6GHBwSriQoBKIzUW6TV8652IjgxbG9dWspoVtwPZr/BEkhweoBqXUfcYemgObI7n78wCgeA/AwepWsR8VVC3C+YVt26A+W0d5qsXSZApfXlQ3LTIkYNGrnwE9l6a5zhCVEc8iGhiXOsK9o0tmvpzUqkTQSs3haUN4cl3L/05/aHzxJRRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vFDU2jlfCVqXnj9NtbCYVEWuDW5a2ws3ajp24LEUj4g=; b=fwl6uQqiVS6eMygIwVE7ufdl+EeTA09cEUWqo2gJZbjINKtFBh22JsUXTM9e4UvhE1LcEIKZEuNs4HfFkAiKsB8PesyuLMG02Ug6L2iwXjgvipmMlrKR/ppT5ChwbYMx5LtRzLPpcK4en7qQmSHdpZOv7ex+1YRi2MXYbfpaRPEZ35joT8oF0iSOm9sfztqa47BahZ0jk0Dywv5Un/SA49sbnJ7QwLz5gPRN9yqatCE8w8QSLCbLIK8vayjeE4E8hapZrXqKQjGjWekZ9g+tDDQxkBA/b2GET7DTIDF4n70b9KNStWb6oy3bp4fnMMzeaRn7z+XWl5qr1aqKeC4BJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vFDU2jlfCVqXnj9NtbCYVEWuDW5a2ws3ajp24LEUj4g=; b=sxG3ruKY2QdR/4O5MnhVMs5ifDLxUQoVWh00UX5VLxQJ+jiNRn9jMM+0cpdq26gRaWq3+G6V7UuFvB6KiIWev/itmC5cMZTgn18CKIfO024Ow1isSAc4yJ7HvUkntSKKJNtNh83XqBDKMgu7KfVFQcrIdP82XNkjHH77OvBqnjRr4XFTSaZImuFpLeM6ZsBCOkv21oB0+brFRCznEISVS8K0olf1A1cIY2lcX7eZy2UQKWB73V9hqsS0zs7lDnAbiiYFZu8RCcP6wO6vP1vLdPo7JiECdV5H4DmofkA9eFJRTFp8pt0bu+2swVu5Vt23MoOeS37f6V3UN82U/I4OdQ== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB4481.namprd12.prod.outlook.com (2603:10b6:5:2af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.30; Fri, 26 Mar 2021 13:23:32 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::20f7:11fc:9d46:9258]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::20f7:11fc:9d46:9258%6]) with mapi id 15.20.3977.026; Fri, 26 Mar 2021 13:23:32 +0000 From: Slava Ovsiienko To: wangyunjian , "dev@dpdk.org" CC: Matan Azrad , Shahaf Shuler , "jerry.lilijun@huawei.com" , "chenchanghu@huawei.com" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null check Thread-Index: AQHXIiOijxorhGP8O0ONUBwvPpXVZqqWQRqA Date: Fri, 26 Mar 2021 13:23:31 +0000 Message-ID: References: <8a980b235eeba49721dfef9d0f23be375e8958b0.1616741870.git.wangyunjian@huawei.com> In-Reply-To: <8a980b235eeba49721dfef9d0f23be375e8958b0.1616741870.git.wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38a9b6f0-9edc-40a0-9fa7-08d8f05a5a0e x-ms-traffictypediagnostic: DM6PR12MB4481: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KvcVMOQ9NfU8fpz709ZR+D9GTTGy/QjSWEw7DZ4ot+fY7A8Fk7ws3oMY8cS71Qas0lUKHN3dyYd6TM0kJV7RCVHxGzxaGfTlaVoSmJU+d4FnT86mo54mPS4+z0sc4OBJH15OUUFCvdLVuK7xRIIDBwygZBdSZxcCtouKjTLuUzpJu4unwc5igfH1uCvSNpi2etgL8RjF+mYd3AHb+ubcfdNs2u2cX7ZJXBIe+1oXjF8q8Q2BVf41pF5ZSKBwieItxQykcm1XmcNYhHNM9mGhGcthoa/IclZG5md87lAOhT+i3m+xTZ5UJnTNrxRhLsoMOgOyVxdaipXPC3blV9qqzILQUpV04QUNWpxLQsY/I/JZk9d6e94UCydAog24CcLJOu3hSVs2efnhR6pbRwxGG4+G8pgGyWq6GLD+VUxVROtb3vu3W43yQyB5n7omAJVTIFsuxilSRJRk6SkBZd0EpGUWWepylIpwdS769s8LVv/Dj6gfHVeEf3GcnLD25OvOEKNCnFCvPbQtL/JPuNjxd41N2vYVuiyy5zUvO2Q0A0PQ4Y8M3heupgW1yza/2kwQCo6+G5b++x/nHoGmwCNJ1AXQ/JxN8JNdyDflPES1FuXQ+WgQUcJUC8Ya9z4RYy8F2+tAs/DCel6RXl0OK/F37xnXjEC8mhvGKMjIOuLU3Hs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(376002)(136003)(396003)(346002)(4326008)(54906003)(110136005)(478600001)(33656002)(52536014)(83380400001)(316002)(66446008)(64756008)(66556008)(66476007)(76116006)(66946007)(2906002)(86362001)(7696005)(5660300002)(6506007)(53546011)(55016002)(9686003)(71200400001)(8676002)(8936002)(186003)(26005)(38100700001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?WiSgX71RSNb8oX8zYkzwndqURORRUiOk4tkbW4M8LNdiAkQY8aakf1tlb7Vr?= =?us-ascii?Q?0/TDlRPSTif60BmEX+aTfApkmUZ3qCiUsfn5yq3wgKVc6J2OGCju7SaLxz47?= =?us-ascii?Q?rYbNIuSTpxBr8RkE1lvkYH+uZM0XtVJSczvAs2noNaLwVd78olGSot3v3y5Q?= =?us-ascii?Q?E8b1jVoSIQj7A69nlyrRBbro0vho3sr9t5P5WObvT4vWqR17uER738yMp0Uv?= =?us-ascii?Q?yRlmxaioWpFaMtx8mxJlwxcOESP1dMsvvm1TI+XTbEpngckG1AfuQN7KLmsF?= =?us-ascii?Q?IkEU9Hr69RtKX0B0MkANlXP0QGOqVODOxXGqlMpVIfB13NlLZMeziiYbL5rp?= =?us-ascii?Q?DWplQJyTq1zxGJzc1tzwodzYimSTOgb6XxMct/gKNtqJMLVnTV703W8YHtG8?= =?us-ascii?Q?nN7jR3uXI6PDJJRBt6zxw3VxzT3OWkkB3RNziBdVwVfSohl7F5HQaygwg+4Z?= =?us-ascii?Q?VuLPmrXtH2/bdufTqlPpeUeH/BTezhCWN1TkpegDYWRwyeUjSqto8D1OrVDA?= =?us-ascii?Q?8iwAt5i8SvUDtaYPWfLS+sV45fwkjgBA4ubssIG93q2v7EjIN8n+Fa2q8ON0?= =?us-ascii?Q?QqF9WGrhB4mh153RKZ+YVDDK4u3WwXYvu6E8FwUTh94DgO+bHj3ok79SWS3r?= =?us-ascii?Q?mL0RJD5Sawokiui1XDj6GmmDa/5K1+6H/nD8VUmUbvup1EGus7By13e1nnFm?= =?us-ascii?Q?HtCr3DiJ7lQdQ/eFP9cVj2sZ4ozaRhNMj6YmTWGHLtWsqZC/7aGVSkAe0GrH?= =?us-ascii?Q?CbppdXETUhHMfFK42Fp/i/wj93pLQoUernuFflVKe1B4l2AGmCs6JViN9w1k?= =?us-ascii?Q?wtWzuVT+fXTQP+Q9Kas4cdqwC4HC2czflBJrFkbAudZvM66zlYrP/22uPUOv?= =?us-ascii?Q?GR8sfTBppY+YkktC1aULrkVCzXVJjgpaXHFbhgX27a13xh8M/goVUsfv8jgj?= =?us-ascii?Q?UJYTPM8WmCnPIcvUVEdVAcs8jsdXPV2bYDY0P1/xNNozGMXVGyBg0Qru9uvQ?= =?us-ascii?Q?1N+1puzwbofdFOXVwdjn3D12rB7QcehKZsoIwTGyqplQuOMWhGZCvnfTZtxN?= =?us-ascii?Q?o01NnI/bH0JGxwrJaOZhVNISNIb2u/B3iIcNkTPS62pJbjv6veAOxoAThHnC?= =?us-ascii?Q?hOuChOXl9cmHs5P/MvBxDuaM7+Z1+cy9yJZ8Kr6vDoVxmanUV/5qD0YcKimi?= =?us-ascii?Q?yOXSe5JAuH6yLYp0D1/1UvHmsoqEHEB261ezqK2zr0mUTHKmWpqKpQFtOtux?= =?us-ascii?Q?BmDiP5txBirG4nuF32NlrIgvjfLo2Oj3Xo1T13SoALBw+myNf9nZvJhLgxbk?= =?us-ascii?Q?pzA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38a9b6f0-9edc-40a0-9fa7-08d8f05a5a0e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2021 13:23:32.1156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gctGoFcaUvC3N2NakrHbuoRpf+Hao9Orit2c6whnm+CYxtvBBD534YggPNYhyUeUqi3ULuW5NpjC0QwhQ9hqIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4481 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: wangyunjian > Sent: Friday, March 26, 2021 12:37 > To: dev@dpdk.org > Cc: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > jerry.lilijun@huawei.com; chenchanghu@huawei.com; Yunjian Wang > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null > check >=20 > From: Yunjian Wang >=20 > Coverity flags that 'ctx->tunnel' variable is used before it's checked fo= r NULL. > This patch fixes this issue. >=20 > Coverity issue: 366201 > Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread > protection") >=20 > Signed-off-by: Yunjian Wang Acked-by: Viacheslav Ovsiienko Thank you for the patch. I suppose, this one should be the part of 20.11LTS either. Could you, please, add "cc: stable@dpdk.org" and send v2? With best regards, Slava > --- > drivers/net/mlx5/mlx5_flow.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index d46fc333d1..bb8d09cdef 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -7899,10 +7899,11 @@ static void get_tunnel_miss(struct rte_eth_dev > *dev, void *x) >=20 > rte_spinlock_unlock(&thub->sl); > ctx->tunnel =3D mlx5_flow_tunnel_allocate(dev, ctx->app_tunnel); > - ctx->tunnel->refctn =3D 1; > rte_spinlock_lock(&thub->sl); > - if (ctx->tunnel) > + if (ctx->tunnel) { > + ctx->tunnel->refctn =3D 1; > LIST_INSERT_HEAD(&thub->tunnels, ctx->tunnel, chain); > + } > } >=20 >=20 > -- > 2.23.0