From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC9F1A0C52; Wed, 24 Nov 2021 17:37:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 564F940040; Wed, 24 Nov 2021 17:37:33 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2066.outbound.protection.outlook.com [40.107.94.66]) by mails.dpdk.org (Postfix) with ESMTP id 769844003C for ; Wed, 24 Nov 2021 17:37:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8uY8toTgYnMbwlDzzOZJZZUQqZCLujRC6rhCNOaW5wsC2Vd6ktHqySEQGHRbTIGzPCaVXSHqTKYw9BRNlL0lHBEgriyVQ/P6XOYm8fi6n5wLz3779+R7IYPK/6sgf6cwVGHNCq7TYKHcGn1pWjoC9KXJy6tKqpq1dUAjqQ5h/e5FRYgMaIa5jHCkyDpZ4f7HonN6SRNVzjl2Q7GeChIl46VX/yErYbFUE/JCMEGFjViNpQkVEFekOK0WJF9SWMlC+mPdNZfJqvI5ChdBb1zoc1/1XE+bL/xhONFo1YRLPwIviBKXyVnf9De32yWKgbTAFhBakBSn3b2tIzIb2lQ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0g50boXrdvYhV/LYMLdvegq8My1k+zEnrPHM1M6cPbk=; b=lAq9MAE/eJrStxuG1jal0ozm7Q8GVfP1D8733qpPrlgSjMrcj1XoU8VIbsqpd/XDCCdcDW+S6nVvzWHGwjwf1nfxdv0TRlf1Cp5DLRFEFc3MpJe0M1A5VdSuiPBSTKjKQtbe7o6RAqwGEbwrMLp1yKAvXDTDuLSLcOOZpnxDIa3YqsMiQq9uDg8kJe/nfTWw1RFce5bnNLk0ui5XEwSAyMa4smTbZXiHPK4qA8XuXY9t6qNmSlMvKjMp5qKuUByh2Z5PJXxpUoFcmjsIpRUNGMy2uuIuR8asmNmdzFEhiOjsas6WH4MucZJFCztbrgsdGCKI6volncrshJYXVl86/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0g50boXrdvYhV/LYMLdvegq8My1k+zEnrPHM1M6cPbk=; b=af6PuQPXCHzjFhmrHqmtxkpBHt3N6Hej8Gf7SzDBGPuRIvxkvjZfA8VIVXpDqAyr1k14SKLis8NE1eRjkx6J90FiSQGd+O70qFwf5l6x5unsd5q028Q/pyhmJJfEVBnea1kJOyUu/K0UGUA1JD6CONNdacIMgFd9X7/Qzshl9sv2bqWS1qyWlhFReSVE6egskdifUT5JA52Xlw6+J2pxqcecrmY7dtT2KT2DjpvxivflmZ459IQvRPdrcFmZQzxlNCHqskRL7JCawSJJVhsj6cp2S0OrR8a7ow1sxSnKzjYmEwV9MKLp25muWbOjM7DRZT+RYewZJQg3y+hNoFZfVw== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB4580.namprd12.prod.outlook.com (2603:10b6:5:2a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Wed, 24 Nov 2021 16:37:29 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59%5]) with mapi id 15.20.4713.025; Wed, 24 Nov 2021 16:37:29 +0000 From: Slava Ovsiienko To: Ori Kam , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" Subject: RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Thread-Topic: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Thread-Index: AQHX4UlWIFQ6Z2FZ90Odbm76K82hcawS3BcAgAABdJA= Date: Wed, 24 Nov 2021 16:37:29 +0000 Message-ID: References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211124153756.12198-1-viacheslavo@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 410d153c-1140-4596-d960-08d9af68b4f4 x-ms-traffictypediagnostic: DM6PR12MB4580: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m69N1M8KEKGcbsDITHG5pJsILRfV1kMMjDRSTdxGe3h7qyBg9vc0ZHolQ/GjN7oGT9t3xmHg5QGkgzqE+zDv8wVtzEG+rGBxtVnEuHaTZ6gBk5v/OV21cVo0s57fXTqiYzGLxtIObFil4wjsia5P+viAChGB0TZ7AUnD+qUqOZICpscBmSLJEecy1unZmsZfX0kixPkqb2RHbco2ka5kkOondc0HZ6ad9JRmW16/FWcO5y/2Bv/kOK0J6iiO0hCwsL1RCKMnLRQuc1lx6uS09Y/tPMxC5LeyiUbCzTsi7+CVot8pxKFEl9kryRKyr98rdIomBZ1p2uNeCzJ1Oni0HTjV8pF3bSN3LDubh0eMWMrcjh4uH75J4OucFLSPj8QMPDqg7MxG4+xhMMqsiJpJQCg+Ar8F5BiEl7FHjf2quu4GLpV9aYQtdF+0upIgQO7+mWv8GiwJhE+dxnHgyniS7+EYtGhOwfKgnaqj9F5+WeJj/NCYcCYiA1CxW/zKPNqdkqi0e3sNUeSz8INHRoaukeJEKzbaJy4uTsTqhG3pQNNOUOkQsQn8EvMUIg0uqxNG4LL76m1PdAAdQua00m7vSRlC4YlDC/8xaY4GOSPSfG87P+ZWwOZAJHkI91zfP81iAMffd++NJXGPjjxjgh0r/3LVWEd8dvT8AH9AIITFtBNxHyfWDxyy0vjDwvTLoPNfAQar0b434uXnzBi50HaU2A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(33656002)(4326008)(71200400001)(66946007)(316002)(86362001)(55016003)(26005)(66476007)(5660300002)(53546011)(76116006)(122000001)(38100700002)(52536014)(186003)(9686003)(38070700005)(54906003)(66446008)(64756008)(66556008)(8936002)(2906002)(110136005)(83380400001)(7696005)(6506007)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4aVtgx+rKnj0ru844Fs+I0aImAY0qvgyAtP/rWb47mfd8FccZw8qnWsUlMXg?= =?us-ascii?Q?Yu3uVRcE1cTw8+f3AXSqUn4JSJgq2LLY55NMFId2LZNKr4NNvNC7qdmf6U84?= =?us-ascii?Q?RS3dFXU1iJa81fMW0f0O7jENErFCfutj2cxPOd8rWzjW6FbQ51JkqD5xIsD8?= =?us-ascii?Q?Ss4RjwaxMdDdhuO6P9u7JnVa7UNIkpwKW8C++LRuuVjhFAsbNTcZ3supwCnf?= =?us-ascii?Q?THmQM4PKYMgSYvEezIUYRiL/nY2CAmXJwkh8wPQuwyMjaZqHHVDk/pnSwrVm?= =?us-ascii?Q?9YSCAoKGSvfkV6N/kAQKh9yT/V4Zp5rpYfZaGUlLB2DUEbjIb5bUr/eWCF8d?= =?us-ascii?Q?13x7c8RIdyEq9mRQJbOBAzGz7nPRxCD0eiYNBZ5KlthIsMayb5PLvJEWl2G2?= =?us-ascii?Q?3gePiDQKmjfiG9YUAUcgktfJ2AkjorjpmI34gDeFe2Q/Te26AeF6diQ66Ptl?= =?us-ascii?Q?RBjYKYnCyTxoknT5FxaqWqhHKgYeXKlRwjLVUUPBvmqHOPjrlPg3CYUzGojq?= =?us-ascii?Q?Hojfkv3BquD671gMshYU6l/ICCOt+3UqVDvyRYoTN9mDY5GaA9CHUPTHhB1/?= =?us-ascii?Q?k06x16QNgFAxUZRTpq15t5/9kdie6lBJYoU0NmSYl17jgpr30rFIaH9l0HVF?= =?us-ascii?Q?KjCtpQhgOlzmyRu1UCZ7sdjZEmpBN1koiTbC293pWY2sq5E3SxaBczGCQQLi?= =?us-ascii?Q?JBM5+66555e/AE1zW8fk4nNG70JlP6M9ZaqZiDd5QhdXlu2Pp3Kckr+YNvY1?= =?us-ascii?Q?+KTh432ATj4ljx05pzF3VaQIs3BK53ap4IDBLU2IA6YPrUyTuoLlDgEwVT6b?= =?us-ascii?Q?YRHsn7zAzNtBg/v2GiuvY5+rMGnv3yEdV1bTF39593dy3QvkRBm4GggpqJKe?= =?us-ascii?Q?r2nx5CqThnmgrp4WY8fkjsk0EBXigUakNvn1TLP4RFBUXamXA1GcA6LF4w2b?= =?us-ascii?Q?sVWHq0KwVBMYlnbmKgQ5bsdWJ3LwAnzSADcxdUl8YPrBwWRNTjHUC6W3i76I?= =?us-ascii?Q?0iDOxye2AsPeo2VWGn/5nYR1vW4BHXuGnPGl8HxV3nwKjoGio6qqMBWZL0Da?= =?us-ascii?Q?r4fNPEOIupdqWlchJkqwFTU4Mk98l9o5nMjKiVSODdijolicT6ZF7UPJi6eN?= =?us-ascii?Q?GBqNCxwHYY5Sz0woNamgeamNzx+gPev9etu9NvrFojAyCRVWRRyE2pOgfNJx?= =?us-ascii?Q?8aHDJXHwf8M4Kv5JvCwjjR63E4DuKv6NdJD3PYauLuvsShKwVMa/YIQIlCoF?= =?us-ascii?Q?XYGVPwBZgW1z8FUNxB1J3GYPJTecDKDte5E7EAQYfocw5fth/LOdXs0g7xMX?= =?us-ascii?Q?WfX1HQImTHyL1nX80ckrV+SzDxKQtgq7AxM7zGEEHuoxONiLY3FQMAEJKLlj?= =?us-ascii?Q?e0pIGJpaGZtzh9ur94VciwPabFk4sDzHAA5UZOqGlAsnKD70FmiTzNFVQIHz?= =?us-ascii?Q?ULop7Ffn2qHTwyA9DPUsQ/DDjhTatebGOtDWoQTUH0OGtu38zoHU3JxLCw/J?= =?us-ascii?Q?PSEjj8oxyhG6UkTi0b7Hx0TGWVgtqbzvCHo21wwkxjNQEfnARAWL8LLH70i7?= =?us-ascii?Q?TmCna6vCA1s/OwfXadB3IislnCvBZXNydUdcbN44KKUr8dUcZlWxXSmu5VvB?= =?us-ascii?Q?2Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 410d153c-1140-4596-d960-08d9af68b4f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2021 16:37:29.5571 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f+dOLXtZeR/BzGi9l2zVvAPDed1nFPPhb3N4/JpZ/1msezLjs3SUJtNcIsTcx6KEjZWr5waSSnLGVH81MgzigA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4580 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Ori > -----Original Message----- > From: Ori Kam > Sent: Wednesday, November 24, 2021 18:21 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: ferruh.yigit@intel.com; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Subject: RE: [PATCH v3] ethdev: deprecate header fields and metadata flow > actions >=20 > Hi Slava, >=20 > > -----Original Message----- > > From: Viacheslav Ovsiienko > > Sent: Wednesday, November 24, 2021 5:38 PM > > To: dev@dpdk.org > > Cc: ferruh.yigit@intel.com; NBU-Contact-Thomas Monjalon (EXTERNAL) > > > > Subject: [PATCH v3] ethdev: deprecate header fields and metadata flow > > actions > > [..snip..] > > > > Action: ``OF_SET_MPLS_TTL`` > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > +This action is deprecated. Consider `Action: MODIFY_FIELD`_. > > >=20 > Since no PMD support this action why set reference to MODIFY_FIELD_? > Same for all unsupported actions. There are some references to this action in PMDs (for example bnxt), but the ENOTSUP returned. I.e., action is in source code, but actually not supported. Hence (due to this and in general), we can't just occasional= ly remove existing actions, we should deprecate these ones first. Other point - if someone will decide to implement support for this action in his/her PMD - the deprecation notice will point out the right way= - "consider MODIFY_FIELD." >=20 > > Implements ``OFPAT_SET_MPLS_TTL`` ("MPLS TTL") as defined by the > > `OpenFlow Switch Specification`_. > > @@ -2254,6 +2255,7 @@ Switch Specification`_. > > [..snip..] >=20 > If no PMD support this why do we want to add it to the modify_field? > Same for all of the unsupported actions. As I said above - we just propose to consider MODIFY_FIELD actions if someone has intention to implement deprecated OFPAT_SET_MPLS_TTL. [..snip..] > > * > > -- > > 2.18.1 >=20 > Best, > Ori With best regards, Slava