From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96B0BA0093; Wed, 9 Nov 2022 08:27:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86AEC400D7; Wed, 9 Nov 2022 08:27:59 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by mails.dpdk.org (Postfix) with ESMTP id AE795400D4 for ; Wed, 9 Nov 2022 08:27:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdsSyE+06lpMj756hqF9axyrOcjc20eJYjMmrBbj5yxUo6xNI7oAM/VA7OmU6LgbhwNqEeRWDVcjeh4QIMq1RpeGl+MCKuwrbvnBxWCfSy+PqJu1zZdDlOSAt5Er7AHqwsMOGAVyL40AGBROOzzeQiurnd/v3RYdtRm/n+VehI5MFVVo3FzXuKfqFWlqYjDl4C1emEb6TLZfPZ8iYM7isDoWjqb1LaNgSJVj9rikBXZofAJRreiCxFr6Xglm16tJfSFm194wN4+tE9ZcwF4B4xPdlA6JwIGutoDacoOj0RRgv4wvd0jDxW6deKqF2847PyUeTGtuUshFzQ5VElb6tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e8PkYyn0ISObb++AWSQ7ZaHUA8sAkJtAdaiTe+ydA1g=; b=NNk/FPjBRe0GXOxjI7vrp3PizbOu1lZgxUbYHAK3WOZ14Zxpe2lMYKYOEW/AMksAzqb0iVKWhvXtNDr8XAgHoq65cfFojGbyYdeeQsq0qqwauiwa730BGUVXm9kJkjW7RF880KamKn+q7bw0Wf1zbsVsYSn0IbiGXBWi1KIHlPdjERN+ulvytZdzScPTmiG2kEMzXxKaddJ4KfMqgXsDx80/u5xi5AKW50GWfBH6qYMqbbJnN3gOUMcDmbVJ/vdnG7o9+mAG/gU1d1ekGlGT2JtuCQN517My/UIjFADjkukHge5FxqnC+L18ZpnwFC01MgMtjlM/duA/OTgiwzTmGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8PkYyn0ISObb++AWSQ7ZaHUA8sAkJtAdaiTe+ydA1g=; b=GaK67yq+mdh4db57wxj9eI/rcDHY01Y7S7uM7iTbuWPdTM3tD6cpxczCFUw5OVIeW+XixOSy1/UoKQLj0hEUCeDy6Nk0AhvgMUBb+gjxsGOtUQZ0WReLnru4hld71j6Rh2kJT2huZzfDURJdzpveTew2tDU+Y6+PhKwkrCZ6oImfEVmydVlsNWl1MQmZYx1CkNjIU76V+Gkn66fcgXnc1hmjkDoSLY2W7eUNySVYaA99r7l0alTnL1lFWXYVbdbnacPpxpjbfx4oyTe8MfuM2hEgA/vBdM2FY7ouopXjrQ43s3kbmEj3LNOuFQgRe+Zxgd/SDUJ0ay2BbSTwosVjnA== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by CH0PR12MB5074.namprd12.prod.outlook.com (2603:10b6:610:e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 07:27:56 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::7c8c:ea68:bd84:9458]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::7c8c:ea68:bd84:9458%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 07:27:55 +0000 From: Slava Ovsiienko To: Suanming Mou , Matan Azrad CC: "dev@dpdk.org" , Raslan Darawsheh Subject: RE: [PATCH] net/mlx5: remove unneeded GENEVE option length assert Thread-Topic: [PATCH] net/mlx5: remove unneeded GENEVE option length assert Thread-Index: AQHY89xJGn3Sq9Cx5E+LVyuic26q2642Mbzw Date: Wed, 9 Nov 2022 07:27:55 +0000 Message-ID: References: <20221109014018.23965-1-suanmingm@nvidia.com> In-Reply-To: <20221109014018.23965-1-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3753:EE_|CH0PR12MB5074:EE_ x-ms-office365-filtering-correlation-id: 7e1e8fae-80ab-4797-3d46-08dac223eb9f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1AFlPsUc5dA6pudfTI0uygQLbH3WrhuYJXufRGNECToAY6c0nKqT4zeA5PLyD3VBt356ulzWs2iplXV5racA3FfSu3EbivAT6TqBLT/zk9NiSQrCMPZPCoUYroQWC1um3UtNvDd0m4r4tyCcIxojL7SAC10WBIOomAzqMUj5dW/WOo0jcYMXZ8BKK4unWpZg2ghsIJtvcHqxK8cY23Qfbz8yvu54jWB1pHtHESlBTa6EvixP2PyLNqN51jgLOUCn0NxSZlB/PgR1pKdl6u+AB2e3PGYbVu4auW6OURwIFUAAgJKP6/DehW/OXcv0iGXz/l3dkoa0HZ4EVKFkNLUgMlmNARkJl3pQwuZlfmOP3cqteCTO8BEnjsrlWBNvKvXnw/GUMbgKlfht2YSuvSyy/B+VGiHGEyU6ZWd3uJHHoKOdP6GeNWgn7Y3fM4lF1NmPTBGZUyI1e/NRLgiOXousXrRccoVnuGilnyj4zyo0IVknPPmPrmLd2IuMgAABRkjGzh+BdXyEdn4/2Gh0VAsB107HDJuMvSb4sLvXyjU8k16rWWiDv1Q4Fo28LiBYzraPvrdVVUAzFvJfcQFxOU5VKfOssgavd+XavJx/f26Szjy5cIlP1De6BT8YuMBLmfHobNdQwxkICxDxcGxlOKS/PK+4qU76RPvw6iL7RsdRlxi+HkhVpww/o6LBko+uAZAl+kLwiO+UHeZmFQnq73/SUbATYgUIxU/ir0EEvVt9ylbEQ3nWohd3OvqWhYRUCixDQT6ozbJsyfpUcUBRnQRlXA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199015)(54906003)(110136005)(478600001)(41300700001)(6636002)(33656002)(107886003)(9686003)(316002)(52536014)(186003)(8936002)(26005)(5660300002)(4744005)(38070700005)(53546011)(66446008)(66476007)(66556008)(76116006)(71200400001)(64756008)(66946007)(2906002)(7696005)(83380400001)(6506007)(86362001)(55016003)(38100700002)(4326008)(8676002)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BXx9lLatzsXOyKvOdPqBz5sWRIDBNphHYTURtE80L8QR344P3k5dRrbXBd1X?= =?us-ascii?Q?y3kOA/n2smERX+epvBaX+JJZNMkxTyRd+0w8Ctk4eK89i6OY5yD79MNBybnW?= =?us-ascii?Q?+sHrF/Zw/fLTaTaIw2tsLDWTihQBomeIWDNEu/t1JlyzqwNqmFwwj33ECoiK?= =?us-ascii?Q?rUMKp+DI39PAI4IJMMZr1gBS1kowMfcDR+j+dGPfiYWzcJnMYue5+ucZ/ejz?= =?us-ascii?Q?5c+pQcu2I14lkPqOOROdk7Nrz38dKMQ2EskA/qnzUe9f8vfprgINTAhVysBO?= =?us-ascii?Q?tG/1JB2uqkzCsIoNznl0RSUKVB8kMAjK0qOmUIRD6RLKmKs3SoM5O2kQ0Tih?= =?us-ascii?Q?x07T15lBkbCXXp01J7No5ZaU05hVkVJVB0JIx963vpc0Q3OlOKT3oYLd6Orl?= =?us-ascii?Q?/8uC8L7ScdBKgFC2rOaTJTnq0xwIkklNrbL5dHw690sr/4rxbF7a/xJVypqU?= =?us-ascii?Q?gA2BMtr2rlZaxdqbFGKZK3uwQIMYdw2fCZd5UK58dMQvbanPbH6ZyN6EuOX9?= =?us-ascii?Q?jK26Ynb2ZAYfu21nV1hkmMoUb7hs81UpefbD3xi+MbDowBsHoWffeqsd8iYz?= =?us-ascii?Q?mPYaJItudp1xeC9HJZAXh1NP60PMsgNUiQEH7iVNN9d41Z09OKsvJ8NhZiTh?= =?us-ascii?Q?yfBgpgQ6ckFjI5fmPnrbiHD8KhWJXFoRv43EIzZE4/ZeH0k7DRkNC2Fz0TkN?= =?us-ascii?Q?2I24IWu2NLn6Y0osVQ9Cj0iFN6iBw7/NZ20LYrJ4Z35oVaMcFJUs42BqJFUN?= =?us-ascii?Q?WQgpUYvSptIygQdkQWh84RzuR8M4Tml/Ze4Zy55ekZMj0/OEUdi4xyo8xJAB?= =?us-ascii?Q?MCBCW4GOiXEwvbzWAkEI+RKPundY4kb/YBV1WK0PQTSKLVYy2JdapwDeqUTs?= =?us-ascii?Q?juKxyDL+ISdnsE3sUZph6Sc7O+kv700HCKlA7tREIdKeMuf4mSwUhpBu+XoU?= =?us-ascii?Q?hsyZH3x99RLP2mfdtvgEH6DfAz1ip2acIOj5cQtMqNOrg1/DMtvGEBaCk6s1?= =?us-ascii?Q?1+t3W4yXld70SwhmSxUI4mTCOhD3/xtUhqHp4EVOodihTq3fGyEYziMDVqhe?= =?us-ascii?Q?W/mzjqCS9e+C+iKO1bxb5xeie4LulRqDKN9KnD7ajQwbx2FtsIFj/rzu27sK?= =?us-ascii?Q?Abi2v8mjHFF+uvE4YJ70n/eQ3JzqHiEkfym9r2X3/rlram/YpizPWkN89jma?= =?us-ascii?Q?6VE4Ixqh8HEomzBSUn6z/Is+eGgAzcm01CURv7OM5oqyW1unQIuYON0gfbz2?= =?us-ascii?Q?QQymn5/fRUzo6wurUuviywlNQrL6obujgD4zgW1Nkp+eZj5sdmK9tHtbKuus?= =?us-ascii?Q?EVY3R2oszqlTog316bWgKOBSuN9uSr84PsLW9Fg0JAZGRK2crM/Ie7a+HgO+?= =?us-ascii?Q?/xtnZ18RvjE8o+nV3XEHjnguIm0AZurF04UlqiToWfnLP+Qz0cutvlIw7Od/?= =?us-ascii?Q?4VO/Za/Ih/+v819NpKQ0TJK6b11fg9mjrjUjkwHp9bCHxbwd1R8CWNRk71/p?= =?us-ascii?Q?ulNMLcs7CCsO0dGvbG0qpL+nw09MbkhXwb58iTkPjWuk5EGk+bleYoH7SlSb?= =?us-ascii?Q?+0dtidv/Zzv9pvUptgpiKoFU5NHpxKCn8jPmXLSV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1e8fae-80ab-4797-3d46-08dac223eb9f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 07:27:55.8759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wr36sf4Vp9Uz9ZYzpLZtl6610OQWr/ACZjTdWM2adVjla9+nZAcnr0iBwNvbBc1qi3TBKKeoLZMAFgVBrI7SCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5074 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Suanming Mou > Sent: Wednesday, November 9, 2022 3:40 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert >=20 > In order to share flow items translate code, flow items translation of sp= ec > and mask was split individually. >=20 > In that case, the assert for GENEVE option length with mask becomes inval= id, > since the length in mask is bitmask. And as memcpy around the assert alre= ady > checks the GENEVE option length, the assert looks redundant. >=20 > This commit removes the unneeded GENEVE option length assert. >=20 > Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value > translation") >=20 > Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko