Re: [dpdk-dev] [PATCH] net/mlx5: fix default CQE compression config

[Slava Ovsiienko <viacheslavo@nvidia.com>]

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Thursday, February 4, 2021 18:07
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; ferruh.yigit@intel.com; Slava
> Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: fix default CQE compression config
> 
> CQE compression must be enabled by default unless the rxq_cqe_comp_en
> devarg is set to 0 or FW cannot support CQE compression for some reason.
> The latest commit that introduced checks for FW capabilities for new CQE
> zipping formats disables the CQE compression unless the devarg is 1.
> Revert this logic and enable CQE compression by default again.
> Please squash this fix with the original commit.
> 
> Fixes: f5ae0d46b9 ("net/mlx5: check FW miniCQE format capabilities")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

> ---
>  drivers/net/mlx5/linux/mlx5_os.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c
> b/drivers/net/mlx5/linux/mlx5_os.c
> index 79a4376f91..2dc079779d 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -867,6 +867,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>  			mprq_caps.max_single_wqe_log_num_of_strides;
>  	}
>  #endif
> +	/* Rx CQE compression is enabled by default. */
> +	config->cqe_comp = 1;
>  #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
>  	if (dv_attr.comp_mask &
> MLX5DV_CONTEXT_MASK_TUNNEL_OFFLOADS) {
>  		tunnel_en = ((dv_attr.tunnel_offloads_caps &
> --
> 2.24.1