From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F432A0524; Thu, 4 Feb 2021 17:11:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB60E240693; Thu, 4 Feb 2021 17:11:15 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 6EDF824068D for ; Thu, 4 Feb 2021 17:11:14 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 04 Feb 2021 08:11:13 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 04 Feb 2021 08:11:13 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 04 Feb 2021 08:11:13 -0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Feb 2021 16:11:12 +0000 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Feb 2021 16:11:09 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 4 Feb 2021 16:11:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K29sSHCXnUw+0JCHGme+NSAuWnKpoCxBQ0GJjEcgFQJN8LZaVZ3mQ5lYGDAXoTcAWyZ7xlDq4zSaKIw03jHX0ezw36gv2pscndF/FNv2L6mq+C3ON7HLui1aw5IRr9i/uj84cNwan0mf9yKZcYzWWxqtrb1yfksl+WruD4RZByIId5uD2QbDWE4ZWxWi5fXYAkRbCYq2mTS3F3+Z7HTiWxQMEw+ePgHjK1TAE7SUwL6V5ziagxmk7oEvEsIvJTr1gSfv6gnbzWCzMR0Su4rGLRKGM0JmffJyMCnAa47QMmyGoC9ULJTynoLWj0QBxUuasgHCwqio4AcUHU0rkSPrhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nl6e53HyPsydqNpR6Q7P4u5YKgANHI1ErKVTKfdmpfg=; b=hiWQYfgorhV8zBetRRbaAmtR9Ms0xzHaY0fkZSFl8VtgX4d3l+LmvN9Wjw9qc7+hYeU6Y/D7/fVmfAqUjYbKpv5z5Hko8zTOs01YVSM49Msy0dgCGIheBczf9u5hxmHUpMZ3KKhl0hYqC/I4girooZwRWsI13bJfQjflIaMtrV1TSndrHW3jjAxzWl38enlIu5TID4xCNuSAEYvL0QBVc3ZOb+812eDgyufuXTEsPndgRcY9u9s1BqoPePvb8oyJvE6CGOUfo3NK3tCaf9dRH2c/je0VgXcU8Hgoz/D39xOdP7cJnR3O9LVc+JGSCSMtRXkXej2kejmjw2hn4Rnc+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM5PR1201MB0267.namprd12.prod.outlook.com (2603:10b6:4:55::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Thu, 4 Feb 2021 16:11:04 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a%5]) with mapi id 15.20.3805.028; Thu, 4 Feb 2021 16:11:04 +0000 From: Slava Ovsiienko To: Alexander Kozyrev , "dev@dpdk.org" CC: Raslan Darawsheh , "ferruh.yigit@intel.com" Thread-Topic: [PATCH] net/mlx5: fix default CQE compression config Thread-Index: AQHW+xAkaoevN3quGUqTF1PwKVf7TKpIKnTQ Date: Thu, 4 Feb 2021 16:11:04 +0000 Message-ID: References: <20210204160728.16048-1-akozyrev@nvidia.com> In-Reply-To: <20210204160728.16048-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69488c36-3e12-473f-93cb-08d8c927794d x-ms-traffictypediagnostic: DM5PR1201MB0267: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:632; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jC1YdGoJPBlpDPBA4sGG8XD1qbkKGojT9Gkng1qfDsxPIxCzaL6NuHU/T57F/+qVC/cv3S9aWHM+JfokrkYedl7tYpA7oT38FBbLb1KIzlciQFFW5lur8soRe8BKoJyLKQ9CUF4FIIQ4kbG8X6U27NaAS6epr6fVrxVVdYWvjgsEgcQeTnyLy42w/nLSz28/to/6K4rAmIJZHktDELTlP5je/T5FyldIqyeOk/24NVrjNdkGw88NRulRXsAmVZO5NIWdOuOHApd9oHgMoGpz6uIky7gwnPbUcbR06yXMq7f9HEdWwBszTV/HDC7CI3/1bskpX2VIfmVYu5lX1iX7cQ5rlXE5eSJZ2Xf0HmFeMOqr7XLq+3sN80O7VeTebXbA8eHc3d5yD1qnP+j2SLW2cT8bYP3pz82CHnQFX1THRD61D7TduCCHn2SiEKma6XippPTDKQWelUuT8II+P9HjzEl/x7DZrjVvwz6kCUfmvRuGSuNMuBZfAuyImsFapTgV/jiqir6kFYA/pWkr0WV1SQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(54906003)(110136005)(9686003)(76116006)(66946007)(478600001)(33656002)(66476007)(86362001)(26005)(4326008)(316002)(83380400001)(8676002)(52536014)(64756008)(7696005)(55016002)(71200400001)(5660300002)(53546011)(66446008)(8936002)(6506007)(66556008)(2906002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?xtPXAMHrY9RvsJMjnVwbmpRW+hlf5xAYhD3o6JH5/yY2AOemEQSQT8qKFy7U?= =?us-ascii?Q?QC2deatvKChRsbODKINKvC8Sp6LkH3oOPeQoMyJMhbwVIptHPDh+pouBI+np?= =?us-ascii?Q?zza0hJPTxJ5w5vy9YzWnELdJYvPC53GAoOB0WYeXKvHd/yDOvUk81kB3K58h?= =?us-ascii?Q?mjyZCzckuQ8oDfTuHf4kLFNspI/BOA3GckY+W9Lcgg8Kr/b/293QmY0DtT3K?= =?us-ascii?Q?WrQrYP3Stq1XLfGt9Ig5lcJSnIfZ3mhB9MFMlxeFoAEZg1PmsgQhpbsqGXhw?= =?us-ascii?Q?nkW4Q5/dgvX1cUaGgojtkNMkIPki4ySIbbaXCUtH+rEbiu7SW/4niRQlaGyD?= =?us-ascii?Q?bo1U4k2Xhl8zeMMwyGzB6OwITNuU+sOkm9PTHQlpo7oMsUePZIcP6OowRDbT?= =?us-ascii?Q?pj8jATzyGm5TXXLkTJVt1R2SPvy9NN4DjdTHpny75K3d8mbTkV8P06rfwUUI?= =?us-ascii?Q?BC3SSx7q8WxBaov/4KxeoZJBfJE24a5MxldpgQn96OAaFSxVleOeBXbzH/Tu?= =?us-ascii?Q?wIQwiMTZUbLetNzHRdqyPYHHsIIcCM7pfUPTrulxYUrzbZ2vvyQi8Kn8tTB9?= =?us-ascii?Q?7YSLr9L7ZnJhlP79NNzkunJgtMTIyoxyRmc1zd/d6UgXjtQRIOEBr073V8MM?= =?us-ascii?Q?CFG+Cm2SnvqpQkaB6QvBzuW41QKBpTpYJruTSu2FIpNNCixe/a6kPG6boqTd?= =?us-ascii?Q?62oqq7707c/3YccZH+7z9Xc2bNbcUtQPNKFVXzGOJGvvZnPE9XCbRJVC/h9I?= =?us-ascii?Q?nl9R4iTqYu5IUMtwXsgC+punLye06h7PIeklvPqym2lWDaFpESCvHWCYFok2?= =?us-ascii?Q?xYndUAHzU1JktoX9i/FGnpGynnRYgHYB9aF5ya2nLR5ek4wR2W+x0e71fwpJ?= =?us-ascii?Q?bINqx9CQfx5B9cmLFbhOiPiaR/6E9opUYqjh+4TcVXcLtGK4KD5BkjdfueGm?= =?us-ascii?Q?zMV7jUXA8dEpNGKgItJoVWYrvJC4zSr4px7shWK1twzItHY961wNJF58DJ4j?= =?us-ascii?Q?8eWoTjxxJ2/Pv/+eLqdY8+oI56p2gBo0axwX77l95pFIhcj5+iiIt1eZhKNI?= =?us-ascii?Q?5GLMsxqm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69488c36-3e12-473f-93cb-08d8c927794d X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 16:11:04.8100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4j/UTc3oMKmA+/rmvQ9C3Ul4bqhfu0l3TJ1CanlOhbVPdQo5YfS/gyveJnbU4rfQVjwGu9CX+a5LvVsNILFuSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0267 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612455073; bh=Nl6e53HyPsydqNpR6Q7P4u5YKgANHI1ErKVTKfdmpfg=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=j2ALcJv4AGCN6B9kvhEXCjJF10nU2mMn977ahD7u/spsuvt3TiNcMD9eUM+64XUao QnwRxTFoHWStL38o5pfwDFlSxaRNaz2MszFliGtc0oJJ/h58W/x67jeU7M3j9FxBfW dwF4DGn0nuztow916Va3FV/MaG94Zl3xYXulPecwmIqzloX0Lx6zr68i0+UC3L18vS lMvpCqCjpdbNAHBWGGC3NX/TJg7pFWqhSo/sA4Vkyq2aXgLKM5LXnHnGHn+yTRkbFL Wvi2mnw93q51LIaz8e2WRQnqynomPNvr1wN4/3yeTY76hxGNzMXNU4nXz/KSws4Tbb QeFFR28mclFQw== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix default CQE compression config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Alexander Kozyrev > Sent: Thursday, February 4, 2021 18:07 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; ferruh.yigit@intel.com; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: fix default CQE compression config >=20 > CQE compression must be enabled by default unless the rxq_cqe_comp_en > devarg is set to 0 or FW cannot support CQE compression for some reason. > The latest commit that introduced checks for FW capabilities for new CQE > zipping formats disables the CQE compression unless the devarg is 1. > Revert this logic and enable CQE compression by default again. > Please squash this fix with the original commit. >=20 > Fixes: f5ae0d46b9 ("net/mlx5: check FW miniCQE format capabilities") >=20 > Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/linux/mlx5_os.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index 79a4376f91..2dc079779d 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -867,6 +867,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > mprq_caps.max_single_wqe_log_num_of_strides; > } > #endif > + /* Rx CQE compression is enabled by default. */ > + config->cqe_comp =3D 1; > #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT > if (dv_attr.comp_mask & > MLX5DV_CONTEXT_MASK_TUNNEL_OFFLOADS) { > tunnel_en =3D ((dv_attr.tunnel_offloads_caps & > -- > 2.24.1