From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 710E2A0540; Thu, 7 Jul 2022 11:43:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46F5D40A7B; Thu, 7 Jul 2022 11:43:34 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id B0B41406B4 for ; Thu, 7 Jul 2022 11:43:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SISQ/E65JVcfeFwGsas4ma2Yr0LqXszFWyj52ZAyNmW+FubIID+Iz6D425iovPkiq5wq/1GhyqFf4sYKNDuu+FalPseMmhmr41Y/yUucbD16k+ed1906dvedxXO4mQ11MvYm2hxruPYmjVEzkrUGB1X5kR8k2rhVAAbsKBFyP31TGGxnPV7IuAGxS58RednOxIMit0w8O9vk3yCx1voQun6XvvCgzf+l3j4m1Kee4jZHiYZYE+56lN5/VV9+aOXP6YUyeIRjjHbqt4YTPv3O4Yt1QgqfKZ+vrgc8YJgbCiSBC0xrRErgF//z17JTkumLgWyYcyc7MrQYaAZxS0OvaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KYA01VGc2E0iwSzry66ugEIewGQn52kyXIx9QaJb+OA=; b=PoziMg9XIN9GWzZhLz9YuJHclqzvcBaePZM/2Okpwuny/IizBdF37BV9kRXd9zhdQ6kYnfJwG71meII7X03XsKgqCaZ2qcGiznFmv2c6uwKymlF9gwsiPkIHZdX4LW+nLEDJzdcf0XyspM7jltUsW/s+JxVa/sUv6flcXRPT78CuPdAhRR0gG1Lf3mD9BONYCPengpYr6Z6yJ+a+764Z7p5qHx2wmwJvBwHpwfcHt2ZBZNly5J25J3Ieayk9DsKUIUNk0C5dUBCXAE2IX9FZELdWNRz4yYzECJaxxDtYZZKuSy22G6QK+CcCtH2DJDjZnYODQIMkLDk49kB2BoEEDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYA01VGc2E0iwSzry66ugEIewGQn52kyXIx9QaJb+OA=; b=PTIKuhonnbimC5McjU6DmXTx18uHXP1LnyNEdPfKiGGyvoLYvaQUg7A8UmVtVJhwACkVBoZOqa7aj4PmSH3Yb3xUDfnY9BvS4rkQ6Cf4H34UVlk3J8NITqvycdvQbvpeX2UtOsXbQys01zCaS4pimaI4hlq4Hv7rUi8Ji43ljWdETasw+qzsVnh14+6JvLI8gGUq4vO07YFU8XHVwuyvr+wWDpPe8sgn1nmYhIs4c2X7c7zrKjyhJ/JcYAOXYE6dKYG8J5P3KsSPRggvCRK8C+rK/OwBwDzd/NocihyAjy7cCf5eyerfVpkT/6459tpmJOt5/WmINOZ3xuT9LKdudw== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by CY4PR12MB1637.namprd12.prod.outlook.com (2603:10b6:910:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 09:43:30 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8cc6:67d3:8b2e:ff64]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8cc6:67d3:8b2e:ff64%6]) with mapi id 15.20.5395.020; Thu, 7 Jul 2022 09:43:30 +0000 From: Slava Ovsiienko To: "NBU-Contact-longli (EXTERNAL)" , Matan Azrad , Ferruh Yigit CC: "dev@dpdk.org" , Karanjot Singh Subject: RE: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process Thread-Topic: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process Thread-Index: AQHYkWCxRyA8FBblZ0GRWDMDBAsPGq1yqOuA Date: Thu, 7 Jul 2022 09:43:30 +0000 Message-ID: References: <1657129733-12126-1-git-send-email-longli@linuxonhyperv.com> <1657129733-12126-2-git-send-email-longli@linuxonhyperv.com> In-Reply-To: <1657129733-12126-2-git-send-email-longli@linuxonhyperv.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b884dee-bb17-4479-84ec-08da5ffd26a2 x-ms-traffictypediagnostic: CY4PR12MB1637:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JelNAyeNH4K6JB+Lo236whgsvqJjttOQkJm1U6RKRtjBoC6OPWX2NtGU406HbHocbJV+hwcl3E3y+tBAu0HvDEW+yz7FHihDrMkaREHupv6nEXttlZJMIaEF08tCy+vpY8ly82ecZYRqVwqfKtqpOVc2q8EyGZBH/Qyqx4HS2vwWnRzs0ZtD1whLGhFKQkNVDr2pTuJWyYBopIZuLaQnlMEGuQ6o8tM2JBCpEPamMLsfalaE6qqJvzR2AcaBQCrjGkf+5m33cwdXbV4mJEAtQO8DMp/i5iL8bbUW+nzmM3B6U2S5zzI0pB6YDZFdwnePuzX9LXPq4dSt3ak6zqR9fAkUAxR7fY2d/JzbMcIw16vJlz38RYAswHbVaVuDz3SbMBIv2o4XI4Cd1Yky/vDbFyYJ9pH8Q4fv5sz7YvtBphRxB11MLPLqsJJHg/3AlJP8OTADvLlcKKU5uMpWbThQpCDoD3RldTbPgxUUHyUbcCImeAvu7rjEzMc6dJSiD/oUiuqSAYuiNcc+s68QPTFfzYH9T/4Cq/Xvg6B7suFz9a3L9D9/GybDiHkD/P1mzYgcvwwEZ2ScvcoK3DixI60Yx++ggu1Sq3bEPoCZlr2ugxQYSZfrXL7JVhujqhGoU+Yd7YqNaxU3K4LQOx/cmCu9OQP1H0pFImLlw9BwRXdlZ3UvBof6c7zmecCy2JR7izl1x8fMzMO5J6ZFp6zwg/a4i4972oMF7eRzUKegF1FnBvV8Ros+Pw+eby6xXz4ArTGRhKn61SKfMhnzG1VtgA0Gna7tuRZiBSfzCqcgSCQ2UACbl9sxPCtEskT0ri5pLAny x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(136003)(346002)(376002)(396003)(39860400002)(26005)(478600001)(6506007)(8676002)(122000001)(53546011)(41300700001)(4744005)(9686003)(2906002)(5660300002)(83380400001)(7696005)(38070700005)(54906003)(33656002)(76116006)(66476007)(66556008)(110136005)(66446008)(52536014)(4326008)(8936002)(38100700002)(64756008)(186003)(55016003)(66946007)(71200400001)(86362001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cChRBvqTh2ccmrvhej5SvpLQiOdGtIdoWEM2ejIxXgO6SlShCflQUk9PY+un?= =?us-ascii?Q?sH0T2Q2X8vWLEzKf12JADlzHdimIHyoVUdbVzaaOswY+BnYxTRSErlEWnzvI?= =?us-ascii?Q?KX5FbbnijeJROaZAg9eto6OmFL0+yCWRKNzTL//tBsZDpHb96NFT1vO21ekz?= =?us-ascii?Q?QG9r7OmZW/hztSgLHVppnnc2ETwG40UxYcnz8NdwIncwBSJW3usvuVk7Y7MQ?= =?us-ascii?Q?wk5eAutGi9gJ3fliIFYg2RXkSwwcaMIwkFSjo0cIFD7xRyQ6EaQlohTDW2q5?= =?us-ascii?Q?NrPel1H8ASJOmNp67DZXO83uNR4SRXTfJjZfoPf0bCoemsLBjkHpMJOAg9L3?= =?us-ascii?Q?adHebrEbmakYybvEQucSNduxtyMEFNIZ/xMsAe9o7vN30gjZXs4B9bQaJLef?= =?us-ascii?Q?GN0JgE3JsSYVUDcW+pok26ctDRQhiaUypgA7G0bW9O/HBGkbEWYXm3Zh5nID?= =?us-ascii?Q?pG+pssSU/Zs6vXObtiaaIpJSenMvS2SoeefgLDK/YDM6R7JImYVTUWKt8CPK?= =?us-ascii?Q?Z15zztI7vIefZAzZrkDq5k3yfwG5+Hei9d6LwP36S5eoFlWYvpfZ11Z+Lw9g?= =?us-ascii?Q?bztF/7Af5xmmquiI6hAFkwOX5pa3qG+keiUepMLRZk0j/ViSP/7hrnu65DEx?= =?us-ascii?Q?ScxcKnK3NFhcVuW3Kvtvs8uyEJiHB2UNaKniw3312T7J9O8bqRerg/fFkuLl?= =?us-ascii?Q?CVQLqL8e0CbPz8wsqTSl6ipMr9viB0ISW9GscJmGOUO7yBUCCckPoYrr+sQj?= =?us-ascii?Q?vTfUYl0Dz38uDlfNiau+DoogUub9DIS3zdv0rvFqovZx091XnNW6EqyQVmCw?= =?us-ascii?Q?/6tspIYBcGyXN6SPhXNeuAnoU/eGK1FedGNVVkFhyqzoVRc1FK9uIkNnRhqk?= =?us-ascii?Q?rC1bwIIaYayiR8f7O/ndCe+ouPbg1EI+eP4S28WpRxk1ESW4R4Z/RiHNXH4O?= =?us-ascii?Q?kfLVfHd7SQ+HnoKjg50UGTzfL1bG8frTBDPVISsGwvNuRpd2bUTf9IXe7nOe?= =?us-ascii?Q?xvZZKw+HZYP7+d9zavKT1JSMI52O924SOU2vzQyvcSsUajQ3fxjuL3FCLn2W?= =?us-ascii?Q?uPNNiBYgwo9W1clMrqDlGdIdvuagTVwBo0mIzwmCd3sTHxUgrykV9LhJrqvg?= =?us-ascii?Q?DIOZwTI01FlmqamR50595v4VzlTNRFmMxydm2JZ+aCG3pH3H1cTQekbXrp2s?= =?us-ascii?Q?tME0hm26VxVYnZuZPfHDqH3AqLsc0/BJVSTIWVc5WizCeTfb5ndjf99z4Lb8?= =?us-ascii?Q?k/+PvIYu7OKCOg93MMTLVMUHrlzLg6672or/nhahn1PWribHh9sy6m3g6fyA?= =?us-ascii?Q?VsVPrr3bsRM0weSfftsd2EK5uuUH1czW3cF/hKqjbafjaVlRrEFTW9GOG38i?= =?us-ascii?Q?4PMIF2Gop76iUPAjsY/Yh8H9FX19B/FvYUjSS4uoebQsZhs0Dxv7zyQAaEph?= =?us-ascii?Q?E/vpYENKNVbpOs272+XppDUC3816MxRBNypFLu3V3bDrIKn0Oh9LqNfZJkCg?= =?us-ascii?Q?rAq2kQtxyGsNCjw7yeUSGzUiQf5Sm3flRqDS9HfoZuhvhvxEzdA2T8MWmIs4?= =?us-ascii?Q?BegmT7U2z4TvDMmfvpXS9r3iGxrxuCo9TGAPEyLM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b884dee-bb17-4479-84ec-08da5ffd26a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 09:43:30.5271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5XJXswoGNmNKKQC4qDhFt5W8NT9I6iXqEknL20E1TOYc997VfU5lF4t5PhtdLa2MauAMot7TCy1F4di2ILAYcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1637 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: longli@linuxonhyperv.com > Sent: Wednesday, July 6, 2022 20:49 > To: Matan Azrad ; Ferruh Yigit > Cc: dev@dpdk.org; Karanjot Singh ; NBU- > Contact-longli (EXTERNAL) > Subject: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process >=20 > From: Long Li >=20 > FDs passed from rte_mp_msg are duplicated to the secondary process and ne= ed > to be closed. >=20 > Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API") > Signed-off-by: Long Li > --- > Change in v2: handle error case where mlx5_proc_priv_init() might fail >=20 Acked-by: Viacheslav Ovsiienko PS. Nice catch, thank you. Nice catch, thank you, Long