From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Subject: RE: [PATCH] net/mlx5: fix build failure on Windows
Date: Sat, 18 Feb 2023 20:56:30 +0000 [thread overview]
Message-ID: <DM6PR12MB37539A9A0FF9030FE9EC219ADFA69@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230217143717.203737-1-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, February 17, 2023 4:37 PM
> To: dev@dpdk.org; Slava Ovsiienko <viacheslavo@nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] net/mlx5: fix build failure on Windows
>
> __always_inline is not supported on Windows, let's use __rte_always_inline
> instead.
>
> ..\drivers\net\mlx5/mlx5_hws_cnt.h:162:8: error: unknown type name
> '__always_inline'
>
> static __always_inline struct mlx5_hws_cnt_pool *
>
> ^
>
> ..\drivers\net\mlx5/mlx5_hws_cnt.h:165:9: error: incompatible pointer types
> returning 'struct mlx5_hws_cnt_pool *' from a function with result type 'int *' [-
> Werror,-Wincompatible-pointer-types]
>
> return cpool->cfg.host_cpool ? cpool->cfg.host_cpool : cpool;
>
> Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode")
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Thank you for the fix,
With best regards,
Slava
prev parent reply other threads:[~2023-02-18 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 14:37 Maxime Coquelin
2023-02-17 16:56 ` Thomas Monjalon
2023-02-18 20:56 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB37539A9A0FF9030FE9EC219ADFA69@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).