From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70986A0524; Thu, 6 May 2021 13:27:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFDEB410DB; Thu, 6 May 2021 13:27:18 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770045.outbound.protection.outlook.com [40.107.77.45]) by mails.dpdk.org (Postfix) with ESMTP id 460D040040 for ; Thu, 6 May 2021 13:27:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fD+O3aMSxt1XFyJsS3gvjx9AEy3zM4sOl8j2VkLFjyBEF/I5/h9AjXwCtqQufwdUx2qF2VlZDtwF1RW3XkT7UwQxMsp2DVLcUWFyTDk3S+qJIdVPvDROfEbC6MD7S58tm3y5f57C1dnmSXpQGFOxCcO11kk8YVxoD5hrnKAapDyldYSdMfKJSLGXKkMDyKRoZJVddUqyZybozZPr8nYGBZ8dey6VscpcSL/Q1NcfY+LJw8dL7mEYkNlB/zkaZ7fn463kqiUOF7lv5g0vA1CTwusJZbAc3f2JJyyEgR+CYwUrZUUCRo7uM2uACefbNo/rx+cuemHw4+uB6SHIC0nibA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bjDRnwM/bLvasHuEIEWO8HewsUaAciYdhKsE8CrhaUU=; b=UQKNDZ3ZlD2kKlkZm29UuLmvGeRp2GPkJx2aT75sNtriGxTOO2HMw4Dhb2ufDZA74/fzFQnMR47KXxnF1gaHFpO0akzSkuZ5Qx5RAzAsEXMN+H/IRLGHoPUiWXVszqD/+KMFwViF6OfVardmovD3WhoGEXyA19XNPfAps0pWKIk6smvSeC6xjv39RHpXEQZ5uFvEZKVAH8eJQ/P5G5av1Gub8odNkC+aq7cC9aCjKCHXWjNLCWLc0oWccqg6bIIRb8jN1js40NMYiCL06tff491suuJ+32QLcEu4vxUH7YI4NZ8D/RoF905VupxUdaXTenTTXZFH/tiR2+4D/FAmmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bjDRnwM/bLvasHuEIEWO8HewsUaAciYdhKsE8CrhaUU=; b=VymXLt6YBdEG9gL5fUprftcZGKUdTsBorVYHqdAqhIIz/lhC8bqvsvqu3wsF2TGuMjacchSPmpZSLLT6QPKy+hGOnmXlATWArNQIHknZC98W9E0CMVzzHL1rDxicTYTmmpnTbf1i61YcoysrJtpmaoLf/oNTiJ5LpCJjYW79mZ5FtPRXsOqWW1tNTWOJ7WWWIJWjPrpYIBHfiVJwlAJi0YOX/IXoCwiAmrhowCZlhmNSyvnNWX/yQjindXDGu/MButXZKjFfAgjoKD7GrDGBY324Z6TXn2Wh6zx9TqF68rAakc1YTWJqGV8+dyJtGscd7w0liWSN05q2OfrJP3TC0g== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB3035.namprd12.prod.outlook.com (2603:10b6:5:3a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Thu, 6 May 2021 11:27:16 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::c595:e3bc:686c:16a4]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::c595:e3bc:686c:16a4%5]) with mapi id 15.20.4087.044; Thu, 6 May 2021 11:27:16 +0000 From: Slava Ovsiienko To: "Xueming(Steven) Li" CC: "dev@dpdk.org" , "Xueming(Steven) Li" , Matan Azrad , Shahaf Shuler Thread-Topic: [PATCH] net/mlx5: probe LAG representor with PF1 PCI address Thread-Index: AQHXN0iwq3AVEVlPZ0OVwIfqKFU3dKrWZpew Date: Thu, 6 May 2021 11:27:16 +0000 Message-ID: References: <20210422072446.29455-1-xuemingl@nvidia.com> In-Reply-To: <20210422072446.29455-1-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c76c0e8f-d55e-467d-893e-08d91081e750 x-ms-traffictypediagnostic: DM6PR12MB3035: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Od9iCVQdw8obkgZ2BLzihJNcDFD4QJy5x21iis/QA30mCAvzlEA9glOOlgwOLtNRtRzhXPfmXxuwcfIxuSibg2CZ31yYLEepSh2Tas/HqorTFgC3Ri8fgsm1wOgdWCtMFJ5or4vWZ6PCEhdyYRadoyEHG7G1++SAzP8QyuXxhxGFTwRJ0TDidT3mKGBIScTpwZI4Cm44vqgMbEbCx59/XRWYptnWzT35Ggwh/Zv0FQeBZ5o7nGryddkpxFdK4CEuqqX7Raka74jl0i19qGAx8zIslLdQFMZjYjERycnxdRs+s34pqH238pKsgp836k3PMG/+wOTQaPeHCpMNwMcX7Nwx2tOOdZy+3bi/KUHWmUhyL2SjF8zmkbiiruUnefmiAzoVQ8boiJd+htMfpgA5K26G2fZLN65hmEm+hh4WnO6nnWm4UxGama2Za1HBHAHUG3FFDHcVp5TmHfyJx8ri2QLPPmRGHhbhVIMOe9QHPVNuOOqV1rjZ8EikTsXtVZhe+IvdQyhbX3lcTUyZ7DpEA1mBXweOWBR66NNMC3IJVebCkh1Ayo9TV3lMLHrUYxkkD48ay3RgRNoFoMb4iDJyOjY3lgOdp9ZlnIpuYXagJmM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(4326008)(5660300002)(2906002)(9686003)(55016002)(107886003)(6862004)(86362001)(83380400001)(54906003)(33656002)(8936002)(66446008)(66556008)(64756008)(66476007)(76116006)(66946007)(6636002)(71200400001)(316002)(186003)(122000001)(38100700002)(6506007)(7696005)(478600001)(8676002)(26005)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Mxa7Kf5jLdY2xo5J1QQh8vX545Ur7CKR8gkcZacmoSEqyQAIu44ahh4vdVAs?= =?us-ascii?Q?vkexoaCLOiBa4/axik67fNgIiN/cY+U5axriBZuueChdeuXr5eewrp2bfuiQ?= =?us-ascii?Q?RvCwppVRVNBhEeRZFz+4uULByn6PYNVDafEiySOgnsAibZY+zsC+boipaHQP?= =?us-ascii?Q?PyY9q5fHRuVFzd8FKLJATMyQX9yH9KwSz/Xp793+yROsC2yvKDRjdHXUhbhK?= =?us-ascii?Q?ti/m/dbo5mDilPc2UaIblPYwUF9HAoQc5LaCb1/kjK7t1fHAC38CVYCv/s9O?= =?us-ascii?Q?q7gbGO0D6oluc8ETCBOmdKlbIWnJ/79UW8NHRkNVU7jvrc3NSshQqpDxEBDS?= =?us-ascii?Q?ufkKRkMAj0hcDFEI50CMW/uqpq4YTDuTFo1F3tGvAlZ94y7P2bS5D+RYkvrN?= =?us-ascii?Q?CWZPZnpeoDE/mQ9yI3uP/n1jbdje7njzbQDJ6ycP1nYWaO0Ixwl6qnUPICyi?= =?us-ascii?Q?L1ESr0wWI1swuUoQOLy8Jb2cnJiJniABP7aw9M/UUkayfsLYESYU20rkQXFH?= =?us-ascii?Q?4SHL5UlYJ6LEMGYG2n1vbSvkYDS7PT2C/nJsD1D0ouBsTgsftzKgS2+Naghe?= =?us-ascii?Q?EzfGZEtLvhGyuzMTpqzcN5X2XXDWs0hzkmGwxoHwLUx3upG/IaFoUokF1B9a?= =?us-ascii?Q?f5YuwILphq5gieP28ENTlDCNP80rOtQ/uqyWDQj1qvDWC1hZEBTZmggJ1cAK?= =?us-ascii?Q?5dLWaYTGfT7oPl2G2N2QhZKeOkIjOEZrqw6djcC2lO91IuWjK1CmhNGGYLZs?= =?us-ascii?Q?cX5HmEQufgtNbykLhOLlljskEv9dXMuE36EivI146ViPOxeEk2Y4g11UDmEj?= =?us-ascii?Q?/8e2HyGdFaHkoKwIUpZ6yR7wDuMdZILhfeK+I/6cnsqpIYbhoUdGMpUw0rDm?= =?us-ascii?Q?yy9WcLSJdFHyHUvdkp9EC0KvbvSnAuLnISVfxHeSPN4aydzwDADW15bfaKnV?= =?us-ascii?Q?pSZGcGDGH95k0wdV1BE4AouYb19l5uyIFn0kZcpv+jEOxXj00ECyvMLChHpE?= =?us-ascii?Q?PiNy8UvdgqPqtzfLhd9rxMa7oVpccqpcjhfIllRU7scLbKUHIgnLuJlXft5M?= =?us-ascii?Q?+xFf1ZXe+WFiu3DwucfOQBJMBw2EhgWg2gm/Zp5sohLtid994mhx0NknuDKU?= =?us-ascii?Q?Jp29rvPAry9sLtWRiaL9fU4niAaCXvi9hOhBxjDQ3WN+3iJNuRV+AP14tjcp?= =?us-ascii?Q?d8xWshoQ3YBtan2mwJ6ZYLCy+gFDF94hhwOAb7Sg2H9XdL/KRNt+LELFLRsa?= =?us-ascii?Q?gD8+jXlV3/m3PtyCZ0upwCs9M4uvukVYgSbvowJv7nQ0263R8lLK0Xxz2wx7?= =?us-ascii?Q?CBQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c76c0e8f-d55e-467d-893e-08d91081e750 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2021 11:27:16.6476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1YLLMHkfBMxBQQeO2cw8MXDBvRWkMf2xf3uJF2e1zWVa0D5jRTt1yHTQr/+HCOBlNqLQansok9yb9LekNJikXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3035 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: probe LAG representor with PF1 PCI address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xuemig This patch looks like a fix - could you, please add the "Fixes:" tag and mo= dify the headline? With best regards, Slava > -----Original Message----- > From: Xueming Li > Sent: Thursday, April 22, 2021 10:25 > Cc: dev@dpdk.org; Xueming(Steven) Li ; Matan > Azrad ; Shahaf Shuler ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: probe LAG representor with PF1 PCI address >=20 > In case of bonding, orchestrator wants to use same devargs for LAG and no= n- > LAG scenario, to probe representor on PF1 using PF1 PCI address like > ",representor=3Dpf1vf[0-3]". >=20 > This patch changes PCI address check policy to allow PF1 PCI address for > representors on PF1. >=20 > Note: detaching PF0 device can't remove representors on PF1. It's > recommended to use primary(PF0) PCI address to probe representors on > both PFs. >=20 > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/linux/mlx5_os.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index 76c72d0e38..22271e289a 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -1875,11 +1875,14 @@ mlx5_device_bond_pci_match(const struct > ibv_device *ibv_dev, > tmp_str); > break; > } > - /* Match PCI address. */ > + /* Match PCI address, allows BDF0+pfx or BDFx+pfx. */ > if (pci_dev->domain =3D=3D pci_addr.domain && > pci_dev->bus =3D=3D pci_addr.bus && > pci_dev->devid =3D=3D pci_addr.devid && > - pci_dev->function + owner =3D=3D pci_addr.function) > + ((pci_dev->function =3D=3D 0 && > + pci_dev->function + owner =3D=3D pci_addr.function) || > + (pci_dev->function =3D=3D owner && > + pci_addr.function =3D=3D owner))) > pf =3D info.port_name; > /* Get ifindex. */ > snprintf(tmp_str, sizeof(tmp_str), > -- > 2.25.1