RE: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length

[Slava Ovsiienko <viacheslavo@nvidia.com>]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 15, 2021 21:02
> To: Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: stable@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header
> length
> 
> On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
> > Current implementation for raw encap sets the length to be in bytes,
> > but, GTP 'extension' header length is an 8-bit field in 4-octet units.
> >
> > This fixes the length calculation of the header length.
> >
> > Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw
> > sets")
> > Cc: viacheslavo@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> > ---
> > v2: fix spelling issues
> > ---
> >   app/test-pmd/cmdline_flow.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index 24b224e632..b4c5aacdbe 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
> >   					uint8_t qfi:6;
> >   					uint8_t next;
> >   				} psc;
> > -				psc.len = sizeof(psc);
> > +				psc.len = sizeof(psc) / 4;
> >   				psc.pdu_type = opt->hdr.type;
> >   				psc.qfi = opt->hdr.qfi;
> >   				psc.next = 0;
> >
> 
> Hi Ori, Slava,
> 
> Can you please review this patch?
Looks good to me.

Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>