From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CF77A034C; Mon, 24 Oct 2022 11:43:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EFF74281E; Mon, 24 Oct 2022 11:43:43 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061.outbound.protection.outlook.com [40.107.223.61]) by mails.dpdk.org (Postfix) with ESMTP id E45294281C for ; Mon, 24 Oct 2022 11:43:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f5DHWim2IGig8BIxENFrfvVTkM5qnn9ynFI1TRSGZ4s4PecqSxA0geefMIo+xXAhrrv1NUBmS6cgA40FshVmOvfsXoV3t03nquGl3X/14MrQ+56czoqEDyDP9T0F4Z2+c/j0mJpLuUkc6Ko/wV0jgVigLQ3XC5ZUKb8Hd4QHvuEafifwxM0uGOIE4im/8LCtmeJvgGQQAGDYjXM2JvDrXDINek+kUA2VJhLo7CmYiiJM4UMkANFeNAknfslEzXt2oI+9U/0L1cR+9FgicChgtudnh8qlwZ2sr2sGtNDgU+EFeY4HpQyAGAGIdyD4yoYxipJNGph91dr6v3JeogM7dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+kAVMDDu9xAWIkZUSNkhtPrTVlxNu9Wj1g7jM7R5/GQ=; b=DeAj27dog4rAfl0eDK0ddBi4DJ0UH7AbQ1cLcm1J6EWIeiVpUzQHx21kKpcX987bQL40pJe+TEoX6uGpAB3cYVsI5aK8btH5w/McVshD5+LW3bkTZuTmoLOBl7hEPN4u199DgN8gPzkC4mSfwzfSCTeAeDBEXZqf/IqIitxN6FtF+PZGi6G/bzW0ebZh/421XoOeDfRm0u+SLdxcGC2tJUhDnoH9C/HhhM4V+EjWFUSU0NhlQjq3F/so+YqjDEuiikNiUBbmmtCbeqXan/1bU+yRTSDDF93JGw4mSPduUT6SacBH7bJFCkZb2Wt1s/ORoDYv5Fh5sF/Pe9BAXIj/zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+kAVMDDu9xAWIkZUSNkhtPrTVlxNu9Wj1g7jM7R5/GQ=; b=bCQ7W4WlDSuRDblm7XNjMmhrLk5EJKUpv8rW7J9UxzS6E20ZjAeIyduYV26+cQmOjzyiMMNoqmcqXdQJ9JIXU+5l87Zn2dc2vVbHx7lC6NfokPdIZQ0KVqDksBKVfGXsf8iGuL0ntuvSFJJ0D/5jzx+0pw5UJLvsQ7QHEU2RfkuHYd3rLRbu1a/K0TmnbGXQY4vdcOPX2U0gvbucqObRekBIuFWZwDSvDAVVVrzT5v+GgXVmW3Bny89Xfs1J52xdSN5L+6DMyhIk8jrZRHtvBB0jOd73EzMMdxylbSIdBoDVwa7qq4HBg40RKGSwvry6M5ssHBh9gj3ifgw6i+tTwg== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by PH7PR12MB6860.namprd12.prod.outlook.com (2603:10b6:510:1b6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 24 Oct 2022 09:43:40 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::7c8c:ea68:bd84:9458]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::7c8c:ea68:bd84:9458%4]) with mapi id 15.20.5746.028; Mon, 24 Oct 2022 09:43:40 +0000 From: Slava Ovsiienko To: Suanming Mou , Matan Azrad CC: "dev@dpdk.org" , Raslan Darawsheh , Ori Kam Subject: RE: [PATCH v6 02/18] net/mlx5: fix IPv6 and TCP RSS hash fields Thread-Topic: [PATCH v6 02/18] net/mlx5: fix IPv6 and TCP RSS hash fields Thread-Index: AQHY5JqSEmassZxmPE+/hNnn2C0prq4dUO5g Date: Mon, 24 Oct 2022 09:43:40 +0000 Message-ID: References: <20220923144334.27736-1-suanmingm@nvidia.com> <20221020154152.28228-1-suanmingm@nvidia.com> <20221020154152.28228-3-suanmingm@nvidia.com> In-Reply-To: <20221020154152.28228-3-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3753:EE_|PH7PR12MB6860:EE_ x-ms-office365-filtering-correlation-id: b5456b75-32df-4b97-e4ca-08dab5a43b94 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aijMMz1dee6wxu4JL0+xNN32N98KVfkjjQQzp8CfxHA06h+oH0TMpaJyxcMokv3tWzqMloeUk32NBiVLkHhtldER0F6FZIODqoawWvVrv+hZqHpJ14C+sxTkYiVju+qfYma9zpHVlnokDL9o3Eywklxm25uZ0B0rdVklRjxonrdQWgfcZCO/nVGAbZNfsxRS8ypVFH+7+N3Sbe4O85leUEjXfeCa/bGB0gq6oGC3SN0/i0EB7msUnLT8DyenrrTfFIIAXzCe5h5zpKyw9G3nbotEc4guRhbs8PQOES4+G/Pg7dF6NEKwFmsfH+rfoOEczGp8Mp8TNto1wj6GszXTapqcY2/lUfQ8CmTsMS5cYDf+8fkRXGdEGQRxLQ8oULZhUsYvd7eja6GximMX4J8P1FIXjQ4TVUeT7rUOO6R48nW1jBKw3nc3lMPPdVviyJT4fzg0HJopXfAlrH4l3yBsRPMHlQcRKvyWaZYLZkPCfQzxhbU7bIVe1uUvpSXM1Qegy7Ur85cOBbgs8HJ/aX124cjU1asQL7lG2kRFDeyoAc+3thcxfJhdlLOdY0t3/M4VvErvdpdBP1F9wPBKmmy4BFXyrO9VP08IOMRZpouI3V36wMKxPGFTeh0JtgDQvktglj1ymcf0QDwsLLW7D+ubX2xRghR+f5nU2YGKjx714wHZEOJgaro8zcfQGS/qMDulxLr5SBXglq7SWX3zusolpcNEV7LPd1O8hFxFWBJrfhT2a/g8LwBcT75gkYDtku4jeglCK6F4RYumTtRE7O053g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199015)(52536014)(2906002)(5660300002)(41300700001)(66446008)(4744005)(83380400001)(8936002)(33656002)(55016003)(122000001)(38070700005)(186003)(38100700002)(86362001)(6506007)(8676002)(110136005)(7696005)(53546011)(9686003)(54906003)(66476007)(66946007)(26005)(66556008)(4326008)(64756008)(316002)(478600001)(107886003)(6636002)(71200400001)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZvZRrtbrNgjGpVTzg3I+Z6+8iRP/geXfyJA5a9X8PPeN6QMXRBq4ZZ6/Wtpc?= =?us-ascii?Q?2YDYHg2B3FXB7kdMQqA9DjjnmyRNJmHVtG1LykzrrmVoosIWqiBdlG6tsjnj?= =?us-ascii?Q?UJXrZWXTfziUe+/I9Rngela5wWetlXbcGd4juX8bwsar1rE8kQehrt6KR9Ua?= =?us-ascii?Q?OSiuVoRksEZ2NaI1iebtlS7pZUjUiUV1MlRgE3gVQsnNCUixHQpgERCu8T2K?= =?us-ascii?Q?ZLgHJ7JI+JpLROj+vY/+078VnywxBTl9kct13/3BXo6x9lqdN12citFvVG4r?= =?us-ascii?Q?VWP/sNda2JYWt0RL234TQ5O0LY9CpqlyWy6fHxcZy4FEJJB++Poo7vl7Kyn4?= =?us-ascii?Q?2HpOpWjILv30DS5MdPTzRM3oJnuY6/H2+v6Fum48fmGlfPaTSWrr/9qI5HoO?= =?us-ascii?Q?9k2nrO9iUQpzCT1h/3XYY5n5QgZv4IIRaqrhwRpQoe/Dx9G3d4dRtgOyvW00?= =?us-ascii?Q?bCkZMgkzO7hZBBFIaNSMngm6ZKg2jjkZvOakufeHhHyoxsrvBE2Dj4rVAbM7?= =?us-ascii?Q?a+bS7cx2gKZJbKktX8koJiVGMY2Gkfh2f+DZcPQh4XghejQEG5OUgajpJpdw?= =?us-ascii?Q?wZSO/CpHTnQ+fRyKFVoe0Gt9fVqRAfNxjP4TuKbKsdC4R0qAJPZC83JYVp4q?= =?us-ascii?Q?TqLvxgOT3XTtf9UibaXK7z7YZgeSVH1i9DCGpdfAZZtqZQr6+zDhFIwaG7pW?= =?us-ascii?Q?V1/X5+6f+6sh2J3VR7EURaYVKJpFHvpSGcXGFWRXc9i/pSW/OSrEWaHaCuc5?= =?us-ascii?Q?LcZNDHFcda34NZb9JrygDF5u5ryEL3/5K6kv7h1OV10kzYNyzmh31+9wPGM0?= =?us-ascii?Q?x4Kn3O4nVHWpUFr4lMzcHNZyhGlm2DHFy1RczuhneJ9mZv+3UkHnwTrEESbF?= =?us-ascii?Q?oXYgVhHQhTjP6I27M3p+1DtQToHtESEKmFym+oeZEpdaVd1IqVlZ0bP4hjfD?= =?us-ascii?Q?1QV/pw1Kz2RNswWRS70+LLJhdKNX5VJFUA/c9eVNtDffYaUVEb+u17HAdYYu?= =?us-ascii?Q?au0/BUVLldGmxJF3tByDcQ7iR7L35z6VrigzBxej1vwtzSpIc72cQ7RDnKnX?= =?us-ascii?Q?y+3OF6MoDCiYn2EcH9MWMbXc8eXPDsV4xXUcSR70DRJbC+Oc8BFErgdNxkmQ?= =?us-ascii?Q?9WZHe6WJhgeYz5moq2S23b7+lqfHqJtjD8K7h6NPv0k6itgAPr0HNxKFf9Vp?= =?us-ascii?Q?qedLaDGokQHOcofnIUywjB8bL2cHGttSxs2zjGfFeNhmh5gFlgr+PSJ20Cfm?= =?us-ascii?Q?w9n35cHIJmYKwdbgUqb1hQaORXvCf6dWPnZJmY+LuBm0EYNnfhzUqM+NG5uT?= =?us-ascii?Q?Mh4vXjMGf15QsvmO23NTM5dRAeUQZjAF/JbnIDmFjIfUm28Uv/lAPmWNE+b3?= =?us-ascii?Q?jaFDKj3B4RQp0Nsf3OkpjuOZk8ipPmDFf8loJL8hCYaYO+Rzf5jYIdvf9K0b?= =?us-ascii?Q?8A+NJ+Uh73KgoW4YE8xg9IHvYTxxpMqFsy7b04whKKq8bUmBe04wI3sr9Qd2?= =?us-ascii?Q?NYUlfshK7xs8SY5Gfr4bhD5EnZYz1EAi14tQKxz8aCMOvEievH4w8TSjiGKC?= =?us-ascii?Q?wKLFCRcDzwuNH+ovxB71Ku4E+zl+ANcfWo9WSjMW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5456b75-32df-4b97-e4ca-08dab5a43b94 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 09:43:40.5067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oDQWrfO5FY0xWh3ZlsDz3t1tTxTzW/N4vZgLq6hB1dkxFzg05HptMLNsze2UDB1aK683Om9lgFgSkCCq6xjf1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6860 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Suanming Mou > Sent: Thursday, October 20, 2022 18:42 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh ; Ori Kam > > Subject: [PATCH v6 02/18] net/mlx5: fix IPv6 and TCP RSS hash fields >=20 > In the flow_dv_hashfields_set() function, while item_flags was 0, the cod= e > went directly to the first if and the else case would never have chance b= e > checked. This caused the IPv6 and TCP hash fields in the else case would > never be set. >=20 > This commit adds the dedicate HW steering hash field set function to > generate the RSS hash fields. >=20 > Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action") > Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko