From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 790DA42D0A; Tue, 20 Jun 2023 18:43:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C6A0410D7; Tue, 20 Jun 2023 18:43:51 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2053.outbound.protection.outlook.com [40.107.220.53]) by mails.dpdk.org (Postfix) with ESMTP id 76A7C40EDF for ; Tue, 20 Jun 2023 18:43:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SR+Tr2rCximBD1mwkjDUmKcph73G9N8SvPoL5NgjRCuFhJloygkUX+ECjCXVpKT/JAJy42Kvifs2TT2pXkscWvQ6jPw0UoLw8fa3rqYXRRGRDrjJ6RFBjfMOEqhK5Ar/r7XDN/qbOoT3ppreipe/TY5jlDoC4oB5n5gkR90ypu7nysq5xxYhQtAp11ceCDZpJQ0q0OuRg5skFOcrDBWyPMDHAESwtSPv2sYr/poonbYehuw+VYdROI7XIY7ZyvdCCec1a7Ula9qHcwFxbq2Bm44jnVukC3c6JPsM60PrJhmqTJvghzLkcJPNVttgao+X9trIb4bhhnlH5MhbWPGq2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kg877IIN7f9XsqCEhND/O8fiK3W2WcP8yyoTjqDoE9E=; b=Dzses4OfR8cmMFKE4Tc5RnEt9GkIrM1BSlRBM15USZ8qKSmFzRhnjgtVTeW5MXAS2LUkrxvAk8CuM1TpzDz7o0zJ/QJDXmtnL0mXhzvjkkvzV+UIAtF+OHQTIULpkDCiAfxb1TQBqA6P6CK/Edq1S4+GSPMp7wiHUCvhqO2CqIQ2pIYMbjvhhN7QtR8g3Qy7GA/kC1E4XsfU5or/QpyO9KRFrK4Mc3F4ciaBUDNyAIc45KcuYd2qUbiID1j2q6UWQZ0J/aATdJc8WZg+Ilfs8+011M93vmobOpEhA3LWnAh1wWS+0aHvyXTtXcxvSmaVUv6hm8JCV0tzC5L9tKBNfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kg877IIN7f9XsqCEhND/O8fiK3W2WcP8yyoTjqDoE9E=; b=gPxznuCCniu7mvVb3a2Rghs3/L5jzfV8j8M6mC1lkyNvT4ZhCHG63Fw4MmSI25aZEnEGOqaqinR3OgpQj6y3SzsXUyunvKN/+RltUskxVlUqYhnbCFj8DD/hbppBchPyRUoig/IeOurUFzORRaJQLBKaJD0xiDj/LOlSDC+neyiVOcijROxmT4UZ84GPsCo2TDTKCnoPqX+0KgdojAciYXnKaCIzIztiC49Csu/3LmkKCjRRRxNPMytrKfVMlLuEc+7b955n+OwDgC+W99WhxA/L1QsddhPTVw6FCJnw0wqFYFWzH0hF+UIqy0kMXx7/CMRqlMkfTJ2OkBPGpq0YHQ== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by SJ0PR12MB6782.namprd12.prod.outlook.com (2603:10b6:a03:44d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 16:43:48 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::ab87:3bac:b8e:a23d]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::ab87:3bac:b8e:a23d%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 16:43:48 +0000 From: Slava Ovsiienko To: David Marchand , "dev@dpdk.org" CC: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "i.maximets@ovn.org" , Ali Alnubani , Aman Singh , Yuying Zhang , Matan Azrad , Ori Kam , Suanming Mou , David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Andrew Rybchenko , Ferruh Yigit Subject: RE: [RFC PATCH v3] ethdev: advertise flow restore in mbuf Thread-Topic: [RFC PATCH v3] ethdev: advertise flow restore in mbuf Thread-Index: AQHZo2fYSVTLVRJ6fEqjBrjwa2GJPa+T5ZLw Date: Tue, 20 Jun 2023 16:43:48 +0000 Message-ID: References: <20230505103102.2912297-1-david.marchand@redhat.com> <20230620111028.4116505-1-david.marchand@redhat.com> In-Reply-To: <20230620111028.4116505-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3753:EE_|SJ0PR12MB6782:EE_ x-ms-office365-filtering-correlation-id: a1c3fa6d-303a-4af3-a1cc-08db71ad854c x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dX9VilF9C4utB/Xf1M3VFnIAENP+5mTsE+ycg7PvmdL6vCqMihoE7xVdWD2P9SN+VNn16U19x2RRRoheliQMONkf+zsiStkqe826r6Dnssz7yHpMGEqHUsR6XICZzZdPqq2wrfYoq9W2CTpx6ODJRZfQRI6ciRQweI/caQyFTHO1TI+WzkZPONwZgCImEN11igtu6PRkHezq3Gvt+at5dndgcgq7T/3bcth87eOak0yh+s9uw+xkwVxbKizOhB8KtZxmOfINZZm5Z5tqDQ5LsPh+U9ju/QB6xmwLbGk9VJ5FmNM6pcD8nyA/B71unLaS16kNF6I2jIBZfNNwuXAoz2Zw3AEIX5VQZH+WXNyy+WZXdnK5srA1bGsQhMKHp13VtLUQ7X0mNwe3M/Q4msQ06WFrZGLHYExKRsAfuzdFkDqNCin21OcuBTsfuGlILgRsvrbfJ48lhFjXcF/PUaEkByG26KTtYrEDH/B/gvtDsMJ4BX9ybJHz6eHEZSOuw8d0S/9j68vFVH/I+WMXXfeb2T7nMLZ8kItr2q8B6ood8kXsTy1m7UE7Yyysa+y7z9nefaRZxJAFl5on9Xn1uVPbhL848w7sD60IlSF2JCaojjdV8/7Ylgv2V5HWH4QA1XiSPBU1Rum09Urn/Ut+8ibYTDLGsxbFGsGixDZo8qd6vSQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(451199021)(41300700001)(5660300002)(52536014)(55016003)(54906003)(71200400001)(966005)(2906002)(316002)(7416002)(8936002)(8676002)(66946007)(64756008)(66556008)(66476007)(66446008)(4326008)(76116006)(33656002)(478600001)(110136005)(7696005)(38100700002)(53546011)(9686003)(86362001)(122000001)(83380400001)(186003)(26005)(6506007)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yaDgXEsFgeMYeHKllXatkzi7hbOkzxPEh8K6852Tku92o10LEDcNChSKvCld?= =?us-ascii?Q?94SCQuXBAr4cwdfduLlQ311NOG1tBOuLlaBumx/bdqnyYwZVoE6TOv5s1wZt?= =?us-ascii?Q?WQ0f02tR5ZZpX45cGL5uCLWQVmkEP+vTu3qxeZ2nzHNPIGT1gLUjCglJ9uRm?= =?us-ascii?Q?ye33VOlt+vHfjOA49XFDL9ogWSVLj/7GHDlft5kDW6alBUKVP6RPEGBEbhhZ?= =?us-ascii?Q?MSjxqoza8DEFNL+6FLm2CtryNz6/I+deOA5l9FGdruMsT0GBCVuhGeCJR98Z?= =?us-ascii?Q?InQatwAnsvRPn7801scgNxwdu6p5ZgnxK3wCHlZV61xYT1KbNvBEytvOKR/Z?= =?us-ascii?Q?i/D4ijLLUcKGCZjb6OV2qbafU9Kl1eVBO1Ewc1MamJtviapDmduSdqiuHWcE?= =?us-ascii?Q?xcAM2P1exCZicOqVj7AX1Ib/o8C4zM3ndB0pugFhDOheigBLKb2QJWyqKEli?= =?us-ascii?Q?nWQ2fHzwoUo6I161K1no8DzJjDjAqbcdq4ConCaGl/EGZuW1T5yfk/OBTA/C?= =?us-ascii?Q?F6V6bWCCnzA8KMNhv7ptMkRu34H+XQSaKpqfm9ioI5wrXU+rssBpSLIeGVC9?= =?us-ascii?Q?7nVihGuHUtBrlGLEXQ2C16h5t7JUjzaXVtnPz8Y/gKH1v41sSBFNtGwQKDpa?= =?us-ascii?Q?YU2Yj9MYyS3bJtrXAjp7Wv67DWMpCMWc0GhhYBnvMCrDY8yBohDTq4e11ukY?= =?us-ascii?Q?3BZlvEOMucelwTOz6Rvh+h3atUg6ByQpqhskBfz3Tq47wfFqaE78NEOgNw4D?= =?us-ascii?Q?Kb2ifbIrh+l2GtUj2v0gvo3a37psTqNCKe90pcwyqIHh4HZnTwhzPiOXGO94?= =?us-ascii?Q?q6gQ4/PRwSCyUwTlwW6YlzibhFolalQMqAJuNMemvNfo1xdTrrU6FUqrYahq?= =?us-ascii?Q?CLRO7p5biucphtk7UyaGDy+xEi05JZsdr8Q4OQslulJO/Cq494byrSDkcbEh?= =?us-ascii?Q?IRGtYU632EXxaC3YVv3Ha7dL8rDzgKv452G62aE/a57nrHLSBLKch7WcjhKr?= =?us-ascii?Q?kCep7TC7FQQGI6cQzGOUhZjyFqqFJY8agSRfZRtA6Cl4H9xd2qt30w+zoqmG?= =?us-ascii?Q?ZQEZgyeUl6lkHxLsP42DhXntVK8MYCYnF38OKB/cgjLObihRaDRtPocTITqQ?= =?us-ascii?Q?3ndtFldX7CLVRIS2hwZceWTpbT/dLxUPO8yc0Neu34gOdicIvh5o7Z6yTaq2?= =?us-ascii?Q?2g4ME6hGA2Rn/WQlULgaBKGAXtlU4fKTLcVjH/pqCkxJXEuN18FxdQbVnx09?= =?us-ascii?Q?1PiueEMQbFmSCEO7cYaM+hO0nIJZ+iZF5sfeMav2cKufuib+kmuBpvNHg3K+?= =?us-ascii?Q?kWuBfa9RrcHvgQhlH2MWlGOSUreEJqGClLMqR7emGB+vU6h74erPhOSHIxLM?= =?us-ascii?Q?QGHn47V6m2veZrtVuh4CvpwRCoSPQOtVh9qMaKDVZqntiMwBsSvH5EzQxgHy?= =?us-ascii?Q?j+lkO7x+AL75Jn8UP4eSktqaWViIQNTQE83afXepuSJ9+Locr0rrCHYxflFd?= =?us-ascii?Q?TJZMv2CRSxT/bMOEwAfLDb6IjjYbaxuwtAfWHwN29jpWjSkQ+UJSln44EIrr?= =?us-ascii?Q?gwhlQMsBkQz363lrwC09gsJieEjRtc/VYJHJzHwn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1c3fa6d-303a-4af3-a1cc-08db71ad854c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 16:43:48.2198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VT5u54W7BmKcS8t0cPEPu6nFfytB/w2+7ot05GFroogSBpGl6MTMOa7vcoYUWFQzvMv9ou0JvRSyC0raUpIs8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6782 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Tuesday, June 20, 2023 2:10 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > i.maximets@ovn.org; Ali Alnubani ; Aman Singh > ; Yuying Zhang ; > Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; David Christensen ; > Ruifeng Wang ; Bruce Richardson > ; Konstantin Ananyev > ; Andrew Rybchenko > ; Ferruh Yigit > Subject: [RFC PATCH v3] ethdev: advertise flow restore in mbuf >=20 > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for driver= s > that do not provide this ops. > It could also impact processing of packets that require no call to > rte_flow_get_restore_info() at all. >=20 > Register a dynamic mbuf flag when an application negotiates tunnel metada= ta > delivery (calling rte_eth_rx_metadata_negotiate() with > RTE_ETH_RX_METADATA_TUNNEL_ID). >=20 > Drivers then advertise that metadata can be extracted by setting this dyn= amic > flag in each mbuf. >=20 > The application then calls rte_flow_get_restore_info() only when required= . >=20 > Link: http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8- > 7f659bfa40de@ovn.org/ > Signed-off-by: David Marchand We did not notice the degradation, so: Acked-by: Viacheslav Ovsiienko > --- > Changes since RFC v2: > - fixed crash introduced in v2 and removed unneeded argument to > rte_flow_restore_info_dynflag_register(), >=20 > Changes since RFC v1: > - rebased, > - updated vectorized datapath functions for net/mlx5, > - moved dynamic flag register to rte_eth_rx_metadata_negotiate() and > hid rte_flow_restore_info_dynflag_register() into ethdev internals, >=20 > --- > app/test-pmd/util.c | 9 +++-- > drivers/net/mlx5/mlx5.c | 2 + > drivers/net/mlx5/mlx5.h | 5 ++- > drivers/net/mlx5/mlx5_flow.c | 47 +++++++++++++++++++++--- > drivers/net/mlx5/mlx5_rx.c | 2 +- > drivers/net/mlx5/mlx5_rx.h | 1 + > drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 16 ++++---- > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 6 +-- > drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 6 +-- > drivers/net/mlx5/mlx5_trigger.c | 4 +- > drivers/net/sfc/sfc_dp.c | 14 +------ > lib/ethdev/rte_ethdev.c | 5 +++ > lib/ethdev/rte_flow.c | 27 ++++++++++++++ > lib/ethdev/rte_flow.h | 18 ++++++++- > lib/ethdev/rte_flow_driver.h | 6 +++ > lib/ethdev/version.map | 1 + > 16 files changed, 128 insertions(+), 41 deletions(-) >=20