From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08AF4A0C45; Thu, 25 Nov 2021 15:13:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87DF840DFD; Thu, 25 Nov 2021 15:13:31 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2080.outbound.protection.outlook.com [40.107.236.80]) by mails.dpdk.org (Postfix) with ESMTP id 3ABDA40DF5 for ; Thu, 25 Nov 2021 15:13:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZp0tUJy1MEfguZ7h8cV+ePBC4P3HGP852VG7UUNzmMdTmebBvBBJs0QafVO9Ho8dRwSo9anFvScwJmoVLpRjaX106mXzzwzi/Tj7tUCTYAaDJtO9a6EDlFJtXK/2Pj0XI2OUt+b1DHSG9SXkiQ6F7y3muu7V1krmiVQCYNp5/BZUyH+4viAAJNMGQlcg4NajrljjkgmjJL11mdBLL9BVlxXt06cuoBSQsY9aJfgir1OKpg/i0Y0iYPB663LdF/fWfoaFh6dtTY+gc/lvtgd0ax97URDbAxVFhJ4S02M8lREy0ZaZgga/rFycrDInlIaoik2+99wpRk+xDw6lDmV/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kWxFx2wsti4//FMmA1EdbQYAZovXd3c0OzL0fjZXIrM=; b=H5l7CeEY0nHwDmkJLv7eT9ZXw7sztdX0UnLVbzPgLHPXd2fZzy+64ejMTbGXW4hQprABwWaz9C5N915r4s6mGaJlG5nZUwhlKWS290p52EiUIpnfISmDvuJfFuD/XVYClaWxA9yqL/NcXwQRL5/bevI++jcpx8JmRACrlI8CQ04QePpkydsz18T5ZJ3VZVsjxfsiEKs779nrKh79kQyBtlCw6w0guzAi//d18SNLKuaR10bNUyxx+QSj/r8/dz3bt98wjkK/TLlzgoPVqyw/f83wVLkb85wryG0R42mnCxoKGDE7Nle8UD6qZLt3GOy3crOKv3qGlUJ2uzXszydbXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kWxFx2wsti4//FMmA1EdbQYAZovXd3c0OzL0fjZXIrM=; b=lLDyz4/o3h3EVnrub1jdd2z7vj9I38AG+iezTTNWvHEI/wuLJ9bJB6/vew3U1zCWPljMBK8TNSzIm/hxLsnF8AHPl7BoG52ywB66pTC9WZeHDVemL6bvIm9Rq48eeDne8ykj9G6JgEksK1yavFFLi0s38VOoQdOZX/68DGaIXhgfZuZfVVapLXjerSuI7vdj8nGfr0a35FuJcuEGtSfcHwAL4agBq93t7F1YKWRgeTBhDx51EAXlVxg/RkAzLdDBD3WUlbRC9Usg70QX7YmKGVzQHel831AGtiCrelDuAl23w1qNYet8x08S9/O483LGAWpwWqQxK1TtEwimuhHAZg== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB4761.namprd12.prod.outlook.com (2603:10b6:5:75::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.19; Thu, 25 Nov 2021 14:13:28 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59%5]) with mapi id 15.20.4713.025; Thu, 25 Nov 2021 14:13:28 +0000 From: Slava Ovsiienko To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Ferruh Yigit CC: "dev@dpdk.org" , Ori Kam Subject: RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Thread-Topic: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Thread-Index: AQHX4UlWIFQ6Z2FZ90Odbm76K82hcawUI5wAgAAUYwCAABGTMA== Date: Thu, 25 Nov 2021 14:13:28 +0000 Message-ID: References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211124153756.12198-1-viacheslavo@nvidia.com> <0e5753c9-85c3-1dc1-69d8-460cb0a7b5a4@intel.com> <1989679.70EXCg8c8L@thomas> In-Reply-To: <1989679.70EXCg8c8L@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 98fc9d98-47f8-4dce-3fcf-08d9b01dc0c1 x-ms-traffictypediagnostic: DM6PR12MB4761: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qQYXrOwnXMFhl+vOgQrHu9Ax0liQbmzDR6cn3pmE4F7wSMi1wxRuigY0VIIF2NJtYPbD5Rymvqt6HzE1vRmIrgP3zsKU5EjRWE6+7QXI6+dAbXMf2N146MvyTudW0d1xLh0q4kOEL95ACra80KqtXzYtlKxODhG12HdXKe3lOdkLJELglxqxyLzEqF3smPjiVbdWRs8YFPWvldG3+cgN/IaiGQXkcoI4tm/8UecIbIJRfqEsthu3iO+xauWUjZigK9hy8/GcvOIrdSyfFbYmk4wsG8hrkp2bJM45/AKWjM3e6p/OILkqHgSnCV21zFEqShhPrCgp2f7UP8xO7nxyPXL3G+M67qus9fcjZdodBEsovbJZudDP/XhP3uVnnjzOjePAjpF33VPg/OvETNdQ40Cv0PefZ6VEroh0EvIV5uLN1LyLKscoBCXZ/xKqi1i569g60ZsI3SgH1Ida9XfklUOiS/qmL/Wcs6jggr91iGbB+v8I5e9co31z+F3dZ91IQ5Rz0Gdz1EPwOsQpR7JThqmv+G3Lq8kFD/X+/rUx3oAJddVW9NGah5Z1aY0JEZPOMI7GeoAkUawQQkSb87wGr3SqmvjyjjkQj2fKiuJs3npMjIR3RpldQ+f5lJY4kUapJTgKK2N69g/dyQGeN3S+/+VZIn/tniwmCiQeUFPANxZGMo3Qgv51/w1H2JW173Y9cic/mbHs8f11+WGv5A3cGw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(64756008)(66556008)(66476007)(66446008)(55016003)(8676002)(83380400001)(26005)(38100700002)(2906002)(9686003)(66946007)(54906003)(110136005)(5660300002)(508600001)(86362001)(33656002)(38070700005)(71200400001)(186003)(4326008)(8936002)(316002)(107886003)(76116006)(122000001)(52536014)(6506007)(53546011)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wLArTk9S4rGg4wqk1ulHasFmVKim6Cz2d9QZzq0IYihyv64/wj06fPrBm7Qr?= =?us-ascii?Q?uC9S9dbNYxhXVSZZrvWXqQi/AeiV6UXokY5NRL6Aq3Xo4RgGaQcyWBS6Q8iP?= =?us-ascii?Q?Kjgv8OmwiLOnIGfBXT7MvOvvETvH8Y1IMkgV8y9tVacqjwf+xS+DxVhny8l2?= =?us-ascii?Q?p9ch4rno05WHLNn33J75PUr+sOVVd/CtS78kwyv5a82Lx9CcnRZ4wisWDiIq?= =?us-ascii?Q?IWoyUU4eF6+GIpVs+ssPRgTdz+gDhU4nzJFk4DUmohCOQYTFemzF6aE7oVUT?= =?us-ascii?Q?LAKac6VLKRI5gu71VvxZJ32P2VPWQXN+7kMfAxnuWcaeNQZOQomD7akNsC+E?= =?us-ascii?Q?6oN6V/MyZK5ogBdJmbQYCY5eoUDOR64M4FeSwD/ElCSwQAdswuYuN9Dj0KKw?= =?us-ascii?Q?WVXh+YBmKkUcVoYxjZ5JGixrcAz7nJkaRFlmtJGyqP7P1yDM9XLM1jjQUQ8L?= =?us-ascii?Q?5/60y757V1DMCuW+vy8lkGIT1TIHtb6rEId74TGYQkpIkLJlUqMhMgUNWs7A?= =?us-ascii?Q?wpBEekWcm3coOBS20mVeciVZppKgXM+WBWg6P/1GcVsKSQuNNNksQdtfbkV6?= =?us-ascii?Q?kZ8AxVGcuyi1LZIKSyS15bxthsEPYjILbuip6VY8crrMiM/hueO82125JZ8v?= =?us-ascii?Q?Pj3FXo5wPquE3gv4HzaUvDy7e2ga2Y8a/ksDMwPCRZept4ejNVDsVKNQz9tA?= =?us-ascii?Q?7ghayIBKUqEFmfLOWMmARBNklSPDLcjwI1Ms0vxwgPMuQxvX7YaQVLNahfv1?= =?us-ascii?Q?H0+TMsOFIQX4OhhuH7puErleYqdXLxbbBessfaDlXlRuKQvNBUgJ2gFZwx9d?= =?us-ascii?Q?ynlwVEmT3Jrnapqh8S0zBqIcL9o+n/Aau+c621lAY72Yxq7qCAB9qdFBmvKd?= =?us-ascii?Q?31jcuzJJsBYecVblTnrtuRbtvUsFwONj+n7Q455t58RlkfvK73/yzn8vhn87?= =?us-ascii?Q?nXBL8uWGJbAOZ6n524p7b+QKa3XhJRuHL2c8xhvZx9aKsyFc7c2Xdll46tkw?= =?us-ascii?Q?Svuc48fUppM8caZRJnpxAZvkHbvYXXsu8/H6hYmdYjJZPqdV0WicT58uprv/?= =?us-ascii?Q?GRHOEkVyza3GiC6/2Bx22SEjbqC2mNthw7QXjJjps7L7t4SuNTrWKJAdpZpJ?= =?us-ascii?Q?weDysgs6BaAZzpFJOb+Xn3T8Fr1Vd1Am5dEHN2b/9ZSCjJdrAnb2zE3++Sve?= =?us-ascii?Q?RJIRSfPhFupg6P7iOHK/qbWnhjI+jmTVQzFd8hnGqBjUK8XuIrgHFRf+nkWb?= =?us-ascii?Q?wE8J5rwqIQ4vQ47ger8QydVvw7aUZw9wRTw/PcTqjhzp0NMFRnI+JvPB1MZV?= =?us-ascii?Q?PukzhvHth/X+JuueX2cnsNzrJbdzziDFQysIFCORk3OyVvUKapsM1Gk+hLAl?= =?us-ascii?Q?2cERXIZ+2E+MhUm6bt+XBe1jQp2pi54DRO+zbyXGS8Sify1Kc8c4Niqn7Q9A?= =?us-ascii?Q?GLXV0nttOv+NQue9ZoFQaSTS36AzoqCJHCm5bOWiQGumxb3/R5HlixlruCRW?= =?us-ascii?Q?nyGOJMKPUjK2yVTKaY8EKLpZvQcK8x6l7tQ/aOfU4tyIxeS0lEenR8QF9Vqg?= =?us-ascii?Q?mHH1sKFUmhi9Oe3/1ZeDRwAKMHvb0/rVSvSB2qSY7GMCfnfsTqfTZav4gW4m?= =?us-ascii?Q?rQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98fc9d98-47f8-4dce-3fcf-08d9b01dc0c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2021 14:13:28.2946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j3qX9yBeT6K6cOP2XkVV++EWS7evOesds5nnzqyvA5oaQid4Vm5jl6A2pWCZdzgyzf714kwy2TTZF24t8hWp3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4761 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, November 25, 2021 15:07 > To: Andrew Rybchenko ; Ajit Khaparde > ; Somnath Kotur > ; Rahul Lakkireddy > ; Slava Ovsiienko ; > Ferruh Yigit > Cc: dev@dpdk.org; Ori Kam > Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow > actions >=20 > 25/11/2021 12:53, Ferruh Yigit: > > On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: > > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > introduced > > > by [1]. This action provides an unified way to perform various > > > arithmetic and transfer operations over packet network header fields > > > and packet metadata. > > > > > > [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow > > > action") > > > > > > On other side there are a bunch of multiple legacy actions, that can > > > be superseded by the generic modify field action: > > > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL sfc > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC bnxt, cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST bnxt, cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_DEC_TTL mlx5, sfc > > > RTE_FLOW_ACTION_TYPE_SET_TTL mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ mlx5 > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ mlx5 > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK mlx5 > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP mlx5 > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID bnxt, cnxk, cxgbe, enic, > > > mlx5, octeontx2, sfc > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP bnxt, cnxk, cxgbe, enic, > > > mlx5, octeontx2, sfc > > > RTE_FLOW_ACTION_TYPE_SET_TAG mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_META mlx5 > > > > > > This note deprecates the following RTE Flow actions: > > > 1. As not supported by any of PMDs: > > > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > > > > > 2. As supposed to be replaced by generig field modify action: > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST > > > RTE_FLOW_ACTION_TYPE_DEC_TTL > > > RTE_FLOW_ACTION_TYPE_SET_TTL > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > > RTE_FLOW_ACTION_TYPE_SET_TAG > > > RTE_FLOW_ACTION_TYPE_SET_META > > > > > > The VLAN set actions are interrelated to VLAN header > > > insertion/removal and supported by multiple PMDs and supposed to be > > > just deprecated but not be removed in 22.11. > > > > > > > Why not remove them for v22.11? Do you think PMDs can't change the > > existing implementation until 22.11? > > > > > Signed-off-by: Viacheslav Ovsiienko > > > > > > -- > > > v2 - deprecation.rst is updated > > > v3 - doc comments addressed > > > - commit message comments addressed > > > - SET_VLAN_VID and SET_VLAN_PCP actions deprecated, but will not > > > be removed in 22.11 > > > > Deprecated symbols are to prevent new code using them, but for this > > case there is no alternative, since PMDs still don't support > > 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD' yet. >=20 > This patch is not preventing new code using old actions, there are just > comments to point to the new direction. >=20 > > This patch is forcing users to use deprecated actions (except from mlx)= . >=20 > I don't get it. > It is encouraging to use the new generic action, which is supported only = by > mlx5 for now. >=20 >=20 > > What about a slight change: > > 1- In this release, update header/document as > 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD' > > is preferred way if supported. Instead of deprecating old ones. >=20 > Deprecation is just a comment, clearly showing that it may be removed in > future. > In my opinion, it makes the message simple and clear. >=20 >=20 > > 2- Have an agreement with PMD maintainers to switch to new action befor= e > v22.11, > > and don't accept old action implementation in PMDs anymore. > > Based on agreement update 'deprecation.rst' in this release to note= that > > old actions will be removed on v22.11. > > (It would be good to have a check to prevent old actions merged > > during that time.) >=20 > Not sure I get it. > You want to remove VLAN actions? I think it is premature. >=20 > > 3- In v22.11, remove old actions, the PMDs that don't support > MODIFY_FIELD > > action will lose the feature. >=20 > The VLAN actions are probably already used a lot in the field. > I would consider removing them only if it becomes a burden to maintain. +1 Dropping VLAN might trigger an avalanche of changes in applications - it is= supported by multiple PMDs and should be widely engaged. Other legacy actions are supported by very limited set of drivers and usage= area should be smaller, I would say risk is moderate. With best regards, Slava