From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
"Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix resource release issue for mirror flow
Date: Mon, 12 Apr 2021 06:36:59 +0000 [thread overview]
Message-ID: <DM6PR12MB3753D52E01EB35D7D5372145DF709@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1617971608-89460-1-git-send-email-jiaweiw@nvidia.com>
> -----Original Message-----
> From: Jiawei Wang <jiaweiw@nvidia.com>
> Sent: Friday, April 9, 2021 15:33
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix resource release issue for mirror flow
>
> The mlx5 PMD allocated the resources of the sample actions, and then
> moved these ones to the destination actions array. The original indices were
> not cleared and the resources were referenced twice in the flow object - as
> the fate actions and in the destination actions array.
>
> This causes the failure on flow destroy because PMD tried to release the
> same objects twice.
>
> The patch clears the original indices, add the missed checking for zero and
> eliminates multiple object releasing.
>
> Fixes: 00c10c22118a ("net/mlx5: update translate function for mirroring")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Reviewed-by: Suanming Mou <suanmingm@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
next prev parent reply other threads:[~2021-04-12 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:33 Jiawei Wang
2021-04-12 6:36 ` Slava Ovsiienko [this message]
2021-04-12 12:57 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3753D52E01EB35D7D5372145DF709@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=jiaweiw@nvidia.com \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).