From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: compile_success <980965867@qq.com>, users <users@dpdk.org>,
dev <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: RE: net/mlx:mlx5 mlx_flow_create failed when set bond_mode_8023
Date: Wed, 12 Jul 2023 11:29:56 +0000 [thread overview]
Message-ID: <DM6PR12MB3753DDED17AD3E406B183171DF36A@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <tencent_DD9E4087F3178CBF1A854CEFD82C346CC606@qq.com>
[-- Attachment #1.1: Type: text/plain, Size: 1684 bytes --]
Hi, Yan
Sorry, I do not follow the letter?
Are you proposing the patch for bonding PMD?
If so, could you, please send your patch in plain text, according to ML rules?
It is application responsibility to start bonding virtual device (and it will start its slaves)
before flow creation.
With best regards,
Slava
From: compile_success <980965867@qq.com>
Sent: Tuesday, June 20, 2023 6:26 PM
To: users <users@dpdk.org>; dev <dev@dpdk.org>; Matan Azrad <matan@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
Subject: net/mlx:mlx5 mlx_flow_create failed when set bond_mode_8023
Hi,
When I create bond4 with ConnectX-4 , mlx_flow_create return error;
When bond_port is opened, slave_port will be closed to sync bond_port config
（bond_ethdev_start -> slave_configure->rte_eth_dev_stop）
slave_configure(struct rte_eth_dev *bonded_eth_dev,
struct rte_eth_dev *slave_eth_dev)
{
uint16_t nb_rx_queues;
uint16_t nb_tx_queues;
int errval;
struct bond_dev_private *internals = bonded_eth_dev->data->dev_private;
/* Stop slave */
errval = rte_eth_dev_stop(slave_eth_dev->data->port_id);
if (errval != 0)
RTE_BOND_LOG(ERR, "rte_eth_dev_stop: port %u, err (%d)",
slave_eth_dev->data->port_id, errval);
However, If the device is not started yetm it is not allowed to created a flow from application.
（slave_configure -> bond_ethdev_8023ad_flow_set -> rte_flow_create -> mlx5_flow_create）
I want to add rte_eth_dev_start before bond_ethdev_8023ad_flow_set. This can solve my problem.
[cid:image001.png@01D9B4CB.A5D91B50]
________________________________
[-- Attachment #1.2: Type: text/html, Size: 12494 bytes --]
[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 47269 bytes --]
prev parent reply other threads:[~2023-07-20 5:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 15:25 =?gb18030?B?Y29tcGlsZV9zdWNjZXNz?=
2023-07-12 11:29 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3753DDED17AD3E406B183171DF36A@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=980965867@qq.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).