From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"chenbo.xia@intel.com" <chenbo.xia@intel.com>,
"amorenoz@redhat.com" <amorenoz@redhat.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
Michael Baum <michaelba@nvidia.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
NBU-Contact-N?lio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] net/mlx5: Fix RSS RETA update
Date: Tue, 21 Sep 2021 09:55:16 +0000 [thread overview]
Message-ID: <DM6PR12MB3753E5FF5C47B8495894C863DFA19@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210910091734.7023-4-maxime.coquelin@redhat.com>
Hi, Maxime
Very nice catch, thank you for the patch.
Minor typo in the commit message "ithat" -> "that".
Besides this:
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, September 10, 2021 12:18
> To: dev@dpdk.org; chenbo.xia@intel.com; amorenoz@redhat.com;
> david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru;
> ferruh.yigit@intel.com; Michael Baum <michaelba@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>
> Cc: stable@dpdk.org; NBU-Contact-N?lio Laranjeiro
> <nelio.laranjeiro@6wind.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Subject: [PATCH 3/3] net/mlx5: Fix RSS RETA update
>
> This patch fixes RETA updating for entries above 64.
> Without ithat, these entries are never updated as calculated mask value will
> always be 0.
>
> Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update")
> Cc: stable@dpdk.org
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> drivers/net/mlx5/mlx5_rss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index
> c32129cdc2..6dc52acee0 100644
> --- a/drivers/net/mlx5/mlx5_rss.c
> +++ b/drivers/net/mlx5/mlx5_rss.c
> @@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
> for (idx = 0, i = 0; (i != reta_size); ++i) {
> idx = i / RTE_RETA_GROUP_SIZE;
> pos = i % RTE_RETA_GROUP_SIZE;
> - if (((reta_conf[idx].mask >> i) & 0x1) == 0)
> + if (((reta_conf[idx].mask >> pos) & 0x1) == 0)
> continue;
> MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n);
> (*priv->reta_idx)[i] = reta_conf[idx].reta[pos];
> --
> 2.31.1
prev parent reply other threads:[~2021-09-21 9:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 9:17 [dpdk-dev] [PATCH 0/3] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-10 9:17 ` [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support Maxime Coquelin
2021-09-10 10:06 ` Andrew Rybchenko
2021-09-10 11:44 ` Maxime Coquelin
2021-09-10 12:58 ` Andrew Rybchenko
2021-09-10 13:10 ` Maxime Coquelin
2021-09-10 9:17 ` [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update Maxime Coquelin
2021-09-10 9:51 ` Andrew Rybchenko
2021-09-10 9:57 ` Maxime Coquelin
2021-09-10 10:06 ` Andrew Rybchenko
2021-09-10 14:16 ` Nélio Laranjeiro
2021-09-13 9:41 ` Maxime Coquelin
2021-09-14 7:20 ` Nélio Laranjeiro
2021-09-16 3:03 ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2021-09-16 7:33 ` Maxime Coquelin
2021-09-16 7:41 ` Li, Xiaoyun
2021-09-16 8:08 ` Maxime Coquelin
2021-09-16 8:30 ` Li, Xiaoyun
2021-09-10 9:17 ` [dpdk-dev] [PATCH 3/3] net/mlx5: Fix RSS RETA update Maxime Coquelin
2021-09-21 9:55 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3753E5FF5C47B8495894C863DFA19@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=amorenoz@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=michaelba@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).