From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ACC9A0C4C; Tue, 21 Sep 2021 11:55:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A33240683; Tue, 21 Sep 2021 11:55:20 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2082.outbound.protection.outlook.com [40.107.244.82]) by mails.dpdk.org (Postfix) with ESMTP id 598B24003C; Tue, 21 Sep 2021 11:55:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=McYVaYPrDKIM8pqG1zMNvSiH3lpNzkBMH0b00RCOExQ/X0Z7yNvnyD5kiWwNjpx1ECJ4NfD5Sge00EUCMKbqiuyEN2XDL+CbJzpoCnpv/WyrFII5JGZFsw9BTVP2VZiWzBIn99pb6DGvNF/SwMyiR5K2fX2fC/9gIMY86fbaISmeiusc3OSuq4KbmuzwJXZyeQAGsnZnm/ZxBnkb6M7YVrtcgX0WBUa/dahY60QsW7YakYcrsmRaldoRQ7ZOrodiV9eRxG/mxunS4inu0xrzbfaGpjPqAKCWvp/BGemhX4GtZ3ZMUChPMNcBdWmdZRCXXg2aOH94OOE5q1jf9bIdAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=l+OALVcKChndnV/0nCGuaTvRgdmlrWMuVpluqx9WRAk=; b=kdOO6dBAcPj2hvQdLuMQ30prwwMVr3ZFiQ2UOGCt8LI7kfrBKVeqVsIBjuzgIlFjp1qEShHw66TYPOc6KU54UDwKets6BRpky4FcxnNWliNr9lB9yzKepT1+/Z6a3yj+ZrLQQ1e6wFjDr25qqlJH7xmZpkcBq2uwPDkD0GdIHfeR/8/vdzdM5hdAdHnqJOQCk2nVf/nsl3TwjTINbjW5vjWw5Hp8VkmI544UPvH+DSwBAUWybWHuMsg/Upyd+x22FKEim5WNyDMPJ9eIOLu0e62i8g2Bsgs2efIYkRRFuIQgaBZhIYVZMlYKrW9pufKX7YsDZAC4+JhE9lX9IQMHVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+OALVcKChndnV/0nCGuaTvRgdmlrWMuVpluqx9WRAk=; b=Oc5KtSIu1CQ3yTwmD1xlm4ZKN/+qwuwQbWrxYrFKqx1qehYtJPMVUtrHyKiC/+HeTQlo21SMnWBesOSv9YNgDg68PdSj4oFVO2iTZqEsaPyd4aGSvo9K22km0ARIDt2xjgi2hZlIKnVtl7jFW0gelWfOC5uRH0cwcMD/hAkC0d5hHkuedpumJ01um/ePYU+31bW0ALLxVpAtHD4tqhu0YVFdqVEVWAyj9moUy/IXfzTnwz8IgQYIkvLihmn5ld4G7ly7h4th1UlO9Y+NZnWr3AT3eElnnpvwqAW/hDLfwhsYeYmx+19XcNp4rxEwZTxqOQkNtR2s2oWWmIOUO10CZg== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB3657.namprd12.prod.outlook.com (2603:10b6:5:149::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Tue, 21 Sep 2021 09:55:16 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e550:35a2:96e5:657f]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e550:35a2:96e5:657f%4]) with mapi id 15.20.4523.018; Tue, 21 Sep 2021 09:55:16 +0000 From: Slava Ovsiienko To: Maxime Coquelin , "dev@dpdk.org" , "chenbo.xia@intel.com" , "amorenoz@redhat.com" , "david.marchand@redhat.com" , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@intel.com" , Michael Baum CC: "stable@dpdk.org" , NBU-Contact-N?lio Laranjeiro Thread-Topic: [PATCH 3/3] net/mlx5: Fix RSS RETA update Thread-Index: AQHXpiS7BlVyLCGcbkGdTiJ3N3KPsquuUEJA Date: Tue, 21 Sep 2021 09:55:16 +0000 Message-ID: References: <20210910091734.7023-1-maxime.coquelin@redhat.com> <20210910091734.7023-4-maxime.coquelin@redhat.com> In-Reply-To: <20210910091734.7023-4-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e48e1c89-73ca-4513-08c2-08d97ce5e9f8 x-ms-traffictypediagnostic: DM6PR12MB3657: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:309; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jspk2d8Cegzs7/vbXEGQAB6pKOYjP1JyydkR5huur2meNtDPSBBdT7tyLKv+4jR1cNhsiVyGLHf9H0dymOxIsmqNeleYfxaCQjqjqzniTXR4umhnSol3K739VfEPqODAHyP7XBIhrpWPk2cCkJNVukoOd292Fk08Ro1o083KFuFSAerJTHrqVa04Q7Qfy05FO0Jad3bo4F3mmjMvPzi0NC71FryFdtQAjUlbOT3mDYNUhoyXihgjberLe+Eq9crTYrpz9G3n4JDpKSx5TM3q1q2/20R1lK0J62wLLvZE8F05oOq5qgvBGxaxXmBweNQQDRB7jIPwyXKCelXwcXvwLoLdtpUrPwuFIB9yAbAsKVl85oV+ivM+FtbUhpVt2IE+ccZYosvjqAjNEN70xOEZXG+GVvmVz90BBBXVhxG6kM/RxMlztfaNv3oOA3IaLvFzyTUOj1qeP+MMeqnAfdZhaXeZLjhxfDhfN/YjpKkmUrY7fhni/0PZ5C9Ojg7fUD8+OepSiauDRdec5qxLBfqJBZEP/twUJxZiwokYdq1K3cFMbHkChxJ9WATvfTZS6BxMIPhcVmWj9Rmw/GJtNwX2TMueaf8hAbHJicCBdb0aOXY+vAIBEQIEvgVC7+DBdhRaK0VHKZ4vnN6UY/XrbWecqyKMhaWAF3CSpqMACKsp01yX9+sKaDbHHVNSdAdLyIG2Z2+wXjzZddCvOUsHkJeTeQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38070700005)(26005)(55016002)(76116006)(122000001)(7696005)(66446008)(53546011)(110136005)(15650500001)(8676002)(71200400001)(83380400001)(38100700002)(9686003)(52536014)(66946007)(33656002)(54906003)(5660300002)(66556008)(186003)(6506007)(316002)(8936002)(64756008)(2906002)(66476007)(86362001)(4326008)(6636002)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hggn7X0myoz5mxwMLd3yee2aCSn8qykYjWhVLvKltcxSycJMb9R0+GeRZh8v?= =?us-ascii?Q?SX/uVzymOYFFFYktHyx0JzLArnXa+vWhMx8P9uKr152nxnfbqOolG0D3m0/4?= =?us-ascii?Q?wl99VG6bzsez40QJsNHSkKeAp3mAUp/5dxDEocvAh49HrQjCOLBQhffan1VO?= =?us-ascii?Q?dbUaWKo0B8DU8rgb8jYZBi8/TB+A8JVtk9SvcdLOtGcQgpLaKorf7bVJT6bl?= =?us-ascii?Q?S6Zr31HyoH2hnnbW6TrotzSTwnJf8ahBWn37ZPwsvVavloUEqn6MDsNZPD86?= =?us-ascii?Q?ApWsB0sHGGrrl8PPh8Bk0LKC64W1yFGEgGHQwVyaUOSYiuvmayzC1g4Uk+6P?= =?us-ascii?Q?btq0zMPA7iBNGZMm2PL75uB7R+yY/6mZ73UwM1qp6F0ZYnADmMJKZCKiB48V?= =?us-ascii?Q?SthIQbpXPhPhHCQJ2d6E4v/1E+DPil8usOm4FC8ChFe1fvpdgnEFlcIniq8l?= =?us-ascii?Q?Aa14SxbeKclml5eN28USoPMXBmFakmdFnGt4gJt/4sjO1qNUmTHFnHZOFnwO?= =?us-ascii?Q?Pgh8WmkeOa6OEMpzZKGGapTuxUQFRDR0BywbGaJFHRQNFobnWpU7BfBl6zvA?= =?us-ascii?Q?ZBCWxQxBgysYMxDmJe/I9c9ctmzHDGSpgqXJRzK5vVbVm4CBc50gMKJ+oSlM?= =?us-ascii?Q?eGa8+nPHCS5QpSb7nQ4cgEVpbnrYZP2oxzYsQTDHvkuMlpbcm16DFio/xLVg?= =?us-ascii?Q?sD2YADtZLoXJ7dn3TJqaDiOvH7OhclW3jYiCL7bJwSc1VymBaR7v3Jt9/4Md?= =?us-ascii?Q?+M012RSEOTd3TAbuk44/7+0BuXPipHkd1zThDvMJbeCRub5xKes7DsSTCy4K?= =?us-ascii?Q?mUB7ITfh+gr4BJ1fMji2urcqprxiQJ4ITpCidj1K+Pt9ldUxNfgjnRxLnJRK?= =?us-ascii?Q?eAY5FjGAM96Rmt6yVYrlkei7Gc+gddjIr+iUrHFn16BxA4CMVKl3xBpfL5IP?= =?us-ascii?Q?SE1IOFG1UgYfAFhtJB6kwCligbEaGSxIRZty9wl6FARAGC6YQfPJdLe1RQvy?= =?us-ascii?Q?7iEZ0mCDj/lcpjUaRRJESxgGH9tKzjoTklkpqUsQgZg2GV9NfOrwaIqvyw0k?= =?us-ascii?Q?rQYSPx4jCdM4McTTQo93U1RNghmEjS5hjzfQx7gphG8AwKA2h47+1XGyW2pM?= =?us-ascii?Q?D35g4muixUw3UhRnbSEHwsDsdYHc53manV1tVxqnAGuI4lE6AzUG+FHNO9M1?= =?us-ascii?Q?P8SBfmD8jz0SR76gT8gEHDBja7edMSScZYV6jxIon39TwsMGQb5ury5upSKj?= =?us-ascii?Q?XpZ0RWkJqUVOpK9HbMYoj+i4QK9p20PPt4e+71wvMMCXW5Mo8qriMUMlaCS9?= =?us-ascii?Q?cI0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e48e1c89-73ca-4513-08c2-08d97ce5e9f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2021 09:55:16.3387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YQTkQaLSOTQtGmrSVugv3D8IeU+t5KfoKQcS7cd5LIvWHTnCNaB0UXk7KvY5QgfzkMtInyDykR0igka8M73wKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3657 Subject: Re: [dpdk-dev] [PATCH 3/3] net/mlx5: Fix RSS RETA update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Maxime Very nice catch, thank you for the patch. Minor typo in the commit message "ithat" -> "that". Besides this: Acked-by: Viacheslav Ovsiienko > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, September 10, 2021 12:18 > To: dev@dpdk.org; chenbo.xia@intel.com; amorenoz@redhat.com; > david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru; > ferruh.yigit@intel.com; Michael Baum ; Slava > Ovsiienko > Cc: stable@dpdk.org; NBU-Contact-N?lio Laranjeiro > ; Maxime Coquelin > > Subject: [PATCH 3/3] net/mlx5: Fix RSS RETA update >=20 > This patch fixes RETA updating for entries above 64. > Without ithat, these entries are never updated as calculated mask value w= ill > always be 0. >=20 > Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update") > Cc: stable@dpdk.org > Cc: nelio.laranjeiro@6wind.com >=20 > Signed-off-by: Maxime Coquelin > --- > drivers/net/mlx5/mlx5_rss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c in= dex > c32129cdc2..6dc52acee0 100644 > --- a/drivers/net/mlx5/mlx5_rss.c > +++ b/drivers/net/mlx5/mlx5_rss.c > @@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, > for (idx =3D 0, i =3D 0; (i !=3D reta_size); ++i) { > idx =3D i / RTE_RETA_GROUP_SIZE; > pos =3D i % RTE_RETA_GROUP_SIZE; > - if (((reta_conf[idx].mask >> i) & 0x1) =3D=3D 0) > + if (((reta_conf[idx].mask >> pos) & 0x1) =3D=3D 0) > continue; > MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n); > (*priv->reta_idx)[i] =3D reta_conf[idx].reta[pos]; > -- > 2.31.1