From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C522FA034F; Sun, 21 Feb 2021 09:59:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A514422A252; Sun, 21 Feb 2021 09:59:57 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mails.dpdk.org (Postfix) with ESMTP id 5964740696 for ; Sun, 21 Feb 2021 09:59:56 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 21 Feb 2021 00:59:55 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sun, 21 Feb 2021 00:59:55 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sun, 21 Feb 2021 00:59:55 -0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Feb 2021 08:59:52 +0000 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Feb 2021 08:59:40 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 21 Feb 2021 08:59:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gASHZOI/oBDgnUynq8Ifh0Mn4se4BAUPD0gc8jg0lRHRH+w6e16rGvlCWPOwsJtY7UFn2iuzIrTabjFU7pPKnDNNc3yNANN1pBCAXzokIHYe1TnqwjKHVZgMPHToKQ5CcYEcru3IIdhNK+fs5adM1lPGBuU1Mzvu8RrT2/0BixA7i5WIyfD4lximI2GfmoFJkoAxKiTZFWgaFtpyDdV4jKBg7HiLoJq9BGl4Yz0jap6RH37GoN4RVEzaFGg9nlZDICLKh6b6WIgEaEVYzjH315N/KNe8nB/ITh2qVlpyaEy7y3Vw64FPU9/5va+lb/0iUtawNw2EeNm10KbveKpDTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kpEqEes9+TGq3Cry3ePcsnZK+2uVKSf/NbTknwVLrwY=; b=CxKgd5rc0OK/ugHNuf+mZlY6YGrLzC9+JqCkXG4XugGhhsbkNQTvKjLC840/gNcLCeiITGq5wZ0AeWPba4QaOxRZZrFXrqBb80ADIrm0TlcKc6Tu9nCqbS8wmZ4V27SzEyOqDWawa0ydOw9DnWXOXTJyvy8Pv+mdNEmafCMpttVXoFahn30non2PlJGAKPv7sX7Mvri34aILxzgm5xiV6AhpEQzfU6C1CTm1HFC7FUJEzn95WIF0vmF19sP/zuazKCQbZbqTgyZCj2/bzsaxyyVcOhhOMp1J7gQnIMKHwaEiGj6to6DzRrLjhpILk5GsEAVKh3yq8kbGX4SI/dwLEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB4169.namprd12.prod.outlook.com (2603:10b6:5:215::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27; Sun, 21 Feb 2021 08:59:38 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::d1dc:9fb2:4724:53df]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::d1dc:9fb2:4724:53df%7]) with mapi id 15.20.3846.041; Sun, 21 Feb 2021 08:59:38 +0000 From: Tal Shnaiderman To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Tyler Retzlaff , Nick Connolly , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Beilei Xing , Jeff Guo Thread-Topic: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies Thread-Index: AQHXB/EJTCJmPLQsdkeOKah5K01Z4apiSpfg Date: Sun, 21 Feb 2021 08:59:38 +0000 Message-ID: References: <20210220232910.772-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-7-dmitry.kozliuk@gmail.com> In-Reply-To: <20210221012831.14643-7-dmitry.kozliuk@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.56.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e006bed-4094-4ea2-5ff5-08d8d64704e3 x-ms-traffictypediagnostic: DM6PR12MB4169: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AVC8Uj9YODIf9UW41wV98HJtiHOVwaHUiGBbx1xiKJOhBr7UDshB7bZnyEzm5+t4nuUCH29XlgZjZlUnzfyw4K5GjRA1pqvJ5EfTJ7VyrQzzPm7edB5/Oo9H1nBLDQbrA+fyagFAfhgmDGuhXkotuZqR67ihCGvUrWXMjz6BoffBuw1UgbRAyHFsIl/G8O8QI1lIZ3wnDeyIy8NYYfnmkiHyFW+NLpOAWTAD23t+1kQ4Oo77CxwbBG/MMKN3u06LZGnHZfutiPu/7iP1+lqYqz7VfKH/bQEKO6Zgrt081VrrqCF8ub7E3eYo5nGodpgPA6Y9pHf7UJmPQxrO8HomdboG59zrTMnVn+vzTD1QE+/FC2yVq4aMx6RTLMbJj/4Y8BfCb0CJPS6veHgw6pc0pnq1/dERH4jRNDzLTuK2t/ORcvucobjvMNReHFh4TCBw8E759acohWxEGP85kHr2UNJmw04rOUe+beQluhFlDwshWYPNVsLLphPT/iyWloTyF2/Z+IpeFqgeKTqnEUhTdRWBQAMExg2WxD02l4t+MfZqaBa0cdmRX2QWr1B+U7oulWtnHh6YJdXy5lr2rOLh1q66GaSpt2hy+Mm5k738WuU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39860400002)(396003)(346002)(376002)(66946007)(66476007)(66446008)(66556008)(64756008)(8676002)(6506007)(4744005)(71200400001)(55016002)(9686003)(8936002)(52536014)(4326008)(186003)(2906002)(5660300002)(26005)(33656002)(86362001)(966005)(316002)(54906003)(110136005)(478600001)(76116006)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?f70VA/ZGIlL3N0QPP00Nze0IUxNgTbPFTqGIArSKHf51QDSURw8jvMUKqtKw?= =?us-ascii?Q?IW1NjjcJq2aJUIDAAa7WqhpcCDg2TKi6KxhSu49xzFT76qtJImtwlx+mGd57?= =?us-ascii?Q?bF0pgg9vusZsddnD98nfz5Epr814mP2EBSuU4IdHMONWPqb9ijzlDZPWoqvn?= =?us-ascii?Q?rOKusxzb/7rB1MTNtG0cvf61g28MkfEb9AKvHN1l1C0RLYnvUZ3cF7X/Zq0W?= =?us-ascii?Q?R6RqwhsabJrrMYrujOCDo3tNGGLgiFKQ0Y/0SlaWgqYlV5lCkmRlJFWhsATr?= =?us-ascii?Q?jh/gSemv9gK6xymEfN+Genj5q4n3tb/z43g1HwmOOMHddvzJKYITqU+YALlM?= =?us-ascii?Q?aixthANEBe5LU1cbFOCQGZd9FQbyzFL4xerigpUifLOb14/19vv20m9UqvoO?= =?us-ascii?Q?j5crX8FMn7DQHd76WJDJE6ichUe5FjOireNGNfWHQyuTCr9iG4Syo4yKMw5R?= =?us-ascii?Q?4u8BUz1pOiKeN8oqoudxMJ8f3PlYXe5PGSCi/IkbNNGYT6UEQemF4UFLCymU?= =?us-ascii?Q?zTOWXqlf2ZV9uccNZrCj+cxA53avMQQk0RB8Bgkynkrd+SFI51o0FcddkleX?= =?us-ascii?Q?BRpAE1pjroD/x99SBBEwX0qBBKaUwKn3Jw/lc/m/h0BHy66C0SHsynn3k2H4?= =?us-ascii?Q?Zvo9YgAe+vkt5lj5cSTbo+oTRpw6L0UDCRQy4edh6wWU5BAeWWxtP9l/zk6V?= =?us-ascii?Q?uazRsVZlT2TcoR6Wb/1L3sRzuTBtc83qn5Czdnifig8s0YVSHBzhp6RLhBCP?= =?us-ascii?Q?c2Jk64FRq8tARnqQxJ9lbZ8haK+yufBj/zAydsr2gnmhC9amUAiMU7g8B5/f?= =?us-ascii?Q?WxigHHtAdil05NAcmDvbiOQVI09bjO4ntsPJAAUsLVzp6xBATO2JRlpnKwyH?= =?us-ascii?Q?P2euRhu5k4Xk+rve4NCxea01GTmkGEUu3r43KedekWLxkjltP6ZYVMAJAP4X?= =?us-ascii?Q?gk1TmWMfRQRgdrR02pjUO7MmP9ZvaonmwAZmwj3/wXfQUVVyj7CbDTm/JS9o?= =?us-ascii?Q?9x2PNpeM01vGt3poYB0JJyjt1POCKzkXvt9YYs5AsK7gEe0uqGOK9v0QvFDN?= =?us-ascii?Q?sPDR2mvKTECeh9NukDwuD0IPEcJdDcZfiOlpgHWyeEC4y/wzT9xJvy3lv8b7?= =?us-ascii?Q?pC4mCw3mxWs88gaOFIgxNOLa0pO2uw2HAv9960cHsshB8Yj3Hm+TyAEHB8N2?= =?us-ascii?Q?wCPpi8wW4rvOm2proZG0QMXU/BVZ7nIRGxShIAUnNkqim7NlvTcqxUp44UJD?= =?us-ascii?Q?WiI5OueetH0L8K6IWh9NYzIuV1KlCpUjooIFQY52/mg4jSzAkuRNirLIT4yv?= =?us-ascii?Q?3Cj+YhIYj29w+Oe5zG7AfDfQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e006bed-4094-4ea2-5ff5-08d8d64704e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2021 08:59:38.4508 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HC7bJgTopsh/Y+NDOWhOkZykuuI1VrPRCgkj00HIOhLGO/EtCPyZavsFY5OOd6WodIQviSP0BdoKfvXYZzlF9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4169 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1613897995; bh=kpEqEes9+TGq3Cry3ePcsnZK+2uVKSf/NbTknwVLrwY=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=ewrrYKxLDsOkPthCPOXpMXMyknRDOkkTIPADFssyVi3yxjct1gznrcpMKWO4Pxm2r kkADjVjQxrvb/CvsdOJI/ydPoRjzWxJZUzk9jK3FLGXyj5zDzYYbnizjGcJWOnDXbV xgxwchtMAx7zjnleq69mD+vZVFl3X3uc20+8lLLDsqvi3MygqmeZcTuyW7mAoxdUl9 S+QRCCiJXH494RDC1jdEtAOsxchXVIvxjUriyLPuxD/2Xt0raVKDVz9FiyMnucksbT u9o9A8l0PHWm4QjkA6vT71EW3+Mpqn4T/2SN83e4hIU6S5Bs2UsqZi5qku1RzGOJdf C3nqZuV7SkvSA== Subject: Re: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies >=20 > External email: Use caution opening links or attachments >=20 >=20 > Replace POSIX strncasecmp() with EAL rte_strncasecmp(). > Replace POSIX strtok_r() with EAL rte_strtok(). > Replace POSIX strdup() with EAL rte_strdup(). >=20 > Signed-off-by: Dmitry Kozlyuk > --- > i40e: checkpatches.sh complains about long lines (it's ~85). > I doubt that mechanical fix would keep the code readable. > It's on 5th level of indentation, so I'd extract a function, > but would like to hear from maintainers first. >=20 > drivers/bus/pci/private.h | 2 +- > drivers/bus/vdev/vdev.c | 4 +- > drivers/bus/vdev/vdev_params.c | 3 +- > drivers/common/mlx5/mlx5_common_pci.c | 4 +- bus_cmdline_options_handler in mlx5_common_pci.c has a call to strdup which= needs to be renamed to rte_strdup (Also failed CI: https://lab.dpdk.org/results/dashboard/patchsets/15674/ )