DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tal Shnaiderman <talshn@nvidia.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Leyi Rong <leyi.rong@intel.com>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
	"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
	"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
	"beilei.xing@intel.com" <beilei.xing@intel.com>,
	"aconole@redhat.com" <aconole@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>, "ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW
Date: Tue, 2 Feb 2021 14:13:44 +0000	[thread overview]
Message-ID: <DM6PR12MB39451E504412B37B48EFFF5FA4B59@DM6PR12MB3945.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210202102450.GA139@bricha3-MOBL.ger.corp.intel.com>

> Subject: Re: [PATCH] net/i40e: disable AVX512 with MinGW
> 
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Feb 02, 2021 at 05:06:39PM +0800, Leyi Rong wrote:
> > Disable i40e AVX512 code path for Windows build regardless of CPU
> > capability to avoid the MinGW build error:
> >       Error: invalid register for .seh_savexmm
> >
> > Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> > ---
> >  drivers/net/i40e/meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/meson.build
> > b/drivers/net/i40e/meson.build index f5fc5a17e..26cd201ee 100644
> > --- a/drivers/net/i40e/meson.build
> > +++ b/drivers/net/i40e/meson.build
> > @@ -56,6 +56,7 @@ if arch_subdir == 'x86'
> >
> >       if is_windows and cc.get_id() != 'clang'
> >               i40e_avx512_cc_support = false
> > +             i40e_avx512_cpu_support = false
> >       endif
> >
> 
> This fix seems to imply that there is something else wrong in the logic in the
> build file. If the compiler does not support avx512, the fact that the CPU
> supports it should be completely irrelevant. Therefore, I think a more correct
> fix (logically) should be to remove the "i40e_avx512_cpu_support"
> from the next "if" condition, and only check the compiler support. We don't
> do anything with the cpu support variable.

Moreover, this patch doesn't resolve the issue [1].

 [1]  http://mails.dpdk.org/archives/test-report/2021-February/177665.html

> 
> /Bruce

  reply	other threads:[~2021-02-02 14:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02  9:06 Leyi Rong
2021-02-02  9:30 ` Thomas Monjalon
2021-02-02 10:24 ` Bruce Richardson
2021-02-02 14:13   ` Tal Shnaiderman [this message]
2021-02-02 14:31     ` Rong, Leyi
2021-02-02 14:32 ` [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW Leyi Rong
2021-02-02 23:07   ` Dmitry Kozlyuk
2021-02-04 10:41     ` Zhang, Qi Z
2021-02-04 12:36       ` Ferruh Yigit
2021-02-04 12:59         ` Thomas Monjalon
2021-02-04 13:43         ` David Marchand
2021-02-04 21:57           ` [dpdk-dev] [dpdk-ci] " Lincoln Lavoie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB39451E504412B37B48EFFF5FA4B59@DM6PR12MB3945.namprd12.prod.outlook.com \
    --to=talshn@nvidia.com \
    --cc=aconole@redhat.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=leyi.rong@intel.com \
    --cc=pallavi.kadam@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).