From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E409A0A02; Wed, 7 Apr 2021 13:38:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 301334069F; Wed, 7 Apr 2021 13:38:26 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by mails.dpdk.org (Postfix) with ESMTP id EA0974013F for ; Wed, 7 Apr 2021 13:38:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I4ApNcYCwtlKohvY4ck3gZhkSw+D9yC0RJ+yiR1rO5YOLoCrLzoaVNeiOw89QRKbvJlTU8KX4guQGdbomh5lUaRrG9DjNinm3SLmwG24w7FKrT3moaYJ6KupFfkrtNLK1/bn48wIfAmRl5EKN0+ufpIWvyGxgXdKDb5iqrlw8/G1eNP/xISwmBq/ZpjcZrxRhO5d9OiloyAyq5Yrs+zg2JDlLCS2/yoKJPZaA0cn1F0t+8gNTugj4XIIDR+CMgkDQ7eRwAHvYaWebNf3Nm0lhsFe8VM0AHNPZetQrwqzfSVlSDK5VuwHGphoIdSRGEXtfV7I/F460tVdvMo6golrlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=je8imPmS4GzrtPiTetEVLnSDTjXDa4VgXb3UfgH69uM=; b=G6Zp6JJoPLbrjLHKrXRLklTkN6NXbpKHQQGhCW2XayVimlWS4oSMiF3foNjodrJAUe/bJKdltGlZqNma9fwaWYytLZqIrCKgfi3tZnH9oLMlhuwAsuRZ1aqeuXlCyGVkIbItUeX3qZ6Ov5dzAfySpobfOt7tYtCKJxoYTkaxxT49VvVn4mW/RxnexwmZNf9kWwcAU0yxyOf741u3zRszp6HY0baNn0puGv6HKGi36xV1ZYAJeEhagHJpCv/FMG/px6mBe2OjbrQMAOO50risYYM6CWNN86t+HBCRmBP9cp4jl1ocGGinGSevcNVn9f/yuBkNvCozL3Aegzv/gRHeOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=je8imPmS4GzrtPiTetEVLnSDTjXDa4VgXb3UfgH69uM=; b=KBRzFXI2GbWIF/sewjpq/OixsApU4Ayss8koQfTicTvbDxd1lNDFphMHdn87L3G1GZS80hyNCJUOVo7c6f6Oc3fD2x9lq5hKNOgXlYPBPdf/08xguS9wCVoRQ52EqIkR7lDU4XeXLs6XA8yQI38yEg9j9MfcQ1cDWDwqdhDUcp+J8fA5FWOGcRK7+RHuc665Trqj6Ujz5R9PraoZIqVaWV6q/F1P6Y386qQRGlkydhQ6BEEqhNGfqLYE/I7+eJ5iXQfJJz7qP4Ux/QCXbpeAU/SQRPwMuxnHtij9sgUKcL/mom4P/yU9odn+TrKCqf0b/zzlYkUtNWIApQHyAqwJkw== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB3850.namprd12.prod.outlook.com (2603:10b6:5:1c3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Wed, 7 Apr 2021 11:38:23 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.3999.032; Wed, 7 Apr 2021 11:38:23 +0000 From: Tal Shnaiderman To: NBU-Contact-Thomas Monjalon , Dmitry Kozlyuk CC: David Marchand , Narcisa Ana Maria Vasile , Dmitry Malloy , dev , Bruce Richardson , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Ophir Munk Thread-Topic: [PATCH v2] build: list symbols exports in a single file Thread-Index: AQHXK4wWYRzmHQdFR0aMkyonXwQC26qo6sTw Date: Wed, 7 Apr 2021 11:38:23 +0000 Message-ID: References: <20210406163231.19663-1-david.marchand@redhat.com> <20210407115330.42701deb@sovereign> <161779865.tXBAfqbjCS@thomas> In-Reply-To: <161779865.tXBAfqbjCS@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [5.29.63.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43d57504-abab-40a5-117b-08d8f9b9a6aa x-ms-traffictypediagnostic: DM6PR12MB3850: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gf/PzJLkmd6JiPYd93NRL8K8jjVe8U1oh2E3U3ugxzBC+A5tRmjJs41oBPxrDtb8JTMX+FEUJk+L4yAH5StFZkVlgiwVfKhn8E2rMfcJLknKgkKDI+zsod+FhsIYqzfiBycGzEPuT9EyC09u4Q9VEIiHxOQ5dCePF16M4fp3xUEhaAv2K0gPbh6eyXWTwIIB9xVOFfmmGzNlObkA28VO5NWZ9pvJVjeYohoXQbb2zeSvRrW0Zg2I1KohqFlxy9ZeQFMN8I+pQdz3TgK0lAAZOvLg6mgZd46UdLB4rRHmcK14ubitGzNAoqiBCE88TO+VsCRYnxY+tkxHT46EjtXNbQawjJKdHszJk5GO8UE687gT0gCuqPYrIRaK4mN6hw+eOwB3I7Ihp0vP5eGGphZs190Bo4EGRxalaZsW4U3EVRguPniO8YlY+tk6QiRkWZ2YifOVp73OF4qFMd93TII+fJiHUsjag+aZoqi8GDuqxF948f/eg5I6J0SgXu4dBnOlfr6kgHIrp1/VGC8QASkyPTVrYfbsG4F8hayfa2zhf4xY784FBQ4rPGNVUyz3ZRDTB6h9wDr9wOWzTSFvT8sjEeISB0E2K8pFgLyiPfKBeO+aDkK8NvEH5g8SlXHprhQtVHyMVJubUQxpO7EPRRsT9CoL0KZ2vycfH8wpL5q9ZHU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(26005)(76116006)(38100700001)(107886003)(110136005)(7416002)(8936002)(8676002)(5660300002)(4326008)(52536014)(55016002)(7696005)(2906002)(53546011)(186003)(66946007)(316002)(71200400001)(478600001)(54906003)(66446008)(9686003)(66556008)(86362001)(64756008)(33656002)(66476007)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/HE9vMH0U4YgHX2qdJTnGfUyzXG9EWMDE8heaHzIOVEuk7hM1tyl85/yuxxU?= =?us-ascii?Q?G7xF8pDtBWznTbJgPfrerUkyv7pVOKbGKCZ9njpUZ1eSIRcGHAw3igvaiNSL?= =?us-ascii?Q?3X3z5iE9m4lwZK15wN+v7UT6AlnRZ8Vqq7bH90UD13N0pJowJhs9IrWfcIHc?= =?us-ascii?Q?ISUsMGLYmWdZ9PrVAjG6WZPXylWAaSAukKZnjuzWLWLETIBqdQmxcOy6EfkA?= =?us-ascii?Q?EZ6RaQx0lcpjiPSyh39lA6XW2x43418lA8MfTEmbvLxYjbMpJQfFyVibkfXT?= =?us-ascii?Q?CtXjCSQCF7cpSe5Iyn0WcNdbvgchN65MdPttz44UmDc1ESmP68v0bqOvREXF?= =?us-ascii?Q?xdzxHw/4b4d9PMBZ3kT4WvTB5kqSXBbVg7Gs/bewlAi7OktV+s50sxseOfMK?= =?us-ascii?Q?x//pOnsyYiZup81RFhK7CQ0zs6KFHuxW25eBcfSU6nLMFSTfhAwM8mUKdYPG?= =?us-ascii?Q?jw91bNhqICJJT2GiujFPgNHVZSEYfrq1t5amLZouU63GBxQEc3z7SeIl9wDB?= =?us-ascii?Q?APLn9DQH427a/cA1k+1gXY6584DJg3A99G938ruUNmRpb0/HWxaGFRp7zCqx?= =?us-ascii?Q?YEP3Jyc1ODiTY6ajYVOFTyG4ofOOSmX6OrOVXPzcUuDSpidf5pKRADiRJ+Pw?= =?us-ascii?Q?BnHrZe60j7mRly9VfphZo1lk+NzV6Btutwc+amlnkjU4m1fLbihuz4aFQwg9?= =?us-ascii?Q?VZ5WPvg2jCt9nRvjaLNeD7/SYqdhRv1C/Zfd+8jQIvrhW3gmmEOrRMYABOg+?= =?us-ascii?Q?a8pr3QqpK8DpVUVwvqr7aEIbMLl05xBQn5HEDaJikAzML81E18U8FhEbliZk?= =?us-ascii?Q?mQtYgmHx5G9tOE6bOuZUQhLpYUy2/jE3LWZcuysC8LVQo6YroWcWAs5BOWg3?= =?us-ascii?Q?1Wu3gB6DGvnhTKhPlFfZdU52xe2hAj0Sak4nPaK3+egq7KLlgiZWHx4Jx9Jt?= =?us-ascii?Q?HUO9EuCGcCxWK6jhEs6ubrIeQekY/GJtDMWsKv6u03rGFaqrAhw6lnRshyhs?= =?us-ascii?Q?SyNfpZz4c/NMedzrg/bvkL9UHrWgowcr24rTE3FEzPN3IQ3YIGuSP78xgUw7?= =?us-ascii?Q?Jdm4uuBngleq5MQaQpvYkK51v5VyozcybSiW10hRC5Xw8dYBgxczpmJI+Hv4?= =?us-ascii?Q?YZjTWdUWlBRZpTLPzGDztonpJUCkJtcomo/XbzhI37OHqwXLzMCmS3JXhiYP?= =?us-ascii?Q?u8+qpL8+Nca+9jHBbJQvotuITHXLRcZgGcoACzvehk0IxMUwMDWzeZ3bLtzi?= =?us-ascii?Q?1x87cesI6HD6dBAf+bec5H/ZHExA7E9vOFJGg1QpM9iSWI0Zt5wOtbUpXa0E?= =?us-ascii?Q?Eik=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43d57504-abab-40a5-117b-08d8f9b9a6aa X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 11:38:23.1425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3SFPeaOiEmc6QtpJyNADUKYqn6f+xtGdZC3jw5knCFcHWR0cyvpaDxEzB8texUH0/j3d+slRHc2vlqzyz48TgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3850 Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [PATCH v2] build: list symbols exports in a single file >=20 > External email: Use caution opening links or attachments >=20 >=20 > 07/04/2021 10:53, Dmitry Kozlyuk: > > 2021-04-07 10:16 (UTC+0200), David Marchand: > > > On Tue, Apr 6, 2021 at 10:09 PM David Marchand > > > wrote: > > > > We have exports missing in EAL for some series posted on the ml > > > > waiting for merges. > > > > I suspect some recent merged changes have issues too (but did not > check yet). > > > > This current patch does not address such issues and we need fixes > > > > afterwards if this is what you mean. > > > > > > I did a first pass. > > > > > > I see symbols from rte_random.c and rte_version.c not exported, > > > while those files are compiled for Windows. > > > Could you explain why these are not exported? > > > > These are just forgotten, can be safely exported. >=20 > I prefer we don't mix fixes with this format rework. > Please send fixes on top of this patch. > Cc'ed Tal & Ophir for mlx5. >=20 Thanks David for resolving the duplication. For mlx5, the functions mlx5_devx_cmd_*, mlx5_mp_* and mlx5_memory_stat_dum= p are compiled but currently not used. I can send a separate patch exporting all of them to be more aligned with L= inux, or we can export them whenever we'll actually start using them. Regardless:=20 Tested-by: Tal Shnaiderman