From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BF9AA054F; Mon, 15 Mar 2021 16:37:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64F854068C; Mon, 15 Mar 2021 16:37:22 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2075.outbound.protection.outlook.com [40.107.220.75]) by mails.dpdk.org (Postfix) with ESMTP id EE10940687 for ; Mon, 15 Mar 2021 16:37:20 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gBF+LMhXLUhvp0C22SysHOV1z7ubLeGH/yimmUk6Awh3Js3l/LlFYXGMhIiQtH4lzhrlCouXnHdzTBUwOvV+R6AKCCcHgmaa4No8/1aghyXcuCOz+bTo2rP2AAn2lSzBF4ISJj7MP/VRnB8MoAoHPwnt7DMU5twciHlBi0MOwgeR+8qgmdCMUW5z05H7pWiKrkE8QDvO3hGCX2TASpy9ggo68vSgblTU26OTuIRT9yPov9X7v49NXOs3iVHzdFkJAlx2Wpllm2Zwxajs2u/VXSInX3hlT6CjqvX9F3ovS818pGAN9uSgqcRK04ubAdT8QdEnehrfaz4mVP4rJNVXvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4zandjKgQTFxh4/1oKO3780lgrTG8Os/HkAWAnwKDy8=; b=BGLZeufZ7Pq2xXY0UAFPkxSm16gg/qTrOkLGovdwqtltlYlsXJnv4UPXzeIVrkimB6H2TwQN1y8fDq+Z7Ea+72oNoEzQudQQ0AGDdhvA+0ydgVIqbBIssoO5dmruqQPvzau5hTnn6FE9OJR7SJ7GZJkB4CLT4rXUNTWgH5Z/n8PYO73BcqQNpj18dvV+USHqeFN1qGfUMsCz2pC9T/yr+Dfdm+D9aX0Tk8Jiu/prKi7bmEr26gA7dzMcaTxsVociXLzwg2taNcdMydC+4G1MoADK724FxKXIdbxWPHtzwLwxGw7MnqkFFQ4n7WcEEoWWY5pBohoN4+/ehbog30pfEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4zandjKgQTFxh4/1oKO3780lgrTG8Os/HkAWAnwKDy8=; b=UCUHghQfwUKaY86WpSvkJqm03n/XANfLUOGzVMiEiZJQ3ex6rz3VSpnQoNoN+e7r5jF/ag1TPwmuaqdO7CfA+FDFpi7U1aaL1+qfURpIGuKzFTOzjns+tM+VEg5EREViYVj1ibaJgspCw2s4nheqtswwWB5Iia7HHAtx9hieO55dfoSDQQa4tQeCeXqLO6FCVgBLzkHhHFlOsVwHIAjX5OLsXsub+vjX5r3+BpRsyTnciQlEbIGnk+hveOjiS4XT4dsbJEi5tloxpf/d3HQOZ2dZadB2JWyLdzUq1DHcUWQLaW6cTYSDwu3gT68+TD47/Ro+w/+QBfiKHI5ysRjLkA== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB3419.namprd12.prod.outlook.com (2603:10b6:5:3c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Mon, 15 Mar 2021 15:37:19 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.3933.032; Mon, 15 Mar 2021 15:37:19 +0000 From: Tal Shnaiderman To: Narcisa Ana Maria Vasile CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "pallavi.kadam@intel.com" , "dmitry.kozliuk@gmail.com" , "dmitrym@microsoft.com" , "david.marchand@redhat.com" , "anatoly.burakov@intel.com" , "vladimir.medvedkin@intel.com" , "mb@smartsharesystems.com" Thread-Topic: [PATCH v4 1/2] eal: error number enhancement for thread TLS API Thread-Index: AQHXFeX63HIPlAK5DkaE7d4sXlnkjKqFMyTg Date: Mon, 15 Mar 2021 15:37:19 +0000 Message-ID: References: <20210310120632.14464-2-talshn@nvidia.com> <20210310124856.8188-1-talshn@nvidia.com> <20210310124856.8188-2-talshn@nvidia.com> <20210310194534.GA12609@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20210310194534.GA12609@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [5.29.26.201] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d268d59a-3b6d-42c1-ff4b-08d8e7c8382e x-ms-traffictypediagnostic: DM6PR12MB3419: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kt9Gu5UvzuWCpZHFERO4fAVXDInfSACX7LbQ9cH2ue2oeMwZrAgUdOVyhvzgFIUJn4C29LSvqMJa8xZMHdvAteKMRHQw0vnVt7sI3h01zlDUS4KyurPLG5mv1BhMUj8guUmMDr+dk3VOMYK7XNN+kADKaWf5PCBFkOyWkS1LOexEF2hdlQC7XY0xOgzWckxHzsbvBGyjY/J6ANR2oQoP2drckKbR4k4RjD0UOPmoX2krl91d4Yb0VVKcaet74/NeS+3ig9AhJVAtzqbtXqqhDyCw2V+r0LQbQa1wWMGJ6ymln3W6tPJCipMX/824NhMK+Y8ZmXImXZOdRdmdk3o4K6hto/BQDgIueE1Iwx4Yp7XhVteBGVQnX4mrspgNLumjCkZebVYHpgU2m9wGl9B88yFZguyn5QCYLQZPz9qUoWrMDiFpCzSxQFYUHpxcnbrG7oDPREkd3a4auXOxO3MK5yPs7G4v4vh8z4DdQxnEQI3IxNpl+8jkIz+0lvZxXaD+H7xbtpH/A14s8trP/55w1u23KZhladGwZqZfC3OUJ4i4NyPOmkDyyJboOAmtxFjL x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(316002)(478600001)(66476007)(54906003)(71200400001)(64756008)(76116006)(55016002)(2906002)(66946007)(6506007)(83380400001)(52536014)(186003)(8676002)(66446008)(86362001)(8936002)(6916009)(66556008)(33656002)(5660300002)(7696005)(9686003)(26005)(4326008)(7416002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rzjH781IpneB/Xg7oGBnDfQ0gGcudkkPSnioXeR+mLUe9H9oWnmPlYg6xvpT?= =?us-ascii?Q?X1nwpp37A1SFQtaZDvDiIS2d5lFan6EKogt43cpNafpgmkHLb5l00GM0PAjE?= =?us-ascii?Q?FnPe1zl1kNcTnBFNqfdL0JyYFFYA+ePZTby7dCHCzsE7KIAGasLCw+FtaOQr?= =?us-ascii?Q?5N5pI6Da9hDkxlDAYeTGTsGKj9SyRjz34BgnyIpT4QLUapfX5SXNipoE5mgo?= =?us-ascii?Q?Jj9X8Rdlvqak28OLY3kIe71wiLUWXUZTSrC+3X/P6yYYzJn/W0sx5gRj+tEx?= =?us-ascii?Q?Zxk8/eMXdu/46Lf2QfRPHSQpZQfWaKAy+HU+AGk8+TB+K/Lu5ZBASBXHyCKT?= =?us-ascii?Q?CD+nBz1dVoFIIloEfJQK5L0KofyR2yj2M0PSgNsyntax/3rEa45V8jSvWgGB?= =?us-ascii?Q?o8BE5LB9GJlWVCqin7LqORl3Ks2N2Ic8zjACRk8v8j8B6+6kHjRJayB0UlGw?= =?us-ascii?Q?jl+2v168lYWoLkqcHT9xGLVU5P8AUXrTG5NuRVar0Lg/O8mnYh1fDK5TIjOd?= =?us-ascii?Q?PQgpu7lnyvOrrv2kvF4qAo/vBHyfjbwkw5i3blE6w9IoizDEyCARJ4bC1OsT?= =?us-ascii?Q?EETbmCbbQ1d9WkEYpbMZVlv8gBSn8FEcMhsyLzeIlLm9eeVnwsY0qUSs41wJ?= =?us-ascii?Q?xJ6NXBcFWKq/NRZUjrrQKGyXMJCoqlLnMLaBTBkzaf6LrGodjV7/ihPjMPgb?= =?us-ascii?Q?sBfXpfevneYeYjym7ridx3hSbSIleAhMughIy9D7eER3lxjJHgeinWWrs1I8?= =?us-ascii?Q?g9tGzGbkiIas2vt283yxakXAi+F2jRBHmH5zSAr0K3Ju8BcqGU8LK3M8IwC4?= =?us-ascii?Q?0DJR6bduZTRcwL0ZJJrKBSHKgSclfHFPi9aY/bXLAPo/Zg74bDsMlHPFUVhh?= =?us-ascii?Q?MYkn/eRYdfk1qrndlYP2Rdg20cntEW1tqoLz2Ln9y0hltumAL/vADeQcDiIQ?= =?us-ascii?Q?xCmSUtRga7AeBlj8XROVGgg2qdxcFjgArdp17encm95AM61fGPe+J+gB4Uvl?= =?us-ascii?Q?igLpGcpYB2TSOTqNkne91oeBFbP0EqeXx+gK+42JpMoozy+56i9VtG4fo/oA?= =?us-ascii?Q?EliT7L8ajLUokfXnTbpeMjOyADP4P/IQ/MyMxcz6nczyQnrTFPIwVTFpl/yD?= =?us-ascii?Q?wgyqbD9etxURMbZIslKDIfOsrryp857iPlEWaHa4ZFnYhkNRiFLwwut2BLE9?= =?us-ascii?Q?UVCxP1zhT3HG9MFwh+jeTuegHIuga3hscy86sbpsxoyFHI9wfAb9JKAr96Si?= =?us-ascii?Q?HDYQi4FFWjWsH+hd8K5lszaqax+/5ZObj/AkxbWDQ/7FjUNPKvEhvRIkJhBR?= =?us-ascii?Q?JNE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d268d59a-3b6d-42c1-ff4b-08d8e7c8382e X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 15:37:19.3895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +XTaaNboHN0c0p2Ba46+Hkwb55teoMJd+EWKQqY+6F/F30HRZ2BPtYjzcKXGLrVhZhHilyMCtlh6RC2n66vfGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3419 Subject: Re: [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for thread TLS API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [PATCH v4 1/2] eal: error number enhancement for thread TLS > API >=20 > On Wed, Mar 10, 2021 at 02:48:55PM +0200, Tal Shnaiderman wrote: > > add error number reporting to rte_errno in all functions in the > > rte_thread_tls_* API. > > > > Suggested-by: Anatoly Burakov > > Signed-off-by: Tal Shnaiderman > > --- > > lib/librte_eal/include/rte_thread.h | 14 +++++++++++--- > > lib/librte_eal/unix/rte_thread.c | 6 ++++++ > > lib/librte_eal/windows/rte_thread.c | 6 ++++++ > > 3 files changed, 23 insertions(+), 3 deletions(-) > > > > diff --git a/lib/librte_eal/include/rte_thread.h > > b/lib/librte_eal/include/rte_thread.h >=20 > After we introduce a translation function to map from Windows error codes > to errno style codes (as part of EAL threads API), should we change this = to > directly return the error code from the functions? > Or do we follow the pattern of setting rte_errno? Sorry for the late reply, I'd stick to errors in rte_errno, note that in cases like rte_thread_value_= get the only way to get the errors is with rte_errno since it's returning t= he value itself. BTW will you also add translation function for the UNIX errors to get ident= ical errors?