From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5794AA0547; Sat, 10 Apr 2021 21:59:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E9BD1412F1; Sat, 10 Apr 2021 21:59:47 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2049.outbound.protection.outlook.com [40.107.94.49]) by mails.dpdk.org (Postfix) with ESMTP id 5E3CA1412F0 for ; Sat, 10 Apr 2021 21:59:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WQuN+JdVS/BHvfvxWVOTX5KQaT5bx3wVbVLU8zvfz3zy0T+CTd8ZWMT5I7nr3YZQJIDsiliIiXJ6bK5Onnpac92hQra/0zqRpBjWX6T4Rd8Nv3AMCbidHT3xb/njmOBmnyf69TATDUQFiYIaTOmayz9bKeyvGi+HJ/I9O0emXaBPMcrANyvomo7SUpwisUU+g2qF/gp++mpf2AQihZnVGvByjQgppQuhrC/T1+1FjSQ7mTMN53ZxiWZkG/C3ABqlpJWYFQKGjnyhKOHA72RvvZWfRq+pG45gtQvUO+oCYsk5EF/F+Bon1WrtTS6k/5MORMTA1sklyMwbv6sN02pKxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=frYiTjSApkOOv1tIf3YbSM/sGybgb7hIdtErZh+A+JY=; b=RKswjQb5wERtyFz+D5q/xyhiQag9Sifw+tRCI+FcxO38ony6YOHC8zhl7Dbb6wG9yt/ZJnqd2OFd5MGeP5ibLywwaYmMPgfzuanTiiFg5nmYe/xATTinGi0RSRCAQVKUGDHYO0cyOATTff25Pli45Ip6COQyftm1xj8wUHAGS/pzXxK6hhvl9jYXDr00lQnc+sqQp34yLnkURlM46LEMpU0izxxZHqYp6lLvJaaRY+dpG7/1l4qK6zWLgsd5Gs9WDwNQY+DVi5GbHF8dQxNmPzRd7ZxtIi9Yurjl0J+I97A5m9+oeSruBUkqV37Xd/LstUV/jNY2LyYk2/5BZlDSWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=frYiTjSApkOOv1tIf3YbSM/sGybgb7hIdtErZh+A+JY=; b=M4m599THUr8nzzKA2o5DZ257VuDRzea1FGxClauPgVXZsd+h1G2Ev8palLAQAsokxJgkkB1UDIqZABmdgRaDJI/BDOBRW0TgJNlSqMAehfpWoN953VeoSXWAHbygW0NnhNFPIGaoYbBY+q1aNpG/kqW36gPmAHz4IwbOeJ0ZWydO176/LPtDPYq2Mx3Q3Y1nbBXBxYFajPVr2LWzyR98JIyNxt5io0eMw1ZTxI/vekp2AwKRPP43PMX+uDJQz7mX/TdFICw+x4ApMuxhrSXBO/FQ4gsyaCOs8JjCfcKFq7mbuMqwqASVlxXWPewnlUjroxweQCDRyxlJ8RYQKf2NiA== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM5PR12MB2422.namprd12.prod.outlook.com (2603:10b6:4:b9::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Sat, 10 Apr 2021 19:59:42 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.4020.022; Sat, 10 Apr 2021 19:59:42 +0000 From: Tal Shnaiderman To: "Xueming(Steven) Li" , NBU-Contact-Thomas Monjalon , Gaetan Rivet CC: "dev@dpdk.org" , "Xueming(Steven) Li" , Asaf Penso , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Gaetan Rivet , Anatoly Burakov , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage Thread-Index: AQHXLhU1aOM0BIMQ80uN7EdRt67eYaquEuiA Date: Sat, 10 Apr 2021 19:59:42 +0000 Message-ID: References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1618064637-16413-2-git-send-email-xuemingl@nvidia.com> In-Reply-To: <1618064637-16413-2-git-send-email-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [5.29.63.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3ffc122-dce6-4cae-8086-08d8fc5b2e56 x-ms-traffictypediagnostic: DM5PR12MB2422: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1775; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: anhIZ2bEDmAHdMav5Voj/GSuynwf/F0KD3+JIF6sdIH8JSLBIYHW/THP8l1BtYClNmGHrrgPmWTwn/l/m9KHv1qqP2XZUfa0T29gY1pJ5RIzVN/LRBGCdzptx5z9kCN01IreeuwhkKplVus7J3xm+xUOEz1OOAX+zGKHH+SwofJmxefPX7AY78WaYyUvuADownNzVM71R8Rp9HXkCpu358urCyU/0sL6cjYbsNAdovD53Erhj++LU42pbIiMhfNASp9ndgjkCHgGbq49O76KsygamEsbDZORamXosk++cKRaZVuSKOzUWy3kVfo7qqggwgBZ+evVbhCHeVqYVg5ymsLiFltODKuxyN3weqZRy7SGFXpwIUlvlEz4hu+4RqdgDN3hchVZgfTi/CB7v/6vw37386mM/Dp8FLvANRKsnid7Ly5rMAhH/D/bCA07z/OIhXiFjfZTc7+Ew7OhFfgEo7h1kzE5DZXk2Weyob7IKL91s0iE19FpCxWBlm5WNHhZC/BD5nJJunuN39XiQ3mtkqjxchUoZNOLODiYYAvp9kKu+xV2+u55lKH4rnjqOuZo+ri7jMiwa/7KWr0y2BztLAJKa8kv0eaEyal+UXG9d1Y= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(2906002)(76116006)(54906003)(110136005)(38100700002)(71200400001)(55016002)(316002)(7696005)(26005)(9686003)(186003)(6636002)(8676002)(5660300002)(64756008)(6506007)(8936002)(66446008)(66556008)(52536014)(4326008)(66946007)(66476007)(33656002)(7416002)(83380400001)(86362001)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QZh7vvYj0blpXpy5JJIir4YnbleMEaU4NddkpzbzgaVbblkIjwBoWvEyx4k9?= =?us-ascii?Q?g4hcTfpnx7AZ2zogOjntEjKiGLLnXG/hUGeFjW/fPpYn6GZ8YsKAoOMSQKLn?= =?us-ascii?Q?f3BwKqvjnK9wlf7Abz+2rKb2WHxfql9Ce4FbjQyOSF/Yy97DywVECklehN2j?= =?us-ascii?Q?cYSP26CjwN3LOU6Ytw8t/9Fv53SJ9NZYO5IWAZkppRdp2WWW6P/VMOcNSk0c?= =?us-ascii?Q?NSqH226bLGHIr1mCqqfIR4JKtn1qaipUm5fWfAzm1u8BivdRN3q4Q0Dubwui?= =?us-ascii?Q?gJV0u2g7sDwFFFnsRY+GDC0+AMhmqcMdtOqRbLuHWGvDNo02gMw3ULpn7aYP?= =?us-ascii?Q?66Lj5Ftlzhi0yOdbWZqGvCNFi1PQT+cNMDjN4ble1YODp6egP1fMlDLZy+P+?= =?us-ascii?Q?1sbKq1uBXe7oYQXsFeizt8GW6LNsozFtXYf3PEJHERQt3lOANwuNKl5PZwVb?= =?us-ascii?Q?YqOveRVceUGJTYy2KTUBCQlr+MgEVtJHkFJuEL9aX7zGzvP8PCYGQR8MVTzb?= =?us-ascii?Q?9S9RjJEH02FJx+8/xRki8vpPm/1CUhzWBF+3pA365j+BNgylJwdhHSUH3D4l?= =?us-ascii?Q?oomOek4ElEiHa/J4vGJbp/ev3dV3GeXdzYDE2TBImkviR0I8c0m8SkJ/wnij?= =?us-ascii?Q?i4V3d6+aBEl5rRDp39AvwwfZXvuBAE4beJwvyI08YSbNjns6M/LQQ0PGF7rb?= =?us-ascii?Q?GNpSW8Bxo6Td7TJQXmasV5BJJfw2ILURv044Qg+KPu9Vn/vlzGOIYo5Kef3U?= =?us-ascii?Q?7zK9Q6p2eiNfYozYhYwaxmDjG5er9VlIxr467LTFAr+TrPbdfFUh2zlN1nX7?= =?us-ascii?Q?cHGc5BtVA8ouOdwOyKIQfWG7mVRfvUPfuIQYdRlmwLQnNYzKgwIjW9Y7zNVB?= =?us-ascii?Q?/PPrYi6imEacKlqx6siRV1ABtg6SKMUNoolvMAXtq2a7t6tbil+5fKPMzIin?= =?us-ascii?Q?Zygo07yT8hFT8ZsB8M+IdWsZgXDzgbSVtShVSyMK9KnpVI0dUecnNjwDParW?= =?us-ascii?Q?4fCg2wA+5NIKhdRKdTu9zi29ktGUZUwYv8ZfNK30GH+Uit+rwrncQbecx0ck?= =?us-ascii?Q?MRS5/jhifDiSExOHolHaa68Lu/qOq/DVqbH0LtxnpaA9kxbXgwTOS4RaQXSq?= =?us-ascii?Q?4tH/HpxV6ExVbVgZKuipYDLSoXV0/3Ej9p1U2eV0EHbpR7PwkgA1tXzyewsV?= =?us-ascii?Q?nKJ3L8O0n2UynsI7b4iGk1iTTkZAT6MUD7NTzzPh1uPunKDWqR0DxQDT4h/D?= =?us-ascii?Q?M66idsGKZQWD26nQxevic9lQhH9U22/0H0ijoI23/hvnRXmrLaEUOVICQW4w?= =?us-ascii?Q?WIw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3ffc122-dce6-4cae-8086-08d8fc5b2e56 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2021 19:59:42.1939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GApwVrDFR16Z2geHTnnha+x4a5AQld5bvwMyvu7n2ya2gnMUK7qqiPbS6Bfv69SE8KQWMnTH4v3S8IWaQQnD3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2422 Subject: Re: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage >=20 > In current design, legacy parser rte_devargs_parse() saved scratch buffer= to > devargs.args while new parser rte_devargs_layers_parse() saved to > devargs.data. Code using devargs had to know the difference and cleaned u= p > memory accordingly - error prone. >=20 > This patch unifies scratch buffer to data field, introduces > rte_devargs_reset() function to wrap the memory clean up logic. >=20 > Signed-off-by: Xueming Li > Acked-by: Ray Kinsella > Reviewed-by: Gaetan Rivet > --- > app/test-pmd/config.c | 3 +- > app/test-pmd/testpmd.c | 5 +-- > drivers/bus/vdev/vdev.c | 9 +++--- > drivers/net/failsafe/failsafe_args.c | 3 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > examples/multi_process/hotplug_mp/commands.c | 6 ++-- > lib/librte_eal/common/eal_common_dev.c | 9 +++--- > lib/librte_eal/common/eal_common_devargs.c | 34 +++++++++++--------- > lib/librte_eal/common/hotplug_mp.c | 6 ++-- > lib/librte_eal/include/rte_devargs.h | 18 ++++++++--- > lib/librte_eal/rte_eal_exports.def | 1 + rte_eal_exports.def was united with version.map and removed thus the modifi= cation above is unneeded. > lib/librte_eal/version.map | 1 + > lib/librte_ethdev/rte_ethdev.c | 8 ++--- > 13 files changed, 59 insertions(+), 46 deletions(-)