From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E5F3A09FF; Wed, 6 Jan 2021 21:33:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C3C0140E1D; Wed, 6 Jan 2021 21:33:57 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mails.dpdk.org (Postfix) with ESMTP id 1924F40FA7 for ; Wed, 6 Jan 2021 21:33:55 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 06 Jan 2021 12:33:55 -0800 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 6 Jan 2021 20:33:46 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 6 Jan 2021 20:33:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nb3JFpJFQzfSaIKR+FN9HwnXtqbphrYl5boQV0XWGugyyS0qe5aT+LdHuWuB19SIMI3LhYinnj9j1EoQu7NzpONBw3+4sAqRQIplLcRRU2kbQAMtQPmr515QhDsXjcKVmOdJk+lu7nVd3o9RCfi2ZOrRfx7MnC5Z4xkDC+teA/kjWuIuAanPC7r5tDxko9nJM6/jxb7Gg5AegbRXr3y3SbFlZFTVMUNhFYTBIlSGnaCletgOqcb7YQ7HFYlDDoU2D1/ociI+D6aG+jTGO/sIR1DL4eqfRBg9QzS0weWhOu710vN450XGjj+pR8QB14fuasdLcVvUE19aMh2m7n8XMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8C0Me8V4jCjDT71i8X5W8LDj5MtyIOndO69oVYIKLl4=; b=UIvrkbTNvi+KCco0r81kKP8zZ0j+wBoTwhQwlCo63CeNgpikE8zHoivYDVRfuofpcSmjmNMyspa47z6E8A4InkZ2hjjgwcOILrHhdHS3L/TYh1Y0FV5/U2c/5Tu3zw8xwjUqfsJbGd26cDWHxHj0Y4WUHbMRnM+Ts7kC/zxryRL9JKka+7Aki6NYj7Kh+qvEgfhI6YX1e62P0VIR1AtRlaaiS4LdfYD+zt9NTdlMbcM5eF+HrLETAoZ6M0KN5imUbIvj7HarJHTgsqlSjcjqTa6CBMBuiOvlQbbnCkvkmnHIRtjmLfcoJpRhtUGq7l5B8BsItEwnXHCzOgEb4jlOxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB4370.namprd12.prod.outlook.com (2603:10b6:5:2aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19; Wed, 6 Jan 2021 20:33:45 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::d1dc:9fb2:4724:53df]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::d1dc:9fb2:4724:53df%7]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 20:33:45 +0000 From: Tal Shnaiderman To: Dmitry Kozlyuk CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "david.marchand@redhat.com" Thread-Topic: [PATCH v8 2/2] eal: add generic thread-local-storage functions Thread-Index: AQHW5GgB3DhE36mik0O8bR5J4r/3y6obDXHA Date: Wed, 6 Jan 2021 20:33:45 +0000 Message-ID: References: <20210105170635.6212-2-talshn@nvidia.com> <20210106194543.14024-1-talshn@nvidia.com> <20210106194543.14024-3-talshn@nvidia.com> <20210106231032.1ecde254@sovereign> In-Reply-To: <20210106231032.1ecde254@sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.141.17] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39165339-d21e-41f7-2f11-08d8b2825d75 x-ms-traffictypediagnostic: DM6PR12MB4370: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KXyaFGXB/LOvNFWSLGtPu5mKQnEVvZKOyDjmOwNOj+bj2LFlYUE1xXBfCENayB++baQ9M2gSwALQaHJVTjS1aclyvED1S0sDX8mVYAILU32HgOG1vkz9kmfyStDCPy94u59OVQlcVj+OMllCIeRXRRSN7fpCjgjCJPPxsKMmmXAGjGzB4/A6CL26RCFmSy8nMCesR3HET6nA4EqMeysqcJH3CjUH6xGomkxdfPBOQW4TTkHj24gYpd3HHAnD5wdJmf9fBvBccJvgrorCRRzisuN9DYkAydfefVi9zJChZ95ikGGzEAf1InHNjsbn4gifArZSuUGOOBUf9/QPwwiQ/vBYyJtwr6F7lLEH6zVQLnkwRol1MzRGKx0Xh/v7s7NQ1WWTvzmkmvjC+qRbHMN+8N893BAmAaXgVDLQFYTWwP23UO2/PJnmifD8KpmmbNiW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(66446008)(52536014)(64756008)(316002)(76116006)(2906002)(66556008)(5660300002)(66946007)(66476007)(83380400001)(55016002)(86362001)(4326008)(478600001)(6506007)(186003)(7696005)(8936002)(26005)(71200400001)(8676002)(54906003)(9686003)(6916009)(33656002)(41533002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qrRJR7iu3mSmj4/FFIy+u78XTb9LIaUC052YS/3GyJ4ur/qu2aL8QY4+fY/s?= =?us-ascii?Q?LAQunTSWFqFd7EwiWLsM9FjVPoLOI4JSRfJeJltrn2bnf7Oyv4GrSJiqel6f?= =?us-ascii?Q?YCaYa0IL42wihZDxW1pWr4badmrUpw+WeHJxnR5IvEoFEgS6uGA5sM6ZNaLf?= =?us-ascii?Q?WgprEhOWhkVefY2DYQO/9mwrqoq9+mnjMx9cGA+s6XaYySjPuqxEHSVGWggB?= =?us-ascii?Q?mS2jffM6pAiu1gbPUMkVR5UmbClnBq/UGL1QKcBqp9wuKSx0mch6SS6b8h2X?= =?us-ascii?Q?9NF9a+HPoyaBof7Z5jXuWGwjbwOlzLyVdtipqnmHXt/aO7tbwLKulx325qfA?= =?us-ascii?Q?j2ZJd/aOKZbZhN6iwG5cKz/sSyyalzryqVqYMyTqud4ErIIUBNggXqJoWtXL?= =?us-ascii?Q?ATu0CBIvKaMPv/YoLqxWP80jcNk8vA35Nn4oCKr6FUIpiIP6ycY4LNHgb3t8?= =?us-ascii?Q?F5jFxpB7wcFk9MMt9h2zsBWQ2mcBXwBm7ZFUM4YeeqI2d0xgjqJaUJLGcFMc?= =?us-ascii?Q?lbw5NIhjkBcksui8tmYMGByT4KY3wMDzWENmBrveA8jtbyAtBOMOZl7k4jYx?= =?us-ascii?Q?Kv9D41jTAvJe+WfbMtRKmb+CsTrNcmSHnnmL6SczRJZiyilEpC+qUz3o+D0X?= =?us-ascii?Q?TstEaW43CaHv5BT8zAFl0/td2W9XzNNDIYqjPWvvaTDa7fyvWKv1Q6WffrNt?= =?us-ascii?Q?PEPU0/ndBkgSXYCzRTNlk5OrhO83BQaPEOKNThng+95OH9LspnOEMWg6Vris?= =?us-ascii?Q?nMko0F9UdcanvSjFqHL3YlLYdmLX7Vym0t4HlieomFvIHqvW1+bAyEeF0k2H?= =?us-ascii?Q?1sYr+p140gN+d419mr8y0t10kcwZZbisPnf6QCgcATAFaBXpxpg5AFFBrw/M?= =?us-ascii?Q?Sir1+IAIQWK39bT6weTaJcOo+OOWau+whhgNc2e5iyD61En+5b/W+PoD0y0H?= =?us-ascii?Q?5JORH4fDwd8hRfwxjlgVnF4tJhj8DUpacut+kFqiiyA=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39165339-d21e-41f7-2f11-08d8b2825d75 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2021 20:33:45.5409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GYEPfZ8Lt1tlTjs7Y+VHWIPlFigftlVkdf1XiShBrLFzinHhWVVvFy66zInXEkeEVeItoHT1KMkR+PPxMrQdKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4370 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1609965235; bh=8C0Me8V4jCjDT71i8X5W8LDj5MtyIOndO69oVYIKLl4=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Sx/Esp0wGfacPCXj/vnvmHYOowuDKyc7374eyYX6MC//k6Mtq7geEJ3P+cPoKJjmr erCbi2QdRr08E/0Dwhf3HoPyHYFY+6HMQNwFbdTVVCOOE7lGvuLw4xdsLLsQes8zp8 aTI7yl8u711yd9Ma5QH1Y69AQthzHaBCum80GAxfetUH5Dtk/xX1VspI87rp8Tex2L Vo4zEvDdGuFojIw51hBSjFkLk7vxsF9T/UcTJoiYW6XqF2XK+a/hHn4ig6uM9RPMVm W2/zzWjXo78juNMxAM7gonajqagx+rX12RKBlZdc6d4QEHrMi2zrIENBDr4tSStHm3 WhvsUOf5cxReg== Subject: Re: [dpdk-dev] [PATCH v8 2/2] eal: add generic thread-local-storage functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [PATCH v8 2/2] eal: add generic thread-local-storage functio= ns >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Wed, 6 Jan 2021 21:45:43 +0200, Tal Shnaiderman wrote: > [...] > > +/** > > + * Delete a TLS data key visible to all threads in the process > > + * rte_tls_key is the opaque pointer allocated by > rte_thread_tls_key_create. >=20 > This line repeats @param key description. >=20 > > + * > > + * @param key > > + * The rte_tls_key allocated by rte_thread_tls_key_create(). > > + * > > + * @return > > + * On success, zero. > > + * On failure, a negative number. > > + */ > > +__rte_experimental > > +int rte_thread_tls_key_delete(rte_tls_key key); >=20 > [...] > > + > > +struct eal_tls_key { > > + pthread_key_t thread_index; > > +}; > > + > > +int > > +rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void > > +*)) { > > + int err; > > + > > + *key =3D malloc(sizeof(*key)); >=20 > Should be sizeof(**key), which would be sizeof(struct eal_tls_key), as > needed. > Same for Windows file. > I had to double-check my comment on v7. Thanks, missed this one as well, sending v9.