From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81832A0547; Sun, 18 Apr 2021 21:05:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50EDC41108; Sun, 18 Apr 2021 21:05:00 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 0516D410D7 for ; Sun, 18 Apr 2021 21:04:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZsvRnK2QfoLL7/JwEsOZ2pmR9SUrsJ68m/dBr7aID6lnK0AS2u2GWaUtbmpIWFznYpasvIVoVYbPRmlSAAFTssgg7kz7M1N37jRpp49HpXjV2msPqmommlKYAqfutzBt9VwdS+pCBtEniR/eKnJdNmgynOqm+yY2/BQ92TpbhWW8yK9qpLQyrLn9Ax+IbcG9D++iDnX0zmhPif1Mag6HNhtImPxzA+n0rAUAccJpbpJmsm2F5DO1gE7kLGMvkzdOrG4B9rvYG9JKQEzeWhfh1xOfxwpUMKY5kruS4n8xv1v0ECTg9+NthWMvfmb3A68irYaUQHoL1wTZ3lhOrd4kJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yvm8GclBm1HBtL1TB00+3bZmQRNKLwsxL3a8odqEXd4=; b=C193/fJGW16ZbPoAvI5TfIBOnShmny20LTE+0a3U4Q8NlvyA1Kv0KuudE1d8f9lPgMDL8cLkqzoXQwrLN0349f0hFzynILC3Ax28ziH/VGjTqJm9NvadTgdrNK9Nwf9VL8wlrqQdtwOcsBpRvSh2jGLEtGSNEjIr29zC/ywJukh8Tm82MklP1740vBOHiJmKn0V6ugTj4t3GQTrMdX+wt/OEmnr5uOZYEbSwBlILBviH2Xt92BpdjNt+SVGZFIpVySn3vEwxMKjGToQTys89GaEieP1lKZJBn3S3WxMYMYjceWaoBqTYSyJXpZlRhaKrS6wNQhr2aJF2HZlolRKzqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yvm8GclBm1HBtL1TB00+3bZmQRNKLwsxL3a8odqEXd4=; b=fj+vgYz68hO+8eu0A5ZRHWtFMg3ZFwmy+3+H52eYOFI0sThmAGStoWAMPFbutd4t5K/Qc9c1Ait0JwRmNUItwbtVPSG4mWl0Mm/tUA1aYujx7Y4JMIlhBSyuGGkXyIdj9HQIJFe6glWDBp+eZCJxVXL0IVZHl+Q78i0vMH1CoFPH/beQgeRzphW8/0WUd0CrMbG0AYYKgwA3kIjbIn5h79Pi456IJ16Hhp3W8FnOaxnqgBxhchZC0pBQUvpBzGNc2TUD1zq3gbZFYRKjH6M8mjgNw/cdIq5v04y0rpfzJjz4b/TAgy3GJILYJ3OAuilrWXDb1s+jq8yJ8PsMw8bDoA== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB4986.namprd12.prod.outlook.com (2603:10b6:5:16f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.21; Sun, 18 Apr 2021 19:04:56 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.4042.024; Sun, 18 Apr 2021 19:04:56 +0000 From: Tal Shnaiderman To: NBU-Contact-Thomas Monjalon , "dmitry.kozliuk@gmail.com" CC: "dev@dpdk.org" , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" Thread-Topic: [PATCH] eal/windows: fix build warnings in MinGW Thread-Index: AQHXNH6ZwWznH+guDkSl6v4FBquUUaq6mXjg Date: Sun, 18 Apr 2021 19:04:55 +0000 Message-ID: References: <20210418170803.15684-1-talshn@nvidia.com> <2018619.JnGxiWPmQR@thomas> In-Reply-To: <2018619.JnGxiWPmQR@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [5.29.61.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b844b2a8-20cd-42f6-f07b-08d9029cdae3 x-ms-traffictypediagnostic: DM6PR12MB4986: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IJzcjzR3IG/KyzJBxeku3g+xP+ws7XDXnXXaRXCi4RG7b0JfGRE3Ul547A9K8E331DW1r4KVzVyDn6Wqp5Tp25zOGioD1XAJShoxUhPod+TUTgrR0VVBQWtShGpgRviwjV6n70BOxGnaWp9up1eN8O+n4T1GR3N+lFbwi1r8xzgHXwi+tfuWKf/RjZWzPNtVdRy12bPYDuOnYTAWcg9mWDcZqxIO+rMk9dZRf9BvYI2vDzY1bF6PULTMgMmocY6n4Fl7fSHRaKHXcRzCBw0nbWWAGrCwgzgXIXY8Vhp9+FiDCf8RpwH6UOFYOWi/+seNySRh8g+wwMfUb4uODpwkjWXxDXXAYz1ajPSZC7j70VmWqWb8u/es0v3Y325TsQrsmOTxkGMlTJMbnDBPI7kE1S2YH/CB+u/BJwyv1ek5HjXNKIQ72MCeWZiyMHrMPZ4dzB6rtBOABrY+Fq/SP3KeDsmav9cungLpqzZnOAGxBuQbN4im00WHmIgFyShuodOe3jmFL3PQJdOqdTZOU3xa5KOhdguJcJY428jb8suK+hwmvEWg3GEvKFRr/MiJtGiMcSVkPdCg+NZrVdtej/DoZfEHeMy/tqapvvveXWm3XSI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(396003)(136003)(39860400002)(55016002)(9686003)(110136005)(7696005)(122000001)(66556008)(64756008)(66946007)(86362001)(66446008)(66476007)(71200400001)(6506007)(5660300002)(38100700002)(478600001)(54906003)(2906002)(8936002)(83380400001)(76116006)(316002)(8676002)(4326008)(33656002)(26005)(186003)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QHiwuXUailECoz1SVNB0xJz4UQkKFnZjEt5i7g0PEtaoAhMt3zN+sDeqmlt+?= =?us-ascii?Q?z9yNKFEaZYfdfY8kQoia0Dur0lw6HmTAHVEsHEZCKtzWuxm9tKHTTMcQk2Mo?= =?us-ascii?Q?xTqQm5Nv14bvZQjFmCcs67HLxFwnvomMSRbYMdPY0TTCEhL355xXsQtCHZ9H?= =?us-ascii?Q?SuJDEpAVI8ocz/MV1V9qqIEXDBC3ioCbK9tc6FA3Co9n61Yr48snzWbv4s7f?= =?us-ascii?Q?j9ACxNfV0JiLrTgH8C3paOFU8bwEeRxMwzfiyyUTaiV7lC67z9+dbadVDAM8?= =?us-ascii?Q?z61Ul2kOn2pV1tlXVfOWqx/3UXtnv61sGsKO0weLfOTVpiDHF9Yx7y2YXo5L?= =?us-ascii?Q?qLcK77BC3Z3tT7ZGEHZ9sS0Fn2mGUae7D31KVZ9O+9UC4tm3AZFO/wgaiT44?= =?us-ascii?Q?bPv0q5vVuk1UQz8qix+wdJmo4jR4Rv5OYzvEo/Up8l4wrBDEKR/D1p5dpL3K?= =?us-ascii?Q?eDh38kzYT0FT+1SKSJHeHrtB+TTcExDiSISFFKGDQMhC0b0Sn8uNzlgX1qav?= =?us-ascii?Q?a2dGZ21EAnQrx7SuoC2e2nZGUr1/C8HMgD4JTi3zKrTCGJo+x5dO2NeqZFzi?= =?us-ascii?Q?o2/KHPhTkEnJ8kuNn1Xcpmn4e7H+LHW3Vhtg0/nNRxiWFm5gZnVUjdDRRtTC?= =?us-ascii?Q?mdddh7b0IQT97WnJLoMmZ10P2W4sl0h6E3+n9Rralvk6wK3YbD4/owCWffmW?= =?us-ascii?Q?e9jdF0euTLs8QTcn40YvmxAmy+vofNtHqnYkwIcA3THD5UoAPeXUjk3uoG/e?= =?us-ascii?Q?uEoK1EpzNZ4hmyt6r/Dlw5d6W0nnvTAf3jJtwdIxPlkB8xi+uNryUeI4qMfl?= =?us-ascii?Q?ejOBaxBvgfemTSJa0gBM9yjAMhEr1hNoUFIOb5cGxFchaRcg6gU09rxGARSU?= =?us-ascii?Q?OvvzclDivfZ1qNbp+Y5tM0btkOx5Y/gdlkzaIWOc+I9f6YxCtbVcEId/pUIY?= =?us-ascii?Q?OWe58ij8eacb1uhNnauy3L3x+4Ry2yRexjN20D6Se/Znz4goSRCBmkV/9Igo?= =?us-ascii?Q?Fi4soXZb1JmkdbdZZYkzHRRoIbDobeOQkjAg2IT98yLULeZAttX40P5M20bj?= =?us-ascii?Q?U9Jl3MC1bf7etrSGF11wl8uuOU7o2c4+Lev0Fb3q6UKz4XqaEVa5ABUTxFZr?= =?us-ascii?Q?jK79oWIp989QaQ2bfvCzSx380pp6UD566K3V57o9vgQdayt5kK4LooZY/Tft?= =?us-ascii?Q?oN7x5bD03xxemH5SbbF8umWZc1i92TjKfeATvKlm55q8r3G0RbX5f/0IQQp6?= =?us-ascii?Q?If6RHdKzyEy58e1EPAqbrwIWsQhzbeEAgWDaa5knciaBYONerVLwx6QXNAkx?= =?us-ascii?Q?0f8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b844b2a8-20cd-42f6-f07b-08d9029cdae3 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2021 19:04:55.9361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mmKVDFT1s4LiWrOPUfWubsthECTbmSryQNAD4+XRenQERSnzo2QifFXESS/duFvZpepsOBVJtEcbi+7pYcigfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4986 Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW >=20 > External email: Use caution opening links or attachments >=20 >=20 > 18/04/2021 19:08, Tal Shnaiderman: > > the strncasecmp marco defined in rte_os_shim.h is already defined in > > MinGW-w64, as a result the compiler prints out the warning below on > > function redefinition whenever compiling a file including the header. > > > > ..\lib/librte_eal/windows/include/rte_os_shim.h:21: > > warning: "strncasecmp" redefined > > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) >=20 > Why the tests are passing? Are we allowing warnings in build test? It's a good question, I see CI is passing without warnings, Dmitry can you = reproduce it? On my side the collision is with the following file: C:/mingw-w64/x86_64/mingw64/x86_64-w64-mingw32/include/string.h:119: note: = this is the location of the previous definition #define strncasecmp _strnicmp I'm using: -gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0 -meson 0.53.2 >=20 > > Fixed by defining the marco only to the clang compiler. >=20 > That's a very common typo: s/marco/macro/ >=20 Thanks, will fix in v2 if this patch is indeed needed. >=20