Re: [dpdk-dev] [PATCH v4 2/2] eal: rename key opaque pointer and functions in TLS API

[Tal Shnaiderman <talshn@nvidia.com>]

> Subject: Re: [dpdk-dev] [PATCH v4 2/2] eal: rename key opaque pointer and
> functions in TLS API
> 
> External email: Use caution opening links or attachments
> 
> 
> 10/03/2021 13:48, Tal Shnaiderman:
> > rename the key opaque pointer from rte_tls_key to rte_thread_key to
> > avoid confusion with transport layer security.
> >
> > Also rename and remove the "_tls" term from the following functions to
> > avoid redundancy:
> >
> > rte_thread_tls_key_create
> > rte_thread_tls_key_delete
> > rte_thread_tls_value_set
> > rte_thread_tls_value_get
> >
> > Suggested-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > Suggested-by: Morten Brørup <mb@smartsharesystems.com>
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> >  drivers/net/mlx5/linux/mlx5_flow_os.c   | 10 +++++-----
> >  drivers/net/mlx5/windows/mlx5_flow_os.c | 12 ++++++------
> >  lib/librte_eal/include/rte_thread.h     | 19 ++++++++++---------
> >  lib/librte_eal/rte_eal_exports.def      |  8 ++++----
> >  lib/librte_eal/unix/rte_thread.c        |  8 ++++----
> >  lib/librte_eal/version.map              |  8 ++++----
> >  lib/librte_eal/windows/rte_thread.c     |  8 ++++----
> >  7 files changed, 37 insertions(+), 36 deletions(-)
> 
> Updating an API, even experimental, requires an entry in the release notes.
> 
> 
Thanks Thomas, will add in v5.