From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6122A0548; Thu, 1 Apr 2021 14:29:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5C7714115A; Thu, 1 Apr 2021 14:29:57 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2085.outbound.protection.outlook.com [40.107.223.85]) by mails.dpdk.org (Postfix) with ESMTP id DA747141152 for ; Thu, 1 Apr 2021 14:29:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVLMaSDu3DFMcDNpN1/tsgKEI/2++OdnkcglRAj1fGNiPO8VwcXKPy0s7HwDd0BBVQ/MPrUQnH2ZCbVvDs/jMhpHqOBxKffk3748nc2vDU8A51slrbOGoxO0SNw7eD6tLRRv99Ptvm6kwDjj/9X/0pOCHe/SIAYv6SXhh7Svo/eYDxm3jcqeSvoQFBEkR8NotFPGwr7WFMXW3/ac0BxndMHGiaAn/TUqh4cr/3qjZqXrKMxkJAHcj7dvTGFIxxaMDn/Yd8q19bbp003YlG37AQC4O0QkpbSxEEV9wuibJ22ShfaIBWgmczK6/vAmoj9/CA/xr51GrrHq+Mxf2QPJDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v0ewBvK2bdnUkXOTL9R9v+vY6abXz6/QoiJa/SEec/Y=; b=lfFGFVIn9lzW9Fah/j8R+kzSuwDGC6B27VRg1FPIcvZaqr7JbxUkgflE7Z9k+0FaK56PmImxccgQVY0RvFpLyADCT08F1HPyA9BY1M1Pbr6iqHYgHf/k1suR1+gv/UtQaMJ1wP/d/uwk+LCZpeo+QcsrPwnew8NPzzzhJs2MPWT0+wdcnuePHFfoeOS4gZxlAX/pBJfW7ERQfp8ltGXWlYsppz8ZSwUjkvoQ3S7jGy69wJ2R0Ocs1HwP9kLIYJiYYEEEf06/RMfLNJcQ4NIWDBjsrlHEJmhox9e4USOGvnBw2OCcFfBWD95tVYTZwgCjQX16v185lFTn2qPn1SWsmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v0ewBvK2bdnUkXOTL9R9v+vY6abXz6/QoiJa/SEec/Y=; b=GDu3L9cNjeDs5blI96/yE4G+GHvpJBe7nf6mDA752kQx3K1fkbx0X/IoH2TNNPBp5O2ENmzcugmN0g5SuOWMdkDR69K03OFN/mqaTYtQOhKgPe65j8tl6fkQh2m7HKV3gI0a1nlRxQ8T6r/CUXCt2FZapaJpPtW3CbY5VNJg9k087LGVQYNKum+GJGGzVrY4aLAn04ZTGJ/d3S0fnFV4IDUhzmV4SUwig+1WG7X/EOXAIZKiB1TNenwgVJc5vSEW7fVK4SDfVubereALRc779UKkXdar5j/uW8K4m1LNtAXHN7gnplxeMtsbjB7Upb90zvs4xQ8c2wykhsE5vpIieA== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM5PR1201MB0169.namprd12.prod.outlook.com (2603:10b6:4:55::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Thu, 1 Apr 2021 12:29:54 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.3977.033; Thu, 1 Apr 2021 12:29:54 +0000 From: Tal Shnaiderman To: Nick Connolly , Narcisa Ana Maria Vasile , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "dmitry.kozliuk@gmail.com" , "khot@microsoft.com" , "navasile@microsoft.com" , "dmitrym@microsoft.com" , "roretzla@microsoft.com" , "ocardona@microsoft.com" CC: "bruce.richardson@intel.com" , "david.marchand@redhat.com" , "pallavi.kadam@intel.com" Thread-Topic: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors Thread-Index: AQHXJOyP/NKDexPtBkCzznVMKqdjRqqeG09QgACB+QCAAP4y8A== Date: Thu, 1 Apr 2021 12:29:53 +0000 Message-ID: References: <1616802771-31578-10-git-send-email-navasile@linux.microsoft.com> <1617057640-24301-1-git-send-email-navasile@linux.microsoft.com> <1617057640-24301-4-git-send-email-navasile@linux.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mayadata.io; dkim=none (message not signed) header.d=none;mayadata.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [5.29.59.30] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b90e2187-e104-44a8-0e04-08d8f509da77 x-ms-traffictypediagnostic: DM5PR1201MB0169: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qpbze0Xz0eAa2TbbSEcBHVjXrFO5Ajj/JM+OULNoyWWFakE40DYFPgHo5Pd/vIKkYHdSxBseGwBnZu8PDddxiGmx4sR9mrtuQQNYK7VgCMrR0h4PD4e8JG6LiyvHP4e9QAiFjLwQFxV42/PyXRislHWf7hwASJVOmfuSDckhQjvMCaY18fSGc6FtL3bSRA3vWNenrbm0uDD3+d1vkV3Ez+2mDFTzIvFDNZYVssnlG/R0kNuk4M5pg+moHUJicV3NSmCbtOuSpuuHr+at0885+NBpjWEQrhd43nxc067pMSnVbvS87+dRTCmV4xQIBPGLhMmLSoUEpoODFMiD7++ZszpqNqUpvfJvkeTiTO3alYbM4x7hnDxRreYaxsJE2WxeY7lyp7jyoiX4sV3VjXgWi+Qpn6VgM11fh4H8VTCo0m67ngqaySBezqTvXniHV0tIo+1JVg5fu7NZwtlWRYApZMS6iL/iW+dTjW8DacdwypoqiAfHqiv0TCOW03yj3gy+5KMe/jD2XeYWifXcs9KUDyHcYkpApOF5cnxmsubO/YUjLro/39GGK6qAkZJjeTkH5TKgZJkLAHiNvHAjNrnlHDGH5XgB9rd+nenWioRfZMfaZyNiH+RNV2TFdvMWWhtunIQCZ/zArxGxGiKOHE/MJ4wintoOyc5ikDeipQ3d2KYiKCcD5UwLMAZ/me2I0FbzEvz6OjoqugrCv0FOXkNSEhj04wcTW/5kJWx2OgUIZhPxb1/3INTrHFj+BIl3XTaC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(26005)(478600001)(7696005)(186003)(45080400002)(966005)(55016002)(316002)(52536014)(4326008)(54906003)(2906002)(38100700001)(7416002)(71200400001)(9686003)(6506007)(66946007)(76116006)(66556008)(66476007)(4744005)(33656002)(86362001)(8676002)(5660300002)(64756008)(110136005)(8936002)(921005)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?+YkAbV6SRb/12iTQeznXdghPP5YEcrU49L2ABwI2CgiB101WMW3EH50CoQY4?= =?us-ascii?Q?jPybMTf7JYHTZZnEFkvctUxVYUiPByk8EfxRwIg4+k0vYK7PoCuhpi8j7avw?= =?us-ascii?Q?mWH4QUW5YEIKDB0GPHmO53d8zMwQFPf6EdNlC8+JT3O7YTI5EHHo6TA8yaAB?= =?us-ascii?Q?ptRsatVfWW365MGZRfWkCU0dZ9b4sNuA9hnPyhWqOpLJPQkgdW96Odk6p9ac?= =?us-ascii?Q?9vA3lSkgtABwQg4xN2EOfbglfGvyVyqxqnf1gL9nrG5j407aw4CTKoUiBDAm?= =?us-ascii?Q?WC3Sm/ZAEnK0rgo1JfFE6IblNMRjZfCcywV1Ut5eEvcMSJmvZp6Wr1ZffpGj?= =?us-ascii?Q?L5xeW5SqDjzOjOi21B9NWbYVTo7vgUSQXQQ/Bi51cHv5nxO+G8z6ZOHeSw1U?= =?us-ascii?Q?M8hiawpR8bVn/IDt89ty+48w88Gzse8Zgtr46AMjSrmnS35/x7VB3rZ9IHOz?= =?us-ascii?Q?et9WN8bWnBNKjKuZ6ioAIvqHYoNBQ9GVWg88Ydm5QzGg5dEIf6es0dQRE893?= =?us-ascii?Q?5PfprEaJedUAjqWnSyxdxb5c30YgJgYV7CTuIjo2W4h+p3nzY7HVcyQwIreu?= =?us-ascii?Q?MTP2QjMrYbd0FjYfybtUQqdVDDaYBIDAKBEoXt5Zcf9GTVegsZnII7maWAmH?= =?us-ascii?Q?47sLkpKBVCTwSFTYxHMFP5FW5GFkGJZB2XYy0Jp9xNvjW6HsNrkcuV9Fp3Lk?= =?us-ascii?Q?j0fs5MLk/ONpvCsy1AkUtCN+IGf1+au+6upu3sXlwozR10BUCjsUsziZ9WBA?= =?us-ascii?Q?05MPRfrElB/aHzySG0WWeltsq7b9jW0nWa1OkvswLLxucmXnIB3/wKlAUpjE?= =?us-ascii?Q?aTt74tivjmqItYyUPzY1k5Of5nKBv+2fwFUb6unegmmlaubEhkpY/VpM4fsY?= =?us-ascii?Q?MM5hR0WpiWip8zgiFJ991EyycOnAnxqQ+0BvZAp2YxJWjcSR6J49+IBsID6y?= =?us-ascii?Q?Tp8x2Uzx2Bt7UkcK0TJHWS5Vvm77QwA5zHNnjWPfhfvW/T0C4FiKH7kLv9hY?= =?us-ascii?Q?S11K5RCgC1PhBcN095WhssXIBs2SffV8L43QS77MB57f9bfk9uHf6T4OElit?= =?us-ascii?Q?1Q90PnP6gnKaVKKVENremmkyRTmgZs3ZjwE2eths1nTky1gkLLb7DQCnBTxa?= =?us-ascii?Q?BFe3ANT71xQUUkM/ArFKKx1oO5U8iLLS5V7YMqgLcr14aY8VIGZxY6y/NYfM?= =?us-ascii?Q?7TcUYTM6qvjneKW0hsERnXIXbQaM963F9uvJqGFfKxIm7ohviBj6SjZ6oBWu?= =?us-ascii?Q?r4ARTS1gMaVWsQoBttOy+2P3i5WzePIRJPOmP1kAqQg5l/JfcccQ8cO+WwQH?= =?us-ascii?Q?eNA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b90e2187-e104-44a8-0e04-08d8f509da77 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 12:29:54.0302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rkXC3GROxPBJgtVSSN6G4o4b7ke4iSzwb5b6GgZGLFl4pDEeaywjd+/17MObHoDNs7o9+y0IZ3l+KLkoV0KnmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0169 Subject: Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows > errors to errno-style errors >=20 > External email: Use caution opening links or attachments >=20 >=20 > > Also, I don't think this is a thread specific function, other implement= ations > can use it in the future, maybe move it to rte_windows.h? >=20 > I'd suggest that it's probably better suited to a .c file rather than a h= eader. As > an example of what it might end up like see > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Fwpdk%2Fwpdk%2Fblob%2Fmaster%2Fsrc%2Ferror.c&data=3D > 04%7C01%7Ctalshn%40nvidia.com%7C4ab2e17b824842b9f83208d8f48ab4ec > %7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637528223860057761 > %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DAnBHMtSobODNzb > Uhun3GVnsTiePl%2BQzfPSASlur81Ks%3D&reserved=3D0 >=20 > Regards, > Nick >=20 Agreed, thanks Nick.