From: Tal Shnaiderman <talshn@nvidia.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
"dmitrym@microsoft.com" <dmitrym@microsoft.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v4] eal: add generic thread-local-storage functions
Date: Wed, 23 Dec 2020 11:44:31 +0000 [thread overview]
Message-ID: <DM6PR12MB3945ECF08431F60301FE36C6A4DE0@DM6PR12MB3945.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201223041801.5ea13a37@sovereign>
> Subject: Re: [PATCH v4] eal: add generic thread-local-storage functions
>
> External email: Use caution opening links or attachments
>
>
> > [...]
> > +int
> > +rte_thread_tls_set_value(rte_tls_key key, const void *value) {
> > + int err;
> > +
> > + if (!key) {
> > + RTE_LOG(DEBUG, EAL, "invalid tls key passed to function.\n");
> > + return -1;
> > + }
> > + err = pthread_setspecific(key->thread_index, value);
> > + if (err) {
> > + RTE_LOG(DEBUG, EAL, "pthread_setspecific failed: %s\n",
> > + strerror(err));
> > + free(key);
>
> Why free(key) here? Probably a typo.
>
> > [...]
> > +__rte_experimental
> > +int
> > +rte_thread_tls_create_key(rte_tls_key *key, void (*destructor)(void
> > +*));
> > +
> > +/**
> > + * Function to delete a TLS data key visible to all threads in the
> > +process
> > + * rte_tls_key is the opaque pointer allocated by
> rte_thread_tls_create_key.
> > + *
> > + * @param key
> > + * The rte_tls_key will cantain the allocated key
>
> cantain -> contain
>
>
> > diff --git a/lib/librte_eal/windows/meson.build
> > b/lib/librte_eal/windows/meson.build
> > index 3b2faf29eb..1f1398dfe9 100644
> > --- a/lib/librte_eal/windows/meson.build
> > +++ b/lib/librte_eal/windows/meson.build
> > @@ -21,4 +21,10 @@ sources += files(
> > 'getopt.c',
> > )
> >
> > +if (dpdk_conf.has('use_external_pthread'))
>
> Please describe the new option in meson_options.txt.
> Maybe drop "external" from the name, what do you think?
How about use_windows_pthread to be clear that it's unrelated to UNIX pthreads?
next prev parent reply other threads:[~2020-12-23 11:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 20:24 [dpdk-dev] [PATCH v2] eal/windows: add pthread TLS function support Tal Shnaiderman
2020-12-15 22:36 ` Dmitry Kozlyuk
2020-12-17 17:49 ` [dpdk-dev] [PATCH v3] eal: add generic thread-local-storage functions Tal Shnaiderman
2020-12-17 20:56 ` Dmitry Kozlyuk
2020-12-18 19:37 ` Tal Shnaiderman
2020-12-22 7:30 ` [dpdk-dev] [PATCH v4] " Tal Shnaiderman
2020-12-23 1:18 ` Dmitry Kozlyuk
2020-12-23 11:44 ` Tal Shnaiderman [this message]
2020-12-23 11:58 ` Dmitry Kozlyuk
2020-12-23 18:16 ` [dpdk-dev] [EXTERNAL] " Dmitry Malloy (MESHCHANINOV)
2020-12-26 16:08 ` [dpdk-dev] [PATCH v5] " Tal Shnaiderman
2020-12-29 23:13 ` Dmitry Kozlyuk
2020-12-30 10:04 ` Tal Shnaiderman
2020-12-30 11:12 ` [dpdk-dev] [PATCH v6] " Tal Shnaiderman
2021-01-01 22:16 ` Dmitry Kozlyuk
2021-01-05 11:53 ` Thomas Monjalon
2021-01-05 17:06 ` [dpdk-dev] [PATCH v7 0/2] support generic threading functions Tal Shnaiderman
2021-01-05 17:06 ` [dpdk-dev] [PATCH v7 1/2] eal: move thread affinity functions to new file Tal Shnaiderman
2021-01-06 14:40 ` Dmitry Kozlyuk
2021-01-06 19:45 ` [dpdk-dev] [PATCH v8 0/2] support generic threading functions Tal Shnaiderman
2021-01-06 19:45 ` [dpdk-dev] [PATCH v8 1/2] eal: move thread affinity functions to new file Tal Shnaiderman
2021-01-06 19:45 ` [dpdk-dev] [PATCH v8 2/2] eal: add generic thread-local-storage functions Tal Shnaiderman
2021-01-06 20:10 ` Dmitry Kozlyuk
2021-01-06 20:33 ` Tal Shnaiderman
2021-01-06 20:35 ` [dpdk-dev] [PATCH v9 0/2] support generic threading functions Tal Shnaiderman
2021-01-06 20:35 ` [dpdk-dev] [PATCH v9 1/2] eal: move thread affinity functions to new file Tal Shnaiderman
2021-01-06 20:35 ` [dpdk-dev] [PATCH v9 2/2] eal: add generic thread-local-storage functions Tal Shnaiderman
2021-01-07 14:46 ` Dmitry Kozlyuk
2021-02-10 13:33 ` Burakov, Anatoly
2021-02-10 14:26 ` Medvedkin, Vladimir
2021-02-11 7:34 ` Tal Shnaiderman
2021-02-11 7:26 ` Tal Shnaiderman
2021-01-11 22:33 ` [dpdk-dev] [PATCH v9 0/2] support generic threading functions Thomas Monjalon
2021-01-05 17:06 ` [dpdk-dev] [PATCH v7 2/2] eal: add generic thread-local-storage functions Tal Shnaiderman
2021-01-06 15:05 ` Dmitry Kozlyuk
2021-01-06 16:04 ` Tal Shnaiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3945ECF08431F60301FE36C6A4DE0@DM6PR12MB3945.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).