From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9164A0547; Mon, 19 Apr 2021 08:57:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89B4540683; Mon, 19 Apr 2021 08:57:22 +0200 (CEST) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690083.outbound.protection.outlook.com [40.107.69.83]) by mails.dpdk.org (Postfix) with ESMTP id 2303240040 for ; Mon, 19 Apr 2021 08:57:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkV41T5za4FPQmdnYL4c82b165MBEcOSH9yonHwLKnRoRDat7FPNsK2+XrYRYsvzKXTYWvQvbWl5EOZ0FFiQvMYoDS4hqsQOKlpVJw0Q08nlbXNEF0LD4pgKuNljLQxeHxP5JXcqpgoO3UT6zR3bFHEcPIDj2qsDlpV458yI8nk+VQXypjgGzr2zIskAWKm2+CFmPiv+k2RU5fiOw4MH9SD0I1U80enDl9T3sR3lHj0RYmlkDCZrOxYpt1NRSRkvPAjiUYF67+NL75folSwGcZcbwA0nejPufqlxdlHSPrSdozsOgNAirD9x2pJWsE+ma4h/FCC2yGpSmm5Y/jYHjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RgF71fjY+pL+2Ijy6ykrMMHC0BTzxbJgU2N11241oUY=; b=Fa5hog/kF1tARJ+9n7E0T2kXIceCad6X32RwaYNIQdcr9DGX3CpN9T9Uc7U8uIOzn4AOU3MQtSwVef0L+NYjjUsT7nVOswPXXWG8mQSGeokGpZkm0zDpAhxap1TQnUcMALGRyUQdysgi3cHdIhYEkhh3WBf1FkjARyJpOncQCoNRm8bpm5Z4jB6D85vLOCZk0VgkFQThREPomgMvqe5FRthqhpj6P3n+1zHOfQCedXLuYpaH3OYmaRXtwT060FoAynD7DP51PkPCK77G/NdmXhc3i2kqtXfQH6Ai5TcET4hsKrajjPLF/cC7biJc/gxpg5aBMF5TxMqK+soQudYJJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RgF71fjY+pL+2Ijy6ykrMMHC0BTzxbJgU2N11241oUY=; b=HAUiTgxNeP2s9DIEzxrW9ZrxlpYQVOqWQpYzmjFS2Wpq2czD1CeUI8KiRg4oGbCWmmqwAoxVKmJbURJsl5CG/J1rT1QpqpGig1sf9faeFd5k+wTgSl2b3Jryg4RYvHw2pJp83+vXzTYnRpavvK0OA9nwkGRL+T1H6gmX10qnhYB783SPqy2Fx7BvaGoLcjIMHwL7xYYi0x7yRgPklYtCQvSr8aug/dpeoHSYhZG4Tbff2pBY34CNS0396i+CmOBVAfxffaKrs0HAuiGKwKezXGPhGN+79TVN57bDhIJpNBcr+Qk0BVar6BJ8hgM6VU35ZhZpgwPSlnVc1kGZ1JlHdw== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB4171.namprd12.prod.outlook.com (2603:10b6:5:21f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Mon, 19 Apr 2021 06:57:19 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 06:57:19 +0000 From: Tal Shnaiderman To: Dmitry Kozlyuk CC: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" Thread-Topic: [PATCH] eal/windows: fix build warnings in MinGW Thread-Index: AQHXNH6ZwWznH+guDkSl6v4FBquUUaq6mXjggAAe7wCAAKyvEA== Date: Mon, 19 Apr 2021 06:57:19 +0000 Message-ID: References: <20210418170803.15684-1-talshn@nvidia.com> <2018619.JnGxiWPmQR@thomas> <20210418232330.2471f913@sovereign> In-Reply-To: <20210418232330.2471f913@sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [5.29.61.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dbe9864a-c5f8-46e3-9f8d-08d903005fca x-ms-traffictypediagnostic: DM6PR12MB4171: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tK4g2PiLpMjbF9MFPAqYmd8w0wsg3v0yuH74PNx3PhH68GcKyp5zMXvRut1khjW+SBzXhiiYWJ/LcRUek6FR5mWgX/vPzs8QVOG4UrDjjE8dmI5WMTET1BINDGuB2V+BK8T0gLW2uMx/RV479rMhXhxrbklzZDETVg97CBPiTWaC/p8IlDVQ3BL2yqLOa1IJhPhJ5yYzpzFa+I9mO2vtcS6tIVgXbW/PlCiX0Wj0vak5cNJrWt4nThulcOqNamIwLgw+iYfjDlamgy3o30W37VGFh6q+Z3XTnzdYFxinoSt60Lsc9iUoGHKo0lRusCxIy8vHtffJ/fTc6ExDfLddckqGfohNhWYSjhNOpDvaW6flrIUtrW2W2z2jq36kdgOC2aiVFrNw+omYRThj/RzJPWpTU37eLQy1RSQfOnfTcUhBMhPejLGZrVBpIFK+/sw4BTMUJ1ayQAn2fcDiRleAwq+IMUCMjlmapyKldJtizfcoW3LItinz3qS7Al6F0yGwY2FTokykC+dC5IkIU75xRxTKAXC2nX+iX/2GHQ815LRdBhLk5FFYKBmaFcAEEhFnRIh09QU7JS4J5DLJetPdu/OWIpHvxHNGiMm3ZAxQ6YE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(366004)(376002)(396003)(39860400002)(86362001)(8936002)(8676002)(9686003)(71200400001)(66556008)(66446008)(66946007)(76116006)(66476007)(316002)(64756008)(38100700002)(4326008)(54906003)(26005)(55016002)(122000001)(6916009)(7696005)(2906002)(6506007)(83380400001)(33656002)(52536014)(478600001)(5660300002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?fnpaINzxMEQFcrvkFe8FxUuBUTnridU7Pnu3EgBF6IIbkgXQqiJlGwFbYLgY?= =?us-ascii?Q?47C4pte2PvsmL0qFRpgEtG+wrPhubxuiBqe2H3uNl5IcXS35MfxvnHCljPqV?= =?us-ascii?Q?TKNI94Y6tHjxDMOtadncRNCusrQer9wATJp3eMLNYfgq8c/A1emtSLUYtbk3?= =?us-ascii?Q?0OE+iR8ye8GF56hEyVYyKzGmX0hX4dUcZlqEaEU9V0j9XULs3LHvzx2VMOQa?= =?us-ascii?Q?L+dz59sHeIypghxRavMMKOunG8isLNCklSrJ5F9WU5XgYGAgLHrfJYZXTxBr?= =?us-ascii?Q?zHm78QDWIx+HzBcBCtDOd4sKUk3U/okIiJhnEH9hREZUs03PTiV4eHORYctn?= =?us-ascii?Q?6wib6T1AY5S1RsKaE03cnMUJR2wcmchhozqeY3nZvTod6CDj3qhibxqe3UVF?= =?us-ascii?Q?4QgLH3NCPc4G5LcIn6jHPNP7/dcdQP/78y+QE2y4kYxHe86pjhUvo1ALzqar?= =?us-ascii?Q?uTitRVa6CeXaApFyWD1DdJH8b9GIRSRH94WUeROPTWDhcEzdoVcG83UTBP2Z?= =?us-ascii?Q?giWltIyqxpUUSKmu+AlhLNAsiSOSHCiCRxoPD7Y5Bp5Atlhi2bj9+w/S4tc/?= =?us-ascii?Q?mvayiAxQwYI0lrAmNs5fTQ3WvVwL/ZdAcBihmtm4OuLxsP4fajWaCxRTeZeX?= =?us-ascii?Q?BFAtLLQ6alAwW6thmbCi42gTt61xoNK6odTSTqPQXNhl9sb/UlQPkH1LAMEi?= =?us-ascii?Q?oe+I4hksj+fiy2kfHW8x5lxdIqsN0BTRNpa9bsqtKx07Dd6Ffan6Y9+4Esnz?= =?us-ascii?Q?q/tNWcRM2H4V7WplTolsjufitcDFnFVjwKW327U8TjVNDo/sjJzMa6mRx+Ib?= =?us-ascii?Q?ugW6ddXhycWcJPlowRuc04raZDWzTstrtsPAh0roBKR0i90kXu5uxo4pwC8M?= =?us-ascii?Q?eFtFAgLbK8daGtZ2eeO2bLFsMpgz5yVro53C/7je+kR6jBFcj0ifXfGxNvHF?= =?us-ascii?Q?QZUsikImYspAzCGwXexThRH9v4lAAI/1aEw7a87cTQqad4Q3b29XgCFc98gr?= =?us-ascii?Q?PEc62lm/PTJc1JI4IJMYBRsYSdOHgYmnuFx9F5UV5FrUl8ErymqOtjcX89tm?= =?us-ascii?Q?oI+L/9hBNpsvHwkjnDsbSQYEL+QtPPy4qkJeOH71hlYpdoSkwYo5rZEh8bF4?= =?us-ascii?Q?LIG1kwYyCheziALdXTHv+yoW0+RDS83TJWe9C+ycOjedxyCIF9DthIIzuOGi?= =?us-ascii?Q?7f9SmMMflUikVJqyp7DTdfwBV53G4wXsymmu+s6bcjiyhZkSTMVHpGjTbNR/?= =?us-ascii?Q?qwilYHSqoA3oztvpIUFVQ9pHpFLZt8KU/LTr+omqedrSfiCgVmtA3GH017jR?= =?us-ascii?Q?Z/o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbe9864a-c5f8-46e3-9f8d-08d903005fca X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 06:57:19.0384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g0GOYOBGMZCxv8PWjrTqIpCOh416OpjANdyaqo1ggkS1WuWOHZOh3HJTnipp/pQwhaAJLNrbiopBz1z2h8xRUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4171 Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW >=20 > External email: Use caution opening links or attachments >=20 >=20 > Hi Tal, >=20 > 2021-04-18 19:04 (UTC+0000), Tal Shnaiderman: > > > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > > > > > External email: Use caution opening links or attachments > > > > > > > > > 18/04/2021 19:08, Tal Shnaiderman: > > > > the strncasecmp marco defined in rte_os_shim.h is already defined > > > > in MinGW-w64, as a result the compiler prints out the warning > > > > below on function redefinition whenever compiling a file including = the > header. > > > > > > > > ..\lib/librte_eal/windows/include/rte_os_shim.h:21: > > > > warning: "strncasecmp" redefined > > > > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) > > > > > > Why the tests are passing? Are we allowing warnings in build test? > > > > It's a good question, I see CI is passing without warnings, Dmitry can = you > reproduce it? > > > > On my side the collision is with the following file: > > > > C:/mingw-w64/x86_64/mingw64/x86_64-w64- > mingw32/include/string.h:119: > > note: this is the location of the previous definition #define > > strncasecmp _strnicmp > > > > I'm using: > > -gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0 -meson > > 0.53.2 >=20 > I can't reproduce it using the same versions. > Do you invoke meson with other options than "-Dexamples=3D..."? This is the meson line I'm using: meson "-Dexamples=3Dhelloworld" build --wipe --default-library=3Dstatic --b= uildtype debug The problem however is that MinGW's string.h defines the macro in line 119,= for some reason my build includes it and the rest doesn't.