From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75D82A0A02; Tue, 6 Apr 2021 09:02:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0562D140F24; Tue, 6 Apr 2021 09:02:33 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2075.outbound.protection.outlook.com [40.107.223.75]) by mails.dpdk.org (Postfix) with ESMTP id 34E6E406A2; Tue, 6 Apr 2021 09:02:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIvMRhIZ1bMcGft2EwDNi7shIkuqWOWYgosoet0yRncHj1Bu+bUWhceihfQDdbNujGB4IR2mSUIc0cU5LH1pjoW7L36z4n/+HokDDITX8ucNV+8SxmWUyJZBDbuW8MGCrE2BtwzjkGHZoAAhwYh2LonpOeEZjoasu5K5qi5X2fRmtBu4Vk68wm/7FoXV2uTFx1hN+4lh4zdafvDVv3mcf9KD2q4HKS366qc/GzOWjWpH0GQt1hqlW5KxPvytrDg/v0qdDQyloVhqre7zcDTc5o/mUKNDjuT1uheP12o3+IX1JC80bcOVDlmrcCMk565hJszXbSFGgD4bYW8A5kI/2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6+Yt1OYgufWyrS6mfmN6hJyjO8XgCW6iR8xgg/CC+w=; b=I3vRenzdcX7jlaOCLgdmiZ8NHYYSR7hoJ9xM+FSPAXAo/wiveYRe9Zo1QwaVffUEsoYAL9uYZXZQaU8KbC7bcq4h/o+uo3L7ZTBQfI/5ZNYrgJj5MNifcR07aaZOpsz74Kepj6kMe7zpI9OKiiP0b81AZTOxs8e2McwFHxlQNpdd+YmViP2muCtxt5qIFSLJtXbp8vNLv86QiFNL3mAA80HFLtlRzuYf4C6ThxN7I347P1iqrD1+h6aWoJisp9tQwJ0/tTKdDfx1625iPlKgSAXAe7Y5mtqcM3ZX0ULZJV20DLUKzuUT4ibrGeCGidgNtyrtVrySs/Uf+H5B7MIwkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6+Yt1OYgufWyrS6mfmN6hJyjO8XgCW6iR8xgg/CC+w=; b=WbDtxOMHId8506xvzPr/OFGqytOrX0fXwnDL9+8ubCLUGbg9mo6NzRb8FFFecTsy2qXN6BGeR/ypHYIw2o0+Q+3GLrYGQLOLCbB/Q6tdMaqEv7BjLIwgoP/5qpjrWNwBrctnHUr5Q31ZiUot0Zf8eHUGUs1u384gaaHt83Hz9Cgvk4xOJ7AJKILOAnzY3hr3MIlZHXctYky6NDUI0USdZ451Cm7p3fOb6WbfX2SvAIFuGDqoGh0GYzbxa5zUn7Fk6ru3Qutx8eDAkWv/bHDZiFdFxrV4pPrkhbfNlgTyWNkxwvThGDNo5dCC1iDGKwnYMxoLpxseJKhnblf5r44Aig== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB4762.namprd12.prod.outlook.com (2603:10b6:5:7b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 6 Apr 2021 07:02:29 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 07:02:29 +0000 From: Tal Shnaiderman <talshn@nvidia.com> To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Ophir Munk <ophirmu@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH] net/mlx5/windows: fix link speed calculation Thread-Index: AQHXKk4RFPxq2rLl50KFvr2jk+d1bKqnD96Q Date: Tue, 6 Apr 2021 07:02:29 +0000 Message-ID: <DM6PR12MB3945FB4A9B269633AB25E1C9A4769@DM6PR12MB3945.namprd12.prod.outlook.com> References: <20210405161844.9560-1-talshn@nvidia.com> <1920198.nUkcdjmOzk@thomas> In-Reply-To: <1920198.nUkcdjmOzk@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 272e52a5-af83-4799-3c43-08d8f8c9f18b x-ms-traffictypediagnostic: DM6PR12MB4762: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <DM6PR12MB4762E5E997039C6FA5BE3BFFA4769@DM6PR12MB4762.namprd12.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:269; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lk8vawGFKonLtJIYUkzEUuCrFfEaHbD9gK1sQIH6EH4WDUFn7qLabKHAxwaNYFm7QUEBP0nfHdyfGtNXV380gIpaAclxF6iQsdM9y9MRkVdK6JsknU6lJovyC28lt9nVFd+V5/PsvkqqD8GKwLoMnBUzL7LSO6BS7rmbRoqO2+xLT1Do0BmfKBZ9QVxqw/nWbIqHkhXaMOV3b4WLY2DDKd8lbrifm01jjXxT8YlMtqplaT3nLceqK5OS1bN6HoXWxDDSjgXFJdSrbRVDOosXYr4j+T2CAT4DZYcoXYH7FAGH8gy8d8NDAJe//kFUSlN7frDpfR7isRDJZRRMwPh8N/IFMX5E53HHsJnFPLE+tR0BzYJf4rwbB0W5qlLtQsEtf+HfeAfat3mK5VV1K5GWct3P9IBR+KcEQUAtqMYBRpwjkPk2XQifbu+AhWnvFYjFLT8TdNaTgIKI9htiDQpN15Zw7wx30jlBtULSevEKZCZRUwzpSQgRBWuitqN7QgkO7kL5kzmfz0k7ttfL+VVoK+g1PMFX+qBp3q9NN2QOI2k8KNa9WDysn6iGK/ib36QFZ0QSPECQ9fky5tHhWGYAhsKh0EmtV9tsrjFj+Ef6EDU3Ws/p6/FlK86LKjFymhNXMmZa8WPbC0r7EcKb+Cb1XA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(2906002)(66446008)(478600001)(8936002)(316002)(7696005)(4326008)(4744005)(64756008)(86362001)(33656002)(6916009)(66476007)(71200400001)(26005)(6506007)(54906003)(76116006)(66946007)(38100700001)(186003)(9686003)(52536014)(5660300002)(8676002)(66556008)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1gU1dSMGkbJ7yujRW2Nv7Aw6rUqczNomQl0OMWogmbl34cnkgOyEyt0drDUF?= =?us-ascii?Q?FMM/ivZ3hAuRbzu4R+HK8vJMhTzAcGDoKmpoG32hlzLWuGuA/2Dp98iEyhEw?= =?us-ascii?Q?OOfV4JxmUBcNOx6qobNJoto/wQ8EDrOA0J8blmnCoRbLEzob3el1gY0mEaf1?= =?us-ascii?Q?fhSt3iqDxbDRrSyliKViTlZ7+CkC6SwyOHyCR+NEKfgd8qaSbB8I9KlP0VQI?= =?us-ascii?Q?QcY2uK6InAZge0nGmf/Z2WBQ1HrlIgHJ/bR7Bt2NHCJhIbuY2EF+8E3Pbiw6?= =?us-ascii?Q?XTzK6Rk9Mg+k2UIeU/QNUFnWy+Kjj2zLU4lEkmbcyX6FeQyPWH7jf5UvkcwK?= =?us-ascii?Q?1u9LTLSY4kccQGbaAMBipkXXjyL+PAPnlKa28BcpVdNlnxZ2mQAZR48JmUmf?= =?us-ascii?Q?Jv1nHYfPuMhf6OGoY5zWt8qDanf+UkbtcnHCULCwyOwpWzu3f/K1ZXST+nnU?= =?us-ascii?Q?csFz6XcMysxIZf8+lqGD3yFg8OaSJ8+FPyUwzdpKk4ws97nL6yv1ILNz7gFI?= =?us-ascii?Q?5zmn2HTqyUXY3FeG4/NyrB56RWGf2Iq2WmXNUAPzEuCLpRcXFqXF7KPGoO9Z?= =?us-ascii?Q?6tegC1LmwQoR1rmZofrdpBJ3PSPJPFtfqTWHqZfvyVYandxCp7TcO/yJ/ha2?= =?us-ascii?Q?ei3T2rJch3/JAGHictDSOpTjyqnlUF3RfXmIz4bxAsfabIx/NNWSCDDuztvU?= =?us-ascii?Q?zbgvln3oa8arTXRAkL7IoBSs1rQM8oEpWRI9eEmW/7YvYmUEkUzB++mw00OS?= =?us-ascii?Q?5yv70QLcC6V9ANS9f2ztBMUUHJTvloreBypZX0qAX4u+i+WcJKVjQr6yuO7v?= =?us-ascii?Q?XWmKrwEbfIgt3ZnhtnadEOeCC6+EtZZfAL+upijWVnQdjsP1o6wxrTAFomJf?= =?us-ascii?Q?QzpYZHM2plDwEnGJSeMpiOnZ61Xk3b9LLfuQFgFdcCl/qWr8jOGbK+oOAjpu?= =?us-ascii?Q?luzj1F5qP3Tb75/lXBJH2aLxXCt15AyR2fnyu/wZGTKaPLYsINgI61hHqkEc?= =?us-ascii?Q?yAomhCdPTmKhhlaMNFgWoK1IkEF0nXhWNPtJ1hbk7et7BEcMVqkECPQWaUTB?= =?us-ascii?Q?6dHrLc1AVUYsWr4nszZmcsy6drf5TuYFle9cV3gYW/GSBvWHZzTkM9qFz8vz?= =?us-ascii?Q?N01phhKnx/nKDFEXcjyE8Vd/UjAgu4/BE3j17XmqGA3ux2gr5feNcMyesIVP?= =?us-ascii?Q?jCmJrsVGrsQAMZKvo/Dnxlp1yuqcZ9MbkOw5l0gA2Jz9mhoppW2xVLFg5YxT?= =?us-ascii?Q?iWjzgLebFOdheG7040NYot8Ev3MbLRKcTscp0oToqCVQ7O/gTpKpAUBH20WV?= =?us-ascii?Q?mcAoI7eExWPgGVjAXBdgUUdS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 272e52a5-af83-4799-3c43-08d8f8c9f18b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 07:02:29.6234 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4WaRjasZFSP8UcFGaAtHS7oTAtWaFMSnJiix1WjTbwVNw48uyN1Z3EfXTtQlOpP2eDnJoPgYJmSQEGoA44Po+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4762 Subject: Re: [dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > Subject: Re: [PATCH] net/mlx5/windows: fix link speed calculation >=20 > External email: Use caution opening links or attachments >=20 >=20 > There is no previous commit with net/mlx5/windows as title prefix. > In general, there is "on Windows" at the end of the title. > This way we can have the same formatting when fixing the common code for = a > Windows case. >=20 > 05/04/2021 18:18, Tal Shnaiderman: > > In Windows DevX returns the value of the current link speed in bps > > rate, the conversion to the Mbps rate expected by DPDK is incorrect > > and fixed. >=20 > "was" incorrect. >=20 > I think you should explain the confusion between Mbit/s and Mibit/s. >=20 > > - dev_link.link_speed =3D context_obj->mlx5_dev.link_speed / (1024 = * 1024); > > + dev_link.link_speed =3D context_obj->mlx5_dev.link_speed / (1000 = * > > + 1000); >=20 >=20 Thanks Thomas for the review, will address the comments in v2.