From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B503FA04B5; Wed, 30 Sep 2020 17:20:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E24D51DB49; Wed, 30 Sep 2020 17:20:24 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 9E6F31DAEE for ; Wed, 30 Sep 2020 17:20:21 +0200 (CEST) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 30 Sep 2020 23:20:19 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 30 Sep 2020 15:20:19 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 30 Sep 2020 15:20:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dQulp+ZUXkYZG0ALUQyX7N+hJ9V6UCRScz8Hooi3coSyhAT/R8G7P4pNXrOnyL4U0uclKQy+zxnfBtGVP/wfPssfOW5CyZYGuagU/vG1rPO1v5GklfgjoGx1wzh2/g5f+SBVXO9QU7jIQqr+4ez4oprrbjHHvAA5FtFddFX/v0/EUJ7/MowQmvMQdfWuKfC+TiBz+1k7IpHYthbsQ9VmS56maNGGztqFgdzJeVYBTGXBrup0VkgkVw1uan38X72pWwB8TQbRL6GgybpwLJZMTzm7rGTu3n2b7xrEMfkuq9Vwxd31h7uXVt11GrX57CpGi0q7gEss0Eq4AFEK+Nu5WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RPTY+nb4xRIafxyvn7G5ue7NywCBXxIGHah605kSmbQ=; b=Ms8fijWrLYe4JBo7yGZ5oQn6/PpDaREpxlANfjqeVmW3JiHrXY0aNhlXOXhZ+CtIY6Qq66+QEZJnt3XItkbjlUYhtzQdVkkWWUKx6yT6BROdxLs3AXy/7CXmYQgD5p4iczwwVACxl7KGOd0etlvkyjeRBHGJDIdpZCEGc0P48/gJir3pu4DqdVJaA3Hd5SXjcO9VMxNuQLm2/1gbCIbeTCYP+LC+aLZq2KY7xeZWw5OIxm4EVmzRr6UyEoyGauMu0FAt3/bELzZSFoCpIyJUdqtzXoiYiGpieKSYK21Q8ZmgQvOiXNP/wOxbIfEbzplTCpKm7232ySst4TCvNzjYFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) by DM6PR12MB2906.namprd12.prod.outlook.com (2603:10b6:5:15f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Wed, 30 Sep 2020 15:20:16 +0000 Received: from DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::8c42:6852:1b18:13ad]) by DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::8c42:6852:1b18:13ad%7]) with mapi id 15.20.3433.036; Wed, 30 Sep 2020 15:20:16 +0000 From: Li Zhang To: Ori Kam , Dekel Peled , "Slava Ovsiienko" , Matan Azrad CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Raslan Darawsheh Thread-Topic: [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields Thread-Index: AQHWlzh7GtHpklUaTUGQkoWf+GmEbKmBSUMA Date: Wed, 30 Sep 2020 15:20:16 +0000 Message-ID: References: <20200923023522.21135-1-lizh@nvidia.com> <20200928033813.22112-1-lizh@nvidia.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [223.166.13.30] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0326f57d-dc58-46d3-7423-08d86554560f x-ms-traffictypediagnostic: DM6PR12MB2906: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cphXLTuJYxgElWgZthfqYkOh33PJOHUJc8zIjNq1QDuLKeFlK0mna/wWRzFboofd73LEB+2RPKK/I4XBIZ7uzXQTTQWYsRIWeIGvw6tc+ouVJylP7oXRPYGrjwyDhWsUp1zIj2wdPcu4jXQm94zCsHio8+nNEVXXq0dznoijyiLeMDRsqrzydTeknUuOJaq78UJlk6JZ/549UOxUUDgFywcuQTtQsCO0+yJjN2uVccNwe8gk1S4FyTeVuwJndKuOgC2aAeMThQtKK1emFMZFFzJECbV9JQtW8L+E+m50YVdV4pviA6B2uUf97OSLAK80NpX2c4+lrz1QVEV/6ivyqaifXrVHykSsZnLDlldOr7GM1+T/Cyif7FKMXIr9PTOa x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(39860400002)(376002)(366004)(71200400001)(8676002)(478600001)(8936002)(66476007)(5660300002)(4326008)(76116006)(107886003)(66446008)(9686003)(64756008)(66556008)(6636002)(55016002)(66946007)(2906002)(52536014)(33656002)(26005)(186003)(54906003)(6506007)(110136005)(7696005)(86362001)(53546011)(316002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: EVOed+K1czZrmLUN2iONcwRrfIQuWV7ofV6WEoI8cbp3haSpRaTxg6bK7Qgcg9S/OVE7BzOqn5R7CLP4T38/XvBZZ5LoDlDvDlg1rdZFU5dyyVII81r0sPsoz31gYGE+S4VrqAt31H6iuifGXcNQIlsRpM9k1ELkgqIbRG5erWnslL0R9Wqq1/b4XgSHhn74EVyvQOnbZi2XJy0AeKgjL9Lp44o8QtEAs1NyjMp9dubOgUAoRmbZ/Xf2x1Ivvkcp7jl5S4YpdTbGuUX9/NZBVPf6V80CuM6S87vq/8Z4WRb2KITlStiu7PiarFepTENmnvgAAJNYApSRQSWIDw9FdZljD2mhO40IXTE4s3awk/6UoFnteKVP3G/LeFT7zIZ4PSgZkC0soyPPFwxP481PKGG/IuQp9RI8Z9GOyCt05m3GKh99YR/kdOXgYhrM9Dh/YEcm1OZB8D2Z3XYm5TPfkYoPHlr2cdeo1MPE10/K5R5cvSTRKD5DWfx11Tbc4c9Q0hFo0ndLVJSqJHSej/47R4dRUBNI2rAQHRlRlWzmKnRKt30TTaE2YDJigBb105+z7CFwNJ3z9V94heUygaRWMnWkzcQDT70B7o9lfXl63mpaZH46EOWuA8R9aXLYjgXj5EQvUrs2669Y3BynAbZF3g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0326f57d-dc58-46d3-7423-08d86554560f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2020 15:20:16.6385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cjvOhOD8rg2H0v5NceINzBh9A5g6epK1zuUL4zGknj+opybt0998HkX0nQPa3max X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2906 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601479219; bh=RPTY+nb4xRIafxyvn7G5ue7NywCBXxIGHah605kSmbQ=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=ZtnzgOlUb0vUX9FRp0HcPxMljvhkLdyE0idFbvfkKc3HpqsSmrwdui2HdjD9ugrq6 hfDRVeNoZ4DtD6BnTR6MtqfY8mrCD0UfQTkp1HbG9GWgSpEA0iwypLeJhnILKsR0O9 JzP7e6P5SZdZJUm/McEUz7muwVnsSvZF5SxDtSy9cshUdsiQjQtSSQw46VS6WS7PIO I2W1KjCROe+gdSqNyR5WNuXueCYjq4JEZBsqVWGgrpVQPhTwNPklFybUWD4gBDfuAJ jg5hxMNVzyhVk/Art0BInHOKpZTcLmW9pNDXpZDBiF7J+YEsSGEbbRYC7Lv/fTGIbU dLPXt7FyGXVBQ== Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, Thanks for your comments, please take a look my reply inline. Regards, Li Zhang > -----Original Message----- > From: Ori Kam > Sent: Wednesday, September 30, 2020 10:46 PM > To: Li Zhang ; Dekel Peled ; Slava > Ovsiienko ; Matan Azrad > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh > Subject: RE: [PATCH v2 1/1] net/mlx5: support match ICMP identifier field= s >=20 > Hi Li, >=20 > PSB, >=20 > Thanks, > Ori >=20 > > -----Original Message----- > > From: Li Zhang > > Sent: Monday, September 28, 2020 6:38 AM > > Subject: [PATCH v2 1/1] net/mlx5: support match ICMP identifier fields > > > > PRM expose fields "Icmp_header_data" in ICMP. > > Update ICMP mask parameter with ICMP identifier and sequence number > > fields. > > ICMP sequence number spec with mask, Icmp_header_data low 16 bits are > set. > > ICMP identifier spec with mask, Icmp_header_data high 16 bits are set. > > > Is it relevant only for ipv4 ICMP? Yes it is only for ipv4 ICMP. For Ipv6 ICMP, it is icmpv6_header_data. >=20 > > Signed-off-by: Li Zhang > > --- > > doc/guides/nics/mlx5.rst | 4 ++-- > > doc/guides/rel_notes/release_20_11.rst | 2 +- > > drivers/net/mlx5/mlx5_flow.c | 9 +++++++-- > > drivers/net/mlx5/mlx5_flow_dv.c | 16 +++++++++++++++- > > 4 files changed, 25 insertions(+), 6 deletions(-) > > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index > > 211c0c5a6c..576dbe5efd 100644 > > --- a/doc/guides/nics/mlx5.rst > > +++ b/doc/guides/nics/mlx5.rst > > @@ -288,7 +288,7 @@ Limitations > > - The input buffer, providing the removal size, is not validated. > > - The buffer size must match the length of the headers to be removed= . > > > > -- ICMP/ICMP6 code/type matching, IP-in-IP and MPLS flow matching are > > all > > +- ICMP(code/type/identifier/sequence number) / ICMP6(code/type) > > +matching, > > IP-in-IP and MPLS flow matching are all > > mutually exclusive features which cannot be supported together > > (see :ref:`mlx5_firmware_config`). > > > > @@ -1009,7 +1009,7 @@ Below are some firmware configurations listed. > > > > FLEX_PARSER_PROFILE_ENABLE=3D1 > > > > -- enable ICMP/ICMP6 code/type fields matching:: > > +- enable ICMP(code/type/identifier/sequence number) / > > +ICMP6(code/type) > > fields matching:: > > > > FLEX_PARSER_PROFILE_ENABLE=3D2 > > > > diff --git a/doc/guides/rel_notes/release_20_11.rst > > b/doc/guides/rel_notes/release_20_11.rst > > index c6642f5f94..791f133d8f 100644 > > --- a/doc/guides/rel_notes/release_20_11.rst > > +++ b/doc/guides/rel_notes/release_20_11.rst > > @@ -73,7 +73,7 @@ New Features > > * Added flag action. > > * Added raw encap/decap actions. > > * Added VXLAN encap/decap actions. > > - * Added ICMP and ICMP6 matching items. > > + * Added ICMP(code/type/identifier/sequence number) and > > ICMP6(code/type) matching items. > > * Added option to set port mask for insertion/deletion: > > ``--portmask=3DN`` > > where N represents the hexadecimal bitmask of ports used. > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > b/drivers/net/mlx5/mlx5_flow.c index 416505f1c8..7bd5c5da94 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -1303,6 +1303,7 @@ mlx5_flow_validate_item_icmp(const struct > > rte_flow_item *item, > > struct rte_flow_error *error) >=20 > This function is shared between the dv and the verbs. > I think we can support this only in dv, so we need to split this function= . Thanks, I will split this function in v3 patch. >=20 > > { > > const struct rte_flow_item_icmp *mask =3D item->mask; > > + struct rte_flow_item_icmp default_mask; >=20 > I think the correct name is nic_mask. Thanks, I will change in v3 patch. >=20 > > const int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > > const uint64_t l3m =3D tunnel ? MLX5_FLOW_LAYER_INNER_L3_IPV4 : > > MLX5_FLOW_LAYER_OUTER_L3_IPV4; > @@ -1324,11 +1325,15 @@ > > mlx5_flow_validate_item_icmp(const struct rte_flow_item *item, > > return rte_flow_error_set(error, EINVAL, > > RTE_FLOW_ERROR_TYPE_ITEM, > > item, > > "multiple L4 layers not supported"); > > + memcpy(&default_mask, &rte_flow_item_icmp_mask, > > + sizeof(struct rte_flow_item_icmp)); > > + default_mask.hdr.icmp_ident =3D RTE_BE16(0xFFFF); > > + default_mask.hdr.icmp_seq_nb =3D RTE_BE16(0xFFFF); >=20 > You don't need to mem copy just init this structure when you declare it. Thanks, I will change in v3 patch. >=20 > > if (!mask) > > - mask =3D &rte_flow_item_icmp_mask; > > + mask =3D &default_mask; > > ret =3D mlx5_flow_item_acceptable > > (item, (const uint8_t *)mask, > > - (const uint8_t *)&rte_flow_item_icmp_mask, > > + (const uint8_t *)&default_mask, > > sizeof(struct rte_flow_item_icmp), error); > > if (ret < 0) > > return ret; > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index 3819cdb266..b5d6455067 > 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -7378,6 +7378,8 @@ flow_dv_translate_item_icmp(void *matcher, > void > > *key, { > > const struct rte_flow_item_icmp *icmp_m =3D item->mask; > > const struct rte_flow_item_icmp *icmp_v =3D item->spec; > > + uint32_t icmp_header_data_m =3D 0; > > + uint32_t icmp_header_data_v =3D 0; > > void *headers_m; > > void *headers_v; > > void *misc3_m =3D MLX5_ADDR_OF(fte_match_param, matcher, @@ - > 7396,8 > > +7398,14 @@ flow_dv_translate_item_icmp(void *matcher, void *key, > > MLX5_SET(fte_match_set_lyr_2_4, headers_v, ip_protocol, > > IPPROTO_ICMP); > > if (!icmp_v) > > return; > > - if (!icmp_m) > > + if (!icmp_m) { > > icmp_m =3D &rte_flow_item_icmp_mask; > > + icmp_header_data_m =3D RTE_BE32(UINT32_MAX); >=20 > Why are you setting the data as default mask? >=20 Because icmp_code and icmp_type still need the default mask. We do not need to change the old one.=20 We just add the new one for our new match fields.=20 > > + } else { > > + icmp_header_data_m =3D rte_cpu_to_be_16(icmp_m- > > >hdr.icmp_seq_nb); >=20 > Isn't the icmp_seq_nb already in BE? No, it is not BE and need use rte_cpu_to_be_16 >=20 > > + icmp_header_data_m |=3D > > + rte_cpu_to_be_16(icmp_m->hdr.icmp_ident) << 16; >=20 > Again the icmp_ident is already in BE >=20 It is not BE and need use rte_cpu_to_be_16 > > + } > > /* > > * Force flow only to match the non-fragmented IPv4 ICMP packets. > > * If only the protocol is specified, no need to match the frag. > > @@ -7412,6 +7420,12 @@ flow_dv_translate_item_icmp(void *matcher, > void > > *key, > > icmp_m->hdr.icmp_code); > > MLX5_SET(fte_match_set_misc3, misc3_v, icmp_code, > > icmp_v->hdr.icmp_code & icmp_m->hdr.icmp_code); > > + icmp_header_data_v =3D rte_cpu_to_be_16(icmp_v- > >hdr.icmp_seq_nb); > > + icmp_header_data_v |=3D rte_cpu_to_be_16(icmp_v->hdr.icmp_ident) > > << 16; >=20 > The BE issue again, It is not BE and need use rte_cpu_to_be_16 > > + MLX5_SET(fte_match_set_misc3, misc3_m, icmp_header_data, > > + icmp_header_data_m); > > + MLX5_SET(fte_match_set_misc3, misc3_v, icmp_header_data, > > + icmp_header_data_v & icmp_header_data_m); > > } > > > > /** > > -- > > 2.21.0