From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33B53A034F; Thu, 1 Apr 2021 09:37:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6EA340142; Thu, 1 Apr 2021 09:37:43 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2068.outbound.protection.outlook.com [40.107.101.68]) by mails.dpdk.org (Postfix) with ESMTP id BD47B4013F for ; Thu, 1 Apr 2021 09:37:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Noz79mBMEzrJawA50pHhBaDNgF8naFwtmiIW5p4ZlBMgmFxPhLlWk1yGYGTGeivsjcmKZhgMb3vXP99Xfi2oi6WOs44X6xQEZTIDk11AUYYc1SDJu65Trc7f4qR1Wgvv57YhpzOnoaCAnVE+RvJjbTej01l6eBhVrAlmo5gU1uuZvR2eG1QeOzYeV8Kf/J3cTA3TcWwURAEAhQDEc+KM5+ZiA2O7A3YGZzBqyIXpdSDVkkSQVxhonBxScXN/1wULO2UOooc/yJcVAmewXp2NdSraKIXMBMNXd5+L0DIBlm+Diw3mqJHpMYVKXeMtz3Jlc4RLezvKz+Z6FdV5/W9+Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Er6bcNaFROYDicjFKMlhBIQgsb/RUyfZyE8sv7BH6Tk=; b=Tl4hkekuZBLQdwiVn9tnYcCmGl4gEoDeSmPCsmX5dCXFkSMTLWC9+4AXI8zb59/Mf4ywjGKynGPX527eW7z6Vew5xDcJUd9eys2+xptlWft4tpegOI02IFHbWYDcMR30P5JWwFSuIsZUB4prbsmJjNfZ+X0sa0345K/6++9glW8jcQB/+/tvQ4ewOhAcy1vw5rePbCx6kECZITxl0jXhw+cIv17ZeoS0ZxWiAfXhUpNYiJusawpzKXqHQihav8xJXp1Sj8dreShhL7utsJ4zbiRbcN4n5i1gaCJ7A3NhgouSUu/OBDPdkr4prcNxPl6+ugzzfqyIA1i+heneHwfuUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Er6bcNaFROYDicjFKMlhBIQgsb/RUyfZyE8sv7BH6Tk=; b=Zf28JERmUcyo5xfbakyk+45ZCGcaL0KuNWTCLf7wX9iZpRX7yUeioqv7ah4jCt4wZ8zVDosFyidje4JVxRYlI5DCTjEsUbRjdg35m6joKNszYrKm6ayEHVnl6M3LBx1hHQCEsaDPmD2xpyW7QdLoYffi/6PxRIefczJgwERkw5uJHFmWE5k/zLM+wyIV3MjNGzA1ZWzbBc6BV9Un/aGDrmQU4CbJvhP9ouUIRJlRd73KWmrhrq/k5J0X4rep4Do2TjRbvmMIgSLyF8yOekDGCgymBOnfN5fUVwg90VyNXPXVt7spQFsMPgfyMCAOz3O66AmIfgOn16Um5uTXJRI9SA== Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) by DM6PR12MB4298.namprd12.prod.outlook.com (2603:10b6:5:21e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.30; Thu, 1 Apr 2021 07:37:40 +0000 Received: from DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da]) by DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da%4]) with mapi id 15.20.3999.028; Thu, 1 Apr 2021 07:37:39 +0000 From: Li Zhang To: NBU-Contact-Thomas Monjalon CC: Ori Kam , Slava Ovsiienko , Matan Azrad , "cristian.dumitrescu@intel.com" , "lironh@marvell.com" , "dev@dpdk.org" , Raslan Darawsheh , Roni Bar Yanai Thread-Topic: [PATCH 0/2] Check meter packet mode in PMD Thread-Index: AQHXJsCeQdSKGwereESwAg4GmKKbw6qfOM3wgAAEUQCAAAjz8A== Date: Thu, 1 Apr 2021 07:37:39 +0000 Message-ID: References: <20210401061618.1478961-1-lizh@nvidia.com> <40266646.2hgBqQEIht@thomas> <19061351.hDx7hfoL4V@thomas> In-Reply-To: <19061351.hDx7hfoL4V@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [139.227.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a644595-5991-4738-216e-08d8f4e10747 x-ms-traffictypediagnostic: DM6PR12MB4298: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U0Yk1z5N1Khcdfa+bawkZ662742Oubgo4dhDVcyCkDBGhG6wTjegMfdGN+2tvyzdudZqFtNdeLsv1PUgY3BqGIaGsJViBiAnF6Evdy7VZfBGeVe0YX/9u++QQ3zGC1oqCbst5o7lwUFx4I8Q902w4r1mhBEyC/wR7yk8yIUxUBJWqgJO74BBUSWpafLI4nGGUsZHx/GKhWOLYYiQyHEMTcM9O8+Lox4SzUU/oxA42Oy8ztZxqmDiS53cle5op6Fdj/KV6/Bu+q6IBm7JvxdBd4cOIbSfian8KONt1OzwJ/KbpNS4HVia2WFaQHsCAe0pFA/dfo1ihyiwF5nDRhGuT4x1hJ7kj2t/C4Lat3nqXZBksNnIT9cmjonvQx8H4CvoXvGTwsvDJg3QwK5MrsbDqZWKW+mOaU6eMLDGIUos2grOh6kCxF4vIRsCw0wZ3RoP2q5VhxFvjgclogzRZwDbT9N+aSEKYZQdU//xqOABzXFjKdVY7xKCPcaHNG2544PC688rpjBeFRnlyLmChUYMcx/UUs4vjihqQLV4PPqK5QPyIZqi/FRM1cEMnyn27aPTIH5IlzDc0CDryy0joLflB7tancKNdPgDRmnCqbKcLHCOuelYMyGOmqTf8SccxouSaPE8zJ+uhBqAbwGbUdGXSt6+FzmaG2tNLK4UzeLuteqD8f7UsvegT8qOphoKuNzl6LcHQKv5r3q7lMhKmUUnBN5/Dc8rXv08roItk/1NkIo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(2906002)(76116006)(86362001)(53546011)(71200400001)(52536014)(8676002)(54906003)(7696005)(8936002)(5660300002)(6506007)(6916009)(186003)(64756008)(66446008)(316002)(83380400001)(4326008)(9686003)(33656002)(66476007)(66556008)(45080400002)(66946007)(26005)(55016002)(478600001)(107886003)(38100700001)(966005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?pHVHHIIO6oqpQGk5MDgwZ7jm8qHmA0QLWEX/owQ9d7gJtwIY/UZd02o8CWY6?= =?us-ascii?Q?QLAMT4ybYYR2GPhxkHkq2rVFuK7Lj9+G8LHJn1WzAF/W5Gb25+HvVtdkvai5?= =?us-ascii?Q?lZh6nz0qrKtohkgug1JhsEM29YQ41KM5zMUfJCSTJd9irpumOQmBpQlbY8Ow?= =?us-ascii?Q?UDQWx6QY+o8qAQi1GNOrL4AvTTJyRh7eJE3SQIjplwfA6xwMSHvgU8b+12xI?= =?us-ascii?Q?hzwDuzjYlrL8h6qnL38xdjnYOxSfsy/Z/h+5OQ6gDh04cudkEBypjKRfWWKp?= =?us-ascii?Q?X+wquzR7cSj9ogCCGFVg/GLwnoqa6I0gfZttnbDzbAcCv8wSm01Np8RXvJzW?= =?us-ascii?Q?zVATcwzeGQX5gywBNcJ5DOXiw7rt6vIBQCIGnQ/nIdRofstw6v7MWS/2cukj?= =?us-ascii?Q?vMUgJ7gRtMiWmMHh/03T1Emny/kW7LERWNAXBg8RASvA7HBYG7rPgaygTy1l?= =?us-ascii?Q?dHU8Nk8Ogsg3QwF4BhIWpRE32SODugsTsxvUp6qcxvoOByv0diUZOf+kh2i0?= =?us-ascii?Q?my94gLqf7bPG2awzOAGwFWyudECUnnaG3/xtBcWRqdnEn4HOhBjCkgrNBHB2?= =?us-ascii?Q?iT+kxb/EZL8HZLHV8hgL2+GxAjDFFC6TyTKlvO49037KqvYdIKj/wUPTUvhc?= =?us-ascii?Q?yiGVsBRrs//ASLHqLcSMun/KjiMEgAGzMKF4EeBS9KAt8yoHUpR8oF16RAle?= =?us-ascii?Q?vf8R6Is4PrzUsDKRvbCiHTqehSvVcjbgLkPIBZLBvNJCDM80TWqXbhUNz/eO?= =?us-ascii?Q?1wByDkiAO/VtMPwLAkCibtR58IkAdpyedKeRELc3mBmwcgdorpODEdOFvs7M?= =?us-ascii?Q?4r6//lulz8wH2V9E9Lso33iyCzXLmXXEaGUGI9vWMzIdVXrcT/STPeWBTxIN?= =?us-ascii?Q?PeuBKYrldckkM053uMs2st3CAJyY3UBnri/ifIEt9+oYbBz+3xhEzCgUfGns?= =?us-ascii?Q?chLdoUnArfZBR3r4IABVDf9RO4Jca99hKQueDB+kUZAxV3mcb8prSZy4wPfQ?= =?us-ascii?Q?mKbTN+m2T5elNDtYPxOqGaAXqy69L3nfdTXsXCUTxdBjtbeGzWNrYjV5FpN3?= =?us-ascii?Q?B0ekBRdLqWOM4lJxTbTH2ckT6yccPc/G0QXb2MmM1aOxjjUay4uVgPlEddiS?= =?us-ascii?Q?aJiNOrJDSZzW33yIoiarrqAR7FSYxQfkXO3pXgk4KHBoBQcCV9jwtlINzxhy?= =?us-ascii?Q?vQnUUq60w6Lu4RUadzTVy/E6x7kOmRbHCnPgbER5Qx3rdpS9Y7dmf/EwiNBU?= =?us-ascii?Q?poFRYQMI00yu/ArWXy4nosXUy4kcSeaZgyeV1TIWYpmntCM+F00jLlhRtIH8?= =?us-ascii?Q?j3ovA+QrRn98U8OsjVh6VEGm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a644595-5991-4738-216e-08d8f4e10747 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 07:37:39.8447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y+O/Xu3lpQwqat2pIH2We9r75PahoNK1IYR0YcndovM7MKoAVaU+FFgsTM6SuIpq X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4298 Subject: Re: [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, April 1, 2021 3:05 PM > To: Li Zhang > Cc: Ori Kam ; Slava Ovsiienko ; > Matan Azrad ; cristian.dumitrescu@intel.com; > lironh@marvell.com; dev@dpdk.org; Raslan Darawsheh > ; Roni Bar Yanai > Subject: Re: [PATCH 0/2] Check meter packet mode in PMD >=20 > External email: Use caution opening links or attachments >=20 >=20 > 01/04/2021 08:52, Li Zhang: > > From: Thomas Monjalon > > > 01/04/2021 08:16, Li Zhang: > > > > Currently meter algorithms only supports rate is bytes per second(B= PS). > > > > Add packet_mode flag in meter profile parameters data structure in = RTE. > > > > > > What means RTE? > > > I see no flag added in these patches. > > > > It is RTE API, which added by another patch as below: > > Depends-on: series=3D16002 ("Support PPS(packet per second) on meter") > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat= c > > hwork.dpdk.org%2Fproject%2Fdpdk%2Fpatch%2F20210331085405.1445546- > 2-liz > > > h%40nvidia.com%2F&data=3D04%7C01%7Clizh%40nvidia.com%7Cee7b712 > 9413a4 > > > 361efed08d8f4dc74d2%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0% > 7C63752 > > > 8574977185064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ > QIjoiV2lu > > > MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DmtOtA82sfVNg > gKbNr6 > > 2qPbgZymCHCSN9p2JB01LUDXc%3D&reserved=3D0 >=20 > Please do not say RTE API, it is meaningless. > Better to give the exact name of the structure, or at least the name of t= he > library. >=20 > Also your sentence means this patchset is adding a flag but it is not. > It's very confusing. >=20 Thanks, I will change it in V2 patch. > > > > Add the necessary checks to the existing drivers implementing the > > > > rte_mtr API to makes sure that profiles with packet_mode set to > > > > TRUE are rejected. > > > > > > > > Depends-on: series=3D16002 ("Support PPS(packet per second) on > > > > meter") > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= F > > > > patc > > > > > > > > hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D16002&dat > > > a=3D04 > > > > %7C01%7Clizh%40nvidia.com%7C6fc22a58772641cbf72608d8f4d7bf75% > 7C4 > > > 3083d1 > > > > > > > > 5727340c1b7db39efd9ccc17a%7C0%7C0%7C637528554762610316%7CUnkno > > > wn%7CTWF > > > > > > > > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC > > > I6M > > > > > > > > n0%3D%7C1000&sdata=3DVZ88lQoAZK3z7MODRycvja4YvpEcjC4apoZZy4p1 > > > ZP4%3D& > > > > amp;reserved=3D0 > > > > > > It seems these patches should be part of the above patchset. > > > > > > > Li Zhang (2): > > > > net/softnic: check meter packet mode > > > > net/mvpp2: check meter packet mode >=20 >=20