From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A18D0A0524;
Tue, 13 Apr 2021 04:53:35 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1E6E016099E;
Tue, 13 Apr 2021 04:53:35 +0200 (CEST)
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
(mail-bn7nam10on2074.outbound.protection.outlook.com [40.107.92.74])
by mails.dpdk.org (Postfix) with ESMTP id B954616099D
for <dev@dpdk.org>; Tue, 13 Apr 2021 04:53:33 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=SgGi6Jqu4sbuc5RDCS8h/tfw25AItJk5Pxul1Kmp3h4cMgIQiqGj2mZzdjI1cf4DUaMoZXYADdciB5/h8tFWRIqjbnHkTBhgliUkHXJr7YLJkOeDr3s2fyqUwmqbNXbZHIOxxO8gLLpAcKELKYG4loLXL696T8PrIwArumzsh+UwdsOENmptvJoIjzglJVv5gkA6ZMOWNIZPvH6o2rvBINFYLTPFBkDxOlofEk2DFFPqcNcAAMDVRdz9QImHKny5mdiuUR8CIppLQ19zLxGXeOVqG+Iz6E0vNrPPVjeIhspFxfKvCQJ74C/DrxqelLoFsC5TrG50gi+JeRZQf+OfWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=osO+3KYnSkv1vGuiv+UAX00diPRr7tSv+015p6hyAtI=;
b=YIuKJEXCyyld6SduEDTsjmkjhyLhFi/GM0y/gLr3Ya2cK+H9Eyy+uaLE+XAzAx6Pas2XFdpOAPfiIK2ltvy9f3XzlQ5xa27/R0hRe2SRgW4OIFZy11kB4u5R3oUjvv89uzICz8cUivqZe92uGjZrcod26EKZgHjgm6tuQBsuI2dK3p8sHrUYrJiF0FvOmWy6H/U19pUDgpGpPOaZYGuJnOzIHxXHoqj66mRAiMTZAXyUXgVS05F3rildc01JtrmwYeiMCZI+giyNfMaEEFD+SAybhzaVaa0zyfp/MlxdH6QoklfH2M87HoEfR2XIjWriX7WzJFFeYzHrsKxA4hoYwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=osO+3KYnSkv1vGuiv+UAX00diPRr7tSv+015p6hyAtI=;
b=NVEIpkaAJiGEn/gGe2Fk7zP2dE7ShYT9H5CZ7/oIO1bu5KJht+wKtwUgSomVvz2liH2bdex4x5+Uc4pWxvqKUzegBkQrT5q/kx1u435aEpPRhNtZ1jd/KP0ZbXdv4mo7Hcx2489XzsZnQp4dcFiBgT6XySJhXAGYqrxujx2nNmBOkjNFyUWh4eGHK0CIa7gCuPV5ATchKbuP2IFIQk6g7DT23TUEcKyirDZZ6/3DDLo8Qld6GiXSXxfWCI03ZLbqyyHr/KTndVcyW/RF3v3zwX0mFfsklrIAeA88sQbjPkLtLwU8mJyaTR+hLkTBFPH1MO1vrhxcC7f9AMw/vAXKWQ==
Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11)
by DM5PR12MB1945.namprd12.prod.outlook.com (2603:10b6:3:10f::23) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Tue, 13 Apr
2021 02:53:31 +0000
Received: from DM6PR12MB4090.namprd12.prod.outlook.com
([fe80::fd19:da7e:347b:87da]) by DM6PR12MB4090.namprd12.prod.outlook.com
([fe80::fd19:da7e:347b:87da%4]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021
02:53:31 +0000
From: Li Zhang <lizh@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dekelp@nvidia.com"
<dekelp@nvidia.com>, Ori Kam <orika@nvidia.com>, Slava Ovsiienko
<viacheslavo@nvidia.com>, Matan Azrad <matan@nvidia.com>, Shahaf Shuler
<shahafs@nvidia.com>, "cristian.dumitrescu@intel.com"
<cristian.dumitrescu@intel.com>, "lironh@marvell.com" <lironh@marvell.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, NBU-Contact-Thomas Monjalon
<thomas@monjalon.net>, Raslan Darawsheh <rasland@nvidia.com>, Roni Bar Yanai
<roniba@nvidia.com>
Thread-Topic: [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter
Thread-Index: AQHXLdqaoJ6jebFlrkePr8frgQSSQKqxksOAgAAwbeA=
Date: Tue, 13 Apr 2021 02:53:31 +0000
Message-ID: <DM6PR12MB4090EF62C579749EA4E9EB78BF4F9@DM6PR12MB4090.namprd12.prod.outlook.com>
References: <20210408035849.1755493-1-lizh@nvidia.com>
<20210410072445.1872769-1-lizh@nvidia.com>
<eaebf1de-1d4b-9f5d-b5a2-f3b1f2434d43@intel.com>
In-Reply-To: <eaebf1de-1d4b-9f5d-b5a2-f3b1f2434d43@intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com;
x-originating-ip: [139.227.253.12]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e806dc24-63b2-40cd-daa1-08d8fe2752ca
x-ms-traffictypediagnostic: DM5PR12MB1945:
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR12MB1945A9BB68A87171B7B44A5FBF4F9@DM5PR12MB1945.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5797;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: P8NGW7qgK47FN4hehirGTsbwQdI5BdX1gqo/CKm7iHiFVbjdIdOOlEkBPYYegefNFc7w5BDG9NgEFBBUXn/WB9X7q2dAokGVFgXNWIPwo0I3xw8ZMZOaTvKUUsvKD6O1JA25eegIMKOUdgH/FHfV3BpXCb08W0gnoYcl23GNAgpRl8pkUqm2o5AMCwttjbODNuur7v2A6MCyEeDIdEnPTwDrrHiS/65gjIU5+tRAgdUUs5yNQbRy+EcXdXIPI0HePeTMG1492WntfIegX5R2uwwpnxej6dk8oy/LA5hC2tOK4VvALbjFKfQ1Zp8qxK24BHOGFxvNssepDQEaOWnTKMas9Grw0FvPmj65psNly6W6YTtoM+b5A1RUhM5auhJUkMC1Yd9WXCVSeQo62N2HKGZAb+1fqad6Et26sCO7wUUgHHoz4QqpuvW/W1keCWiVhebqt312IV6a2PV9808fKZv52oW2PISx8Zw6JZiJxDyYXSmPJR0x9kFJvfyet1+f4hZ4C9pEP8uNHngmafLN35BMrdGuzaxiH/pe/qB/y832B/XFkZn7w3KKb1KPFOat4hBssrRTZ8sEICkSH3XAPuG07egG2DReJk2jGl5mWyN3KqMvg9qJN4mUzbR6nTx5qZcu2IOuNMZu+baDTbvE5N2c+YY+TeECpXUxTomzNo7nVrSdi9+k1dnRodLRZoCM
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(346002)(136003)(396003)(366004)(376002)(39860400002)(8936002)(55016002)(9686003)(54906003)(52536014)(86362001)(107886003)(966005)(38100700002)(33656002)(71200400001)(110136005)(5660300002)(2906002)(122000001)(26005)(316002)(66946007)(8676002)(83380400001)(4326008)(7696005)(64756008)(66446008)(6506007)(186003)(76116006)(66556008)(53546011)(478600001)(66476007);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?tNWActpLoisXP9RAyoFYwO0I66XSwG9f+rdp7TKLN28Uv+ftbrJHnjZ2I9c7?=
=?us-ascii?Q?RNeZm2j6B6CyiNmlHhLSrzwvniHDZj0USjM9l0FvHjJdQNH0QABu7Ah4nDhy?=
=?us-ascii?Q?9+B7n86ENpLkb0iUTLW7CF6gr7awsoPfy9nnnj8/RiGl1Mj7mqDBojOCt0HI?=
=?us-ascii?Q?jvz0ZOjpA9k8QN7imparD3o9M6tvUpIZujsedb3f3QvCLKlneZIObvnmPkSv?=
=?us-ascii?Q?pc2sXqxfyrCVzJKGfs6TzaYBW4WDpBQMAo7JyPpTEu/sWXUmncgwt/tBUebo?=
=?us-ascii?Q?DBtVcArPAyNw3SwTYnOAXAa3lmTUdwGzNXMFQPw2poQkxcNTlTHuQ89pLCwe?=
=?us-ascii?Q?rxQeDQlBUDHN2q8BDWXnvjc2rzszRdPo9aDh3fBVSYmIrgJ3rOsnPpn38Hip?=
=?us-ascii?Q?66bH9Iy+GlebhjmlRxb/d6dNICvC7M9PZoazpVHzakFFmhraRCV7+fwHLGZO?=
=?us-ascii?Q?Qkr9EsJpKf2RmUQXsC7VguRGJ4qD4OSmWUI2vAquGw3470RdWX+Ik5p629TS?=
=?us-ascii?Q?HRq+XSY0HyHxyY/xmhxnXcSUOUWIOkeJ3LT1eF/cfiaT8HGp6Ij4kEp+8rsU?=
=?us-ascii?Q?+U2rqopENmc5aa50pkMcm8LMiR1X0X2jfG3spib3BBFX9gbGbgk1aE+5uf8I?=
=?us-ascii?Q?YJvPpoQcBZdCwbKQFARAZCISmesyucbovQ/5j6YggeSYxwhk57mmxDQ+zDNR?=
=?us-ascii?Q?mo8o5TLgo3ALuiWDNB1vrDDsewnRMaCkAwtGvPXRu2EWV7N7gyxAMSQChGp/?=
=?us-ascii?Q?NxGxvNR3/csyc02IRlkTMzBNuHDXsN90M5ah0C0jtHRIeZ0hVRdHEJjBKy3I?=
=?us-ascii?Q?+IxwgutGDlNTs8WZLTkUoflQVOFNzJCPrQM3qNhHioM3qh6usNyJ9/MKELFa?=
=?us-ascii?Q?F6rB2CCB04pnYCBDCsDoWgHOSqufxsN9WCnj2Lub4EepBsDYGJGx2m7C2crg?=
=?us-ascii?Q?bopU1eVZ2CFr4tBTtObQCLof9hBhNfHBefKxMg0bwclLgEuaoTFOXqv6myCT?=
=?us-ascii?Q?qJFKscR10h5kTwyoYK8oIGe9ouPo9S+rsQ5oRmPjbZ2IPk9PF9m7M8HGfngl?=
=?us-ascii?Q?dUCTU/HYpE6XNrTwO1gQJltvOZ+lGP28xGkA1TvHZ0vQjAOALf/dcQViQ/m3?=
=?us-ascii?Q?5Q0YO/ObHNiJMENw/eIvjxrPYep24NPIomyJj6bueCWXnpM68udVFQoAYIPr?=
=?us-ascii?Q?xDLTv+ogswaDR9c3YhAYkNmV3iiXrbccdyu9klNwwh46wL7Hl7ZqoBqdTrjP?=
=?us-ascii?Q?BL8SddzFgLZL0h8WWACF6Tu8tby5OwqvQTjOD/JsvH/LlqAOLw1/Rf+29jgJ?=
=?us-ascii?Q?FC5ZB/ThaJt9uNPQBBZXCRxz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e806dc24-63b2-40cd-daa1-08d8fe2752ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 02:53:31.7786 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0YSbQeQKt0jZaGAx1FSZposjw1caZ19tIIFv1qkMmQo9zJit7WOJcsT0vm8uLbVN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1945
Subject: Re: [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on
meter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi Ferruh,
You are right.
I will delete this series=3D15998 and also rebase on latest master in V4 p=
atch.
Regards,
Li Zhang
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, April 13, 2021 7:55 AM
> To: Li Zhang <lizh@nvidia.com>; dekelp@nvidia.com; Ori Kam
> <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan
> Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
> cristian.dumitrescu@intel.com; lironh@marvell.com
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> Raslan Darawsheh <rasland@nvidia.com>; Roni Bar Yanai
> <roniba@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on
> meter
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> On 4/10/2021 8:24 AM, Li Zhang wrote:
> > Currently meter algorithms only supports rate is bytes per second(BPS).
> > Add packet_mode flag in meter profile parameters data structure.
> > So that it can meter traffic by packet per second.
> >
> > When packet_mode is 0, the profile rates and bucket sizes are
> > specified in bytes per second and bytes when packet_mode is not 0, the
> > profile rates and bucket sizes are specified in packets and packets
> > per second.
> >
> > Add the necessary checks to the existing drivers implementing the
> > rte_mtr API to makes sure that profiles with packet_mode set to TRUE
> > are rejected.
> >
> > RFC ("adds support PPS(packet per second) on meter")
> > https://patchwork.dpdk.org/project/dpdk/patch/20210125012023.1769769-
> 2
> > -lizh@nvidia.com/
> >
> > Depends-on: series=3D15998 ("Add ASO meter support in MLX5 PMD")
> > https://patchwork.dpdk.org/project/dpdk/list/?series=3D15998
> >
>=20
> Above patch is mlx5 patch, but this driver doesn't update mlx5, is above
> dependency correct?
>=20
> And there is apply errors in the set, that is preventing CI to run on it,=
can you
> please rebase on latest master to enable CI?
>=20
> > V2: create a unified patch that contains both the series with
> > the API changes and the series with the necessary error checks in=
the
> drivers.
> >
> > V3: Fix comments from Matan and Cristian.
> >
> > Li Zhang (4):
> > ethdev: add packet mode in meter profile structure
> > app/testpmd: add meter profile packet mode option
> > net/softnic: check meter packet mode
> > net/mvpp2: check meter packet mode
> >
> > app/test-pmd/cmdline_mtr.c | 40 ++++++++-
> > doc/guides/rel_notes/release_21_05.rst | 12 +++
> > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 31 +++----
> > drivers/net/mvpp2/mrvl_mtr.c | 6 ++
> > drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++
> > lib/librte_ethdev/rte_mtr.h | 90 ++++++++++++++++++--=
-
> > 6 files changed, 159 insertions(+), 28 deletions(-)
> >