From: Li Zhang <lizh@nvidia.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"dekelp@nvidia.com" <dekelp@nvidia.com>,
Ori Kam <orika@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
"lironh@marvell.com" <lironh@marvell.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>,
Roni Bar Yanai <roniba@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/softnic: check meter packet mode
Date: Thu, 8 Apr 2021 02:31:42 +0000 [thread overview]
Message-ID: <DM6PR12MB4090FFC5C09C79789846F5DCBF749@DM6PR12MB4090.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB2796B9FEFF747B03A8B604C9EB759@DM6PR11MB2796.namprd11.prod.outlook.com>
Hi Cristian,
> -----Original Message-----
> From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Sent: Thursday, April 8, 2021 4:13 AM
> To: Li Zhang <lizh@nvidia.com>; dekelp@nvidia.com; Ori Kam
> <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan
> Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
> lironh@marvell.com; Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> Raslan Darawsheh <rasland@nvidia.com>; Roni Bar Yanai
> <roniba@nvidia.com>
> Subject: RE: [PATCH 1/2] net/softnic: check meter packet mode
>
> External email: Use caution opening links or attachments
>
>
> > -----Original Message-----
> > From: Li Zhang <lizh@nvidia.com>
> > Sent: Thursday, April 1, 2021 7:16 AM
> > To: dekelp@nvidia.com; orika@nvidia.com; viacheslavo@nvidia.com;
> > matan@nvidia.com; shahafs@nvidia.com; Dumitrescu, Cristian
> > <cristian.dumitrescu@intel.com>; lironh@marvell.com; Singh, Jasvinder
> > <jasvinder.singh@intel.com>
> > Cc: dev@dpdk.org; thomas@monjalon.net; rasland@nvidia.com;
> > roniba@nvidia.com
> > Subject: [PATCH 1/2] net/softnic: check meter packet mode
> >
> > Currently meter algorithms only supports bytes per second(BPS).
> > Check packet_mode set to TRUE are rejected.
> >
> > Signed-off-by: Li Zhang <lizh@nvidia.com>
> > ---
> > drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c
> > b/drivers/net/softnic/rte_eth_softnic_meter.c
> > index 0cbf94e8b0..50db74f52f 100644
> > --- a/drivers/net/softnic/rte_eth_softnic_meter.c
> > +++ b/drivers/net/softnic/rte_eth_softnic_meter.c
> > @@ -128,6 +128,14 @@ meter_profile_check(struct rte_eth_dev *dev,
> > NULL,
> > "Metering alg not supported");
> >
> > + /* Not support packet mode, just support byte mode. */
> > + if (profile->packet_mode)
> > + return -rte_mtr_error_set(error,
> > + EINVAL,
> > + RTE_MTR_ERROR_TYPE_METER_PROFILE,
>
> Can you please add a new error type for this specific error case, i.e.
> RTE_MTR_ERROR_TYPE_METER_PROFILE_PACKET_MODE.
>
Thanks, I will add it in V2 patch.
> > + NULL,
> > + "Meter packet mode not supported");
> > +
> > return 0;
> > }
> >
> > --
> > 2.27.0
next prev parent reply other threads:[~2021-04-08 2:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 6:16 [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD Li Zhang
2021-04-01 6:16 ` [dpdk-dev] [PATCH 1/2] net/softnic: check meter packet mode Li Zhang
2021-04-07 20:13 ` Dumitrescu, Cristian
2021-04-08 2:31 ` Li Zhang [this message]
2021-04-01 6:16 ` [dpdk-dev] [PATCH 2/2] net/mvpp2: " Li Zhang
2021-04-07 20:13 ` Dumitrescu, Cristian
2021-04-08 2:32 ` Li Zhang
2021-04-01 6:31 ` [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD Thomas Monjalon
2021-04-01 6:52 ` Li Zhang
2021-04-01 7:04 ` Thomas Monjalon
2021-04-01 7:37 ` Li Zhang
2021-04-01 7:44 ` Thomas Monjalon
2021-04-01 8:50 ` Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB4090FFC5C09C79789846F5DCBF749@DM6PR12MB4090.namprd12.prod.outlook.com \
--to=lizh@nvidia.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=lironh@marvell.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=roniba@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).