From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D3F2A04B6; Tue, 13 Oct 2020 10:22:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07CE01D53D; Tue, 13 Oct 2020 10:22:51 +0200 (CEST) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id A82371C19C for ; Tue, 13 Oct 2020 10:22:47 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 13 Oct 2020 01:21:18 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 13 Oct 2020 08:22:45 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 13 Oct 2020 08:22:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eb5dJvyHfAloRRnUcb7Kmx0ooAVQgGR4Pa3owE9hALixXZq5fiM2DVQ6jLoS4/alSrbhxv1uLBKMYTxWS/xrw3/RR80KAqSZTfjfo0qdqbL37o1IvM40bADpn/ljH0rwlEFrRuMJKcJqR4X/kjnqgJr0jWePYJ3Qt+G76OcpdEzpUA7z6HtGB//sp2gnV0ntGyhAwlAzguaAdEDeW6gYTYDss05fU+2PztOF63z8bQvyLZeV4n0hi13YzMSuXfltsflMY3p1AMiZ0eJLFG+/z8IrFJn41lHyfgfKlmvsuJhlgGoJktVEUkdjHInsrT2k/0oErTZzpGdBTgtC1ZLHwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zTMKLDyGdZmgkd2PiqXq8aspM0NYJfGQa9jG2cw3CGY=; b=iAgUqcT8VeHhqSNvIwmo9AJux0dtXPrBivg9sRNCwm+Mtu2mdjXZf7d8oFbn6b9dp0ezgEDI3zfPaeY/qBpgA5aBOoG+CNNalmCNHF+7p2GDe7o++ZyhEGwyQueb31O+u7i6OfuAvsmq8ee6js/QqgEv+brykUFQ8hMtkjK0dxFbLqNUOvGhIIR9aIxhAqYUurG1CiUDoA0J3qKF23OgRACahxPkbbMtU5aJtBRQJ0L75bmxz4yAmZjdk38z9GjefoXK2KToBQpBmat7wKh4dK04A/uptGn3Am4VLJvtYO4GsIxfBNG+DBoIeM0iqMXXv34nRg/IMO9VA32Gc06rkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB4372.namprd12.prod.outlook.com (2603:10b6:5:2af::14) by DM6PR12MB4958.namprd12.prod.outlook.com (2603:10b6:5:20a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Tue, 13 Oct 2020 08:22:44 +0000 Received: from DM6PR12MB4372.namprd12.prod.outlook.com ([fe80::5c6:df11:96ca:976e]) by DM6PR12MB4372.namprd12.prod.outlook.com ([fe80::5c6:df11:96ca:976e%8]) with mapi id 15.20.3455.031; Tue, 13 Oct 2020 08:22:44 +0000 From: Dekel Peled To: NBU-Contact-Thomas Monjalon , Ori Kam CC: "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , "dev@dpdk.org" , Asaf Penso Thread-Topic: [dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attributes to IPv6 item Thread-Index: AQHWoIScsesaASRVQE2nS99ErMjhbamUbzYAgADAwYA= Date: Tue, 13 Oct 2020 08:22:44 +0000 Message-ID: References: <97bc93abb2093db8eebba0fbe1b9692afb1e7095.1602494556.git.dekelp@nvidia.com> <12619574.BvRjRT2TxV@thomas> In-Reply-To: <12619574.BvRjRT2TxV@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [2a00:a040:185:6fd5:e498:9c5:1ce0:4eb6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a5d1912-a5f8-4fe6-2a24-08d86f5128eb x-ms-traffictypediagnostic: DM6PR12MB4958: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: us938bmxp1S72+xEuOAEPja69oEhxUBwpTbkZaMZ7ZQjVRwdz9UoP4VU9d78QkO3FV9WmUjHkhY25fFfGYSwxUpdomTxHQkCoEmFLw+kRmEoPXAjAk/MA6a015wrtSUvE23BRuo/PwcQuj40wVFOKfUhYuhTLWKWD3le539wYvAE1Sfh43tF3rbpiac+gBQmxJGUyCxohxrm8EDxyOFgdlX4tG7LQgN1zdtcEdQ2YAqduUwL8T4FD6ewnWskHKbaAcLXjAlOe/gGqXe8RetAf73xj1Ty6TZolFiSK5VBN6Sd7N38WPjNPJ8WX225OvruP7Mnahh2VRLJLSmIzj8aOA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4372.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(396003)(366004)(346002)(39860400002)(5660300002)(64756008)(66556008)(66446008)(66476007)(66946007)(76116006)(52536014)(4326008)(7696005)(478600001)(9686003)(55016002)(107886003)(2906002)(71200400001)(54906003)(86362001)(186003)(53546011)(6506007)(6636002)(8936002)(8676002)(33656002)(316002)(110136005)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: TwZ2yk2g2yUy7xyuf75v+qADqqlVs5GO+Fl8csgOWXuJmNKk5T/mPjTmOr4nU9OJUciI5u5YBhRh0GKofVOty/caGS7aoP1L5Yw30BtBv7+B1O9nrvGfOGf2UuIFOk4nuSPCCZBNTFYx/IqqjVDq8KVzhy0wUokUQhc1v9QwyDWQmfHXIR5hQrf3zRHeXb6PF8bBnuzGp70DU+unbXea+7Bjep2g/qZ7g9vhRX8dJ3hhaxdezPq8hg0CBkW5VXsUilMVAXJVFUfggb4EVz91c0MCcxtjxg8cO0aZaSSPaBxQF6BXesbngktBHEbS7OjFaaoy4LAxdUpWSpoXtgK8vigJwnDRGR3/rv5VUJGP45JgGHV1fE2+CK0COsb9TRvVluMdpurQmnROFyNhEoOCYqbFLJFQURAM1plvVmBf3hDnJQNuThklpo2AZAsQthWeOE4wUsduOPb4+qq194V9gFvZEu06Tk77gKpQJDsrPoyossF4QeO1h7Hg0Rcg85pk56pfPV79L8RlrOz2XXTEGJLHQqEsECA9uc8+VC+LBG2nhOSD07Le42SOSAVXiOO9VYLg6rL4Zai/OCXwrUWCnXxfa8a1ffPn7yohhYpRR/3Cs15/LpSBtBP/oV+VDqzEq6kiQ0RvBIqc6cQHSJNgjgrw6QSuQocEx4jsrF8j2fQH0MfiDMEy4Hsk3hsVjSzCtvclefSg4cAjEwJONOtC0g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4372.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a5d1912-a5f8-4fe6-2a24-08d86f5128eb X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2020 08:22:44.0747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bnNp2nEWNAzQyU2dN4JY1QmvlzTrhvILs+2NSb2HQOzI06XzAE/usvAIAWGaqLv1mH9iaTbzcPQvdIjseWMBMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4958 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602577278; bh=zTMKLDyGdZmgkd2PiqXq8aspM0NYJfGQa9jG2cw3CGY=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=aftOGMGwVYYDhBDzBf6GYigUQIgZnL1wIcOqzkzqnZOhWPzRGYieL5XfTPxs9/UpO Fyy3Sd0wp9kkpWOviL33IqA2ZXdVgsCRwx/pf1h5oz1PVayVCdfuTHKDc3xg3CJj1K jR1RtNqZMoM/SxPElSgT0aWfYlrb29KGLjBsr8gjJdyRDOCX2VpO8XwITH8p3PN+qp kpA4CucyzoNwe9jLA+k6PJmrx1SfKBWSH9Bw6ZXo5eZuv8DEEuoz1qzBShBsQe9CyO TbkY4rDODcu4nMVbqiBwhDDtdhgmH/mAKE3vh2lCQ5OYB8XmBgbmjvVkGhO1TjGXah ZwH4710V5bv3Q== Subject: Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attributes to IPv6 item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, PSB. > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 11:42 PM > To: Ori Kam ; Dekel Peled > Cc: ferruh.yigit@intel.com; arybchenko@solarflare.com; > konstantin.ananyev@intel.com; olivier.matz@6wind.com; > wenzhuo.lu@intel.com; beilei.xing@intel.com; > bernard.iremonger@intel.com; Matan Azrad ; Shahaf > Shuler ; Slava Ovsiienko ; > dev@dpdk.org; Asaf Penso > Subject: Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attribute= s > to IPv6 item >=20 > 12/10/2020 12:43, Dekel Peled: > > - * Note: IPv6 options are handled by dedicated pattern items, see > > - * RTE_FLOW_ITEM_TYPE_IPV6_EXT. > > + * Dedicated flags indicate existence of specific extension headers. > > + * Every type of extension header can use a dedicated pattern item, > > + or > > + * the generic item RTE_FLOW_ITEM_TYPE_IPV6_EXT. >=20 > I don't understand this last sentence. I'll rephrase. >=20 > > */ > > struct rte_flow_item_ipv6 { > > struct rte_ipv6_hdr hdr; /**< IPv6 header definition. */ > > + uint32_t hop_ext_exist:1; > > + /**< Hop-by-Hop Options extension header exists. */ > > + uint32_t rout_ext_exist:1; >=20 > "rout" looks weird. Would be "route" appropriate? I'll change to "route". >=20 > > + /**< Routing extension header exists. */ > > + uint32_t frag_ext_exist:1; > > + /**< Fragment extension header exists. */ > > + uint32_t auth_ext_exist:1; > > + /**< Authentication extension header exists. */ > > + uint32_t esp_ext_exist:1; > > + /**< Encapsulation Security Payload extension header exists. */ > > + uint32_t dest_ext_exist:1; > > + /**< Destination Options extension header exists. */ > > + uint32_t mobil_ext_exist:1; > > + /**< Mobility extension header exists. */ > > + uint32_t hip_ext_exist:1; > > + /**< Host Identity Protocol extension header exists. */ > > + uint32_t shim6_ext_exist:1; > > + /**< Shim6 Protocol extension header exists. */ >=20 > About the field names, the "_exist" suffix is pretty clear, but without b= eing > able to say why, I feel it is a strange name. > I was thinking about renaming the fields with a "has_" prefix. > Does it look better? I'm afraid a "has_" prefix doesn't look appropriate IMHO. I still prefer the "_exist" suffix. >=20