From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B56D0A04B5; Tue, 27 Oct 2020 10:13:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 956302BFA; Tue, 27 Oct 2020 10:13:10 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id CB2882BEA for ; Tue, 27 Oct 2020 10:13:07 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 27 Oct 2020 17:13:05 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 27 Oct 2020 09:13:05 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 27 Oct 2020 09:13:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QKpNGoti08sOQ3HI9qmK1btky4chQbwlKolZBdCKzb9Q1Lt/s8neQuJa0mDOT/IF017UogOoP2mFRRIm8ipR0xhN1gWMtOSWk2mmiuAy3mMkcuO9sJOoFQo0UTGqSvaSIBy2svXcid/L1WY2Ol1cDC9S8vdCnfQTNjBvR9kUeTJMHnQeH8gGxuqh0x2u0elicrtl6crOlR3uZhQfWDhndxoGRnxTTFPi0PHhO1L+0YbvD1oq89W4Up5IKFPk2a7RTBkhirDn6PzOk6sGdVJS6YUWTSOZT93CpESFWyW3ax3l1rlB2z/i2OB2dAkRqZWrhQZlLHadCTlcTlbmhfD+Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1lE0c29GP4Bwc6rJQUnT8IzGY6+1E5ZO6R13dkCsd1w=; b=mBG9dYBqTmHUTyCh2xE1318LYy86QStinMEMyw1ewFvhNjfBZynCukt/AvhbEuKuTioP8TTrVRlwxdqwy2+kQOU4UaNOnf/iCQpcuxOzy4a3mlnvNC+oDZHu2wRGY99bg9zRZVavmHL5ekSuCwYgFZI8sFqzvJ+vZ5xn/j9CCf/Y8BqfUd4VZJoIr6LijOjFvei+nrj9OlMrYk1WhBRJa9MmBvlWM3kF4VBNe32XCu3j5sgZV/wdgG2s0t6ehpTUlQbW7i1JGozufnTddvJUHfXmOzuFae9bL5POVUMPtaPTddr4EMobILwTBfLIcaHrpZRARdOtlzoBTf9EL10zHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB4618.namprd12.prod.outlook.com (2603:10b6:5:78::20) by DM5PR12MB1660.namprd12.prod.outlook.com (2603:10b6:4:9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Tue, 27 Oct 2020 09:13:02 +0000 Received: from DM6PR12MB4618.namprd12.prod.outlook.com ([fe80::b5e2:e8fc:9e81:6c09]) by DM6PR12MB4618.namprd12.prod.outlook.com ([fe80::b5e2:e8fc:9e81:6c09%6]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 09:13:02 +0000 From: Ali Alnubani To: Andrew Rybchenko , "dev@dpdk.org" CC: Ivan Malov , David Marchand Thread-Topic: [dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action set spec init/fini APIs Thread-Index: AQHWpsNwrSCYj876B0GAAmHQtZryz6mrNBnA Date: Tue, 27 Oct 2020 09:13:02 +0000 Message-ID: References: <1603183709-23420-1-git-send-email-arybchenko@solarflare.com> <1603185222-14831-1-git-send-email-arybchenko@solarflare.com> <1603185222-14831-15-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1603185222-14831-15-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: solarflare.com; dkim=none (message not signed) header.d=none;solarflare.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91ae34ae-4a5b-49bb-b862-08d87a5881b8 x-ms-traffictypediagnostic: DM5PR12MB1660: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ScZTJSbAQp7c+Y9SCJsssq+gH2WkhjQu/bqYaW4EOgRxEskNZgWr2DJPPFMvu9YdLO8cdNArZfK4G3mJua5Kydu3tSs53Gwt++3znLP6MpIsRKQBzR9pZyYih8H0pW8rUdvMdoPdTwa8Jm555oFAl1ItQ0h+NlAtqd9jiZvvVVp7C0BTfvc+eiVoE4/fzfxAbiLKXyqsW1PvtLc9nTotEoH0iq/HHZj/Q7yziUTiLva6M53L7nc9OkGFnQb/5svz2pk0585KYAa0yciXHCyGsv1omX5jv/OEAaFO3JZ+Ie9xbd0p9bQIm3XQBIcwUEd8w0Gv4ej/YyKoJ9vvzhjevg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4618.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(86362001)(54906003)(66556008)(83380400001)(66446008)(64756008)(6506007)(71200400001)(52536014)(8936002)(76116006)(26005)(9686003)(66946007)(4326008)(7696005)(66476007)(186003)(5660300002)(53546011)(33656002)(110136005)(2906002)(316002)(478600001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: JPbj4L48MHg8wKVv5FUaKmc8Uy8nGlSVMh44zVpY8rXE/YCi4h+31ugk/bH0hs2bMyyWRHO0qrvc9fheCIkUTZlCfbbQZh5qqAA2q+yWps7ZSjK2127tZ8PrImua75kNRPSxFltkLeBaLiJhAfe3JKQd5Ex6u+QdgfabUY5hbE+AUlsknlmjFOWVoh40GOO7voxcaqpZ+9UsluD+Tx4ikh4ujDpwhMUrjiqCvvI87TmzaBXtnr+sxPhJodCc53X4zRTIQVqHKNxdzqtiVHlFgZfyopMX9GwpTy6Hwi+0rYU0MjXqwH3yIK/Sr89or/sWWpXQ0lXo+dYissKjSy2HfRLAJuTMncdfUSzsDbk1U/Dnll+c4afNEbNTIxBUCvIqC2lHG66hhZy9eQTKm3HvMLBHR4qIi6LNVkbNHMEO6TsQKERYWp/+Phd/CmS3ILd8Xs129tnIVuZGIZ6HX1Lip1Zlv44MS3BP4GKWDmdaYn2hisFor1JKNCZzSbUKn1yoEs9lnjoRPg8DH/p/ZKTObGLx2c1QyjGR4No0y8L6wL5qnuawfHEFH6f6/lWTPaJkvfZpXtIadMhosV5QkUMS2QDCjmb11K+RcbcafjjJNsNbooDh8xqlBANmtp5N5ViV4tjHoiaKvt5H6nSXRQjKVg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4618.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91ae34ae-4a5b-49bb-b862-08d87a5881b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 09:13:02.4382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cP+5GRuqPasJUzmKBLyDFehtYoKBtir5AK8qUCihuHPyy9VsC8ZRJqesD8j0B/ooGLiFfnl/2QKeWgurD/ERPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1660 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603789985; bh=1lE0c29GP4Bwc6rJQUnT8IzGY6+1E5ZO6R13dkCsd1w=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: x-ms-exchange-transport-forked:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=CwRbkb37yN8idYLuBx/+t4W7YzI+hVf9JcqOmB7cU34QqK9UicBWgHyEGxoaPwpiC gXkWICv0+lPpYeNvjPmW815T8nDwAtDNyEWlwUId5sKUJp/1OwaYl0zscYFg7dHI+W EBHjB3P6xfa5Pg03wyonwmke54b655vnnJuvUgq8EO4SJxy2kFbinZpVT8IyQsKnFn Xudf0uBJAEnCYVupuv/ZFok5s3yYDhSsPDaIcbgG9tgteOQdLCl7ZG1a1Awmxm/DKY HbOf01V7J1ZV6DSUvGHbcgqj8pxORA7Vno1y//nc61gG5mcGrlH1AhWOXcALQioA1S Kwd6J0gwutMmg== Subject: Re: [dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action set spec init/fini APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Sent my report to v1 the first time by mistake. > -----Original Message----- > From: dev On Behalf Of Andrew Rybchenko > Sent: Tuesday, October 20, 2020 12:13 PM > To: dev@dpdk.org > Cc: Ivan Malov > Subject: [dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action set > spec init/fini APIs >=20 > From: Ivan Malov >=20 > The engine is only able to carry out chosen actions on matching packets i= n a > strict order. No MCDI exists to identify supported actions and the order. > Still, the definition of the latter is available from the FW documentatio= n. >=20 > The general idea is to define an action specification structure and suppl= y a > client driver with APIs for adding actions individually, order-dependent. > A client driver is supposed to invoke an API on every action passed by th= e > application, and if an out-of-order action follows, the API will reject i= t. >=20 > Add an action set specification stub and supply initialise / finalise API= s. >=20 > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --- This patch is causing the following build failure on CentOS 7 with clang 3.= 4.2: """ In file included from drivers/common/sfc_efx/base/efx_crc32.c:8: drivers/common/sfc_efx/base/efx_impl.h:1703:3: error: redefinition of typed= ef 'efx_mae_actions_t' is a C11 feature [-Werror,-Wtypedef-redefinition] } = efx_mae_actions_t; drivers/common/sfc_efx/base/efx.h:4101:34: note: previous definition is her= e typedef struct efx_mae_actions_s efx_mae_actions_t;=20 """ Regards, Ali