From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8105DA034F; Mon, 29 Mar 2021 10:53:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B199140DEF; Mon, 29 Mar 2021 10:53:06 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2055.outbound.protection.outlook.com [40.107.92.55]) by mails.dpdk.org (Postfix) with ESMTP id CCC8F40151; Mon, 29 Mar 2021 10:53:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CXKQLyhl3tyAJE+QDM3ZdsrX8JaGqJbv+UWrRRQ1snZxLybV1BtxLinL2rkQb8JXtL92bviy9euod7yb5dV5mXJ+RmgApvM8C2HOKJgfrB8CYwBLEhfc4MWfr0RL6+rqo9oqBMSkjuYs54W2dpUVvaTKNIInuR6+2txUFtanpAFvv659FY/PfvrCU5i+DOsrVyFTPaHkpJDUnbR9qNIlIut82SOQtXfShtkcE96wIXJixbWdI7diI7KA8+qn5QVjIZzcXXwzNcZ93J5TZnEdaM+4N+A04XNTsg1jmDMaLQlr93J88H7Zp6eQAM37jWLATjFwRBSJLwjZGA1JN7hZ/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k6bpPgcXapn4kIOtaBnuqFv/x0z/18D+4wtdWFvGveg=; b=J4mRWD2/OpWgpx114sPNpFm9JZXgUqCRwrZWuJgpEVePsPhh8sVZCAlY2TMxl0RNQgbr+GgWCxG8bBR/FPYmDiUnVkDqYvUjrtUXYsIpFDc9lIVGtaAcKxplfhIa4nqMNOSjABEzhwpVOzpTFrLSWK6AM0aVH1fzRcJOjDtKMIseJZ+Btdf8FDnk044n++gMRuHSvVUa9dhiWIV8wbwyY3nURew6zxe+U2vH8T73yyqkVbUitm8XxfpMmRQCf+IWVL7IDacvJZ9aZy9KVFFd7DvRBC74P6XomIyoXInSsZM7A1YG3SCvhHXwJ7Tbm4SKhhirt6CYxMSD/RhUzdelHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k6bpPgcXapn4kIOtaBnuqFv/x0z/18D+4wtdWFvGveg=; b=rzDukNyp2WnGJuLPBmFNoSOCP2h/09bl2g1ga89b2k2C3JrgC/HpP2bG7PbjbEz5VCIkSShqTOcqwlbpXyG9GTIBf7lNogYQtjp0axC+DsoNDrqYDAc3xRllnvunciNwF5QipyEQN4WjL8ZxEG57PetCO0K4SxMwoD0VY5AbwbFt4LIEZCFoVjorxjjHKTTI9L57dMksPfJf+BhXddYmla7EclE29AobRZYWY+srDGnZBXIDqdyg4TI9wfPe6q7oiP+sn4jyevvF8jyTg19ne7ZRhuWhN1M8runp5DhCoHAAcQ6jtYCOWIxH9zyVH0EuvZIW8mKTr5yoXhrnHbVmng== Received: from DM6PR12MB4987.namprd12.prod.outlook.com (2603:10b6:5:163::31) by DM6PR12MB4435.namprd12.prod.outlook.com (2603:10b6:5:2a6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Mon, 29 Mar 2021 08:53:03 +0000 Received: from DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::f5ce:c5a8:6aec:e308]) by DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::f5ce:c5a8:6aec:e308%7]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 08:53:03 +0000 From: Ori Kam To: Ferruh Yigit , Raslan Darawsheh , "dev@dpdk.org" , Andrew Rybchenko , Ivan Malov CC: Slava Ovsiienko , Shiri Kuzin , "ying.a.wang@intel.com" , "stable@dpdk.org" , NBU-Contact-Thomas Monjalon , Olivier Matz Thread-Topic: [dpdk-dev] [PATCH] ethdev: update qfi definition Thread-Index: AQHXH93AgW+UsvIKMEK5swdmTHkvt6qWQ7MAgARt+xA= Date: Mon, 29 Mar 2021 08:53:03 +0000 Message-ID: References: <20210323121134.19113-1-rasland@nvidia.com> <20780a26-f27a-8d43-27e3-744293538cca@intel.com> In-Reply-To: <20780a26-f27a-8d43-27e3-744293538cca@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.145.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: faf13154-9716-425e-e278-08d8f290102e x-ms-traffictypediagnostic: DM6PR12MB4435: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VNbKh+OiPoEjGYA8l+4W61lNeJ2veOxuiWJQjXYRdCIzSvk0rpm4CsBAF6ccNsFdyTTGqfnhCe43FfKMAwWRPTI6Gi97dQDjrFrCFVtItGoVGzWF0U/0G6rH4KWNiRyhaMZkPHf1Mza3JL0ckA3C0FNBg64hHGctAVXPHk+I6y+Q+52uXOtislZpDyjhWpWtJHoM+cOxRa9FJ69Bom9KB+J5Vww92PmkgeWdlRJxx2bDapRDptNR190pHCzOoud8qqVS4jUR2iDOYuCUC/kU/TUfbG5CgB9dOn2p899tLXC74yvp+uAOEXy8ttd8s2Qy4n7r8fxG1z5PAjzc83DPfo+QBXN6VH1heqAWgnV4Qivhr1N89L0ZmnYNTMzKP/Uy+aTVyibr+zHbc88rEr9GBveZNd3PCs2irFbwujjkIDPgy17etFV9R2HFsJDzPqnjBvE7xxelHUYiBdocaLpgrAalirvTvrxvM+rP8mJlA/pKg5anfMgFZe1exxb5pFBRZX7p2/E0i51yjmBW0gCrLO6YKYRzNYO8cv028UkwcBAk+A1Kou62HiKWDjE3M/F6lv3DzmyUfRQlvvJmRsOJBGYb2NixG+Tp2LSSUAQZHrZEtaoKReHhOiFbz270N44ovOuIh1hPojezW2xu7AdlijMl7WOOif+YjEZ9Ji3+H+9HT3fFKLVvsF2a27LcHdxLghjkWI/bFYHc3HKgeo5Keg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4987.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(396003)(39860400002)(136003)(6506007)(7696005)(186003)(316002)(5660300002)(52536014)(53546011)(55016002)(64756008)(26005)(66446008)(110136005)(76116006)(71200400001)(38100700001)(66476007)(83380400001)(66556008)(54906003)(66946007)(33656002)(45080400002)(966005)(86362001)(478600001)(8676002)(8936002)(15650500001)(4326008)(2906002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3NySSVVCP70+uymjYVMWtWB0kGfgo9cKwkGaj/U88Qo3TnULy3TzhU936WN/?= =?us-ascii?Q?A1rnFxxoW39iaaCtsSZpZZfK1dOWtMhYMdYVFaKApSaC2xTQmed0PKrQtCVJ?= =?us-ascii?Q?44hRc0rkMbepDPKRy8+8MHe8IKjDNuVdF/xM/NaobuX1IXlcbvW3bL3N93X9?= =?us-ascii?Q?s3ZFp+vHfgl9lWpJNSDDzbApNrRn7OEN6jxY+A/MUNfHRjVIoJHRc9/cv/1e?= =?us-ascii?Q?a+A4QWtDMcS1u5jKYUmxCcpYdlEnSgaJk2qCyRoyo11JG/SttD81UmJ7pR0l?= =?us-ascii?Q?tLEvNM8cF959T4SZ44cPHr4kuK3nWOq5K8aR+C+f+c5/O3zV22ylniCc8kxE?= =?us-ascii?Q?Rnv67mUKUHnyrVHHeXr5AkI2lWJRxKYPM7Jmvf4OCaMhfuj36BDNBITmz+UX?= =?us-ascii?Q?ufWa++EQ30LhDBxirZZ5fukTjHH620eRhr60ZeTIL2HOwyNCwyqzBtEol+P7?= =?us-ascii?Q?tqAjVAusxfR2/nfXc8VHU9fpdV5plsvJktETAg1WMZHYiwl9TrwtEs8yOWe7?= =?us-ascii?Q?v9so1uzqGczPPCpjENpvPTsjPgKcXEfmk7Yz1FxGYipWY4yvsRIi383dsqBk?= =?us-ascii?Q?8ginYZ4xVvU80vL8h8JoJkxqc5wWRDDt2pcQhPKMOiuHg8HIid+AYvIZsLgP?= =?us-ascii?Q?GPSsBBsHdtQL59sSvTJFSTYLxL1FUq5UJKEaPojSBHwqQ0UIY9rCaWsbIBNb?= =?us-ascii?Q?klQWsU6bfDXaQGCmcVpHmr4gYPOZ2qpzung6hyZMBUH1CdJ9c3X5z1NX/+wm?= =?us-ascii?Q?b5m/vM0VpdFzG5aqmlm3sHPPIiFbvIP6+j2S/t8NVRksDRE4vFw1+QW4Xvc6?= =?us-ascii?Q?rAiZNt2cUP0SfbUJSCAt6vYPhegr8DepBEmQL5A7+EivO6Y1hxrlW5FnTECp?= =?us-ascii?Q?n2XrA4HFrTHT1Gn0a8uVwmCjiRhtDm2IVfwARbbOBS7n0X4b3NtQm8KD5vO4?= =?us-ascii?Q?ulWVqIs6a0EC2ty8ISTTO5ma9ZciuqeZmnGugxnlkfEd2GMH0xIshTrXyj/z?= =?us-ascii?Q?7qYP05IRhC22GNzLV8gT8WWxxiKG16PDefZI9aV5sLCxIWabf9Z2HyXmjBzA?= =?us-ascii?Q?NtUNgxMVFAIt12u4VngzBkimFCNyYnrIO03QzG9ovmRUxcvxUTgxVysATjzr?= =?us-ascii?Q?4UFmkIBZc5mXXbpLomD3HeBU0R/TlAESJKY0jhYUAUUF3fbQQDyi6xOnkfgS?= =?us-ascii?Q?LM0tna7O7BsQGplkO4j/HFGkUGjcaT4KQYDzUKxLNThZXO5EmiGR3MG1XvBr?= =?us-ascii?Q?CJqkp6r2DfRWIjc2AVOoY74ah3/SQ59TIAns7D5BoZCTEujAggN5iJJjH74c?= =?us-ascii?Q?NjROFhkdTIv3VJ9ewGglyDqs?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4987.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: faf13154-9716-425e-e278-08d8f290102e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 08:53:03.1936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AM972As71F4qE/a6Mn5/sqYG7ej9mLykJn8laCHrc/j2LCmM9vz2l6NrRXEZoDmdyjLXQX6gvZLMHITBJUCD7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4435 Subject: Re: [dpdk-dev] [PATCH] ethdev: update qfi definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: dev On Behalf Of Ferruh Yigit > Subject: Re: [dpdk-dev] [PATCH] ethdev: update qfi definition >=20 > On 3/23/2021 12:11 PM, Raslan Darawsheh wrote: > > qfi field is 8 bits which represent single bit for > > PPP (paging Policy Presence) single bit for RQI > > (Reflective QoS Indicator) and 6 bits for qfi > > (QoS Flow Identifier) >=20 > Can you please put a reference for above information? > > > > This update the doxygen format and the mask for qfi > > to properly identify the full 8 bits of the field. > > > > note: changing the default mask would cause different > > patterns generated by testpmd. > > > > Fixes: 346553db5bd1 ("ethdev: add GTP extension header to flow API") > > Cc: ying.a.wang@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Raslan Darawsheh > > --- > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++- > > lib/librte_ethdev/rte_flow.h | 4 ++-- > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > index f59eb8a27d..dd39c4c3c2 100644 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > @@ -3742,7 +3742,8 @@ This section lists supported pattern items and th= eir > attributes, if any. > > - ``gtp_psc``: match GTP PDU extension header with type 0x85. > > > > - ``pdu_type {unsigned}``: PDU type. > > - - ``qfi {unsigned}``: QoS flow identifier. > > + > > + - ``qfi {unsigned}``: PPP, RQI and QoS flow identifier. > > > > - ``pppoes``, ``pppoed``: match PPPoE header. > > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.= h > > index 669e677e91..79106e0246 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -1392,14 +1392,14 @@ static const struct rte_flow_item_meta > rte_flow_item_meta_mask =3D { > > */ > > struct rte_flow_item_gtp_psc { > > uint8_t pdu_type; /**< PDU type. */ > > - uint8_t qfi; /**< QoS flow identifier. */ > > + uint8_t qfi; /**< PPP, RQI, QoS flow identifier. */ > > }; >=20 > By design requirement, rte_flow_item_* should start with the relevant pro= tocol > header. >=20 > There is already a deprecation notice for using protocol header directly = in the > rte_flow_item* [1] and Adrew/Ivan already fixed a few of them [2]. >=20 > Your patch is not directly related on this, but since you are touching to= the > flow_item, would you mind create a protocol struct for it first, and use = it in > the "struct rte_flow_item_gtp_psc"? > So the protocol related update can be done in the protocol header, instea= d of > rte_flow struct. >=20 +1 >=20 > [1] > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit.d= pdk. > org%2Fdpdk%2Ftree%2Fdoc%2Fguides%2Frel_notes%2Fdeprecation.rst%3Fh%3 > Dv21.02%23n99&data=3D04%7C01%7Corika%40nvidia.com%7C6391a4c0640 > f4592b70b08d8f058e322%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > %7C637523611870497932%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdat > a=3DvU%2F5oO47zb9erTnZL1pl9j0nHCKzea3NJgOeo1FTW0Q%3D&reserved=3D > 0 >=20 > [2] > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit.d= pdk. > org%2Fnext%2Fdpdk-next- > net%2Fcommit%2F%3Fid%3D4a061a7bd70bfa023de23e8e654e&data=3D04% > 7C01%7Corika%40nvidia.com%7C6391a4c0640f4592b70b08d8f058e322%7C43 > 083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637523611870497932%7CU > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DWurlQ5VSLqFGVthfRj363xZsC > No3xJuvxNQCFVcxdkk%3D&reserved=3D0