DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ori Kam <orika@nvidia.com>
To: Ivan Malov <ivan.malov@oktetlabs.ru>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	"Bernard Iremonger" <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: support shared flow action attribute transfer
Date: Mon, 2 Nov 2020 14:04:31 +0000
Message-ID: <DM6PR12MB49878711414B5BCF18AB8C9FD6100@DM6PR12MB4987.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201102114317.24492-2-ivan.malov@oktetlabs.ru>



> -----Original Message-----
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> Sent: Monday, November 2, 2020 1:43 PM
> To: dev@dpdk.org
> Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Wenzhuo Lu <wenzhuo.lu@intel.com>; Beilei Xing <beilei.xing@intel.com>;
> Bernard Iremonger <bernard.iremonger@intel.com>
> Subject: [PATCH v3 2/2] app/testpmd: support shared flow action attribute
> transfer
> 
> This attribute helps PMDs to tell actions supposed to work
> on the so-called hardware e-switch level from regular ones.
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> ---
>  app/test-pmd/cmdline_flow.c                 | 12 ++++++++++++
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  2 +-
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index c68d22fda..fe18cca27 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -114,6 +114,7 @@ enum index {
>  	SHARED_ACTION_CREATE_ID,
>  	SHARED_ACTION_INGRESS,
>  	SHARED_ACTION_EGRESS,
> +	SHARED_ACTION_TRANSFER,
>  	SHARED_ACTION_SPEC,
> 
>  	/* Shared action destroy arguments */
> @@ -782,6 +783,7 @@ static const enum index next_sa_create_attr[] = {
>  	SHARED_ACTION_CREATE_ID,
>  	SHARED_ACTION_INGRESS,
>  	SHARED_ACTION_EGRESS,
> +	SHARED_ACTION_TRANSFER,
>  	SHARED_ACTION_SPEC,
>  	ZERO,
>  };
> @@ -4286,6 +4288,12 @@ static const struct token token_list[] = {
>  		.next = NEXT(next_sa_create_attr),
>  		.call = parse_sa,
>  	},
> +	[SHARED_ACTION_TRANSFER] = {
> +		.name = "transfer",
> +		.help = "affect rule to transfer",
> +		.next = NEXT(next_sa_create_attr),
> +		.call = parse_sa,
> +	},
>  	[SHARED_ACTION_SPEC] = {
>  		.name = "action",
>  		.help = "specify action to share",
> @@ -4521,6 +4529,9 @@ parse_sa(struct context *ctx, const struct token
> *token,
>  	case SHARED_ACTION_INGRESS:
>  		out->args.vc.attr.ingress = 1;
>  		return len;
> +	case SHARED_ACTION_TRANSFER:
> +		out->args.vc.attr.transfer = 1;
> +		return len;
>  	default:
>  		return -1;
>  	}
> @@ -7273,6 +7284,7 @@ cmd_flow_parsed(const struct buffer *in)
>  				&((const struct rte_flow_shared_action_conf) {
>  					.ingress = in->args.vc.attr.ingress,
>  					.egress = in->args.vc.attr.egress,
> +					.transfer = in->args.vc.attr.transfer,
>  				}),
>  				in->args.vc.actions);
>  		break;
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 289df193b..ebf7e68f8 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4318,7 +4318,7 @@ Creating shared actions
>  shared action ID. It is bound to ``rte_flow_shared_action_create()``::
> 
>     flow shared_action {port_id} create [action_id {shared_action_id}]
> -      [ingress] [egress] action {action} / end
> +      [ingress] [egress] [transfer] action {action} / end
> 
>  If successful, it will show::
> 
> --
> 2.20.1

Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori

  reply	other threads:[~2020-11-02 14:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 11:46 [dpdk-dev] [PATCH 1/2] ethdev: introduce transfer attribute to shared action conf Ivan Malov
2020-10-29 11:46 ` [dpdk-dev] [PATCH 2/2] app/testpmd: support shared flow action attribute transfer Ivan Malov
2020-10-29 12:37 ` [dpdk-dev] [PATCH 1/2] ethdev: introduce transfer attribute to shared action conf Ferruh Yigit
2020-10-29 12:54   ` Andrew Rybchenko
2020-10-30 15:49 ` Xueming(Steven) Li
2020-10-30 20:35   ` Ivan Malov
2020-11-01  8:11     ` Ori Kam
2020-11-01  9:35       ` Ori Kam
2020-11-02  9:37         ` Ori Kam
2020-11-02 11:35 ` [dpdk-dev] [PATCH v2 " Ivan Malov
2020-11-02 11:35   ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: support shared flow action attribute transfer Ivan Malov
2020-11-02 11:43 ` [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf Ivan Malov
2020-11-02 11:43   ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: support shared flow action attribute transfer Ivan Malov
2020-11-02 14:04     ` Ori Kam [this message]
2020-11-02 13:15   ` [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf Andrew Rybchenko
2020-11-02 21:44     ` Ajit Khaparde
2020-11-02 18:54   ` Ferruh Yigit
2020-11-03 14:10     ` Ivan Malov
2020-11-03 15:52       ` Ferruh Yigit
2020-11-03 14:20     ` Andrey Vesnovaty
2020-11-03 16:05       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB49878711414B5BCF18AB8C9FD6100@DM6PR12MB4987.namprd12.prod.outlook.com \
    --to=orika@nvidia.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ivan.malov@oktetlabs.ru \
    --cc=wenzhuo.lu@intel.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git