From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2444A04DC; Tue, 20 Oct 2020 07:59:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E810CBBB0; Tue, 20 Oct 2020 07:59:27 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id CD3D6BBAE for ; Tue, 20 Oct 2020 07:59:26 +0200 (CEST) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 20 Oct 2020 13:59:24 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 20 Oct 2020 05:59:22 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 20 Oct 2020 05:59:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ag5niR76svv6gVz98rJf4qWecAwZOCicRx6p/QkHMUG8jZNguGCyT8WFc3YFo1PSbXSwWqh39sYxgKJjRa5+IKfRVvRYXm7GHuTapVdVWiCC/UJsfddG1AoJQGY0D1UNQGyK/C2sqj7+NUdRnVLgVBm2TI8duahbwAMG+pUVkst61hz71MaT7gHOihlDgzEHE3xu8lYjCOKD6frgFenByRTgYfAxzgl5WGt6FdjrflZAih2UUHI6MXdbmhNLn+D5Fn3Ohl6u1EYkFoUjLoCCKUX+c1ph6euldb06JPJjszIx9IGJNq+FhVza7xxzqo/6EJ5XfyWcNIuZMHfran/U2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNKOS0GXcdPTjygnYUx4k2wKPorlpFMkvel1k6EsV3w=; b=em8qfCZWj/Z35DmBPrwPLuae76htG10IsytlG4dJ0uv24yWXPVgdxgNx+RfLpf5eZ6YJPfktSQe51i65Q172zPmTGoaC/5LYsK99e8zXjt22EhebKL7moYfvpakLTkWyB3ce+rvIddNaQSfEf3i0cIQHys3hHux+rdjb/JY9FQEYS48+k8R3MQwCsJEV7ZiGJyt2HYr0vxfUzPIHUWuf740b+mdIfiFzk+FMEUNC7SI4yisX0nzaIqIm76TnUB6oKj54hpI7y/ir47ANmi26b8unjPjvjlL708ufpDqmOxRp4xjqv2lASYYenYTuRXd34S+UrpUHhphnxPDmAX9KJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB4987.namprd12.prod.outlook.com (2603:10b6:5:163::31) by DM6PR12MB3465.namprd12.prod.outlook.com (2603:10b6:5:3a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 20 Oct 2020 05:59:21 +0000 Received: from DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::cf2:dfd0:1877:bf3a]) by DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::cf2:dfd0:1877:bf3a%3]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020 05:59:20 +0000 From: Ori Kam To: Guy Kaneti CC: NBU-Contact-Thomas Monjalon , Smadar Fuks , "dev@dpdk.org" Thread-Topic: [PATCH v1] app/regex: change default qp configuration flags Thread-Index: AQHWpfovNFtlNny3IUiiSktClAs7fKmfBPeAgAAlDACAANXGQA== Date: Tue, 20 Oct 2020 05:59:20 +0000 Message-ID: References: <20201019092630.20460-1-guyk@marvell.com> <20201019092630.20460-2-guyk@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d86f5d6b-f2cf-4600-15d4-08d874bd49e0 x-ms-traffictypediagnostic: DM6PR12MB3465: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jtMQuntx7sKYz9HJPtdYqsZKfIZnSVNCrzKkGiXyGMWQrJBidaeOoKq3klt2gxSr8/LaKyZp+R91BE1jdL4fhf60fBT+mJc6rNakyqmDVUJ7P06mpvulJYvSsJca++mSCR4oy/uOoWydFIL+V1LWde73N5OMpZBS+I1PYIFkQpW/1EU4oxq15MvpLavxFhmAT5VStc9y3S7Awf/EJJpi9FJQ6D6IlOn2/gU4d6DHjaYeD8kAAoE4HDrwcXaOaW4R2hBZQ7raKT/HAeOadQX78rrVhbcmMCy08PQbVHQgFOibd609K4gP0IjuJudSP/sSDdj+TwUEE9qAS23m77bNZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4987.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(71200400001)(66946007)(76116006)(66476007)(5660300002)(66446008)(64756008)(66556008)(52536014)(83380400001)(86362001)(478600001)(186003)(26005)(2906002)(55016002)(6506007)(53546011)(33656002)(7696005)(4326008)(8676002)(316002)(8936002)(54906003)(6916009)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Gh49d5BWTH8FutMjYWzDE4HFOqrGmhE3N3/ddQJDp5GA61xpXpjdb7opEhZtwbwVdJM8Y03rSRn/0gXMZBbNW8NhcJ+8ObvW+kgOxOAymIKGyVTTjp6vGs7HZpVBaBSwHTlGVN7JuByDMZPVSzvl+bO5sOIFZyQ54NNfRdHhgHlIVUn9yRpdWMMXq5p7F0xUuaNPExJ+YUJx0nCm3fiAwTU8B+HEZutzMgFYvYk6Q/B5SFKzVU7VuKITzPjoWMsc1V0BCHBXYQkLlrtDq1rjwsPlPeoocv6pjN2OXF9bwpoaK1FloQltwjunMdre16/I6x+IrgXyB5HASQiolzBRxusre6EVUEhJ++5rX2GcXTYtA01tOYL+SyCT2Y9hCHKTaJw5kJZt/J2oNLiewM9uXNrzSoonVPSbTVzgoFGx5ENxEMYk0EPwdi32g9f19hRGJexNIfHMKLfu9epvwzfBcybJ7v3tDI4YTgAJJlYCIJJkmgHFIuoxI9ifGmZZeENWlRX4uAanWwJv3SbCV0oAI7VF5AjNEQhlzsXG6dfOxXYuBN4BWGuxIn7Q5huyliyMB60xQMlMIeoqfO20RE9uxzRcciDpZh6H5UX657vKKaQfP6pzpdzVfY90DMkAu91dtQaM0k5jpfhw3+8eeI9EqA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4987.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d86f5d6b-f2cf-4600-15d4-08d874bd49e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 05:59:20.9268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2d5u45+1RX4hkhZFtrqNyhLE5zAHmIJGLgY+xG4XjvdU1o1yP6dUY3UhU197dOudBv0hAwBHz4rmYFkS7UqRog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3465 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603173564; bh=QNKOS0GXcdPTjygnYUx4k2wKPorlpFMkvel1k6EsV3w=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=crRghKfS+aS6kS6KlDuf9dRHS7ee4EYtVrMqwDkYWZeHJ0xH3RUQ5N0lZ51dHRooU pQtYjnccXvvDzOcLuGX4+1oyzmWlmnI6y3K23+fbmGoPOl781dkCyPNZnFiVwVzd1O AbL8PIlIkToR1JxiVvVr1UnD6krc78v29HGLvPt+eQqnJWSftQ4ZTusOwC0zKUX97g 5aksWN95feoQwvaesbj6EZ2eLb5nmGFgLy5VJg/31bERpzBo/VsC2bCgFmQx9YTU+5 ix4DgDNO75MWBqMBHqrRId4zh/2LzkoySTRsmtSk1keZoTRky18W5jZc/BOYHd7cmc oxyxKc70PVEfw== Subject: Re: [dpdk-dev] [PATCH v1] app/regex: change default qp configuration flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Guy Kaneti > Sent: Monday, October 19, 2020 8:12 PM > Subject: RE: [PATCH v1] app/regex: change default qp configuration flags >=20 > Hi Ori, >=20 >=20 > > -----Original Message----- > > From: Ori Kam > > Sent: Monday, October 19, 2020 6:03 PM > > Subject: [EXT] RE: [PATCH v1] app/regex: change default qp configuratio= n > > flags > > > > External Email > > > > ---------------------------------------------------------------------- > > Hi Guy, > > > > > -----Original Message----- > > > From: guyk@marvell.com > > > Sent: Monday, October 19, 2020 12:27 PM > > > Subject: [PATCH v1] app/regex: change default qp configuration flags > > > > > > From: Guy Kaneti > > > > > > By default qp configuration flags was set with > > > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F. > > > Changed flags default to 0. In order to set OOS flag use new argument > > > --cfg_oos to config queue pair out of order scan. > > > > > > Signed-off-by: Guy Kaneti > > > --- > > > app/test-regex/main.c | 24 +++++++++++++++++------- > > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > > > > diff --git a/app/test-regex/main.c b/app/test-regex/main.c index > > > 0d35f4583..9b19031ea 100644 > > > --- a/app/test-regex/main.c > > > +++ b/app/test-regex/main.c > > > @@ -33,6 +33,7 @@ enum app_args { > > > ARG_NUM_OF_JOBS, > > > ARG_PERF_MODE, > > > ARG_NUM_OF_ITERATIONS, > > > + ARG_CFG_OOS, > > > }; > > > > > > static void > > > @@ -43,13 +44,15 @@ usage(const char *prog_name) > > > " --data NAME: data file to use\n" > > > " --nb_jobs: number of jobs to use\n" > > > " --perf N: only outputs the performance data\n" > > > - " --nb_iter N: number of iteration to run\n", > > > + " --nb_iter N: number of iteration to run\n" > > > + " --cfg_oos: configure regexdev queue flag out of order > > > scan\n", > > > prog_name); > > > } > > > > > > static void > > > args_parse(int argc, char **argv, char *rules_file, char *data_file, > > > - uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations) > > > + uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations, > > > + uint32_t *qp_conf_flags) > > > { > > > char **argvopt; > > > int opt; > > > @@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file, > > > char *data_file, > > > /* Perf test only */ > > > { "perf", 0, 0, ARG_PERF_MODE}, > > > /* Number of iterations to run with perf test */ > > > - { "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS} > > > + { "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}, > > > + /* configure out of order scan */ > > > + { "cfg_oos", 0, 0, ARG_CFG_OOS} > > > }; > > > > > > argvopt =3D argv; > > > @@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file= , > > > char *data_file, > > > case ARG_NUM_OF_ITERATIONS: > > > *nb_iterations =3D atoi(optarg); > > > break; > > > + case ARG_CFG_OOS: > > > + *qp_conf_flags =3D > > > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F; > > > + break; > > > case ARG_HELP: > > > usage("RegEx test app"); > > > break; > > > @@ -158,7 +166,8 @@ read_file(char *file, char **buf) > > > > > > static int > > > init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs, > > > - uint16_t *nb_max_payload, char *rules_file, uint8_t > > > *nb_max_matches) > > > + uint16_t *nb_max_payload, char *rules_file, uint8_t > > > *nb_max_matches, > > > + uint32_t qp_conf_flags) > > > { > > > uint16_t id; > > > uint16_t num_devs; > > > @@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp, > > uint32_t > > > nb_jobs, > > > }; > > > struct rte_regexdev_qp_conf qp_conf =3D { > > > .nb_desc =3D 1024, > > > - .qp_conf_flags =3D RTE_REGEX_QUEUE_PAIR_CFG_OOS_F, > > > + .qp_conf_flags =3D qp_conf_flags, > > > }; > > > int res =3D 0; > > > > > > @@ -407,6 +416,7 @@ main(int argc, char **argv) > > > bool perf_mode =3D 0; > > > uint32_t nb_iterations =3D 0; > > > uint8_t nb_max_matches =3D 0; > > > + uint32_t qp_conf_flags =3D 0; > > > int ret; > > > > > > ret =3D rte_eal_init(argc, argv); > > > @@ -416,10 +426,10 @@ main(int argc, char **argv) > > > argv +=3D ret; > > > if (argc > 1) > > > args_parse(argc, argv, rules_file, data_file, &nb_jobs, > > > - &perf_mode, &nb_iterations); > > > + &perf_mode, &nb_iterations, &qp_conf_flags); > > > > > > ret =3D init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file, > > > - &nb_max_matches); > > > + &nb_max_matches, qp_conf_flags); > > > if (ret < 0) > > > rte_exit(EXIT_FAILURE, "init port failed\n"); > > > ret =3D run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode, > > > -- > > > 2.28.0 > > > > General comment I think we should add > > capability to the rte_regexdev to check if the PMD support OOF. and hav= e > > the default based on this capability. >=20 > I agree. > Should it be returned by rte_regexdev_info_get() > And be defined as RTE_REGEXDEV_CAPA_ ? >=20 Yes this is my thinking. > > > > Best, > > Ori