From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78D3EA04B5; Thu, 29 Oct 2020 15:39:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43826CDF8; Thu, 29 Oct 2020 15:39:50 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 15BC4CDF4 for ; Thu, 29 Oct 2020 15:39:46 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 29 Oct 2020 07:39:49 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 29 Oct 2020 14:39:43 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 29 Oct 2020 14:39:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5Ogtg11zrRetGO3e9Iipg4zqerOLAIZ5rium86XOOB+MRd6AKTZmRB3v23gPNMFbPlFyZmEUaKIXjkLrnd6r1xX7DWgm6lIyyNoaUdArkGbtRGshwRg2Lrpgj1ex5HvZ+MWjgC5YOkUAjZ8qoIYV52zetbGggFp+gk+swheL1XkYhlOgVKo+pKuoZwZAslAUhGU8JptmjZZEOU0WyDTkkzdKG9A0AUokBZE1UNIy0Yy402ILwIkgilhyIo7OgV9LRbVoButEeXJ9PB8n4q9mAJTXrKVfEbHgtUwIzgKQ9u+Fb508gEEirT/zOFhakQ7DIuk9AV0ClBaAYBa7VqS8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZt9J/P+c2Zd/s6UnDmQKn5iqBJ5MLNtucc1xUYJFrI=; b=HC2J/bOJuzE5UF2At6bFnyqy+gM8SjTuhNLEe+OeZm7Bi1pI6KUBpEUWJUXY9fuhN7454i84JZ3atxcS+VvfXJq9aC34/nEALaKaOGD9C+qFa/UMyLbG9W7IYK98A4LXPmmgnF3EjrQP2+WDuv/LA0/exdsLx4ORKAVRhsEuphVEDGISKVZkY5d061747072yUFbJUsTdeJa+E5c2OeTBlKlEb8zJvv1pVtAGwXF18H866Lej7atFrg723QAcp8vSh7Tmu9yIfkBMzMnWZ0SH39195WXsCqNDNnolEHZXWqGIh/eZtHeWyqgH7o52zr2Zb5Hv4/WvhwE917cz/5SBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB4987.namprd12.prod.outlook.com (2603:10b6:5:163::31) by DM6PR12MB4155.namprd12.prod.outlook.com (2603:10b6:5:221::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Thu, 29 Oct 2020 14:39:42 +0000 Received: from DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::cf2:dfd0:1877:bf3a]) by DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::cf2:dfd0:1877:bf3a%3]) with mapi id 15.20.3499.027; Thu, 29 Oct 2020 14:39:42 +0000 From: Ori Kam To: Andrew Rybchenko , "dev@dpdk.org" CC: Andrey Vesnovaty , NBU-Contact-Thomas Monjalon , Ferruh Yigit , Ray Kinsella , Neil Horman , Andrew Rybchenko Thread-Topic: [PATCH] ethdev: deprecate shared counters using action attribute Thread-Index: AQHWrdEB0zXIv7HhnkuWHfQb7+UaPamuohIQ Date: Thu, 29 Oct 2020 14:39:42 +0000 Message-ID: References: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: solarflare.com; dkim=none (message not signed) header.d=none;solarflare.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2bef0ed-72ec-4ec3-7909-08d87c1878e3 x-ms-traffictypediagnostic: DM6PR12MB4155: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mO/GbckvuaB/EiSogIxopzPoRND+vsG5GRANwRFYzWow2lZssCrnpjxwxD2I26v42QWs0aM/KULhk6Ohl0RC1z5r6nilk8KcXjFGY9vc0JU/Wt+3cDANmR9SWC+bU0hXfLUos074C6YXpcI1+OFMyehJz7+4veUQtL1lyPlLKlTpzj4LosKNgRAWM6ZE3QnZNW1pO6C+ISpzoRpByvkJY3n/auuxw2qEWf/37wxz6oslEJPlcA9RIWCeMXSX3lKqWIvoRg+8ahblUBcInRyzK8BZ+Xu0RIzFYS57ejIKYp9DpDR+oSB/pI4QJ9FtH0CuvY+Ejw+8qJ+3tTuqD8cCCw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4987.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39860400002)(346002)(396003)(136003)(478600001)(86362001)(33656002)(71200400001)(4326008)(8676002)(2906002)(9686003)(26005)(66946007)(76116006)(316002)(8936002)(5660300002)(64756008)(186003)(83380400001)(66556008)(52536014)(54906003)(66476007)(55016002)(66446008)(53546011)(110136005)(6506007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: QAn6dkqOt6yxZCN8AEz/kuRWVTSmouCDtjGu7uwP7zyXfS5CnMEDW9SCTiDEC3VMG+Wr+YUmYTR/+XBSgGOCqhsUszXmA8ECF2Q+6ogJA0SjwzqLPEj2Is7v6z23s315qd9qNzyIq41/7Ephsbf0wyG4WE5234Yo3SVTSP/g61u4uNiB8ZeTfHV4LJTqhqhANLu9G8H65tYHWLG+BhU8nwx9RKBU6dEdJY/gK46szOlYxpGMfPwenUa6aHh+5CQAkPwRE+AwGwX4czcWXk41LjLgci+p+VTRYHsmLAsoABBGAawHrYblDJLaL+QAu0ltdWAa32HCvfl2E33NVNkK/9Vurp6D2goqV1VpkB8PGW7jbq+qc8b6iHDtwV19orq20FEAMTLVxF9zKBiG3vndxFfUJG75iZa4q5UgcbhaoGJ1peSqO67FYBpuOQceBrxO5HaY4++6dzOmytRXJjwxOkXGe5zpkNjafEFfQK2Tb0F4JjbS1rhLDKyGtEmAU6/WW1Co7S3oQA2TVprO+xoOf/8AAFiSuaF+C+hqpS/L+hZHLMJbAwZNCmGV2SJrmCD0Hxwfz6fNHpQ7kdwf2XlgRshl8e5iUBXf02DivNg1ZdLzaOwKcUgCNkF6q4K6iJG6sm4UjpP5gi0VRmIIcz8fbw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4987.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2bef0ed-72ec-4ec3-7909-08d87c1878e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 14:39:42.1378 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oQI1DIrfCkihbt/OUZmTBZRnXd7qMnigZcO0ApexgYOi0+a0kXSKsqxzOecUG7kXKFupLCFwovceCLWMhdxwbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4155 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603982389; bh=uZt9J/P+c2Zd/s6UnDmQKn5iqBJ5MLNtucc1xUYJFrI=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Dt3MbTqH00TlGIUqgP5qUZT4SohRD9i+eXVMsJoPeV8iH2Fiu6BHOHy5zIYVw9DMB OMYukWmg5TIZ7sJNrSuCxFAMYaBEc7zF0KqTyTCChpb3+GahgiRMbVTS6PJoHijPXM V07pzlWBk1As0ebzruR7SzAhT4Fb5Cdv9VN4gmM3hJPfPwBQHlC4onVRbyC9cZsIjl bzAG13hjqup+mwdPppL0R18cg26uG1AMnfK+7Fc7+RS9UngoyrU4H9gubQ5aaenJXW hFawDBJH4QwKrPaiU/iUQKL+jlU9Eg3jvVz6r4jkGZer2hbyP4vpNxFmc+8+6bedRM PyuKuZTpcT2hA== Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, > -----Original Message----- > From: Andrew Rybchenko > Sent: Thursday, October 29, 2020 10:53 AM > Subject: [PATCH] ethdev: deprecate shared counters using action attribute >=20 > A new generic shared actions API may be used to create shared > counter. There is no point to keep duplicate COUNT action specific > capability to create shared counters. >=20 > Signed-off-by: Andrew Rybchenko > --- > In fact, it looks like the next logical step is to remove > struct rte_flow_action_count completely since counter ID makes > sense for shared counters only. I think it will just make it > easiser to use COUNT action. Comments are welcome. >=20 > doc/guides/rel_notes/deprecation.rst | 4 ++++ > lib/librte_ethdev/rte_flow.h | 6 +++++- > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 2e082499b8..4f3bac1a6d 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -138,6 +138,10 @@ Deprecation Notices > will be limited to maximum 256 queues. > Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be > removed. >=20 > +* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count`` > + is deprecated and will be removed in DPDK 21.11. Shared counters shoul= d > + be managed using shared actions API (``rte_flow_shared_action_create`` > etc). > + > * cryptodev: support for using IV with all sizes is added, J0 still can > be used but only when IV length in following structs > ``rte_crypto_auth_xform``, > ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or= equal > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index a8eac4deb8..2bb93d237a 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -2287,6 +2287,9 @@ struct rte_flow_query_age { > * Counters can be retrieved and reset through ``rte_flow_query()``, see > * ``struct rte_flow_query_count``. > * > + * @deprecated Shared attribute is deprecated, use generic > + * RTE_FLOW_ACTION_TYPE_SHARED action. > + * > * The shared flag indicates whether the counter is unique to the flow r= ule the > * action is specified with, or whether it is a shared counter. > * > @@ -2299,7 +2302,8 @@ struct rte_flow_query_age { > * to all ports within that switch domain. > */ > struct rte_flow_action_count { > - uint32_t shared:1; /**< Share counter ID with other flow rules. */ > + /** @deprecated Share counter ID with other flow rules. */ > + uint32_t shared:1; > uint32_t reserved:31; /**< Reserved, must be zero. */ > uint32_t id; /**< Counter ID. */ > }; > -- > 2.17.1 As much as I agree with your patch, I don't think we should push it since not all PMD made the move to support count action, so the application still= needs to use this API. I think this patch should be done but in next LTS release. Best, Ori