DPDK patches and discussions
 help / color / mirror / Atom feed
From: Guy Kaneti <guyk@marvell.com>
To: Ophir Munk <ophirmu@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Smadar Fuks <smadarf@marvell.com>,
	Dovrat Zifroni <dovrat@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities
Date: Thu, 22 Oct 2020 11:12:34 +0000	[thread overview]
Message-ID: <DM6PR18MB24109E5F5668EC20E86C477FD81D0@DM6PR18MB2410.namprd18.prod.outlook.com> (raw)
In-Reply-To: <DM5PR12MB1161969690EB327D9791497FDC1D0@DM5PR12MB1161.namprd12.prod.outlook.com>

Hi,

The patch was not merged yet:
https://patches.dpdk.org/patch/81673/

I will rebase this patch once it is merged.

Regards,
Guy 

> -----Original Message-----
> From: Ophir Munk <ophirmu@nvidia.com>
> Sent: Thursday, October 22, 2020 1:53 PM
> To: Ori Kam <orika@nvidia.com>; Guy Kaneti <guyk@marvell.com>
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Smadar Fuks
> <smadarf@marvell.com>; Dovrat Zifroni <dovrat@marvell.com>;
> dev@dpdk.org
> Subject: [EXT] RE: [PATCH v1] app/regex: configure qp according to device
> capabilities
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Guy,
> I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in
> latest dpdk/main. As a result my compilation is broken.
> Can you please assist?
> 
> Regards,
> Ophir
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Ori Kam
> > Sent: Tuesday, October 20, 2020 12:14 PM
> > To: guyk@marvell.com
> > Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> > smadarf@marvell.com; dovrat@marvell.com; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according
> > to device capabilities
> >
> >
> > Hi Guy,
> >
> > > -----Original Message-----
> > > From: guyk@marvell.com <guyk@marvell.com>
> > > Sent: Tuesday, October 20, 2020 12:10 PM
> > > Subject: [PATCH v1] app/regex: configure qp according to device
> > > capabilities
> > >
> > > From: Guy Kaneti <guyk@marvell.com>
> > >
> > > configure qp with OOS according to device capabilities returned from
> > > rte_regexdev_info_get.
> > >
> > > Signed-off-by: Guy Kaneti <guyk@marvell.com>
> > > ---
> > >  app/test-regex/main.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/app/test-regex/main.c b/app/test-regex/main.c index
> > > e6080b44b..3deaf3c80 100644
> > > --- a/app/test-regex/main.c
> > > +++ b/app/test-regex/main.c
> > > @@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp,
> > uint32_t
> > > nb_jobs,
> > >  	};
> > >  	struct rte_regexdev_qp_conf qp_conf = {
> > >  		.nb_desc = 1024,
> > > -		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
> > > +		.qp_conf_flags = 0,
> > >  	};
> > >  	int res = 0;
> > >
> > > @@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp,
> > uint32_t
> > > nb_jobs,
> > >  			printf("Error, can't configure device %d.\n", id);
> > >  			goto error;
> > >  		}
> > > +		if (info.regexdev_capa &
> > > RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
> > > +			qp_conf.qp_conf_flags |=
> > > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
> > >  		res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
> > >  		if (res < 0) {
> > >  			printf("Error, can't setup queue pair for device
> > %d.\n",
> > > --
> > > 2.28.0
> >
> > Acked-by: Ori Kam <orika@nvidia.com>
> > Best,
> > Ori

  parent reply	other threads:[~2020-10-22 11:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  9:10 guyk
2020-10-20  9:14 ` Ori Kam
2020-10-22 10:53   ` Ophir Munk
2020-10-22 10:57     ` Ophir Munk
2020-10-22 11:12     ` Guy Kaneti [this message]
2020-11-03  0:40   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR18MB24109E5F5668EC20E86C477FD81D0@DM6PR18MB2410.namprd18.prod.outlook.com \
    --to=guyk@marvell.com \
    --cc=dev@dpdk.org \
    --cc=dovrat@marvell.com \
    --cc=ophirmu@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=smadarf@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).