From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24E4FA0561; Sun, 19 Apr 2020 12:39:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AA081D634; Sun, 19 Apr 2020 12:39:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id BDA761D5ED for ; Sun, 19 Apr 2020 12:39:48 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03JActAT024925; Sun, 19 Apr 2020 03:38:55 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-0016f401.pphosted.com with ESMTP id 30g12nk17r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 19 Apr 2020 03:38:55 -0700 Received: from m0045851.ppops.net (m0045851.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 03JAcsen024920; Sun, 19 Apr 2020 03:38:55 -0700 Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 30g12nk17p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 19 Apr 2020 03:38:54 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 19 Apr 2020 03:38:52 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 19 Apr 2020 03:38:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6zFmZZ9SBN0W9UQME92Q0kXLrDDuwqgzwedjFjdtob/3KESsIdJkkahruGdKW9Pr4271CFeH7yZocYDhLCUIzR+nUX563smklN5FR21a8E71lp2eZLiWbKGtr3YuBdT9M0MGsPPf3odkO8gyP51HTOWsKB7DfAeN+7S5/DSy3uM0pAXAczf0lG9AXB8bYfUZABVDhIVK6A3AYUfZDKIXNeUUeew2OKkEHqiMnAw067HEKNSQRTCyfqAR9PGKDBjWyo0sX9kC3pf+zmqoZ+49ax7J3zShAa66QM39FMZaAQbL4HZJm10/lV1vlWmKG3Lg4FE+kKEPOjn2rZQ+6gspg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=546/k0Xf9Zo8PkhkHRmm8otAQsHJZ+lUoigAVEqn2r4=; b=EToS14dCb2Ts2umd7CmWw2nGt58Yw6HpJHOXX5t9IZKc1h1YfywZwESX4uW4axXV+zLdZNsxby5itD7eMxsfv8gzsplFWYuivL0jlbXBah6HonCNCphHtHEOGtVbfN38/lTBh74yQfdk/eTcqimozWUIb+1ktfngOHjx1G1izqAJ6sa13FRYzhvplX994qCphQ1l1jFLV/kdYvgRCO6RPySccvP6b0HSismTZfzIBSSXSKz93k2U1gj2sFvKQJm/XkIcIaYy4BiSgjRpJdLrLIBBb3NkWfwdTLAArFD8ofBpaBfdgff1nTk+yGgrdPgAQZznJ2ExCdgR2GQoTE0pdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=546/k0Xf9Zo8PkhkHRmm8otAQsHJZ+lUoigAVEqn2r4=; b=bGjVFnLcx3PJT/7DYf2bfip3VIUfJu5KpJjCPLUa7tf/B6Zt3NaRV7QOe+YL738wy3pMsx+ueHN6KjKAeyXC2Gmp05BpCXD39rxsRwePuQe7zaZUEINw+g7cdWvCFCQjjZys/mWz0YyppJp9GHJQE+NKzmRF1XGqrbcnI23t+Tk= Received: from DM6PR18MB2410.namprd18.prod.outlook.com (2603:10b6:5:187::16) by DM6PR18MB2412.namprd18.prod.outlook.com (2603:10b6:5:185::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Sun, 19 Apr 2020 10:38:51 +0000 Received: from DM6PR18MB2410.namprd18.prod.outlook.com ([fe80::60e0:765a:d168:e1ec]) by DM6PR18MB2410.namprd18.prod.outlook.com ([fe80::60e0:765a:d168:e1ec%7]) with mapi id 15.20.2921.027; Sun, 19 Apr 2020 10:38:51 +0000 From: Guy Kaneti To: Ori Kam , Thomas Monjalon , "Jerin Jacob Kollanukkaran" , "xiang.w.wang@intel.com" , Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , "Parav Pandit" Thread-Topic: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions Thread-Index: AQHWDYFTIeUx/l0OeUiyyYOhuBv0x6h7q2ig Date: Sun, 19 Apr 2020 10:38:51 +0000 Message-ID: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2061995.157zFVKu8G@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [176.231.70.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 608c81bc-8ccf-410f-3375-08d7e44dd9c9 x-ms-traffictypediagnostic: DM6PR18MB2412: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0378F1E47A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR18MB2410.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(136003)(39850400004)(396003)(346002)(366004)(5660300002)(186003)(81156014)(66446008)(86362001)(64756008)(66476007)(8936002)(66556008)(71200400001)(66946007)(478600001)(52536014)(76116006)(33656002)(26005)(110136005)(54906003)(9686003)(6636002)(55016002)(4326008)(7406005)(7416002)(6506007)(7696005)(2906002)(53546011)(316002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qgkRZmLLKladJdWsVffjK2OxMAXxjB6djunBbeOcFJrTrVEYm54YbxTCKe2P/oMVT1lxicdY9XcMf1S8o1Wp1fBA+E3inAdQ3uq8DZ43aWiJvsHK0wMVBo3Q2Ed0Y/gN7PM1SC+oMplAnT11ssd4wchNgrQmFkJTt9Mxvc6yupI7rdo/FE75C6hqnqzUgFapO1qakLXx5bas2ZaNpyG5vyfm0p4WK07z+4/DKYOhTifsKONg6+oB8yjhOSX+p0Eaoj1P9Wr3IF23oCP1o3p+FMCoI5HOLxsHiV3EejoR0m5CyzJuiF/DN1bpSyfsrxJuYb57ivFhRXSmbyeQTIEAtIVIaf1hQ1A2zgnTjZMRMYxtltJc1nF8/XXy8TJxyLh9j9/vuEmeglo7FbEbCM9fdTepu2PKKFFNOD4d2X2l/OoAUMKF1b128p1aplywcgLT x-ms-exchange-antispam-messagedata: 2SUFxp+sYsLtwr09NoKEnsll+Y6/o1umyL2Db5fGgJrFTCQ0iweDZe9AwGKTrRNp191NSdz9VcjlburcSCx2gYUtx9cVd2r6tYi7wOWyN4FPhj7A14YZbtd2U7GWr5mj8eBFRcn4QKPWiLcQW49ahQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 608c81bc-8ccf-410f-3375-08d7e44dd9c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2020 10:38:51.2161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sWQiAlWU8IgXOxdmRGD+ftMEj55JTXrwGaUAAPgJgsDGTUNLnIQp1hc3qO/5PKb3SZSrUcSr+l0TzrXXsWNrcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2412 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-19_02:2020-04-17, 2020-04-19 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Ori Kam > Sent: Wednesday, April 08, 2020 11:40 AM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > ; xiang.w.wang@intel.com; Pavan Nikhilesh > Bhagavatula > Cc: dev@dpdk.org; Shahaf Shuler ; > hemant.agrawal@nxp.com; Opher Reviv ; Alex > Rosenbaum ; Dovrat Zifroni ; > Prasun Kapoor ; nipun.gupta@nxp.com; > bruce.richardson@intel.com; yang.a.hong@intel.com; > harry.chang@intel.com; gu.jian1@zte.com.cn; shanjiangh@chinatelecom.cn; > zhangy.yun@chinatelecom.cn; lixingfu@huachentel.com; > wushuai@inspur.com; yuyingxia@yxlink.com; > fanchenggang@sunyainfo.com; davidfgao@tencent.com; > liuzhong1@chinaunicom.cn; zhaoyong11@huawei.com; oc@yunify.com; > jim@netgate.com; hongjun.ni@intel.com; j.bromhead@titan-ic.com; > deri@ntop.org; fc@napatech.com; arthur.su@lionic.com; Parav Pandit > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > functions >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Thomas Monjalon > > Sent: Monday, April 6, 2020 4:30 PM > > To: Ori Kam ; Jerin Jacob Kollanukkaran > > ; xiang.w.wang@intel.com; Pavan Nikhilesh > > Bhagavatula > > Cc: dev@dpdk.org; Shahaf Shuler ; > > hemant.agrawal@nxp.com; Opher Reviv ; Alex > > Rosenbaum ; Dovrat Zifroni > ; > > Prasun Kapoor ; nipun.gupta@nxp.com; > > bruce.richardson@intel.com; yang.a.hong@intel.com; > > harry.chang@intel.com; gu.jian1@zte.com.cn; > > shanjiangh@chinatelecom.cn; zhangy.yun@chinatelecom.cn; > > lixingfu@huachentel.com; wushuai@inspur.com; yuyingxia@yxlink.com; > > fanchenggang@sunyainfo.com; davidfgao@tencent.com; > > liuzhong1@chinaunicom.cn; zhaoyong11@huawei.com; oc@yunify.com; > > jim@netgate.com; hongjun.ni@intel.com; j.bromhead@titan-ic.com; > > deri@ntop.org; fc@napatech.com; arthur.su@lionic.com; Parav Pandit > > > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev > > core functions > > > > 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > > > From: Pavan Nikhilesh Bhagavatula > > > >> >> From: Pavan Nikhilesh Bhagavatula > > > >> >> > > > >> >> Looks like this implementation is incomplete? > > > >> >> I don't see any pmd specific helper functions for @see > > > >> >rte_cryptodev_pmd.c, > > > >> >> rte_eventdev_pmd* > > > >> >> > > > >> >I think the current implementation includes all needed > > > >> >functions, at least for the first stage. > > > >> >You can find in rte_regexdev_driver.h the functions that should > > > >> >be called by the PMD. We have the register / unregister which > > > >> >acts the same > > > >as > > > >> >create > > > >> >and destroy. For parsing argument the PMD may call > > > >rte_kvargs_parse. > > > >> > > > > >> > > > >> _driver.h should atleast include > > > >> rte_regex_dev_pci_generic_probe/rte_regex_pmd_vdev_init > > > >> else there would be a lot of code repetition and possibly > > > >> udefined > > > >behavior > > > >> at the driver layer. > > > >> > > > >Why should they be included? At least in this stage, there is no > > > >code to share ethdev why should we add code for the vdev? > > > > > > Ok I think I failed to communicate my concerns across. > > > Let me retry > > > > > > 1. SW based regex devices such as PCRE/Hyperscan rely on vdev > > > framework i.e. user needs to pass an EAL argument > > > --vdev=3D"regex_pcre" for the driver to initialize all the other EAL > > > subsystems (ethdev, eventdev, cryptodev, > > etc..)support this. > > > > vdev helpers do not have to be part of the first patches which define A= PI. > > It should be added when adding the first vdev driver. > > > > > 2. HW based independent regex devices that are exposed as PCI > > > devices > > would need > > > pci probe helpers. > > > > Same, PCI helpers can be added while adding the first PCI driver. > > > > We can synchronize about how to split the work, avoiding two > > developers doing the same thing. But let's not mandate this work to be > > done as part of this first series. > > > > > I agree with Thomas, let's discuss this when adding the PMDs. I am writing a now the Marvell OcteonTx2 PMD and I think that a PCI helper = is missing. When registering a PCI device, a .remove function is registered of type pci= _remove_t *remove; typedef int (pci_remove_t)(struct rte_pci_device *); because this function receives struct rte_pci_device * as an argument=20 It is required to have a helper function to retrieve struct rte_regexdev *d= ev based on the device name (or another way). similar to rte_cryptodev_pmd_get_named_dev(const char *name)