From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A49EA04DC; Mon, 19 Oct 2020 19:12:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90756A98D; Mon, 19 Oct 2020 19:12:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AA354A979 for ; Mon, 19 Oct 2020 19:12:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09JH5WHe031746; Mon, 19 Oct 2020 10:12:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=Y13hMI5i82H7tyjIHeQWB1cCuo9VEX6/18Uxz1OopZQ=; b=Epqg9hx2PHQy3dTnbeqKSxj9ZMsmduD5kZZvHBzkauDUwmNRDu9qtIhjo9+k/67Vnxys uugNl/vE/YOjMfeoO8Ysfm/nQTE+uCBmAo3br7mbCNL8/SHofqJWLzAxxRcsF/iTCqOJ Tk4UI4ezUe+6vnu2ISr15TfonCgI1JYGtpJ0P2d/ht+BzY296X2OX13+S1eEWDeGN6lr fw5Z1pJBfzTrCXUY2jLbwVEVhVDARvZLm311bJMBvk3zFxVnufyGMlwevBewpXwvWskg 0723QedAhEPMraegGaDx6Mb5kNhSc1b7Gs67zmzPpRwbUkPOAY7fW/NcDDZ1BXdnpOtV Pg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 34804nnq05-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 19 Oct 2020 10:12:15 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 19 Oct 2020 10:12:14 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 19 Oct 2020 10:12:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mq5QyaV3nTZuVpzQuhVcMncjdAnLGIi36ucgUxrVwdvUhsPMntEGYpqzcHd92dD3jb7kXr5QZ8nq7S/4ooAavHgXW3rff1uuit4k27oc2zW2RRYVM0KQ2wLdNjEkRJQij+jOhuyDsq1PCaRdvZ1br/uUfTgQS40kgVLP+MD4h9CZw/jkfJpWql+mUsuBVF3+fGBpc7dQv+KmUHe5RpcE401ocsjYQbK5YBIU/RGzZUd3AcyymEaoG7oOcgWLvKJ8CVjOvPlgWgjdGFh6N29Dw0W3q1ow/vFTr3czY1cUAupNTee73ncxyvnczq+g5XnI+vubYgC2Ms4hvXqWVhiS+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y13hMI5i82H7tyjIHeQWB1cCuo9VEX6/18Uxz1OopZQ=; b=IQ+eGlAneQpXHDCHnO7irQxhhYlUrk/xOgqHMM45zNAw4duW8SmhcdwRqfJfAScXnr0gYyEoax1vvdejpI/5ICAAXsARva/GmWyWaK4ClRZWFCT6KHyp/R2z8KHJmtxKs2QIPo5U49K1wnoY1cVhyVtDEEKLAeb5WjN5ghA0EpHvmYNQczuHbzgAXMluWabhe0zJL51F7xLbHtT73xLj+t7uc+o1Mw9YAoNtAyG1opLkvzT0tw2+xU+qPhg9l4Gn2sFenq8T9YQaEN2diPum2vv9sXHhaP/bQDRxlxVCeorVNDwLfFK0d6poF0jDDb5EfK77rWBUjUAEMRe4RFfwWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y13hMI5i82H7tyjIHeQWB1cCuo9VEX6/18Uxz1OopZQ=; b=dNG8DesHc4Wgw/vxGTob/z7k6O2r+xrJey70AUlbwo/INaFbR3PXhtsiy1ZjYkA0Fw3U+Lpi5w3DEFmunkC0PlI5lI6gm9pnXz3ZzImiCPYZ0oCXtuxBEwdjWmj+h2nNxpQSgG37B4bcNCZQtuceWeFfACghrMZh5t8nNdEPjRs= Received: from DM6PR18MB2410.namprd18.prod.outlook.com (2603:10b6:5:187::16) by DM5PR18MB1164.namprd18.prod.outlook.com (2603:10b6:3:31::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.23; Mon, 19 Oct 2020 17:12:12 +0000 Received: from DM6PR18MB2410.namprd18.prod.outlook.com ([fe80::e184:1839:91a0:cd59]) by DM6PR18MB2410.namprd18.prod.outlook.com ([fe80::e184:1839:91a0:cd59%7]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 17:12:12 +0000 From: Guy Kaneti To: Ori Kam CC: NBU-Contact-Thomas Monjalon , Smadar Fuks , "dev@dpdk.org" Thread-Topic: [PATCH v1] app/regex: change default qp configuration flags Thread-Index: AQHWpfolUWB2ySoTXky54yaOz+0lCKmfBgkAgAAg+wA= Date: Mon, 19 Oct 2020 17:12:12 +0000 Message-ID: References: <20201019092630.20460-1-guyk@marvell.com> <20201019092630.20460-2-guyk@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [176.231.67.98] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c3b389c-77a8-42a1-5699-08d874521ee6 x-ms-traffictypediagnostic: DM5PR18MB1164: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vL9zX+lQnLOebLcXDO5yKwjTTDYFC7WaLwzW5mcYQI3b3IpPQu6DK8SRKx/K7WbcYvMTeUyQrfA8mwu0hkHYTuBp2I0wxhEINcRSsx9P8bybf8THGij6PV5Od0Q5DRCXOyRgsI+UodxA32TGaKxj+3p0Pv3heqwTXbpusx+RzVUnBZRUY1p3msjkmgviCx83sQJ00No+uAqZ26mMqhxxSnQrvrRhcTxhbq2Z+xxfIX+oDN7DMbfWiqSwLpmpP/wzQwSl+R+GhiNj24dBlY4U2q1T7AdpKA/HLHCO2lCKi1uwh9HGvStJp+/aiQu3Cvhnu83DLeD7MCw9kKtfrdSk4w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR18MB2410.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(396003)(39850400004)(136003)(5660300002)(2906002)(55016002)(4326008)(71200400001)(8936002)(316002)(54906003)(186003)(33656002)(9686003)(86362001)(66946007)(8676002)(6506007)(53546011)(7696005)(26005)(478600001)(76116006)(6916009)(66476007)(66556008)(83380400001)(66446008)(64756008)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DVDMiOeLIyna/mW4iqXsMLU2d4K3NpvoX07Aqhw0K2GXaviHj8l5pGHd2JspaAIcX8T6BJzQtW8X79lBaRA023hqg18/XKIELpmgx8+Al14vMOsuz+Bu5GJhFflT+OYARsvNaitLMazf8A2xia58BWT0JNKbHji9L8WqamfRKH5pu2Xc6P0VJs7uBHdOGzHd8loaCXEDassN8RM99nXkajLTD1I9DqecH+UE4Cxep2hxyeM9qBjCo6LYNeWDPcO3PUIZGsVOxjXy+pAQ8o/A0D+tP7YMoTppk2qACC89VANrk5L38sLr+M9pCRlJQQdTZlxUzz/0Ln2ipCuMSWjhpWAemvC+CABxZsVwNglVaNssxsNuiuM7U8fTL7A8i5c0kEP9AM/sMidak/YINWC0sS9kMwpaQjunCtKNtrzU+m2T1nuYJ8h1FX3G1chyfxTk13xlnhxyilCwcbyvNzvGkuUIMZX4m0DV8C/Vbzqbh6BZWjax4hZ9kUsheN7ErQ+8rZBiRKFVqVXZkNAO2iUC4znzqrJWsub5nguhLLuvBNPse8oqcqLxIgQJ/t+bN4GAUjt5h48Pctx1135YPZdhUHNPUYsmH2k42UUDHfKPTRKn3OcMmS5Z1x3v/KXOv2poGonNA2uGEumw5a4ryTn0MQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB2410.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c3b389c-77a8-42a1-5699-08d874521ee6 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 17:12:12.6268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xbJihvqPw6jylKzYaLcNhXg+Y+nHS2fGC/hD4I88c80IMeNrk3aGyGywUeWkwIhOeq3Ikcd0PBDo+aR66v24TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1164 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-19_07:2020-10-16, 2020-10-19 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1] app/regex: change default qp configuration flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, > -----Original Message----- > From: Ori Kam > Sent: Monday, October 19, 2020 6:03 PM > To: Guy Kaneti ; orika@mellanox.com > Cc: NBU-Contact-Thomas Monjalon ; Smadar Fuks > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH v1] app/regex: change default qp configuration > flags >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Guy, >=20 > > -----Original Message----- > > From: guyk@marvell.com > > Sent: Monday, October 19, 2020 12:27 PM > > Subject: [PATCH v1] app/regex: change default qp configuration flags > > > > From: Guy Kaneti > > > > By default qp configuration flags was set with > > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F. > > Changed flags default to 0. In order to set OOS flag use new argument > > --cfg_oos to config queue pair out of order scan. > > > > Signed-off-by: Guy Kaneti > > --- > > app/test-regex/main.c | 24 +++++++++++++++++------- > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > > diff --git a/app/test-regex/main.c b/app/test-regex/main.c index > > 0d35f4583..9b19031ea 100644 > > --- a/app/test-regex/main.c > > +++ b/app/test-regex/main.c > > @@ -33,6 +33,7 @@ enum app_args { > > ARG_NUM_OF_JOBS, > > ARG_PERF_MODE, > > ARG_NUM_OF_ITERATIONS, > > + ARG_CFG_OOS, > > }; > > > > static void > > @@ -43,13 +44,15 @@ usage(const char *prog_name) > > " --data NAME: data file to use\n" > > " --nb_jobs: number of jobs to use\n" > > " --perf N: only outputs the performance data\n" > > - " --nb_iter N: number of iteration to run\n", > > + " --nb_iter N: number of iteration to run\n" > > + " --cfg_oos: configure regexdev queue flag out of order > > scan\n", > > prog_name); > > } > > > > static void > > args_parse(int argc, char **argv, char *rules_file, char *data_file, > > - uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations) > > + uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations, > > + uint32_t *qp_conf_flags) > > { > > char **argvopt; > > int opt; > > @@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file, > > char *data_file, > > /* Perf test only */ > > { "perf", 0, 0, ARG_PERF_MODE}, > > /* Number of iterations to run with perf test */ > > - { "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS} > > + { "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}, > > + /* configure out of order scan */ > > + { "cfg_oos", 0, 0, ARG_CFG_OOS} > > }; > > > > argvopt =3D argv; > > @@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file, > > char *data_file, > > case ARG_NUM_OF_ITERATIONS: > > *nb_iterations =3D atoi(optarg); > > break; > > + case ARG_CFG_OOS: > > + *qp_conf_flags =3D > > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F; > > + break; > > case ARG_HELP: > > usage("RegEx test app"); > > break; > > @@ -158,7 +166,8 @@ read_file(char *file, char **buf) > > > > static int > > init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs, > > - uint16_t *nb_max_payload, char *rules_file, uint8_t > > *nb_max_matches) > > + uint16_t *nb_max_payload, char *rules_file, uint8_t > > *nb_max_matches, > > + uint32_t qp_conf_flags) > > { > > uint16_t id; > > uint16_t num_devs; > > @@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp, > uint32_t > > nb_jobs, > > }; > > struct rte_regexdev_qp_conf qp_conf =3D { > > .nb_desc =3D 1024, > > - .qp_conf_flags =3D RTE_REGEX_QUEUE_PAIR_CFG_OOS_F, > > + .qp_conf_flags =3D qp_conf_flags, > > }; > > int res =3D 0; > > > > @@ -407,6 +416,7 @@ main(int argc, char **argv) > > bool perf_mode =3D 0; > > uint32_t nb_iterations =3D 0; > > uint8_t nb_max_matches =3D 0; > > + uint32_t qp_conf_flags =3D 0; > > int ret; > > > > ret =3D rte_eal_init(argc, argv); > > @@ -416,10 +426,10 @@ main(int argc, char **argv) > > argv +=3D ret; > > if (argc > 1) > > args_parse(argc, argv, rules_file, data_file, &nb_jobs, > > - &perf_mode, &nb_iterations); > > + &perf_mode, &nb_iterations, &qp_conf_flags); > > > > ret =3D init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file, > > - &nb_max_matches); > > + &nb_max_matches, qp_conf_flags); > > if (ret < 0) > > rte_exit(EXIT_FAILURE, "init port failed\n"); > > ret =3D run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode, > > -- > > 2.28.0 >=20 > General comment I think we should add > capability to the rte_regexdev to check if the PMD support OOF. and have > the default based on this capability. I agree.=20 Should it be returned by rte_regexdev_info_get() And be defined as RTE_REGEXDEV_CAPA_ ? >=20 > Best, > Ori