From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 749CC1B3B0 for ; Tue, 8 Jan 2019 06:32:17 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x085PFJE024754; Mon, 7 Jan 2019 21:32:16 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Vb5jENq/Q2dVoIKlrDBn1tmHzlw0gfKNWfuaOpjDGnc=; b=dVv/VikFLwNNU57RvQUEsp0B0ywBZ9b2SqQ0nhpArGD8P8BNjKTBr04VxTuW6HFHYdt2 9O4OmMdPc4xe+i7wxl+DEQ8EhK40nBM38E4Lay44YLW1dKyqZWsDH9ImtZ7aiRV4qJ0/ MJTIlSHwN/3mBRq4xXPvw/gUSJNaZpGTfU8ijaozctsvIFjp2qRjEk+LpYXf9sUck9eq 2C3K1L57ZGTIoRwQxSOCy+LyFEtzJLx3mMXPCMHHCBzJDIA6MwrT+tAwqrCQChzNYk36 j5nVJAv5/10jjBY2AU+7CtQjbF7oILJtREKlIdzFdiaB2G4bYqGRkdNTDDfIrNELTf/l 9g== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2pvh7jhb4y-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 07 Jan 2019 21:32:16 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 7 Jan 2019 21:32:15 -0800 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.51) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 7 Jan 2019 21:32:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vb5jENq/Q2dVoIKlrDBn1tmHzlw0gfKNWfuaOpjDGnc=; b=V7zSHiZJ9KmC6NkZSRXXx06MkhF0vBcmLeXN6kWehbrihqgdOvJ/e9Zn+ScmF56XYLKQ0HpJoYacW/+gHynEl1hf6ryzAQIJExaSX2WYFJhDKoD0pr/Q26clImy7cnBQT9SEr6lPFf+msUjnxEZaYa6O+eEtp1DxTRMc1z48sAo= Received: from DM6PR18MB2427.namprd18.prod.outlook.com (20.179.104.21) by DM6PR18MB2859.namprd18.prod.outlook.com (20.179.52.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.9; Tue, 8 Jan 2019 05:32:13 +0000 Received: from DM6PR18MB2427.namprd18.prod.outlook.com ([fe80::11f0:6cac:aa5d:c1b7]) by DM6PR18MB2427.namprd18.prod.outlook.com ([fe80::11f0:6cac:aa5d:c1b7%3]) with mapi id 15.20.1516.010; Tue, 8 Jan 2019 05:32:12 +0000 From: Nithin Kumar Dabilpuram To: Thomas Monjalon CC: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "Jerin Jacob Kollanukkaran" Thread-Topic: [EXT] Re: [PATCH] ethdev: report error on name truncation Thread-Index: AQHUppbhtFOKYPOsVUWsd7vKUiZ53KWj42wAgAD0r+k= Date: Tue, 8 Jan 2019 05:32:12 +0000 Message-ID: References: <20190107143951.30076-1-ndabilpuram@marvell.com>, <4204389.yEGWC8VWic@xps> In-Reply-To: <4204389.yEGWC8VWic@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM6PR18MB2859; 20:5ZSnRH3xesc5lhupKUX2TV2VGeR596wHSbJMBYpMpT9TK/zFCPnxGvyvKLll44i4hPjsYj3kLjg2XQFx8ADA6PZKIfuIp/Ip8OvKhsSU6pV52Xkk3W2Mo/GLhjFSOlw6W3ZWQEBglnJuh+2FBoIOBbjUuzS6sZj5whz/z1gcJPA= x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(376002)(366004)(39850400004)(136003)(346002)(396003)(189003)(199004)(54906003)(6306002)(6916009)(9686003)(55016002)(2906002)(6246003)(476003)(8676002)(316002)(99286004)(6436002)(11346002)(446003)(4326008)(7696005)(66066001)(8936002)(33656002)(68736007)(81156014)(5660300001)(74316002)(7736002)(76176011)(305945005)(53936002)(486006)(966005)(97736004)(256004)(81166006)(25786009)(71190400001)(86362001)(478600001)(71200400001)(186003)(53546011)(6506007)(55236004)(26005)(3846002)(14444005)(14454004)(106356001)(229853002)(105586002)(6116002)(107886003)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR18MB2859; H:DM6PR18MB2427.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 1624b518-b7ad-4822-74b2-08d6752aa497 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR18MB2859; x-ms-traffictypediagnostic: DM6PR18MB2859: x-microsoft-antispam-prvs: x-forefront-prvs: 0911D5CE78 received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 1b71uKCrLZTqsmohNeQYT+xkJzq9VS39A9m4SHRSvMYvlprSbkO9trcYfLssELBhI9tap9WkUPQAriHnpheUs8RqEWL/n0zTj2/vGLDr3+rAdaZW5of6gTIaUviKzl+4DJgrvD1P3VE/Vpp9HeEp+6LrUwejjb6a0Vzsf8DuOn6rsVWtAhLNK34R87ktCeorwTr41hKTvAZG/TT1kDW55ylQWdnStwBqbD179C6AlGvZ/NpyReDnMxSlc7lJ9DxT5Pefz2jwcSARG021uucNWvYGd2ocjkbE5ZEqZ8Okn+ZBdbzxN8XPIq1pS5ehmFya spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1624b518-b7ad-4822-74b2-08d6752aa497 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2019 05:32:12.8948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2859 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-08_03:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901080042 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: report error on name truncation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 05:32:18 -0000 Hi Thomas, Sorry, missed to notice that format changed by your commit recently got ove= rridden=20 during some of our internal branch merging. I'll send a v2 with same format= . -- Thanks Nithin From: Thomas Monjalon Sent: Monday, January 7, 2019 8:20 PM To: Nithin Kumar Dabilpuram Cc: Ferruh Yigit; Andrew Rybchenko; dev@dpdk.org; Jerin Jacob Kollanukkaran Subject: [EXT] Re: [PATCH] ethdev: report error on name truncation =A0=20 External Email ---------------------------------------------------------------------- Hi, Please provide an explanation of the current behaviour. 07/01/2019 15:40, Nithin Kumar Dabilpuram: > -=A0=A0=A0=A0 snprintf(z_name, sizeof(z_name), "eth_p%d_q%d_%s", > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 dev->data->port_id, queue_id, ri= ng_name); > +=A0=A0=A0=A0 rc =3D snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d", > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 dev->device->driv= er->name, ring_name, > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 dev->data->port_i= d, queue_id); You should keep the same name format. Please check this commit: =A0=A0=A0=A0=A0=A0=A0 http://git.dpdk.org/dpdk/commit/?id=3D5e046832 =