From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 312665B34; Thu, 18 Apr 2019 09:38:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3I7ZGxX015817; Thu, 18 Apr 2019 00:38:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Ck8UVmHxBOzKljsNzGy/JDjiElrxW+bsyTxqgSqa5sc=; b=K1gbKGw8E3fhNoX3fGqmr1Y+AZm4tl3S43jW3t1TEnimxg5K5XP3Yo6xgJnOe9dV7Rb8 sCPd5On+mj/x/+sIPA/kfYx5rWfMdn7veByHEJ86DH/Epq/v0jqsUbbxySnHHhtp6pUM 9xXIxQa3a6NfhB0zbSIhXbwt0MeZs7c8Hxqi9GXI9nPCj3ql1pcKnbPSsAn7GAOo2OgH jaohqz4JYz3jjcYUno8PZr6gDOdiHu0D0hxuO5rbDIaFx82sDyx2OH+tJo4gQG8rw4c7 JL+MAOvo1vWgTvEk3cJBrS3qFw2r/mRLdEjcWMbvByAnss6zp1cyZvL1BGcKpdE8LB23 TA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2rxmp1g2jy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Apr 2019 00:38:32 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Apr 2019 00:38:31 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.59) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Apr 2019 00:38:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ck8UVmHxBOzKljsNzGy/JDjiElrxW+bsyTxqgSqa5sc=; b=qrDnznQOwaG3aTq/s/hSK5T+L2krPyuoGn2ZwdjPZgBgcxnjlw8cG5toPzLhYnh+hrA5EmeiMJMgiVnyNKJDEUV2Sm14IkKcQXGq65TZvaJ9W93raaofi+GKF7QKyhqo29U0EjgOPxl5vKId1PHsQqyxsFHdyHetH3xAG+SO1kg= Received: from DM6PR18MB2907.namprd18.prod.outlook.com (20.179.49.225) by DM6PR18MB2553.namprd18.prod.outlook.com (20.179.105.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Thu, 18 Apr 2019 07:38:30 +0000 Received: from DM6PR18MB2907.namprd18.prod.outlook.com ([fe80::e865:4e62:3650:d7f0]) by DM6PR18MB2907.namprd18.prod.outlook.com ([fe80::e865:4e62:3650:d7f0%2]) with mapi id 15.20.1792.018; Thu, 18 Apr 2019 07:38:30 +0000 From: Vivek Kumar Sharma To: Thomas Monjalon CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "stable@dpdk.org" , "intoviveksharma@gmail.com" , Stephen Hemminger , "ramirose@gmail.com" Thread-Topic: [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support Thread-Index: AQHU9PDrvO/T0FkzO0ifxnv/amY3bKZABvUAgAGAZ6g= Date: Thu, 18 Apr 2019 07:38:30 +0000 Message-ID: References: <1555240302-9771-1-git-send-email-viveksharma@marvell.com> <1555486846-20764-1-git-send-email-viveksharma@marvell.com>, <2967249.IQ5QtALfrT@xps> In-Reply-To: <2967249.IQ5QtALfrT@xps> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2405:204:1122:1858:d161:5d2:b16a:92c7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d5ef735f-f792-4895-79a0-08d6c3d0da50 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600141)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DM6PR18MB2553; x-ms-traffictypediagnostic: DM6PR18MB2553: x-microsoft-antispam-prvs: x-forefront-prvs: 0011612A55 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(376002)(136003)(39860400002)(199004)(189003)(6116002)(6436002)(99286004)(7696005)(71200400001)(33656002)(55016002)(6246003)(9686003)(4326008)(6916009)(81166006)(81156014)(8676002)(97736004)(14454004)(53936002)(478600001)(8936002)(6506007)(46003)(446003)(11346002)(76176011)(476003)(486006)(4744005)(186003)(316002)(102836004)(2906002)(25786009)(74316002)(305945005)(7736002)(71190400001)(68736007)(86362001)(229853002)(256004)(5660300002)(52536014)(99946001)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR18MB2553; H:DM6PR18MB2907.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AoA484NwSzuVoee0DwC5kUD6cShVpB0sJeGDUqH5Nk3APevJGWtnloFREyqqnt9Cmo0r63sqgXTLrHuq+k1YoNfPD+WnHkeuQIE1Zkx2Mfdon3Zs2/O7m2XjKI+iIl0tyt/UQOhT2tTZ27l0Vi2R+u6EBDwkW3zRMWDxHUInZ4kgvXKYfqPQfAGD1GORf9OXcxXZdSy7AiS+D4D6qIH7ZTUPZbMFGjxy3paVsSh6YPvZc5qCBy/0f5BBN4rtbnWmd0SJBAStRI5v63MtmPdKOtIvMEqPph6IF70thlL9kkDKeGlsaafkAdTNmhfnj5Z1rzixG+f3VD2W7VvJDlbQ67DH+zNne6P7DYcn1HDLq3hytHke9KYQ6gNez1b6bzKUEQevdhPb0JqR890Zznstctfhd9RB6cDx4rYk6IgGqEY= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d5ef735f-f792-4895-79a0-08d6c3d0da50 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 07:38:30.2234 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2553 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-18_04:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 07:38:33 -0000 >> From: Vivek Sharma =0A= >>=0A= >> Enable missing support for QinQ strip rx offload=0A= >> in vlan offload set/get methods.=0A= >>=0A= >> Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion"= )=0A= >> Cc: stable@dpdk.org=0A= =0A= >Not sure it is a fix.=0A= >The commit mentioned above allows some kind of offload config.=0A= >You are extending the offload config with support in=0A= >rte_eth_dev_set_vlan_offload().=0A= =0A= DEV_RX_OFFLOAD_QINQ_STRIP was introduced in cc9d0456b870 ("i40e: support do= uble vlan stripping and insertion"). But, the means to utilize this capabil= ity by enabling this rx offload for an ethdev was missing from the patch. T= he current patch fixes that missing functionality so that user can enable Q= inQ strip rx offload for capable devices. = From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 696F3A00E6 for ; Thu, 18 Apr 2019 09:38:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 500C91B8C7; Thu, 18 Apr 2019 09:38:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 312665B34; Thu, 18 Apr 2019 09:38:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3I7ZGxX015817; Thu, 18 Apr 2019 00:38:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Ck8UVmHxBOzKljsNzGy/JDjiElrxW+bsyTxqgSqa5sc=; b=K1gbKGw8E3fhNoX3fGqmr1Y+AZm4tl3S43jW3t1TEnimxg5K5XP3Yo6xgJnOe9dV7Rb8 sCPd5On+mj/x/+sIPA/kfYx5rWfMdn7veByHEJ86DH/Epq/v0jqsUbbxySnHHhtp6pUM 9xXIxQa3a6NfhB0zbSIhXbwt0MeZs7c8Hxqi9GXI9nPCj3ql1pcKnbPSsAn7GAOo2OgH jaohqz4JYz3jjcYUno8PZr6gDOdiHu0D0hxuO5rbDIaFx82sDyx2OH+tJo4gQG8rw4c7 JL+MAOvo1vWgTvEk3cJBrS3qFw2r/mRLdEjcWMbvByAnss6zp1cyZvL1BGcKpdE8LB23 TA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2rxmp1g2jy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Apr 2019 00:38:32 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Apr 2019 00:38:31 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.59) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Apr 2019 00:38:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ck8UVmHxBOzKljsNzGy/JDjiElrxW+bsyTxqgSqa5sc=; b=qrDnznQOwaG3aTq/s/hSK5T+L2krPyuoGn2ZwdjPZgBgcxnjlw8cG5toPzLhYnh+hrA5EmeiMJMgiVnyNKJDEUV2Sm14IkKcQXGq65TZvaJ9W93raaofi+GKF7QKyhqo29U0EjgOPxl5vKId1PHsQqyxsFHdyHetH3xAG+SO1kg= Received: from DM6PR18MB2907.namprd18.prod.outlook.com (20.179.49.225) by DM6PR18MB2553.namprd18.prod.outlook.com (20.179.105.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Thu, 18 Apr 2019 07:38:30 +0000 Received: from DM6PR18MB2907.namprd18.prod.outlook.com ([fe80::e865:4e62:3650:d7f0]) by DM6PR18MB2907.namprd18.prod.outlook.com ([fe80::e865:4e62:3650:d7f0%2]) with mapi id 15.20.1792.018; Thu, 18 Apr 2019 07:38:30 +0000 From: Vivek Kumar Sharma To: Thomas Monjalon CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "stable@dpdk.org" , "intoviveksharma@gmail.com" , Stephen Hemminger , "ramirose@gmail.com" Thread-Topic: [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support Thread-Index: AQHU9PDrvO/T0FkzO0ifxnv/amY3bKZABvUAgAGAZ6g= Date: Thu, 18 Apr 2019 07:38:30 +0000 Message-ID: References: <1555240302-9771-1-git-send-email-viveksharma@marvell.com> <1555486846-20764-1-git-send-email-viveksharma@marvell.com>, <2967249.IQ5QtALfrT@xps> In-Reply-To: <2967249.IQ5QtALfrT@xps> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2405:204:1122:1858:d161:5d2:b16a:92c7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d5ef735f-f792-4895-79a0-08d6c3d0da50 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600141)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DM6PR18MB2553; x-ms-traffictypediagnostic: DM6PR18MB2553: x-microsoft-antispam-prvs: x-forefront-prvs: 0011612A55 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(376002)(136003)(39860400002)(199004)(189003)(6116002)(6436002)(99286004)(7696005)(71200400001)(33656002)(55016002)(6246003)(9686003)(4326008)(6916009)(81166006)(81156014)(8676002)(97736004)(14454004)(53936002)(478600001)(8936002)(6506007)(46003)(446003)(11346002)(76176011)(476003)(486006)(4744005)(186003)(316002)(102836004)(2906002)(25786009)(74316002)(305945005)(7736002)(71190400001)(68736007)(86362001)(229853002)(256004)(5660300002)(52536014)(99946001)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR18MB2553; H:DM6PR18MB2907.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AoA484NwSzuVoee0DwC5kUD6cShVpB0sJeGDUqH5Nk3APevJGWtnloFREyqqnt9Cmo0r63sqgXTLrHuq+k1YoNfPD+WnHkeuQIE1Zkx2Mfdon3Zs2/O7m2XjKI+iIl0tyt/UQOhT2tTZ27l0Vi2R+u6EBDwkW3zRMWDxHUInZ4kgvXKYfqPQfAGD1GORf9OXcxXZdSy7AiS+D4D6qIH7ZTUPZbMFGjxy3paVsSh6YPvZc5qCBy/0f5BBN4rtbnWmd0SJBAStRI5v63MtmPdKOtIvMEqPph6IF70thlL9kkDKeGlsaafkAdTNmhfnj5Z1rzixG+f3VD2W7VvJDlbQ67DH+zNne6P7DYcn1HDLq3hytHke9KYQ6gNez1b6bzKUEQevdhPb0JqR890Zznstctfhd9RB6cDx4rYk6IgGqEY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d5ef735f-f792-4895-79a0-08d6c3d0da50 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 07:38:30.2234 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2553 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-18_04:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418073830.A-zyq-FJNJHk3ZFlwnZ6Zcblzh5hlBXayYAbFN1pdO8@z> >> From: Vivek Sharma =0A= >>=0A= >> Enable missing support for QinQ strip rx offload=0A= >> in vlan offload set/get methods.=0A= >>=0A= >> Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion"= )=0A= >> Cc: stable@dpdk.org=0A= =0A= >Not sure it is a fix.=0A= >The commit mentioned above allows some kind of offload config.=0A= >You are extending the offload config with support in=0A= >rte_eth_dev_set_vlan_offload().=0A= =0A= DEV_RX_OFFLOAD_QINQ_STRIP was introduced in cc9d0456b870 ("i40e: support do= uble vlan stripping and insertion"). But, the means to utilize this capabil= ity by enabling this rx offload for an ethdev was missing from the patch. T= he current patch fixes that missing functionality so that user can enable Q= inQ strip rx offload for capable devices. =