From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A092B42BF2; Fri, 2 Jun 2023 13:25:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7544840ED8; Fri, 2 Jun 2023 13:25:08 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 9173A406B8 for ; Fri, 2 Jun 2023 13:25:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685705106; x=1717241106; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fX7SIqwi8IhrStMxD3MhOmlhs3l9yqd4E8J5qTWMOe0=; b=Ve9eKVo+2wocHPrmUrG1gk4+gTBrjNRCJF60PDLj+HBSR/F9b3k91Jt1 hh+Ld9XW+SQXgQqUQxtsk3Gnma6BtgKf9aDJCmX1e2uUw/trtjqymYpOy WVAa4N8OG/GF24qmYwl3g8OmsFM0nCHBXYHsKaEnrerG3YHxGcuQozf1x LHkjTTrj4Z/crNY1dteYrk7mvtCmgG9hPR8oiy5f6Cc0CrpN7Y0WFL/rT KWqfHHSYwVrA/mHRtlPqpcXrQMR06v9osOWFgcy01S7JBfztmcjOZNFaa 0OjDvZogZyDUT15MRVyoef5YzRi8Suft1icyQxAyb4WEkhURKinnyAo9q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="419376613" X-IronPort-AV: E=Sophos;i="6.00,212,1681196400"; d="scan'208";a="419376613" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2023 04:25:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="707815986" X-IronPort-AV: E=Sophos;i="6.00,212,1681196400"; d="scan'208";a="707815986" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 02 Jun 2023 04:25:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 2 Jun 2023 04:25:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 2 Jun 2023 04:25:00 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 2 Jun 2023 04:25:00 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 2 Jun 2023 04:24:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aj+4KESzW+rqNNtAIlX5fOnEqYa8qIioSPCB21gQvTG5ULldR+HEpYgj2CntH4p2wbAMiTadhJSCk6lv0mTwiuUZz6fV+dEFZ7E6jLsz1JyLCCZPzqWEiAlYIfJY/Fa+kflhWPv7aeV0yNdW4rXeeOGfdP+ae+u0vN3iQuoMS3XikRXJk1l1Z2VfFlWBRbiRVcvfDqOQcAPfZEdEsFntxtEAuPNIn8ir4+BOyFbY9Z9YG9EV+ohCQW9IEyfGU72tC6qTvOCJ4A2JeEIrNoUqJ9zLIyzpe5EmnWA2RyZZb5Iba/ZXZIOkP9GPA3EzHWVQ9dLV2Spm4xLbFobwJDG12A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mygcfJoeKD4E3S1Lbc4KcVIvSPny1wo3BSln6W+xICI=; b=mVOduI10dG5kLEL9enn2BheBLdDQKLGA5DDaVERcIa4VYft/e64Smi8Qn3olaRLXWvy1vx4NX9T5ZPIwZh1MQibkTkpB8XLHC7kpGSMhYfvowDaS3BLcQQQKrQqPZeQugfbzig1PuLaXqFkKqFlAxy50v/coD08nxuKlr1v2AEhm/m92jRTkrgcYonac3Y0BBr3wDwNi8LNnkSZB/jlVcV3LvKXKpYSnzg1qiMwmxq9FenluYJMO6L//fl7fkxBU+Z3vAbaAffnmmI+/ZQ0Oi0/R9bM4cprI7+EHDHWFBj8JE2jKrWetEWPc9bLyYBw29OzISB86I/tbjOXqKgybfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by PH8PR11MB7046.namprd11.prod.outlook.com (2603:10b6:510:216::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Fri, 2 Jun 2023 11:24:58 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::9bfe:f2ec:37ee:f29b]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::9bfe:f2ec:37ee:f29b%6]) with mapi id 15.20.6455.020; Fri, 2 Jun 2023 11:24:57 +0000 From: "De Lara Guarch, Pablo" To: "Dooley, Brian" , "Ji, Kai" CC: "dev@dpdk.org" , "gakhil@marvell.com" , "Dooley, Brian" Subject: RE: [PATCH v4] crypto/qat: default to IPsec MB for computations Thread-Topic: [PATCH v4] crypto/qat: default to IPsec MB for computations Thread-Index: AQHZj7yohAYSJdRMMEmoLBzWkGuK0a93UKnA Date: Fri, 2 Jun 2023 11:24:57 +0000 Message-ID: References: <20230522143959.719233-1-brian.dooley@intel.com> <20230526102650.774625-1-brian.dooley@intel.com> In-Reply-To: <20230526102650.774625-1-brian.dooley@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|PH8PR11MB7046:EE_ x-ms-office365-filtering-correlation-id: 048dbaff-99b3-41e5-7f60-08db635bfee2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kz+sUJfAWI87JHWRJ1b/atj2CoFqJl3lnwbaQloVQer8B98WEScp5NYGR2QFjfzkKdus2PQNb7pT7ezcjmqhUFk07g5Of6lf+RyRKyl1B0rVabLTYscM64rjx825zKqJod5GZ1IekkaRLF7WAgirR9T26nZ6nJ/xEDiOuqk9ujzSuRSdwjP73e9QWhka4+/cvInlndxw3sABdo49fEn3JnbJUdCITrQ2p/Q/ERzYTY9jC85rpCM+RSidlwEtaGrw8rsNX/5YED8Qkk703U7RlvCizg6ShdVvc51mEilikQjkk+j7KTywtMW7Ufj65aD+sk4LoEji9V++Le4TfhC3lCoJEE6Kfb9kpwPGCjj8JJi+qKGzjdN8oWvAv0bSX3bw2kEv/NFa8FE5CCJjTtecFMMuJTkPFf3uitMW4DLN6/MuVTEzvgb5ffA/TAC1qWx6/6/ljGfX9nKAj6NN4XpV51347X4/6uFURfyNJmWibnWPpaPHdTjt9FAn8htMhdtOAVn1tIuXlRRnkhEoCEB+Ic/hyEhtYe3QevhhNuDSTlgGLoNhEvTo/PbCvTUDPf5KmKYbFvdt0JE+sSanUBAOjou3trloHDpFkwZYxjF7r1/GUjp5HhE3+9VwVPUPoZai x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199021)(6636002)(82960400001)(38100700002)(122000001)(76116006)(110136005)(66446008)(64756008)(66556008)(38070700005)(66946007)(83380400001)(54906003)(478600001)(4326008)(86362001)(66476007)(186003)(33656002)(26005)(7696005)(316002)(71200400001)(6506007)(2906002)(53546011)(9686003)(55236004)(41300700001)(52536014)(5660300002)(8936002)(8676002)(107886003)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KBlGEYvoSigcsbwC6EBtQMpjZDb41wX9mya1EkU7P6poKLWrpK6O3WpPo1UL?= =?us-ascii?Q?YF1njXAUqDfZCr2qJGoGvMJmx6aES7mfWCipwDpZRN4Sg50kLXwsJFXQ3whY?= =?us-ascii?Q?ZHlzOZWM4pgtYfstF/YLeaqBHzJRgYJFNoKusBNbRpYiFhqDwzOltvOSSJnh?= =?us-ascii?Q?Gwet/w/OLr1wTfagKsk6eLa+IgIXNqqwCq3pAdymKgh6qjCA58nEqsmMAAeG?= =?us-ascii?Q?9kOiiK+MPgXM5TjwKifrDdmLiiQOpBNyQ4+0dXcsW9FLB67wVOwP2OFs7DEm?= =?us-ascii?Q?pP8x/qwL5ogLJs7q/k6IsBBL3KUSfx0TWUK3A9dTrsNKvD7SAyDG4wuxUf/+?= =?us-ascii?Q?NQNDBg4nIfViq9n8JjV3EhW1gbmJc3ogG8Tasg0WjbRSPPvd+uSQ48TBpKc1?= =?us-ascii?Q?LiNLxpSlMA45Op7iZPRIW7ZQTrgalJ+8XVOdIRmbkoxwpM9NH7d/IgvIc35b?= =?us-ascii?Q?Xj9ZjQbzjo4Os/EybVPgUol1KSUdZinbGPxTzna/FE14e3ykREkvR8FizKK5?= =?us-ascii?Q?bz6inEoHmvxFlDAg35WelMHMVfGpafY46svovUS0bqRS0J5A3BcR/p7DcK6g?= =?us-ascii?Q?T2FGdH3pKiy+hewrRhz3kUXvgZhTzaC4Z8n3d9JpH530ueOAGJmUWwCsFR2p?= =?us-ascii?Q?hvloFcK124EC9zbZzRtuw/to/I7vnE4zgX8Wq3Fm5i2Fg/kfzzVzfq0j5CJx?= =?us-ascii?Q?QyENgMnjPq7W8ef2toTNJB4/cFL5RP75mDA/Oo+ekXfc8oEyNFGr1zI9ukSc?= =?us-ascii?Q?VQav4G9/nKNpqb53igUilMoZ7+4vP8sBBxjhGi4TgZzw45Xi5KaENExKGe3I?= =?us-ascii?Q?ko3u2cmMQ/BoqKLign5RtVk+F8zbTUR+z4jyxLt2X8drhX6B4yr2MGmTJMV4?= =?us-ascii?Q?o39w9RyjvcGNGhPcDnTJdPWwhM5h2x+u87riD5yqDWusTnSX/83hL6jCNGPK?= =?us-ascii?Q?kTnTMf7AvcDIe1zSR3XOOtuE6kO4Ptgb4la3I9sTfeH/bWY+WCUGzmJmWO7U?= =?us-ascii?Q?eDSFc/gFAhKVjY1Rxhr/tqxlKT8Nwb003fsWznOKyP3FlEen3+iL02AohtFW?= =?us-ascii?Q?5fxp4HqqONbLnpYrmogN83Soh90i3G5da2NKpVap9+GoMI2ThWLyBKiBuXFA?= =?us-ascii?Q?bub+I0x1FOCbAJhsW12vSyJYbiro4Orx76IretC36vt9U6OMMUKTPCRAKJO/?= =?us-ascii?Q?rASVf91/94kzNprOynUUFqKLnabw7wNSnxHBRcO5VVN+uJMyDzxiNdkTdxsN?= =?us-ascii?Q?GQXgKh3lc+d4WHitqUcY+CJIOvgRWg+M0OM8+hLfkC+qJjT4pWfkFSZzc5xS?= =?us-ascii?Q?m5ytwoEQ19mnt8zdpadW/PFNvccTeZeSTsdb29d03iGETzxoUzv1vdSi1ArL?= =?us-ascii?Q?bBeUzQBUxaPZp5Rdc5JwkgZSZtmuqw4b4q8ySlORPZ53J/216GuV/yUGFlNB?= =?us-ascii?Q?uXsMPIc3CO8hYWt3nr6c3F3WNG6Grdb5DraRlwCYC2n+vUEUlsBhY9vksyVM?= =?us-ascii?Q?EkoYp9gJYIWClUCk8AMfN1s4UZeilmMnXU6IvmdiB5ksn1xFQIiWPzPzvl2r?= =?us-ascii?Q?E8WVwXGKacesR7WRVJ3hrMLsvyhyUQDovOhpPhuuCNoTqvQ35NzsuwSXi+AT?= =?us-ascii?Q?ng=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 048dbaff-99b3-41e5-7f60-08db635bfee2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 11:24:57.2128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZI0tjumdvlz87kTiZvHIiETB1DkKZs0V5YQMQHyglfi1b7mlfg8QnjqPi842dbTvYv+YOrn0SFmPZo2snFeF4reOaaFdCuXLNxbBEEG3fdM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7046 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Brian, > -----Original Message----- > From: Brian Dooley > Sent: Friday, May 26, 2023 11:27 AM > To: Ji, Kai > Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian > > Subject: [PATCH v4] crypto/qat: default to IPsec MB for computations >=20 > Pre and post computations currently use the OpenSSL library by default. > This patch changes the default option to Intel IPsec MB library version > 1.4 for the required computations. If this version of IPsec is not met > it will fallback to use OpenSSL. >=20 > Added version checks for libipsecmb and libcrypto into meson build. > Added directives for detecting IPsec MB or OpenSSL. >=20 .. > +++ b/drivers/crypto/qat/qat_sym_session.c > @@ -9,7 +9,7 @@ > #include /* Needed to calculate pre-compute values */ > #include /* Needed for bpi runt block processing */ >=20 > -#ifdef RTE_QAT_LIBIPSECMB > +#ifndef RTE_QAT_OPENSSL > #define NO_COMPAT_IMB_API_053 We have removed this macro in IPSec MB 1.4, so no need to define it. > #if defined(RTE_ARCH_ARM) > #include > @@ -34,6 +34,7 @@ > #include "qat_sym_session.h" > #include "qat_sym.h" Apart from this: Acked-by: Pablo de Lara