RE: [PATCH 5/5] test/crypto: add chained ZUC256 testcases

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Ciara,

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday, March 1, 2023 5:39 PM
> To: Akhil Goyal <gakhil@marvell.com>; Fan Zhang
> <fanzhang.oss@gmail.com>
> Cc: dev@dpdk.org; Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH 5/5] test/crypto: add chained ZUC256 testcases
> 
> Testcases are added for ZUC256 cipher-auth, auth-cipher, and auth-cipher-
> verify.
> 4 byte, 8 byte, and 16 byte tags are tested for each chained type.
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>

...

> --- a/app/test/test_cryptodev_zuc_test_vectors.h
> +++ b/app/test/test_cryptodev_zuc_test_vectors.h
> @@ -1602,4 +1602,718 @@ static struct wireless_test_data
> zuc256_test_case_auth_2 = {
>  	}
>  };
> 
> +static struct wireless_test_data zuc256_test_case_cipher_auth_1 = {
> +	.key = {
> +		.data = {
> +			0xf7, 0xb4, 0x04, 0x5a, 0x81, 0x5c, 0x1b, 0x01,
> +			0x82, 0xf9, 0xf4, 0x26, 0x80, 0xd4, 0x56, 0x26,
> +			0xd5, 0xf7, 0x4b, 0x68, 0x48, 0x6b, 0x92, 0x6a,
> +			0x34, 0x1f, 0x86, 0x66, 0x60, 0x0a, 0xfc, 0x57
> +		},
> +		.len = 32
> +	},
> +	.cipher_iv = {
> +		.data = {
> +			0x8e, 0x5d, 0xbc, 0x3f, 0xb9, 0xae, 0x66, 0xa3,
> +			0xb9, 0x5c, 0x12, 0x14, 0xdb, 0xc5, 0xbc, 0x18,
> +			0x48, 0x12, 0x09, 0x06, 0x25, 0x33, 0x2e, 0x12,
> +			0x12
> +		},
> +		.len = 25
> +	},
> +	.plaintext = {
> +		.data = {
> +			0x36, 0xdb, 0x63, 0x68, 0xb5, 0x1f, 0x4e, 0x92,
> +			0x46, 0x1f, 0xde, 0xdb, 0xc2, 0xec, 0xfa, 0x7e,
> +			0x49, 0x85, 0x77, 0xaa, 0x46, 0x98, 0x30, 0x2d,
> +			0x3b, 0xc4, 0x11, 0x24, 0x98, 0x20, 0xa9, 0xce,
> +			0xfb, 0x0d, 0x36, 0xb0, 0x2c, 0x85, 0x42, 0x72,
> +			0xa4, 0x21, 0x4e, 0x66, 0x0d, 0x48, 0xe4, 0x57,
> +			0xce, 0x5b, 0x01, 0x14, 0xf3, 0x31, 0x42, 0x2e,
> +			0xf5, 0x53, 0x52, 0x8d, 0x73, 0xfc, 0x5c, 0x6e,
> +			0x09, 0x92, 0x1e, 0x35, 0x17, 0x60, 0xa8, 0xbb,
> +			0x81, 0xf6, 0x21, 0x8f, 0x3e, 0x05, 0xe6, 0x0c,
> +			0x60, 0xe7, 0x21, 0x53, 0x18, 0x63, 0x81, 0x0d,
> +			0xb6, 0xd4, 0x9a, 0x29, 0xd0, 0xf6, 0x97, 0xd9,
> +			0x89, 0xb5, 0x0e, 0xa0, 0x15, 0xb6, 0x5c, 0x97,
> +			0xac, 0x7d, 0x26, 0xeb, 0x83, 0x0c, 0xf7, 0xe3,
> +			0xf3, 0x18, 0x37, 0x0b, 0x7b, 0xb8, 0x18, 0x31,
> +			0x8c, 0xb2, 0x5a, 0x5c, 0xa9, 0xf1, 0x35, 0x32
> +		},
> +		.len = 1024

My only comment is that you could use "128 << 3", same as you did with other vectors below, so it's clear that these is 128 bytes passed as bits (same for the lengths below).