From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6B7A42CD8; Fri, 16 Jun 2023 11:25:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 729AA40DDB; Fri, 16 Jun 2023 11:25:21 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 4340140A7A for ; Fri, 16 Jun 2023 11:25:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686907519; x=1718443519; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uXRSeYUPgiukbDJ0McTO3IiuwDT8VflIj6uaoN4glUI=; b=Fvt+4GtGYKxaA5xgY8CdimSbrD8slLbSuyvnz4w3GbdplXOUkDKdxiCQ AkkJrvWS4eQVGlLpnC9X2CloXtcdB4hU6ObYKJhiYQXR0CGeIWNJwE0V4 d09QEhN/63TE7Ury39mrPLMMgGD9hmRQm62F/kCC7nS2UKvAVpEnUX9mG Bb6cn2i6khgL7Jgqcc6e+F839MWfcmiJZjoYkWMcCpBcrwmGGPN9HqBHB 3DYij3FjrhfuFbABAcE9uVB8Qpr+ZAtRFUTHxRpCSTwPIYLVMTlx9b438 IO8PIDLHTlJ2f/QFudFPia8+knKfnT1epHjZ3dDX/8vEBshNR7xFRyL6a w==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="361697283" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="361697283" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2023 02:25:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="715944563" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="715944563" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 16 Jun 2023 02:25:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 02:25:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 16 Jun 2023 02:25:11 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 16 Jun 2023 02:25:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3HTwyzdN5bWYlX/Oiip9LTET0rVHDfMzYZrpLlPD+atBAKwmwBhcOpuXN4xm5P6nG/f9IX09lEkTgRj5cwlIDEA0X46FJcTLiG6tYPZLVcAXfnerq/WHJvTvbHOl7hXub4hDWpjVymLMuMaWsUCBlglG86IEqLAr5wqq6oPaiBpHOF3NU7CWnF5hE/audLKLUbrJ3O+0n3uEb07QB/+MA/POKlJnx01nfug8mzqPSTLHVadJUF2PiowvAqv9TzoIH+e1pyRKvM4htNaGxurtCI0O2nWD2ZHEskxGgfzWFhAqr0hYXZVy98kOGgrNgNU3wP1GfnZ7k2etbzvHfhF9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXRSeYUPgiukbDJ0McTO3IiuwDT8VflIj6uaoN4glUI=; b=FNWVLzoi3gzXuD6gUQK729KM3YKYY47in9o6ZwS3sBhGUD5oFl/DBvZH7uCECfL6wscV+Sxi3P0bFbLv277IsxT/do1+q2aE8jzy4xLia7HuO4EVRJD7oJK2GjpAvYdKkJAvOlVj1vGusgvL2g4PvEJ8CwQ451FUZuWyxUIYrB6VQTnFG7D/45JjUrosNmiB8YUaKlP0nZ2QUbZj042oGyQxZThceb8/0VlLwUg2e8foHIqSF1azfK4iXtxN/wjM31G4Sa24hnQY0Z4/3PHMQJjeXLxT7xrDuBVHCi88/NQj14slUgsfF/piP3iLFhagtUPxafPAqvIQaDsnKT1Qjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by CH3PR11MB8341.namprd11.prod.outlook.com (2603:10b6:610:178::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Fri, 16 Jun 2023 09:25:04 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::9bfe:f2ec:37ee:f29b]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::9bfe:f2ec:37ee:f29b%7]) with mapi id 15.20.6500.029; Fri, 16 Jun 2023 09:25:04 +0000 From: "De Lara Guarch, Pablo" To: Akhil Goyal , Fangming Fang , "thomas@monjalon.net" , "Power, Ciara" , Honnappa Nagarahalli , "Ji, Kai" , Ruifeng Wang , "Mcnamara, John" CC: "dev@dpdk.org" , "david.marchand@redhat.com" , Jerin Jacob Kollanukkaran , Ashwin Sekhar T K Subject: RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID Thread-Topic: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID Thread-Index: AQHZiAqMumOjoawi0UWx7hjqo5uJA6+EoGQAgAVThgCAAWMoAIAAIbcAgAHfdkA= Date: Fri, 16 Jun 2023 09:25:03 +0000 Message-ID: References: <20230421131221.1732314-1-ciara.power@intel.com> <20230516152422.606617-1-ciara.power@intel.com> <20230516152422.606617-9-ciara.power@intel.com> <112430369.nniJfEyVGO@thomas> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|CH3PR11MB8341:EE_ x-ms-office365-filtering-correlation-id: 75c17ed0-68a2-408e-40e7-08db6e4b90fe x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RO0NREew0k6MPoSXgFF2kweqM3Mt5g67dXuPDsoqTqM5HXQPq/sku6//ZSXcgazKmsEo+6FjkE/S1XBMOUqBwTkzts/8sNFUSyXtgUJXF414ePTZ2EhU8sROsNm23e0XCZyPU1PDyThUCm3g2Gl0jF2G5J7884JRH8NRNJJqCPrFucjAat1vxk99p862sKhTzOuMOB9gZpqASFapVHgVLLuc4+YtzBiykJ+qin2XsjA6/QxKtSkN8dDT5G71X6udirIwI08GKmv1slvEmclpVLPW5Y3U48DD+cpZ/f3rKaJjzfv3klhgkYeTljXMYrptxG8uoCvQWNfBiKDNiWAukyaMwlGpCuT+6bID17u/LoipdRau7Uj+hwIwTljdPdw68lZ/GLgL6r350eKZrSLF274Ma5zAYnQrMGsxrV56/rSpUswbiyaAw5nwvmil0/4Z6bDYk0h3PZ1ZPUbwtJZJIkhTsR1CctsIMfyuGXQxrr4gWzUlWyrZwIy1XL3Yew6fwEKDc7pYL5eMeLXUHGJ5Zj9g5EIjxAI5nuwLXuJ8WyMkmdC1h+1hmmV+akR+Mq9zs36lyU2u4q1dVvlRrq6gE9y+F6TeAPAU86pOIRQKPF69Qkkas2XJA2M+2DSgQWN5 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199021)(66476007)(4326008)(66556008)(66946007)(6636002)(64756008)(66446008)(76116006)(316002)(33656002)(52536014)(5660300002)(2906002)(8936002)(8676002)(41300700001)(54906003)(7696005)(110136005)(38070700005)(86362001)(55016003)(921005)(478600001)(38100700002)(122000001)(6506007)(26005)(55236004)(9686003)(186003)(53546011)(966005)(71200400001)(82960400001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tQrmqmSyoC+o/qM1G0nPGJMWJre7nSH7m7RZrrpddHzuEAiNfE5pzvnM8z+y?= =?us-ascii?Q?vUTxvqzy+TcrWgRGKxnsH6aUl/SHPCGIvHxdbAMLZAUvqLyXoUq4EQ6Xyz48?= =?us-ascii?Q?lXi2+FoMdohYrCo6zSUJuVHSd64mtDOy3KN7co0QUmUdkI10ySaAI4nJhPGu?= =?us-ascii?Q?B3TDBp0XYhjKSsFu0jH+0mJQJFMTcDvbdvqQsmxgGZt28r/RvBQ67C40Ib7D?= =?us-ascii?Q?3LmI4ti8rqyIusw/O0YvkYlANbG/1pBoHuKh+I7gnxjJWJJmcfeDQ5G/ZBFM?= =?us-ascii?Q?EUMf1mhLZP5zyiTtW5+4L6MUEKKlUqSRuTeK+T1quzWad/hEvXAuBiVyONCv?= =?us-ascii?Q?yUzIGb7X3Tmorr4NvHEa/+9jOmd/ly1a2zyWrTGHLXLuvYhfuObhCOxOfZ5j?= =?us-ascii?Q?rLZZ8rEgrsfquO5cLJjUZ7eK5tRe9WeC3Vy3LRz4qpjYKtbaVHHO+kpv8r+w?= =?us-ascii?Q?UeJF10pp1iflZB5bTAcIebjljWQRkuMASZeOvJVB6d37U2GrhLT3NvXUWCjx?= =?us-ascii?Q?y7bw5x1v9rwOfVq0XB4LfRLiUwQcCPpjRbyocFMC+rBESyPgS5tN9ECegdyQ?= =?us-ascii?Q?ftApoWn0sNpCPJp9UDJtven90FISIM3QtMX41yd35PL+Eht1AHUwZbZRRDnN?= =?us-ascii?Q?C4n+vMAAK7ZADTuafIozJW3M6mJIcMtboM0vLPoFYXfMyZ6/Wdg/YM1NOXPE?= =?us-ascii?Q?lvo/oPeSD0ILpgBW8BOj5JnpSEX+54GsSkFN7CZqFrG1KYmGWr5ln3wpRxVw?= =?us-ascii?Q?SaErxdMYPa2wSPdZ0pf5vwkFUueqzETCFLgvfnerRkX0TNJoq6ITgEemkej1?= =?us-ascii?Q?BOE2/uDP6tt+YXM/MmiScuoHzD+ZMRLbZWNJv4F4mPvZuHBbL1E7RcII2IBi?= =?us-ascii?Q?iwpcPEmGRXFhmLJhLNTgbGzGK1fKn8zJYPFaIxv22LD540/P6cFLQTx22Aj1?= =?us-ascii?Q?NMySDp3GjlHx6LekuyzzeQU6/lCXEQ0VPOQg00nqZA3smLBlqfXgIWtjsMho?= =?us-ascii?Q?Fov1qhRUs0U+I7TygF2pFE3o3We4RQgPhav9keaspaJFwehR2eV925jj1Y2v?= =?us-ascii?Q?T1EzUfi1GkI44AdRgz0VYZe/hAex+W/iCKiX3qUwNxAePniGJSQSlUmGZLPP?= =?us-ascii?Q?uWh4K2pSpWxn2MA0+KOwSC7C1VSjIZkhGVLwP7i47ep/gZilYaq0K1WTQgiI?= =?us-ascii?Q?F1WB68hq6biD/zxymUKAF1PfYK5JcxHkO8x12E+9oJcB2vI2zGDkiRczG66A?= =?us-ascii?Q?jw0m3AidSsf/5jk0dlVkpgY9uUZhcLOeMSDa5MvaaRt7davC2xD1dnNccX1Z?= =?us-ascii?Q?kEwLNGfqWAO/34c0DEz9LYLOYPC7fYnjSFzUiKzKNzW+jlagzg1qldO1gixr?= =?us-ascii?Q?QDg+ziXRMSPLgawtp89NvPuzB+cAhV0fwe0nFRIZe3mg18TLoEMNtQH8CjJV?= =?us-ascii?Q?HLbm9qyBEmLf628XdeIodceIo4T63mMMn/h4h+fBLXYJx3LXni9TBJ/eOkHr?= =?us-ascii?Q?bxnwIBR2COVIws3EbxOY5x29etodS1Vqk06GSPETZp/1vDWddXCDz8EQBFRV?= =?us-ascii?Q?8Xwriyo/wyR9f+7WztA6unL0qkd62/i72qvqKEiMg6JmVEuWbEabLm3RwglB?= =?us-ascii?Q?1A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75c17ed0-68a2-408e-40e7-08db6e4b90fe X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2023 09:25:03.6913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hehMYoLD7PWth/gaSmtpS4oF0wgqbH7e2nA1yNcuo9IYo4OM/bjBnibhJAQMQ4ejhl/fcp37j+9mZPL6xCLMdcnNXP9ur/bAu2fZ7Q/2ZFM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8341 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, June 15, 2023 5:47 AM > To: Fangming Fang ; thomas@monjalon.net; > Power, Ciara ; Honnappa Nagarahalli > ; Ji, Kai ; De Lara Guarc= h, > Pablo ; Ruifeng Wang > ; Mcnamara, John > Cc: dev@dpdk.org; david.marchand@redhat.com; Jerin Jacob Kollanukkaran > ; Ashwin Sekhar T K > Subject: RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use sessio= n ID >=20 >=20 >=20 > > -----Original Message----- > > From: Fangming Fang > > Sent: Thursday, June 15, 2023 8:16 AM > > To: Akhil Goyal ; thomas@monjalon.net; Ciara Power > > ; Honnappa Nagarahalli > > ; kai.ji@intel.com; Pablo de Lara > > ; Ruifeng Wang > ; > > john.mcnamara@intel.com > > Cc: dev@dpdk.org; david.marchand@redhat.com; Jerin Jacob Kollanukkaran > > ; Ashwin Sekhar T K > > Subject: RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use > > session ID > > > > > From: Akhil Goyal > > > > 16/05/2023 17:24, Ciara Power: > > > > > From: Pablo de Lara > > > > > > > > > > When creating a session, get the session ID that defines the > > > > > fixed session parameters and store it in the private data. > > > > > When retrieving IMB_JOB's, if their internal session ID matches > > > > > the one in the private session data, these fixed session > > > > > parameters do not need to be filled again. > > > > > > > > > > Signed-off-by: Pablo de Lara > > > > > Signed-off-by: Ciara Power > > > > [...] > > > > > +#if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM > > > > > + sess->session_id =3D imb_set_session(mb_mgr, > > > > > + sess->&sess->template_job); > > > > > +#endif > > > > > > > > For info, this does not compile with > > > > https://git.gitlab.arm.com/arm-reference-solutions/ipsec-mb > > > > because Arm did not merge Intel's code correctly, and > > > > imb_set_session() is missing while version is 1.4.0-dev. > > > > > > > > Anyway I hate this situation having 2 repos for the same thing. > > > > Please merge Arm code in the original repository from Intel. > > > > > > > Is it possible to make Arm repo as main repo and modify DPDK > > > documentation, if Intel not agreeing to include Arm code? > > > Currently the Arm repo use case is broken. > > > If it is not resolved soon, we can submit a patch to revert the > > > patch which is breaking compilation. This need to be fixed by RC2. > > > > It would be better if the original repo can merge Arm changes. We will > > keep regular sync with original repo in the current situation, the > > next sync will be carried out earlier in Q3. >=20 > Yes, it is better to keep original repo. But if Intel is not agreeing to = it, We may > need to find some alternate way to fix it. > We need a sync as soon as possible, as with current Arm repo, DPDK > compilation is broken. >=20 > For now, we cannot merge anything in ipsec_mb driver till we fix the > compilation With Arm repo - either by Arm repo sync or by reverting the > patches. DPDK is supposed to use stable versions of the library (e.g. releases), not= top of main branch. As described in README https://github.com/intel/intel-ipsec-mb#4-package-co= ntent, tip of the main is NOT a release software version. In case of ARM library clone, it is not clear what the latest stable versio= n is. As the Intel library version is bumped in the first stages of development f= or the next release, it is advisable to avoid updating this version in ARM = library, until a new Intel intel-ipsec-mb version is released. For now, the simplest solution is to revert the ARM library version to 1.3 = (changing IMB_VERSION_NUM and IMB_VERSION_STR), until the ARM repo is synce= d to Intel 1.4.0 (which has just been released). >=20 > Regards, > Akhil