From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Cornu, Marcel D" <marcel.d.cornu@intel.com>,
"Karas, Krzysztof" <krzysztof.karas@intel.com>,
"Ji, Kai" <kai.ji@intel.com>,
"Power, Ciara" <ciara.power@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush
Date: Mon, 13 Nov 2023 11:38:46 +0000 [thread overview]
Message-ID: <DM8PR11MB5591BA36C4AA956052B7CDAF84B3A@DM8PR11MB5591.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CH0PR11MB5492A6871132DAECB90BE638DAB3A@CH0PR11MB5492.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Cornu, Marcel D <marcel.d.cornu@intel.com>
> Sent: Monday, November 13, 2023 11:13 AM
> To: Karas, Krzysztof <krzysztof.karas@intel.com>; Ji, Kai <kai.ji@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Power, Ciara
> <ciara.power@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush
>
>
> > -----Original Message-----
> > From: Karas, Krzysztof <krzysztof.karas@intel.com>
> > Sent: Monday, November 13, 2023 8:02 AM
> > To: Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Cornu, Marcel D
> > <marcel.d.cornu@intel.com>; Power, Ciara <ciara.power@intel.com>
> > Cc: dev@dpdk.org; Karas, Krzysztof <krzysztof.karas@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush
> >
> > Previously it was possible to increment `processed_jobs` to a value
> > greater than requested `nb_ops`, because after flushing at most
> > `nb_ops` jobs the while loop continued, so `processed_jobs` could
> > still be incremented and it was possible for this variable to be
> > greater than `nb_ops`. If `ops` provided to the function were only
> > `nb_ops` long, then the `aesni_mb_dequeue_burst()` would write to the
> memory outside of `ops` array.
> >
> > Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
>
> Acked-by: Marcel Cornu <marcel.d.cornu@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2023-11-13 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 8:01 Krzysztof Karas
2023-11-13 9:12 ` Power, Ciara
2023-11-13 11:12 ` Cornu, Marcel D
2023-11-13 11:38 ` De Lara Guarch, Pablo [this message]
2023-11-16 17:50 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB5591BA36C4AA956052B7CDAF84B3A@DM8PR11MB5591.namprd11.prod.outlook.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
--cc=krzysztof.karas@intel.com \
--cc=marcel.d.cornu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).