From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16C69A00C2; Mon, 26 Sep 2022 10:06:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BA8A400D7; Mon, 26 Sep 2022 10:06:20 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 33F55400D5 for ; Mon, 26 Sep 2022 10:06:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664179578; x=1695715578; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Oxl6t/3eO2kfuoOSyjwVLIudVkTKg0+qNZz1dJBFipw=; b=IlSTKbGyNqrcavmYAQNpAPYqWU/w/4uvF2Fh7+aXSHjGrR2Jc414LofG kbkLq5Ku2/0L4y+XAaaH84nkAsB2676BMYm+nZ1j+6biPixx7eUgbsUwd 4eQRma7syVbt6sU16YMFO/YPrkRKG+WTc1cHLz4PCga5d/5jz3HmQCGSr mD/6x1OlG4deSnQZvPyyg+J5TAogvj016bkNh8FGJSXwtzpIoFGd4QWDt FlstNE0FFMtpfKWykI54hlEfgY/DegByxhMznTLQRVWYhVNlq62migbwA pOpbYCh5HXeZ69xmRzsBBNCk9SQQOxQ5c0+LWeLrNuWUqkzQhGz8xofJf A==; X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="387261650" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="387261650" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 01:06:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="796241824" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="796241824" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 26 Sep 2022 01:06:16 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 01:06:16 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 01:06:15 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 26 Sep 2022 01:06:15 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 26 Sep 2022 01:06:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNDiets82+J5OfjrJnCqdrZfEfCFx5ClqsccMpJUsaA7TWXQ/0m7fKZT3nB6R8kW8g1o8lAoD8bYry9kv0vBVd3+1U7vbmFhT7F7IMxD+A10mlAEfB82sGUmoFuoay+QIXT5m3/Kf66SMMyjav+1ry40NI60ZwzhUH3xKZyCLek4Gf++LXte8vlDyEUg3lJzEk7PDW9DRbiv07LG9gFCnrjFf9gu/ORFZZfpfRI0WxBeH72zoZ/ElFPU1rSensZiJy1eGejLtbxt7cXU7Icn0saOisWK/W6vbcDN1/MrS3K8giehn6LhWUzvC2gRdyIhoqkNj+9hdjyTxZw2AhB7wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8/fSJsfjpaeVdSBPLkFgDtmz2/JUSWZPTbHBWSTocw=; b=T32i/LEeOHWHj/dL0GbV13OEYbdZSRNVZh7duiOa0GyK/oK+fA8axdqX/oE3TwUbYHjFZO6KcLCMIGGDDnpX8YAgPr0gz87YV7fYoAj8E1AFGa0/85dzqAr1bINuJ7KyKGoDfp7t2s69x32rY1XbOPmp59Ile9Qsqxmi5NKLCyNzxhU2wZx+nBFKfEQBFSruXCdVQcr+7yHeSjow/jaBVhEm3cJ8N2X42DcNkIqXAi2jpvpca6JVs5zkGwIfVNoBZWXlwq4uSK/0T+b+qEgKh/1iP/7uq4ZnptjRx8LUE5LSgW5O5cCI0bFYycfAOSbOBZfAYkmOhcsatMeWQJX9lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by SJ0PR11MB6720.namprd11.prod.outlook.com (2603:10b6:a03:479::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 08:06:14 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::1400:7e7f:fc3b:98fe]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::1400:7e7f:fc3b:98fe%3]) with mapi id 15.20.5654.026; Mon, 26 Sep 2022 08:06:14 +0000 From: "De Lara Guarch, Pablo" To: "Power, Ciara" CC: "dev@dpdk.org" , "Ji, Kai" , "Zhang, Roy Fan" Subject: RE: [PATCH v3 0/5] add remaining SGL support to AESNI_MB Thread-Topic: [PATCH v3 0/5] add remaining SGL support to AESNI_MB Thread-Index: AQHYzbjFBj6hiE4C80eaEXNraPO56q3xYhOg Date: Mon, 26 Sep 2022 08:06:14 +0000 Message-ID: References: <20220812132334.75707-1-ciara.power@intel.com> <20220921125036.9104-1-ciara.power@intel.com> In-Reply-To: <20220921125036.9104-1-ciara.power@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|SJ0PR11MB6720:EE_ x-ms-office365-filtering-correlation-id: d33eb611-279b-4065-0abd-08da9f95fb52 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1kUUQDqbUW4IEyFjxM9TO4akjJAl79vfYsXflT1rUJJK2xzXArn13TAdLI+oy4FmfgsiAV0+JXnfMa5o0uf3ipHzT8QBBDDB1DG+IKcyu028ZueFKxSvMW85+3+seuXhcA3sBpag1d6Q6gWH4w4gHdHv8WIaMTcOcSM1J2sdnr/yT1NO9CtsCT9VByMKRdKRk8zG6e79sesTvYCGlz2FtV4TDhqPzx4Zw1WGdG0FitEDDaUJEOACzDR0UJT1BnkLBHAORi0imGqComYlA9BTnyxgCBuxQ/jHScUntaW0wsHa7tjciuAa/atn6D2gcyOMVPsd7pcgI3k2EwdaoThpEhkgA3F441pmThFeWDWNqaoICSM0yz9yklZRIS1p24EU/iP6QcO/4RmytoVP09v1fnpwZ2ur0F78h3WmEQoJTIXGxIsICnMSLN/+P3mmfqH1XZaSFm/+IjBqUJIHbPlVIOF51yRxgw46nAT+v8OZHsJjiO6/OP/86SAFV3orwsOy/KOcqUfAoD2xtZX1WRhK+ZB+BxySg+Dt8XP8Kucb+OluIVwsy/24HnJE23dRoZs0n9xfVBHurWAMGe+HoETc98PbS25Sb7NmstUCBmSr/bdKbbS7NgaQPdRbogvS74ZiXdv7gthzmsNiWPxSKctq8/irEnkzaQ36dKpvHDdql7UwmjxCw1lj/ytJ/a4irogv2gNdFKAhszVfFKFgRjHvdjJSXY/iFyKjwyrGsFSMQWAhZw4P5KSso7Q1lSaD9uDIrCwLaAhEmM/Zh49MOWI6bg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199015)(83380400001)(38070700005)(38100700002)(82960400001)(122000001)(66556008)(66476007)(64756008)(66446008)(8676002)(66946007)(76116006)(4326008)(8936002)(2906002)(6862004)(5660300002)(41300700001)(86362001)(107886003)(52536014)(6506007)(7696005)(26005)(33656002)(55016003)(9686003)(186003)(478600001)(54906003)(316002)(6636002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+nrqc2RjgCZm5EYgAc1drwSbWDjw7C/wI/ZNvBHNmrmwqlPVL3A2HXZFUDZP?= =?us-ascii?Q?2fbEqVx2bqITfbS2XokZAdOAmdsUQ+wxFGQbn2l3caNdID+LTIqkSYVYTeaA?= =?us-ascii?Q?gMdl7T9lg4gfvIuL9sLHAW666gApofWKFPAbaHS5gxd56fd/CsdhXCxhoNoy?= =?us-ascii?Q?3Y4CJBMXlHPl6Sc1BRifIFmiNyvOWPuTKAZyU7nuAUxZcbemX9iwKh7kkoM6?= =?us-ascii?Q?pAmIa4i+Q7ECCczN+CdUTTHNX1GmZ9YH3JJqP3UDA5Xdq0rcTTkx5igYA18I?= =?us-ascii?Q?dBSFCdvY5bvKGqI4oofiEchkiTn0rZwrZOKqg38Nt7KX2Qg+0kZv3kg4hxdU?= =?us-ascii?Q?+tWOfv2Lula6WG7pF7l7gMJen98k5qgQn2MOyCqsFaY4k9TwK8+35iOPOPaz?= =?us-ascii?Q?FNsvkv6KNU4YpCXnhb2FhJwhLZvp/D44YlFxfik5HjjQTj1iGQzGBogSsGLw?= =?us-ascii?Q?8hoP22we+YNGv5F+IO2KXjZ/LLk/PlKDAYczBXh0ToeQXiXvgvg3OxfpTfM0?= =?us-ascii?Q?SqiDcGPEn0ijDuVRAodYXHvZmPwEUfYMp9jtjwvZaBww53Azb2jsk0qPnrpj?= =?us-ascii?Q?N0ir/dOrrPifE30Vq5K20DLfsctAdugwosKVfqWGITQpDzxaf6eWqamcb9Lw?= =?us-ascii?Q?AFBc/w49KLM8+aTWHfccroTNnVsATi3qFHfwWECwoQiZt3zMjTN1z1CMV8lC?= =?us-ascii?Q?xi102HmK9bnckiya1T6zxToES1dRaoEADDAYIeJ8OdunCgXi6Dy8FnsfHjGf?= =?us-ascii?Q?Qg+4wI+VZw1+TRqygKmQiOGstHazlMrF4wtd1NYuFtZja6+HBbc98hi7AUwh?= =?us-ascii?Q?WW+W/0x59mRPpo/XekQRAyBv0J0CJsM0iE6opF/SmQVZnmLiqKMdpdeGSHLz?= =?us-ascii?Q?Jf/EhW3NO9S02yYVtrO/01X+bmHQgh9dXnlocW12W+X5/jwIheMDF31iN344?= =?us-ascii?Q?gNogPmQeFxpPiHYlcJ0XCAVuDujKTNrAHpDljeRoM1cfDwIkyjtmnHyCxZwv?= =?us-ascii?Q?6HeteEvgJmrxRZpQcUN1I10wSrhf1+9LvUK52wUZMufaL4LzrtXZaqLbruhv?= =?us-ascii?Q?b7CgRABz6n9HmygXTLMYWJCmlfS5KxEVNdOc3h/Pvx1uR9jV7A6+LVlzVlwW?= =?us-ascii?Q?R2/B8e5eu57a+4Bw1qxLqHq1vMsAGyJ35/vVCB7QEqbGmDTGWhtqFuAdvCvd?= =?us-ascii?Q?xzO/nKkcIHqrS+LA7Y1GYq0YAOQb4pbCDrt/Psmv9a/wWm0uy6ODwq6XRO40?= =?us-ascii?Q?r9FZHvQ6CDquaK2tJB9vFjAo6yW8kUu3MG2/zW0AuvqNvY9Zpn2T/haj1/fi?= =?us-ascii?Q?j0joe+imKtRdA2vQ1T9PJOtokwqETVtIpoE05RuEjcuvJg/RGfkdyqrZzXOh?= =?us-ascii?Q?saN3o8Yp4RpiELXYX9kKKKv2+Es0uqtxz9agzCrGPFsDN/HWK5oj9koM2M0U?= =?us-ascii?Q?abSm+5czUvk5bNEBcMC6l22yZC1XzwlRzMUAahmewKJIAV5nGXaaUkHusLYB?= =?us-ascii?Q?pfbI4gUajnlLeQdDtl4T3n+kt/cZ7BtzEhT2UGYFPAKRt7l1nEqAUXLfl200?= =?us-ascii?Q?SLQUDn8IlMG0N5GNPLvxYQn2oLp7eNdD700aK8EMV176mb5MwyeDmqV+TdCD?= =?us-ascii?Q?IQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d33eb611-279b-4065-0abd-08da9f95fb52 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 08:06:14.1111 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iGDUf39TTYws2aPLgzhqHSll8wR8w5yFyiJ48bvsxbZrJ8CTYukq3l0EgcTkfRMVgm8G6jY0f8eahHk6NFF9tlw3v0YVD4KyRi1O11KxKII= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6720 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ciara, > -----Original Message----- > From: Power, Ciara > Sent: Wednesday, September 21, 2022 2:51 PM > Cc: dev@dpdk.org; Ji, Kai ; Zhang, Roy Fan > ; De Lara Guarch, Pablo > ; Power, Ciara > Subject: [PATCH v3 0/5] add remaining SGL support to AESNI_MB >=20 > Currently, the intel-ipsec-mb library only supports SGL for GCM and ChaCh= a20- > Poly1305 algorithms through the JOB API. >=20 > To add SGL support for other algorithms, a workaround approach is added i= n > the AESNI_MB PMD. SGL feature flags can now be added to the PMD. >=20 > This patchset also includes a fix for SGL wireless operations, session cl= eanup and > session creation for sessionless operations. >=20 > Some additional Snow3G SGL and AES tests are also added for various SGL > input/output combinations that were not previously being tested. >=20 > v3: > - Modified fix to reset sessions, and ensure values are then set for > sessionless testcases. V2 fix just ensured the same values in > session objects were reused, as they were not being reset, > which was incorrect. > - Reduced code duplication by adding a reusable function. > - Changed int to uint64_t for total_len. >=20 > v2: > - Added documentation changes. > - Added fix for sessionless cleanup. > - Modified blockcipher tests to support various SGL types. > - Added more SGL AES tests. > - Small fixes. >=20 >=20 > Ciara Power (5): > test/crypto: fix wireless auth digest segment > crypto/ipsec_mb: fix session creation for sessionless > crypto/ipsec_mb: add remaining SGL support > test/crypto: add OOP snow3g SGL tests > test/crypto: add remaining blockcipher SGL tests >=20 > app/test/test_cryptodev.c | 56 +++- > app/test/test_cryptodev_aes_test_vectors.h | 345 +++++++++++++++++--- > app/test/test_cryptodev_blockcipher.c | 50 +-- > app/test/test_cryptodev_blockcipher.h | 2 + > app/test/test_cryptodev_hash_test_vectors.h | 8 +- > doc/guides/cryptodevs/aesni_mb.rst | 1 - > doc/guides/cryptodevs/features/aesni_mb.ini | 4 + > doc/guides/rel_notes/release_22_11.rst | 5 + > drivers/crypto/ipsec_mb/ipsec_mb_private.h | 12 +- > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 180 ++++++++-- > lib/cryptodev/rte_cryptodev.c | 1 + > 11 files changed, 547 insertions(+), 117 deletions(-) >=20 > -- > 2.25.1 Thanks for addressing the comments! Series-acked-by: Pablo de Lara